Re: General OFBiz release strategy

2020-02-08 Thread Pierre Smits
In the past I have advocated many times that current strategy has some serious flaws in its design. That it didn't make sense and that it bound the project to a regime it wouldn't be able to maintain. We currently have, besides the master, 3 active release branches: 1. r16, having our latest re

Re: svn commit: r1828233 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/finaccount/FinAccountServices.java

2020-02-08 Thread Pierre Smits
Jacques, I guess that we have difficulties finding aspects where there is consensus, is because the viewpoint of many participating in the project is like 'having it in the ml is good enough'. It is not! When there is a consensus on something (or the outcome of a vote is known), it should be note

General OFBiz release strategy

2020-02-08 Thread Michael Brohl
Hi all, triggered by the discussions we had about new features, important changes and when/where to implement them and also Jacopo's question about the framework/plugins release strategy, here are some thoughts about our release strategy in general: In the past we created a release branch ev

Re: In preparation for the first release from 17.12

2020-02-08 Thread Michael Brohl
Hi Jacopo, I'm not sure about it, a few thoughts: It feels a bit strange to release the 17.12.01 framework without having compatible 17.12.01 releases of the plugins. Users might be confused which plugins they could use to work with the 17.12.01 framework release. This would speak for a 17.12

Re: Test issue

2020-02-08 Thread Jacques Le Roux
Hi Nicolas, Clean and rebased I have now 37688 error: +5 We need a mean to compare before and after to quickly fix. Or do I miss something? Jacques Le 06/02/2020 à 10:40, Nicolas Malin a écrit : Hi Jacques, Strange, after : ~/workspace/apache-git/ofbiz-framework poveglia$ git pull --rebase

Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when initialize billFromParty from groovy context in loadSalesOrderItemFact service

2020-02-08 Thread Jacques Le Roux
Right, Unfortunately we are not able to do that: https://bigbrassband.com/git-integration-for-jira/documentation/linking-git-commits-to-jira-issues.html#manually_linkcommits I then thought we could use "git notes" if we could find a way to incorporate git notes into releases notes. But I found

Re: svn commit: r1828233 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/finaccount/FinAccountServices.java

2020-02-08 Thread Jacques Le Roux
Yes, that's it. I think we already agreed upon (somehow) that. It's not written prominently anywhere, just in  the deep of this ML, like this message will be one day. How to find it back is another story... Jacques Le 08/02/2020 à 12:10, Pierre Smits a écrit : IMO, getting patches (either thro

Re: OFBiz contributions & Github Pull Requests

2020-02-08 Thread Pierre Smits
One most important +1 for referencing Github over Gitbox is that Pull Requests are not synced into git-box. Therefore committers can't check that out that PR from the gitbox repo into a test branch in their local clone. When preferring gitbox over Github the project is - in essence - saying: if yo

Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when initialize billFromParty from groovy context in loadSalesOrderItemFact service

2020-02-08 Thread Pierre Smits
Rewriting commit history is a NONO Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache Directory , PMC Member* Apache Incubator , committer *Apache OFBiz , contr

Re: svn commit: r1828233 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/finaccount/FinAccountServices.java

2020-02-08 Thread Pierre Smits
IMO, getting patches (either through files attached or through commits) in a branch in a repo is a decision in the hands of the individual community member. How the project deals with that to ensure that its adopters stay happy is another issue. The project may say: we're happy with our committer

Re: [jira] [Created] (OFBIZ-11341) Possible NullPointerException in FinAccountServices

2020-02-08 Thread Pierre Smits
Wait and see when the first of the next branch comes out. Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache Directory , PMC Member* Apache Incubator , committer *Apache OFBiz

Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when initialize billFromParty from groovy context in loadSalesOrderItemFact service

2020-02-08 Thread Jacques Le Roux
Never too late and anybody can do it... Jacques Le 06/02/2020 à 13:12, Pierre Smits a écrit : It is a pity that the commit-message of this bug fixed does not reference a ticket. Now it will not show up in release note(s) when generated from JIRA. Best regards, Pierre Smits *Apache Trafodion

Re: [DISCUSSION] bi/birt component integration

2020-02-08 Thread Jacques Le Roux
Hi, I tend to agree with Taher, Birt has a lot of dependencies Jacques Le 05/02/2020 à 14:52, Taher Alkhateeb a écrit : I think Jacopo got it just right! BI to me means a collection of complex queries and services that give insightful information (not necessarily even visual). Birt on the oth

Re: OFBiz contributions & Github Pull Requests

2020-02-08 Thread Jacques Le Roux
Hi, I have modified the title to make it more clear (Confluence does not like special chars, like &, (, ),  you name it...) https://cwiki.apache.org/confluence/display/OFBIZ/Contributing+via+Git+and+Github++-+WIP I have added a warning about plugins inside framework (no auto sync). I added the

Re: svn commit: r1828233 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/finaccount/FinAccountServices.java

2020-02-08 Thread Jacques Le Roux
Hi Michael, I have just backported it in R16. I think a patch in Jira with an explznation there would be also helpful Thanks Jacques Le 06/02/2020 à 08:57, Michael Brohl a écrit : Hi all, thanks for the feedbacks. I created a Jira at https://issues.apache.org/jira/browse/OFBIZ-11341 I not

In preparation for the first release from 17.12

2020-02-08 Thread Jacopo Cappellato
Hi all, based on various threads in this list, the time we will prepare the first release from the 17.12 branch is getting close and, since this is the first one in which the plugins are separated from the framework, there are a few decisions to take. Should we release two products or just one as

Re: [jira] [Created] (OFBIZ-11341) Possible NullPointerException in FinAccountServices

2020-02-08 Thread Michael Brohl
Hi all, do we have a final decision that the latest 16.11 release was the last? Or are we still supposed to backport bugfixes? Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 06.02.20 um 08:53 schrieb Michael Brohl (Jira): Michael Brohl created OFBIZ-11341: -