OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-02-22 Thread Daniel Watford
Hello, Two PRs have been created to address this ticket - please see comments in jira. The first PR is mostly a documentation change as it turned out the required functionality already existed. The second PR introduces some unit testing, but to be able to test MacroFormRenderer without an explos

Deprecate LookupParty service ?

2020-02-22 Thread Nicolas Malin
Hello, During the conversion of party/minilang/LookupService.xml [1], I check the service lookupParty that seems to be very old and contains some inconsistencies. The name LookupParty involves a search on Party and potential extension but in reality it search only on Person. The search work by s

Re: PMC/Committer resignation

2020-02-22 Thread Nicolas Malin
It's sad new that you sharing. This community lose with your resignation huge skill to move forward. Nicolas On 22/02/2020 12:35, Mathieu Lirzin wrote: > Hello, > > As of today, I am resigning from my PMC and Committer role. > > My initial involvement with OFBiz started in April 2018 as an inter

PMC/Committer resignation

2020-02-22 Thread Mathieu Lirzin
Hello, As of today, I am resigning from my PMC and Committer role. My initial involvement with OFBiz started in April 2018 as an internship in the Néréide team to work on the support RESTful Web APIs. While working on that topic I discovered soon enough that this objective would take a very long

Re: Subtasks not working with GitHub integration?

2020-02-22 Thread Nicolas Malin
From my part, my commits has been linked to sub task automaticly [1] Nicolas [1] https://issues.apache.org/jira/browse/OFBIZ-11358?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17042518#comment-17042518 On 21/02/2020 18:12, Michael Brohl wrote: > Hi eve

Re: OFBiz shutdown in Gradle without rebuild

2020-02-22 Thread Nicolas Malin
It's good thing to send command on runnning ofbiz without risk to change the build. After on the modification itself, my gradle skill is to low to have a strong opinion. Nicolas On 22/02/2020 11:21, Michael Brohl wrote: > Hi everyone, > > I've provided an updated patch for the latest trunk in [1

OFBiz shutdown in Gradle without rebuild

2020-02-22 Thread Michael Brohl
Hi everyone, I've provided an updated patch for the latest trunk in [1] for review. Any feedback or objections to commit this to the codebase? Thanks, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://issues.apache.org/jira/browse/OFBIZ-10168 smime.p7s Description: S/MIME Cryptogr

Re: OFBiz contributions & Github Pull Requests

2020-02-22 Thread Michael Brohl
It seems you just removed the work in progess notes from the page without waiting for the review I've announced. The page should be marked as WIP until we agree on the processes described there, IMO. Thanks, Michael Am 22.02.20 um 08:59 schrieb Pierre Smits: @Michal, Your comments have b

Vetting & Testing Contributor’s Code Changes

2020-02-22 Thread Pierre Smits
Hi all, Currently we have Git (and GitHub) in full play for the master branch and the 2 active release branches. The transition to this methodology of distributed version control and collaboration has been adopted by our fellow contributors without any major impediments and/or destructions. At lea

Re: Subtasks not working with GitHub integration?

2020-02-22 Thread Pierre Smits
When the PR does not contain a ticket id when submitted, the link does not appear. And does not appear when the subject of the PR is adjusted afterwards. However, on adjusting the subject of the PR, the ticket is adjusted to reflect the association between ticket and PR. See the 'Time Tracking' and