Re: [DISCUSSION] Having OFBiz web apps listed as components in Jira

2020-06-01 Thread Jacques Le Roux
Hi Pierre, That sounds like a good idea to me. We would though keep the existing components like product, else I don't know what would happen to the related issues. Jacques Le 02/06/2020 à 08:42, Pierre Smits a écrit : Hi All, Multiple components in the applications and plugins stack have m

[DISCUSSION] Having OFBiz web apps listed as components in Jira

2020-06-01 Thread Pierre Smits
Hi All, Multiple components in the applications and plugins stack have more than 1 web application (e.g. product having catalog and facility, marketing having marketing and sfa). In order to better facilitate the community (and others) regarding insight in issues (meaning categorisation/filtering

Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Pierre Smits
With the enhancements provided through PR #117 (see [1]), I have created a few demo party records for only warehousing roles to enhance the user experience for such parties (having only access to the facility app): See below: *For a warehouse manager* *For a pi

Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Pierre Smits
So we're talking about the pdf generated for a picksheet in the order app (see [1])? A warehouse manager has functions available in the facility app to view what needs to be picked and assign that to a picker (see [2] and [3], correct? Then why would he need access to the order app? [1] https://

Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-01 Thread Aditya Sharma
+1 Thanks and regards, Aditya Sharma On Mon, Jun 1, 2020 at 5:09 PM Suraj Khurana wrote: > Hello Michael, > > Just the very last commit on that particular line that we check while > annotating. Nothing else. As Jacques mentioned most of the time the history > can be rebuilt with blame using lin

Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-01 Thread Suraj Khurana
Hello Michael, Just the very last commit on that particular line that we check while annotating. Nothing else. As Jacques mentioned most of the time the history can be rebuilt with blame using lines around. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: s

Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Suraj Khurana
Hello Pawan, IMO, this label is confusing/misleading, this is order pick list or basically order details for warehouse manager to keep as a copy with himself. It will be always on each order level on the create picklist page. So that before creating a picklist he can check/select which orders to p

Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Aditya Sharma
+1 Thanks and Regards, Aditya Sharma On Mon, Jun 1, 2020 at 5:06 PM Jacques Le Roux wrote: > Thanks Pawan, > > I agree with Pierre's concern and yours: +1 to simplify > > Jacques > > Le 01/06/2020 à 11:39, Pawan Verma a écrit : > > Hello Devs, > > > > While working on OFBIZ-11781, issue of the

Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-01 Thread Jacques Le Roux
Hi Michael, Information from Git history and blame mostly, I'd say Jacques Le 01/06/2020 à 11:13, Michael Brohl a écrit : Hi Suraj, +1 for the refactoring in general. What history do we lose while refactoring? Thanks, Michael Am 30.05.20 um 18:25 schrieb Suraj Khurana: Hello Devs, Hope

Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Jacques Le Roux
Thanks Pawan, I agree with Pierre's concern and yours: +1 to simplify Jacques Le 01/06/2020 à 11:39, Pawan Verma a écrit : Hello Devs, While working on OFBIZ-11781, issue of the distorted currency symbol. Pierre asked: Are we confident that prices and currency symbols are a requirement for a

Removal of Price information from Pick Sheet Report

2020-06-01 Thread Pawan Verma
Hello Devs, While working on OFBIZ-11781, issue of the distorted currency symbol. Pierre asked: Are we confident that prices and currency symbols are a requirement for a pick sheet? The important information for picket is Item, quantity, and location. Pickers really don't need the unit price, sub

Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-01 Thread Michael Brohl
Hi Suraj, +1 for the refactoring in general. What history do we lose while refactoring? Thanks, Michael Am 30.05.20 um 18:25 schrieb Suraj Khurana: Hello Devs, Hope you are doing good !! Currently, there are many checkstyle issues in code base which are due to formatting best practices,

Re: EntityBatchIterator for large data set queries

2020-06-01 Thread Pritam Kute
Thanks Scott for your detailed explanation. The solution looks good to me too. My confusion was with why we are going to implement new method if we can achieve that using the current EntityQuery methods. +1 for adding queryBatchIterator() to EntityQuery. Kind Regards, -- Pritam Kute On Thu, Ma