Re: CI github failed : Java 11 or java 17

2022-12-04 Thread Jacques Le Roux
Le 02/12/2022 à 11:23, Jacques Le Roux a écrit : Hi Eugen, Actually I can live with changing java_home by hand instead of using a batch file, not a bid deal. It was only a typo somewhere, RAM disk switching still works \o/ On this subject (RAM vs SSD) for those interested:

Re: CI github failed : Java 11 or java 17

2022-12-03 Thread Jacques Le Roux
Hi, Finally I attached the patch to upgrade to Gradle 7.6.0 (OFBIZ-12400-windows.patch) at OFBIZ-12400. Small change: rather than manually copying the checksum from https://gradle.org/release-checksums I followed Gradle advice at

Re: CI github failed : Java 11 or java 17

2022-12-02 Thread Jacques Le Roux
Hi Eugen, Actually I can live with changing java_home by hand instead of using a batch file, not a bid deal. I only have now to test these small changes in init-gradle-wrapper.ps1 -    Invoke-WebRequest -outf gradle\wrapper\gradle-wrapper.jar

Re: CI github failed : Java 11 or java 17

2022-12-02 Thread Eugen Stan
Hi Jaques, Any luck on this? I use sdkman to switch jdk's on linux. https://sdkman.io/install I noticed it has some Windows options as well, maybe they will work for you ?! I try to stay away from customizations since most of the time they are not worth the effort. If the build is slow it

Re: CI github failed : Java 11 or java 17

2022-11-30 Thread Jacques Le Roux
I found the cause. For performance reason, and especially in order to be able to quickly switch from a JDK version to another, I use a batch file to copy over JDKs to a RAM Disk. So java_home is always the same: this RAM Disk. It has been working since Java 8, It now fails with JDK 17 (from

Re: CI github failed : Java 11 or java 17

2022-11-30 Thread Jacques Le Roux
After upgrading non-functional changes at OFBIZ-12400 (Java code, AsciiDoc versions, Groovy from 2.5.18 to 3.0.13), we can focus on Gradle and JDK version. With last Java 17 and still Gradle 6.5,of of course the same error than before: "does not export com.sun.tools.javac.code to unnamed

Re: CI github failed : Java 11 or java 17

2022-11-30 Thread Jacques Le Roux
Hi Eugen, As you know I'm still on Win7 and was able to manage all related issues so far (like the need to use npm 13.14.0 locally in build.gradle) To simplify things I just committed the non functional Java changes unrelated to Gradle and JDK upgrades, not the same than your for CsrfUtil

Re: CI github failed : Java 11 or java 17

2022-11-29 Thread Ioan Eugen Stan
An update to this: I've rebased the PR for gradle upgrade https://issues.apache.org/jira/browse/OFBIZ-12400 https://github.com/apache/ofbiz-framework/pull/354 I've bumped gradle to 7.6 . I started ofbiz with temurin jdk17 and it works (with warnings and some errors). See screenshot in

Re: CI github failed : Java 11 or java 17

2022-11-29 Thread eugen . stan
Hi, There are some open issues about this: https://issues.apache.org/jira/browse/OFBIZ-10757 - jdk 11 https://issues.apache.org/jira/browse/OFBIZ-12399 - jdk 17 https://issues.apache.org/jira/browse/OFBIZ-12400 - gradle 7.x for jdk17 There is also a PR for gradle upgrade

Re: CI github failed : Java 11 or java 17

2022-11-28 Thread Jacques Le Roux
Hi, After answering << I never tried JDK 17 yet, but that should easy to upgrade when ready.>> to Michael at https://lists.apache.org/thread/8cpz4dh7zoznp4mx2xxv35hns4j8mvf0 I thought it would be time to go for it. So far, I was wrong. I just tried to use the last JDK 17 (Adoptium)

Re: CI github failed : Java 11 or java 17

2022-07-15 Thread Nicolas Malin
Hi Michael, I totally agree with that. However, the JDK 17 LTS failed to compile on my local. I propose to move 8 to 11 as first step and homogenize all server, CI and documentation next move to the 17 as soon as it's safe. Nicolas On 15/07/2022 14:50, Michael Brohl wrote: Hi Nicolas, I

Re: CI github failed : Java 11 or java 17

2022-07-15 Thread Michael Brohl
Hi Nicolas, I suggested to think about switching to JDK 17 LTS a while ago: https://lists.apache.org/thread/8cpz4dh7zoznp4mx2xxv35hns4j8mvf0 Time went by, so I think it would be better to skip 11 and go with 17 LTS, because we will have longer support. What do you think? Regards, Michael

Re: CI github failed : Java 11 or java 17

2022-07-15 Thread Nicolas Malin
After a check from my side, the release 22.01 failed with java 17 * * What went wrong: Execution failed for task ':compileJava'. > java.lang.IllegalAccessError: class org.gradle.internal.compiler.java.ClassNameCollector (in unnamed module @0x11954319) cannot access class

Re: CI github failed : Java 11 or java 17

2022-07-15 Thread Jacques Le Roux
Hi Nicolas, I did not try, how things works with Java 17? Jacques Le 15/07/2022 à 10:14, Nicolas Malin a écrit : Hello, I saw that break the CI github because I commited a List.of on release22.01 [1] not supported by java 8 After a quick check, the CI work on java 8 and the documentation

Re: CI github failed : Java 11 or java 17

2022-07-15 Thread Nicolas Malin
I continue to analyze :) Jacques already done it on trunk to move the github CI on java 11 [1] I can backport to release22.01 and update documentation to formalize it Nicolas [1] https://github.com/apache/ofbiz-framework/commit/65c766e0c9ccd4e22a9c57c5e6dd11b1ce8f4006 PS: my previous link

CI github failed : Java 11 or java 17

2022-07-15 Thread Nicolas Malin
Hello, I saw that break the CI github because I commited a List.of on release22.01 [1] not supported by java 8 After a quick check, the CI work on java 8 and the documentation quote also the java 8 (release22.01 and trunk) but for the demo server we move to java 11 [2] I propose to update