I was for the tests-*.xml type of file because it was consistent with services defintions files names. But I should say that I
don't like to have dashes and underscores in names at large (should I say that it remains me my 1st and only short experience with
Cobol 25 years ago ). It would be
Yes but the definition and implementation of a test need two separate
files. Same is true for a service except the entity-auto feature.
There is an example btw.
party/script/org/ofbiz/party/test/PartyTests.xml
party/testdef/PartyTests.xml
Both of files above reside in different folders in
If a test is written as a simple-method it should be names like other files, ie
as *Services.xml or *SimpleMethods.xml (an older form, not used much).
-David
On Dec 30, 2009, at 2:39 AM, Vikas Mayur wrote:
Yes but the definition and implementation of a test need two separate files.
Same
David E Jones wrote:
If a test is written as a simple-method it should be names like other files,
ie as *Services.xml or *SimpleMethods.xml (an older form, not used much).
Shouldn't test definitions(classes, simple methods, entity defs, etc)
only be active if tests are being run? This would
Hi,
The test definition files name is not consistent throughout the
project. Some of the files name is all lowercase and others have camel
case pattern.
I think we can follow the pattern used in service definition files.
The files under accounting/testdef are
accountingtests.xml
+1.
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Tue, Dec 29, 2009 at 6:24 PM, Vikas Mayur vikas.ma...@hotwaxmedia.comwrote:
Hi,
The test definition files name is not consistent throughout the project.
Some of the files name is all lowercase and others have camel
Yes sounds logical
+1
Jacques
From: Rishi Solanki rishisolan...@gmail.com
+1.
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Tue, Dec 29, 2009 at 6:24 PM, Vikas Mayur vikas.ma...@hotwaxmedia.comwrote:
Hi,
The test definition files name is not consistent throughout
+1
Regards
Scott
On 30/12/2009, at 1:54 AM, Vikas Mayur wrote:
Hi,
The test definition files name is not consistent throughout the
project. Some of the files name is all lowercase and others have
camel case pattern.
I think we can follow the pattern used in service definition files.
Why not camel case them like most other files?
-David
On Dec 29, 2009, at 1:05 PM, Bilgin Ibryam wrote:
Vikas Mayur wrote:
Hi,
The test definition files name is not consistent throughout the project.
Some of the files name is all lowercase and others have camel case pattern.
I think
Actually, most XML files in OFBiz these days (with just a few exceptions)
follow a patterns like:
*Services.xml
*Forms.xml
*Screens.xml
*Data.xml
... etc
By that pattern the test files should be *Tests.xml, with the rest of the file
camel-cased and an upper-case first letter.
-David
On Dec
+1 on David's comment, *Tests.xml looking better.
--
Thanks and Regards
Sumit Pandit
On Dec 29, 2009, at 5:47 PM, David E Jones wrote:
Actually, most XML files in OFBiz these days (with just a few exceptions)
follow a patterns like:
*Services.xml
*Forms.xml
*Screens.xml
*Data.xml
11 matches
Mail list logo