Re: Opinions wanted on r1307895

2012-04-24 Thread Paul Foxworthy
>>>>>> >>>>>>> From: "Scott Gray" <scott.gray@> >>>>>>>> Hi Jacques, >>>>>>>> >>>>>>>> I think the better approach would have been to fall back to the >>>>

Re: Opinions wanted on r1307895

2012-04-20 Thread J. Eckard
On Apr 19, 2012, at 5:50 PM, Adam Heath wrote: > On 04/19/2012 04:41 PM, Jacques Le Roux wrote: >> Committed at revision: 1328122 >> Jacques > > This change would be needed for anything dealing with PAN(credit-card > number for those not into the lingo). Somewhat related - but only in regards

Re: Opinions wanted on r1307895

2012-04-19 Thread Adam Heath
On 04/19/2012 04:41 PM, Jacques Le Roux wrote: > Committed at revision: 1328122 > Jacques This change would be needed for anything dealing with PAN(credit-card number for those not into the lingo). > From: "Jacques Le Roux" >> Nope, I'd not have raised a warning else ;o) >> The user must read i

Re: Opinions wanted on r1307895

2012-04-19 Thread Jacques Le Roux
Committed at revision: 1328122 Jacques From: "Jacques Le Roux" Nope, I'd not have raised a warning else ;o) The user must read it at the end, it's the body part of the email in the service result Jacques From: "Adrian Crum" Is the logged password encrypted? If yes, then I don't see a pr

Re: Opinions wanted on r1307895

2012-04-07 Thread Jacques Le Roux
Nope, I'd not have raised a warning else ;o) The user must read it at the end, it's the body part of the email in the service result Jacques From: "Adrian Crum" Is the logged password encrypted? If yes, then I don't see a problem with it. -Adrian On 4/7/2012 10:39 AM, Jacques Le Roux wrot

Re: Opinions wanted on r1307895

2012-04-07 Thread Adrian Crum
Is the logged password encrypted? If yes, then I don't see a problem with it. -Adrian On 4/7/2012 10:39 AM, Jacques Le Roux wrote: Hi, I followed Scott's suggestion and added a generic EMAIL_PASSWORD EmailTemplateSetting (used to send a new password at user request). I finally kept also the

Re: Opinions wanted on r1307895

2012-04-07 Thread Jacques Le Roux
Hi, I followed Scott's suggestion and added a generic EMAIL_PASSWORD EmailTemplateSetting (used to send a new password at user request). I finally kept also the previous way (in r1307895) because it allows an easier 18n of the email subject. Something is worrying me a bit. Since the service t

Re: Opinions wanted on r1307895

2012-04-03 Thread Jacques Le Roux
Thanks Scott, This sounds like a plan. I will try to apply it... Jacques From: "Scott Gray" Hi Jacques, I think the better approach would have been to fall back to the EmailTemplateSetting (after adding a demo record for it) and failing if it isn't present (along with removing that default

Re: Opinions wanted on r1307895

2012-04-03 Thread Scott Gray
Hi Jacques, I think the better approach would have been to fall back to the EmailTemplateSetting (after adding a demo record for it) and failing if it isn't present (along with removing that default screen reference altogether). The reason for this is simplicity, we give the user one path thro