Am 12.12.17 um 14:38 schrieb Jacques Le Roux:
I catch up to Jacques's comment, I prefer to separate the formating to
the functional even if I was do the same in the past and I will do it
by oversight in the future :)
This was what David taught us and I found it reasonable
Yes, and that's
Le 12/12/2017 à 14:13, Nicolas Malin a écrit :
Hello
Le 12/12/2017 à 13:29, Michael Brohl a écrit :
[...] I have a very simple but effective workflow for this, you might find it
helpful also:
1. copy the link to the patch file in the Jira issue
2. right click on your OFBiz project in Eclipse
BTW Michael,
Don't get me wrong, I want to again compliment you and your team for the
excellent work done recently :)
Jacques
Le 12/12/2017 à 14:28, Jacques Le Roux a écrit :
Le 12/12/2017 à 13:29, Michael Brohl a écrit :
Hi Jacques,
inline...
Am 12.12.17 um 11:48 schrieb Jacques Le
Le 12/12/2017 à 13:29, Michael Brohl a écrit :
Hi Jacques,
inline...
Am 12.12.17 um 11:48 schrieb Jacques Le Roux:
Hi Michael,
I already answered you in Jira here it is another more complete version:
Removing trailing spaces has been discussed in the past and the consensus is that we don't
Hello
Le 12/12/2017 à 13:29, Michael Brohl a écrit :
[...] I have a very simple but effective workflow for this, you might
find it helpful also:
1. copy the link to the patch file in the Jira issue
2. right click on your OFBiz project in Eclipse and select Team/Apply
patch
3. the copied
Am 12.12.17 um 11:48 schrieb Jacques Le Roux:
This is a bit out of subject, but while at it:
As you can see at [3] I'm not against removing trailing spaces. But
experience told me one thing since. One of the most important things
in version control is what happened to a line, because you
Hi Jacques,
inline...
Am 12.12.17 um 11:48 schrieb Jacques Le Roux:
Hi Michael,
I already answered you in Jira here it is another more complete version:
Removing trailing spaces has been discussed in the past and the
consensus is that we don't remove trailing spaces in patches because
it
Hi Michael,
I already answered you in Jira here it is another more complete version:
Removing trailing spaces has been discussed in the past and the consensus is that we don't remove trailing spaces in patches because it hurts
reviewers with false changes.
What was suggested then is to split
Hi Jacques,
I propose to do it the other way around: when reviewing diffs, you can
configure the IDE to ignore these white space changes. It works
perfectly in Eclipse and you will not be bothered by such changes.
In my view, trailing white spaces do not belong there and should be
removed
