the updateWorkEffort is
called? Now the check is not done at the appropriate level
(changeProductionRunStatus), but at the lower level. IMO the lower level
service should simply be digesting the parameters presented and persist.
> changeProductionRunStatus service does not honor the StatusValidCha
changeProductionRunStatus does not honor
StatusValidChange directly but it calls the updateWorkEffort service and it do
check for the StatusValidChange, so IMO there is no need to check for
StatusValidChange in changeProductionRunStatus service.
> changeProductionRunStatus service does not ho
service does not honor the StatusValidChange
> ---
>
> Key: OFBIZ-6685
> URL: https://issues.apache.org/jira/browse/OFBIZ-6685
> Project: OFBiz
> Issue Type: Improvement
>
uctionRunStatus service does not honor the StatusValidChange
> ---
>
> Key: OFBIZ-6685
> URL: https://issues.apache.org/jira/browse/OFBIZ-6685
> Project: OF
to
change the production run status, also removed request
changeProductionRunStatusToClosed as I do not find this request being called
from anywhere.
4) Added data for ValidStatusChange.
> changeProductionRunStatus service does not honor the Stat
[
https://issues.apache.org/jira/browse/OFBIZ-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974037#comment-14974037
]
Deepak Dixit commented on OFBIZ-6699:
-
Removed invalid field Condition from StatusValidChange data
[
https://issues.apache.org/jira/browse/OFBIZ-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-6699:
Issue Type: Improvement (was: Bug)
> Remove condition attr from StatusValidChange data as
rom StatusValidChange data as its not a valid field of
> StatusValidChange
> ---
>
> Key: OFBIZ-6699
> URL: https://issues.apache.org/jira/browse/OFBIZ-6699
>
can remove it
from data. I am not able to see a single reference of conditionExpression in
code and as well as in data.
> Remove condition attr from StatusValidChange data as its not a valid field of
> StatusValid
}
{code}
> Remove condition attr from StatusValidChange data as its not a valid field of
> StatusValidChange
> ---
>
> Key: OFBIZ-6699
> URL: https://issues.apac
Deepak Dixit created OFBIZ-6699:
---
Summary: Remove condition attr from StatusValidChange data as its
not a valid field of StatusValidChange
Key: OFBIZ-6699
URL: https://issues.apache.org/jira/browse/OFBIZ-6699
nor the StatusValidChange
> ---
>
> Key: OFBIZ-6685
> URL: https://issues.apache.org/jira/browse/OFBIZ-6685
> Project: OFBiz
> Issue Type: Improvement
> Components: ma
Deepak Dixit created OFBIZ-6685:
---
Summary: changeProductionRunStatus service does not honor the
StatusValidChange
Key: OFBIZ-6685
URL: https://issues.apache.org/jira/browse/OFBIZ-6685
Project: OFBiz
above but they
may help with #2.
Also another issue with StatusValidChange is that there is currently
no way to make sure when creating a new record that the initial status
is valid, I stumbled across this while fixing the test cases where a
Shipment was being created in the SHIPMENT_PACKED
to copy/paste
(is the status set, has the status changed, do the lookup, report an
error).
I don't think options #2 and #3 below cover problem #1 above but they
may help with #2.
Also another issue with StatusValidChange is that there is currently
no way to make sure when creating a new record
options #2 and #3 below cover problem #1 above but they
may help with #2.
Also another issue with StatusValidChange is that there is currently
no way to make sure when creating a new record that the initial status
is valid, I stumbled across this while fixing the test cases where a
Shipment
).
I don't think options #2 and #3 below cover problem #1 above but they
may help with #2.
Also another issue with StatusValidChange is that there is currently
no way to make sure when creating a new record that the initial status
is valid, I stumbled across this while fixing the test
should be displayed or find some existing code to copy/paste
(is the status set, has the status changed, do the lookup, report an
error).
I don't think options #2 and #3 below cover problem #1 above but they
may help with #2.
Also another issue with StatusValidChange is that there is currently
error
message should be displayed or find some existing code to copy/paste
(is the status set, has the status changed, do the lookup, report an
error).
I don't think options #2 and #3 below cover problem #1 above but they
may help with #2.
Also another issue with StatusValidChange
Hi All
Currently there is a ton of code in various places that checks to make
sure a status change is valid using the StatusValidChange entity, and
there are also places where there is no check even though records
exist (createShipment for example). I'm wondering we couldn't add
support
A couple of notes:
1. if we add something to the entity engine to check this we would
need to move the Status* entities from the common component to the
entity component
2. I played with doing a separate method that genericized checking the
StatusValidChange, but it made the code bigger
21 matches
Mail list logo
