Re: Update our HTTP headers

2018-05-23 Thread Jacques Le Roux
Committed at r1832128 Jacques Le 18/05/2018 à 15:47, Jacques Le Roux a écrit : Hi, At https://issues.apache.org/jira/browse/OFBIZ-6766 I have attached a minor OFBIZ-6766-UtilHttp.java.patch for updating our HTTP headers I think it's OK to commit, but before I'd like to know if we really

Re: Update our HTTP headers

2018-05-23 Thread Jacques Le Roux
It's not related to IE, finally we have not problems with x-ua-compatible Private is well explained in the 2 1st links. Jacques Le 23/05/2018 à 15:07, Taher Alkhateeb a écrit : There are at least 4 links and many comments in the JIRA, I'm not sure which one are you referring to. Anyway, it

Re: Update our HTTP headers

2018-05-23 Thread Taher Alkhateeb
There are at least 4 links and many comments in the JIRA, I'm not sure which one are you referring to. Anyway, it sounds correct because it is utilized from the function "setResponseBrowserProxyNoCache(...)" So I think it looks fine. Good job with the research. IE continues to cause so much

Re: Update our HTTP headers

2018-05-23 Thread Jacques Le Roux
Le 21/05/2018 à 20:13, Taher Alkhateeb a écrit : HTTP headers setting is a complex topic with lots of details. I think we need a comprehensive source and a discussion on best practices, Does not the special page I created in the wiki help? maybe we should make some of the headers configurable

Re: Update our HTTP headers

2018-05-21 Thread Taher Alkhateeb
Ok so that's why we should generally try to avoid mixing topics together in the same thread, that's what threw me off into a tangent. HTTP headers setting is a complex topic with lots of details. I think we need a comprehensive source and a discussion on best practices, maybe we should make some

Re: Update our HTTP headers

2018-05-20 Thread Jacques Le Roux
Hi Deepak, Right, I missed that apart in helpdoc the others are under build/reports/tests/test and under jQuery So nothing to worry about, I'll commit the patch in one week Jacques Le 20/05/2018 à 10:16, Deepak Dixit a écrit : Hi Taher, x-ua-compatible used in html file directly and I

Re: Update our HTTP headers

2018-05-20 Thread Deepak Dixit
Hi Taher, x-ua-compatible used in html file directly and I think its used only in helpdoc html content, Jacques Comments from task: >>I have attached the OFBIZ-6766-UtilHttp.java.patch and will ask about x-ua-compatible on dev ML before committing Thanks & Regards -- Deepak Dixit

Re: Update our HTTP headers

2018-05-19 Thread Taher Alkhateeb
Hi Jacques, I could be mistaken, but looking at the patch I did not see anything related to x-ua-compatible. Am I looking at the right JIRA 6766? It only has one attachment that sets the Cache-Control flags? On Fri, May 18, 2018 at 4:47 PM, Jacques Le Roux wrote: >

Re: Update our HTTP headers

2018-05-18 Thread Paul Foxworthy
Hi Jacques, I'm happy to get rid of X-UA-Compatible. Cheers Paul Foxworthy On 18 May 2018 at 23:47, Jacques Le Roux wrote: > Hi, > > At https://issues.apache.org/jira/browse/OFBIZ-6766 I have attached a > minor OFBIZ-6766-UtilHttp.java.patch for updating our

Update our HTTP headers

2018-05-18 Thread Jacques Le Roux
Hi, At https://issues.apache.org/jira/browse/OFBIZ-6766 I have attached a minor OFBIZ-6766-UtilHttp.java.patch for updating our HTTP headers I think it's OK to commit, but before I'd like to know if we really want to keep x-ua-compatible in several *.html files.