ve ""Bäume" problem,
anything I missed?
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
solve ""Bäume" problem, anything I
missed?
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
>
:
10.04 @Rev1392767
11.04 @Rev1392768
12.04 @Rev1392769
Trunk @Rev1392766
So we could finally close the issue :-) ?!
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.
orks for me.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
>
from trunk.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
>
cannot reproduce NPE exception in WidgetWorker.makeHiddenFormLinkForm after
patch "OFBIZ-2628-encoding-hidden-post-params (list forms)", but I have
prepared new patch with checking for null in this situation. Maybe it will
help.
> No Url encoding for g
hars like + and äöü, which works fine. But
the a space is really a problem. Let's see what we can do here...
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apac
code}
{code}
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type:
one
{code}
{code}
So yes, we have a problem Houston
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
&g
-- stack trace ---
{code}
Looking at lookedUpValue Method = deleteProductAttribute...
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apac
roduct/product/ProductServices.xml,
Element = <remove-value>, Line 961null
This is because in delete from url encoding replace space with + symbol.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2
t on trunk and 11.04 and it works fine. No problems with creating
and deleting an attribute.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jir
form encoding issue:
https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAttributes?productId=DEMO-PRODUCT-1
Add an product attribute "Test Attr" and then try to delete it.
> No Url encoding for get parameters
> --
>
The encoding of the parameters works now. But I get
NPE's when loading the global decorator on different pages i.e.:
https://localhost:8443/content/control/ListWebSiteContent?webSiteId=CmsSite
The exception occurs in: WidgetWorker.makeHiddenFormLinkForm
> No Url enco
occurs only on list forms with submit action per row, where tag
form is genereted for the submit action. Hidden fields values inside such form
tag should not be "url encoded".
I prepared a patch. Please check it.
> No Url encoding for g
hort example of your problem that I can
reproduce it here on my machine?
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
>
e to find another solution to fix a problem with
encoding POST hidden parameters. I have noticed I have this problem only on
forms of "list" type.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
&g
hich causes the same issue as described in the
in the bug description.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
>
n do you test? I have 11.04 version, but it is quite
old (from 2012-05-09 01:24:16)
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
&g
-encoding-hidden-post-params.patch" break the encoding
again.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Proj
[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-2628:
Let's see...
> No Url encoding for get pa
ng these problems for me.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Comp
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>
ncoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affec
dbot
http://ci.apache.org/projects/ofbiz/logs/10.04/html/
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project:
CUME~1\JACQUE~1\LOCALS~1\Temp\null279273951
{code}
I decided to commit at r1390845 and will see later why we get those
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://iss
)
Release Branch 12.04
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
>
I finally back form my holiday.
Great observation Wojciech, I will check that.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFB
reat observation Wojciech, I will check that.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
>
);
}
... it solved the problem.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Iss
i.apache.org/tomcat/FAQ/CharacterEncoding#Q8 (OFBiz is already most
of this, did not check though)
Also, not directly related, but it's a "well known issue" that UTF8-encoding
does not work for fields sent with GET method using Ajax...
&g
coding#Q8 (OFBiz is already most
of this, did not check though)
Also, not directly related, but it's a "well known issue" that UTF8-encoding
does not work for fields sent with GET method...
> No Url encoding for get parameters
> --
ields sent with GET method...
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Ty
ategories like: "Bücher", "D+Ä" ...
{code:title=WidgetWorker.java line: 382|borderStyle=solid}
returnValue = URLEncoder.encode(retVal.toString(),
Charset.forName("ISO-8859-1").displayName());
{code}
ing for security reasons, i'm wondering what we can do
here to provide correct search strings and don't open a security hole?
Any suggestions?
Have a good day,
Sascha
> No Url encoding for get parameters
> --
>
>
you get to fix this, please check if it fixes also OFBIZ-2837 anc close
it
TIA :)
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
&g
issue you metioned and maybe we get
closer to a solution ;-).
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
>
hort comment on [#OFBIZ-2837], this does not
seem to be resolved, we still face this issue in the ecommerce application. We
are using ofbiz trunk.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
>
causes this error.
The new patch is committed in
Trunk @Rev1298454
11.04 @Rev1298455
10.04 @Rev1298456
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/ji
rce login button.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
>
Release Branch 10.04
Thanks Markus for the initial Patch i committed my modified version in:
Trunk @Rev 1297006
10.04 @Rev 1297030
11.04 @Rev 1297031
> No Url encoding for get parameters
> --
>
> Key
UTF-8 is sufficient, first i thought of getting it from
an property file, but as you mentioned the World Wide Web Consortium
recommended also UTF-8.
Thanks for reviewing
Have a good day
Sascha
> No Url encoding for get par
s in WidgetWorker.java are OK with me
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
>
the default encoding of the
platform is used.
{quote}
So I think we should rather use Charset.forName("UTF-8").displayName() instead
of Charset.defaultCharset().displayName(). AFAIK, UTF-8 should fits with all
server and clients types...
> No Url encoding f
URLEncoder to fix this issue (see attached files).
The URLEncoder does a right encoding for the url with a special character.
Any comments to this solution?
Regards
> No Url encoding for get parameters
> --
>
> Key
ally very old and imo we should not worry about it (unless
there is a real interest in the community). I will start a thread to discuss
this (and 09.04).
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
>
t if you can have a second look at this.
Have a good day
Sascha
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
>
But when i create a new category "DVD+R" the widget encoder encodes it to
"DVD+R" not to "DVD%2BR".
It would be great if you can have a second look at this.
Have a good day
Sascha
> No Url encoding for get parameters
> --
[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sascha Rodekamp reassigned OFBIZ-2628:
--
Assignee: Sascha Rodekamp
> No Url encoding for get paramet
WidgetWorker as well as in the RequestHandler.
Tested using the already mentioned DVD+R category, more testing is needed.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://is
cket anymore. Would like to help out here,
do you still have the patch somewhere, so that the start is easier?
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.or
houd we not close?
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Compon
7;PROD_CRLP_CURRENT' for key (DVD R). The statement has been rolled back.))]
Patrick, do you think you will continue to work on this, have you solved it?
Thanks
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
>
7 PM:
-
Trunk patch at revision 830787
Patch not good, need to rework it
was (Author: patrick.antivackis):
Trunk patch at revision 830787
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
>
[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Antivackis updated OFBIZ-2628:
--
Attachment: (was: Patch-OFBIZ-2628.txt)
> No Url encoding for get paramet
[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Antivackis updated OFBIZ-2628:
--
Attachment: Patch-OFBIZ-2628.txt
Trunk patch at revision 830787
> No Url encoding
[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Antivackis updated OFBIZ-2628:
--
Attachment: (was: OFBIZ-2628-widget.patch)
> No Url encoding for get paramet
for this efficient answer.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
>
0 PM:
--
We should be using {code:xml}&{code} to separate parameters since we target
xhtml
EDIT: jira turned my & amp; into &
was (Author: lektran):
We should be using & to separate parameters since we target xhtml
> No Url enco
l tag.
So if it is the official way to write queryString, i can do the patch, else if
it is not, i can't because the queryString would contains '&' that doesn't mean
'separation of parameters', like dvd+r is in fact output dvd+r by
freemarker ${product.produ
rs since we target xhtml
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Co
like dvd+r is in fact output dvd+r by
freemarker ${product.productId}
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project:
is the official way to write queryString, i can do the patch, else if
it is not, i can't because the queryString would contains '&' that doesn't mean
'separation of parameters', like dvd+r is in fact output dvd+r by
freemarker ${product.productId}
&g
your patch but I'd prefer to commit the changes to
makelink in the same shoot.
Could you please update your patch with the change you propose ?
Or have you some concerns about the way you propose to change makelink ?
> No Url encoding for ge
s would be wide and hazardous task (I
guess I did not check, using regexp replacement in Eclipse you can do miracles)
My 2 cts
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: http
y opinion ?
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Components: framewo
Url encode the value of
parameters.
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
bEncoder.encodeForURL instead of simpleEncoder
Beofre i do the fix, can a core developper let me know about possible side
effects
> No Url encoding for get parameters
> --
>
> Key: OFBIZ-2628
> URL: https://issues.apache.o
No Url encoding for get parameters
--
Key: OFBIZ-2628
URL: https://issues.apache.org/jira/browse/OFBIZ-2628
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Release Branch
After digging deeper, the widget are also buggy.as the function
buildhyperlinkUrl in
framework/widget/src/org/ofbiz/widget/WidgetWorker.java
is not using url encoding either.
I found that the StringUtil.defaultWebEncoder.encodeForURL shoudl do the
job, but i would like a core developper to have a
So after looking into :
framework/webapp/src/org/ofbiz/webapp/ftl/OfbizUrlTransform.java
and
framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java
the ofbizUrl tag is calling the RequestHandler.makeLink which is using
httpServletResponse.encodeUrl.
So parameters are not url encoded, as
in fact in the source there is
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+r";>
which is really stupid !! as it means 2 parameters.
So the ofbizUrl tag is encoding, but i don't understand why it's
encoding like this.
2009/6/17 Patrick Antivackis
> Hello,
> Before
Hello,
Before filling a bug i would like to confirm it with you and validating the
way to correct it.
Let's say I want to create a new category which ID is DVD+R
Creation is ok through the admin interface, but whenever i want to access
this category, the get parameter categoryId= of the url i
73 matches
Mail list logo
