Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-07-14 Thread Jacques Le Roux
It's actually finished and has been used by a company during 2 years. Initially I did it like the other appservers has been done precedently. But I then got a requirement to automatically deploy. This works began at http://svn.apache.org/viewvc?view=revision&revision=646349 and was completed, se

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-07-14 Thread Jacopo Cappellato
Hi Jacques, if you could help to remove all code that is specific to Geronimo/WASCE that would be great in my opinion; some of the code I have seen is really a kind of tweak and if it is not finished it would be better to clean everything and then, when someone will really have to work with Ger

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-07-14 Thread Jacques Le Roux
Hi Jacopo, If it's only that part (all related to GeronimoMultiOfbizInstances) which worries you then no problem for me to revert it (I will put a note into Attic though). It was a try (not in requirements I had, but made sense) but I never really got a chance to finish and nobody was interested

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-07-08 Thread Jacopo Cappellato
On Jun 25, 2012, at 7:12 PM, Jacques Le Roux wrote: > From: "Jacopo Cappellato" >> Hi all, >> >> this is part of my review of framework code to make it cleaner. I see a >> series of questionable changes in this commit, do you >> agree? >> Jacques, before I start my review please let me know if

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-06-25 Thread Jacques Le Roux
From: "Jacopo Cappellato" Hi all, this is part of my review of framework code to make it cleaner. I see a series of questionable changes in this commit, do you agree? Jacques, before I start my review please let me know if you want to do a first pass on it. I can certainly have a fresh look

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-06-25 Thread Jacopo Cappellato
Another commit (somewhat related) that will need to be reviewed is Author: jleroux Date: Tue Apr 29 15:35:32 2008 New Revision: 652177 URL: http://svn.apache.org/viewvc?rev=652177&view=rev Log: This add the possiblity to run RMI services under WASCE or Geronimo. There is only one small drawback :

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-06-25 Thread Jacopo Cappellato
Hi all, this is part of my review of framework code to make it cleaner. I see a series of questionable changes in this commit, do you agree? Jacques, before I start my review please let me know if you want to do a first pass on it. Thanks, Jacopo On Apr 9, 2008, at 3:51 PM, jler...@apache.org