Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-09 Thread Adam Heath
Adam Heath wrote: Scott Gray wrote: Sorry, yes I have had a look, my initial hope was to explicitly set the parameters that we wanted to be passed through the survey form rather than blindly including the entire map of incoming parameters. This is unfeasible though due to the number of

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-08 Thread Adam Heath
Scott Gray wrote: This change breaks purchase of gift cards. Go to /ecommerce, select gift card, $100 variant, classic type, add to cart, fill out survey, and then it fails to add to the cart. I would suggest reverting this commit, as having broken functionality is worse than having a

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-08 Thread Scott Gray
On 9/12/2009, at 9:26 AM, Adam Heath wrote: Scott Gray wrote: This change breaks purchase of gift cards. Go to /ecommerce, select gift card, $100 variant, classic type, add to cart, fill out survey, and then it fails to add to the cart. I would suggest reverting this commit, as having

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-08 Thread Adam Heath
Scott Gray wrote: Sorry, yes I have had a look, my initial hope was to explicitly set the parameters that we wanted to be passed through the survey form rather than blindly including the entire map of incoming parameters. This is unfeasible though due to the number of potential parameters

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-02 Thread Adam Heath
lekt...@apache.org wrote: Author: lektran Date: Sat Oct 17 08:40:17 2009 New Revision: 826196 URL: http://svn.apache.org/viewvc?rev=826196view=rev Log: Fix security issue reported by Alexandre Mazari - OFBIZ-2747 Request parameters were being made available to surveys which in turn were

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-02 Thread Scott Gray
On 2/12/2009, at 9:23 PM, Adam Heath wrote: lekt...@apache.org wrote: Author: lektran Date: Sat Oct 17 08:40:17 2009 New Revision: 826196 URL: http://svn.apache.org/viewvc?rev=826196view=rev Log: Fix security issue reported by Alexandre Mazari - OFBIZ-2747 Request parameters were being made

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-02 Thread Adam Heath
Scott Gray wrote: On 2/12/2009, at 9:23 PM, Adam Heath wrote: lekt...@apache.org wrote: Author: lektran Date: Sat Oct 17 08:40:17 2009 New Revision: 826196 URL: http://svn.apache.org/viewvc?rev=826196view=rev Log: Fix security issue reported by Alexandre Mazari - OFBIZ-2747 Request

Re: svn commit: r826196 - /ofbiz/trunk/applications/content/src/org/ofbiz/content/survey/SurveyWrapper.java

2009-12-02 Thread Scott Gray
On 2/12/2009, at 9:35 PM, Adam Heath wrote: Scott Gray wrote: On 2/12/2009, at 9:23 PM, Adam Heath wrote: lekt...@apache.org wrote: Author: lektran Date: Sat Oct 17 08:40:17 2009 New Revision: 826196 URL: http://svn.apache.org/viewvc?rev=826196view=rev Log: Fix security issue reported by