Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-29 Thread Adam Heath
Adrian Crum wrote: > David E Jones wrote: >> On Dec 28, 2009, at 4:32 PM, Jacques Le Roux wrote: >> >>> From: "Ean Schuessler" Jacques Le Roux wrote: > Thanks, I saw that but was not sure how to use it. I remember now > why I > created Java services. I needed to create a PartyGrou

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-29 Thread Ean Schuessler
David E Jones wrote: > The original idea was to use this as an extra protection, ie so users don't > describe a party's relationship with something else using a certain role if > the party isn't really in that role. > > The result, however, is that it is cumbersome, a real pain, and a common >

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-29 Thread Jacques Le Roux
From: "Adrian Crum" David E Jones wrote: On Dec 28, 2009, at 4:32 PM, Jacques Le Roux wrote: From: "Ean Schuessler" Jacques Le Roux wrote: Thanks, I saw that but was not sure how to use it. I remember now why I created Java services. I needed to create a PartyGroup. So initially I looked f

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-29 Thread Adrian Crum
David E Jones wrote: On Dec 28, 2009, at 4:32 PM, Jacques Le Roux wrote: From: "Ean Schuessler" Jacques Le Roux wrote: Thanks, I saw that but was not sure how to use it. I remember now why I created Java services. I needed to create a PartyGroup. So initially I looked for a service and found

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-28 Thread David E Jones
On Dec 28, 2009, at 4:32 PM, Jacques Le Roux wrote: > From: "Ean Schuessler" >> Jacques Le Roux wrote: >>> Thanks, I saw that but was not sure how to use it. I remember now why I >>> created Java services. I needed to create a PartyGroup. So initially I >>> looked for a service and found createP

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-28 Thread Jacques Le Roux
From: "Ean Schuessler" Jacques Le Roux wrote: Thanks, I saw that but was not sure how to use it. I remember now why I created Java services. I needed to create a PartyGroup. So initially I looked for a service and found createPartyGroup wich is implemented by a method in PartyServices.java. The

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-28 Thread Ean Schuessler
Jacques Le Roux wrote: > Thanks, I saw that but was not sure how to use it. I remember now why I > created Java services. I needed to create a PartyGroup. So initially I > looked for a service and found createPartyGroup wich is implemented by a > method in PartyServices.java. Then I continued in Ja

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-28 Thread Jacques Le Roux
From: "Jacques Le Roux" From: "David E Jones" The reason to use SECAs is to avoid changing the current service. All you need to do is have another service run before the PartyRelationship create/update services that checks to see if there is a PartyRole record and if not create it. In fact, I

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-28 Thread Jacques Le Roux
From: "David E Jones" The reason to use SECAs is to avoid changing the current service. All you need to do is have another service run before the PartyRelationship create/update services that checks to see if there is a PartyRole record and if not create it. In fact, I believe there is already

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread David E Jones
The reason to use SECAs is to avoid changing the current service. All you need to do is have another service run before the PartyRelationship create/update services that checks to see if there is a PartyRole record and if not create it. In fact, I believe there is already a service that does th

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread Jacques Le Roux
Hi David, I had a fresh look, I agree it can be easily written with simple-methods instead. I don't think I need SECAs, but I'm not quite sure right about that yet. I will rewrite it (notably the helpers are pretty useless). I was coding in Java and thought Java, so I forgot about the comfort m

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread Jacques Le Roux
Thanks for reviewing Scott, From: "Scott Gray" Hi Jacques, I haven't reviewed the actual logic but a few comments inline. Regards Scott HotWax Media http://www.hotwaxmedia.com On 27/12/2009, at 12:21 AM, jler...@apache.org wrote: Author: jleroux Date: Sat Dec 26 11:21:21 2009 New Revision

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread Jacques Le Roux
From: "David E Jones" Thanks for your review Scott. There really are a lot of issues with this commit... Nothing harmful though (or I did not spot it in) From a higher level perspective, why is this implemented with so much code and so many new files? I think all that is needed to implemen

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-26 Thread David E Jones
Thanks for your review Scott. There really are a lot of issues with this commit... >From a higher level perspective, why is this implemented with so much code and >so many new files? I think all that is needed to implement this functionality >is a service definition, simple-method service impl

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-26 Thread Scott Gray
Hi Jacques, I haven't reviewed the actual logic but a few comments inline. Regards Scott HotWax Media http://www.hotwaxmedia.com On 27/12/2009, at 12:21 AM, jler...@apache.org wrote: Author: jleroux Date: Sat Dec 26 11:21:21 2009 New Revision: 893961 URL: http://svn.apache.org/viewvc?rev=89