Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-06 Thread BJ Freeman
I use the commits update my 9.04. I also use the ml to check on what has been done when something goes south. I will try to look at the commits. I have about 15 projects I am trying to complete so I am rather busy. = BJ Freeman http://bjfreeman.elance.com Strategic Power

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adam Heath
doo...@apache.org wrote: Author: doogie Date: Sun Apr 4 19:08:46 2010 New Revision: 930737 URL: http://svn.apache.org/viewvc?rev=930737view=rev Log: Make use of UtilObject.equalsHelper in storeAll. Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adrian Crum
Adam Heath wrote: doo...@apache.org wrote: Author: doogie Date: Sun Apr 4 19:08:46 2010 New Revision: 930737 URL: http://svn.apache.org/viewvc?rev=930737view=rev Log: Make use of UtilObject.equalsHelper in storeAll. Modified:

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Scott Gray
On 5/04/2010, at 5:11 PM, Adam Heath wrote: doo...@apache.org wrote: Author: doogie Date: Sun Apr 4 19:08:46 2010 New Revision: 930737 URL: http://svn.apache.org/viewvc?rev=930737view=rev Log: Make use of UtilObject.equalsHelper in storeAll. Modified:

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adam Heath
Scott Gray wrote: On 5/04/2010, at 5:11 PM, Adam Heath wrote: doo...@apache.org wrote: Author: doogie Date: Sun Apr 4 19:08:46 2010 New Revision: 930737 URL: http://svn.apache.org/viewvc?rev=930737view=rev Log: Make use of UtilObject.equalsHelper in storeAll. Modified:

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Scott Gray
On 5/04/2010, at 5:47 PM, Adam Heath wrote: Scott Gray wrote: On 5/04/2010, at 5:11 PM, Adam Heath wrote: doo...@apache.org wrote: Author: doogie Date: Sun Apr 4 19:08:46 2010 New Revision: 930737 URL: http://svn.apache.org/viewvc?rev=930737view=rev Log: Make use of

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Bob Morley
Is it reasonable for a non-commiter to review commits? To be honest, I never even considered that I should be doing that. However, two other things occurred to me ... Got the distinct feeling that this points to a not very good practice when it comes to unit testers. I definitely understand

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Tim Ruppert
+1 Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Apr 5, 2010, at 9:43 PM, Bob Morley wrote: I am definitely not a fisheye expert, but I would hope with its JIRA integration that something could be automated that would drive reviews

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Scott Gray
On 5/04/2010, at 9:43 PM, Bob Morley wrote: Is it reasonable for a non-commiter to review commits? To be honest, I never even considered that I should be doing that. Reasonable? It would be fantastic, we have 166 subscribers and very little feedback. However, two other things occurred

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adrian Crum
--- On Mon, 4/5/10, Bob Morley rmor...@emforium.com wrote: Is it reasonable for a non-commiter to review commits?  To be honest, I never even considered that I should be doing that. As an OFBiz user, it seems to me you would have a vested interest in reviewing commits. -Adrian

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Bob Morley
Scott Gray-2 wrote: Buildbot has been reporting failures since yesterday: http://ci.apache.org/waterfall?show=ofbiz-trunk The problem wasn't missed, I just think Adam was a little peeved that no one noticed his simple mistake in such as small commit. This isn't a dig at you, but talk is

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Scott Gray
On 5/04/2010, at 10:34 PM, Bob Morley wrote: Scott Gray-2 wrote: Buildbot has been reporting failures since yesterday: http://ci.apache.org/waterfall?show=ofbiz-trunk The problem wasn't missed, I just think Adam was a little peeved that no one noticed his simple mistake in such as small

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Scott Gray
On 5/04/2010, at 10:54 PM, Adam Heath wrote: Bob Morley wrote: Thanks for that url; very interesting indeed. From what I could tell the set of unit tests that execute are littered with failures (or they intentionally cause a lot stack traces due to exception). I've been trying to reduce

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adrian Crum
--- On Mon, 4/5/10, Scott Gray scott.g...@hotwaxmedia.com wrote: On 5/04/2010, at 10:54 PM, Adam Heath wrote: Bob Morley wrote: Thanks for that url; very interesting indeed.  From what I could tell the set of unit tests that execute are littered with failures (or they intentionally

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adam Heath
Bob Morley wrote: Adrian Crum-2 wrote: As an OFBiz user, it seems to me you would have a vested interest in reviewing commits. Agreed. Our fundamental problem (and this is definitely our problem) is that we branched off pretty badly and as a result, have not merged Ofbiz trunk in a

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adam Heath
Adrian Crum wrote: OfBiz is famous of catching an error, logging it, then rethrowing it. Repeat ad-infinitum. OfBiz is famous of catching an error, logging it, then rethrowing it. Repeat ad-infinitum. OfBiz is famous of catching an error, logging it, then rethrowing it. Repeat

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Bob Morley
Scott Gray-2 wrote: On 5/04/2010, at 10:54 PM, Adam Heath wrote: Bob Morley wrote: Thanks for that url; very interesting indeed. From what I could tell the set of unit tests that execute are littered with failures (or they intentionally cause a lot stack traces due to exception).

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adam Heath
Bob Morley wrote: Scott Gray-2 wrote: On 5/04/2010, at 10:54 PM, Adam Heath wrote: Bob Morley wrote: Thanks for that url; very interesting indeed. From what I could tell the set of unit tests that execute are littered with failures (or they intentionally cause a lot stack traces due to

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Adrian Crum
--- On Mon, 4/5/10, Adam Heath doo...@brainfood.com wrote: Bob Morley wrote: Scott Gray-2 wrote: On 5/04/2010, at 10:54 PM, Adam Heath wrote: Bob Morley wrote: Thanks for that url; very interesting indeed.  From what I could tell the set of unit tests that execute are littered

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread Scott Gray
On 5/04/2010, at 11:38 PM, Adrian Crum wrote: --- On Mon, 4/5/10, Adam Heath doo...@brainfood.com wrote: Bob Morley wrote: Scott Gray-2 wrote: On 5/04/2010, at 10:54 PM, Adam Heath wrote: Bob Morley wrote: Thanks for that url; very interesting indeed. From what I could tell the set

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-05 Thread David E Jones
On Apr 6, 2010, at 12:51 AM, Scott Gray wrote: On 5/04/2010, at 11:38 PM, Adrian Crum wrote: --- On Mon, 4/5/10, Adam Heath doo...@brainfood.com wrote: I just fixed the first. The others should have their logging fixed, don't change the log level for run-tests. If low-level code