Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6387 --- trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/M

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r// --- (Updated 2012-03-27 00:47:30.189828) Review request for oodt, Chris Mattmann, Ri

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

> On 2012-03-26 15:50:17, Chris Mattmann wrote: > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java, > > line 326 > > > > > > Are all of these @VisibleForTesting coupling our test system too muc

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6391 --- Ship it! LGTM! - Chris On 2012-03-27 00:47:30, brian Foster wrote:

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

> On 2012-03-22 07:15:57, Chris Mattmann wrote: > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java, > > line 90 > > > > > > does this make it so that Exception is never

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6280 --- trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorPro

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6349 --- Ship it! My comments are pretty minor, but check em' out. LGTM. tru

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r// --- (Updated 2012-03-25 01:55:32.563950) Review request for oodt, Chris Mattmann, Ri

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6215 --- looking good happy to review unit tests when they are there. LGTM dude

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6214 --- trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorPro