Re: Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23225/#review58968 --- On Oct. 20, 2014, 8:50 a.m., Azrael Park wrote: > > --

Re: Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

adoop/LauncherMapper.java 4923fe3 sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 8686a23 Diff: https://reviews.apache.org/r/23225/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Re: Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

23fe3 sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 8686a23 Diff: https://reviews.apache.org/r/23225/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Review Request 30308: OOZIE-2081 WorkflowJob notification to include coordinator action id

/TestWorkflowNotificationXCommand.java b427180 docs/src/site/twiki/WorkflowFunctionalSpec.twiki 21199e8 Diff: https://reviews.apache.org/r/30308/diff/ Testing --- UTC and manual testing Thanks, Azrael Park

Review Request 30310: OOZIE-2042 Max substitution for config variables should be configurable

/org/apache/oozie/util/TestXConfiguration.java e7d7d24 Diff: https://reviews.apache.org/r/30310/diff/ Testing --- UTC and manual testing. Thanks, Azrael Park

Re: Review Request 30310: OOZIE-2042 Max substitution for config variables should be configurable

e133838 core/src/main/resources/oozie-default.xml fcc73b8 core/src/test/java/org/apache/oozie/util/TestXConfiguration.java e7d7d24 Diff: https://reviews.apache.org/r/30310/diff/ Testing --- UTC and manual testing. Thanks, Azrael Park

Re: Review Request 30310: OOZIE-2042 Max substitution for config variables should be configurable

/java/org/apache/oozie/util/XConfiguration.java e133838 core/src/main/resources/oozie-default.xml 6f76b07 core/src/test/java/org/apache/oozie/util/TestXConfiguration.java e7d7d24 Diff: https://reviews.apache.org/r/30310/diff/ Testing --- UTC and manual testing. Thanks, Azrael Park

Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code

/TestZKUtilsWithSecurity.java ffced02 Diff: https://reviews.apache.org/r/31103/diff/ Testing --- Unit Test. Manual Test. Thanks, Azrael Park

Review Request 31255: OOZIE-1638 Action retry does not respect default retry max count

Diff: https://reviews.apache.org/r/31255/diff/ Testing (updated) --- Unit test. Thanks, Azrael Park

Re: Review Request 23301: OOZIE-1918 ActionXCommand refactoring

/TestEventGeneration.java 14f5294 Diff: https://reviews.apache.org/r/23301/diff/ Testing --- No added new testcase. Done manual test. Thanks, Azrael Park

Review Request 33108: OOZIE-2159 'oozie validate' command should be moved server-side

reviews.apache.org/r/33108/diff/ Testing (updated) --- Unit test. Manual test. Thanks, Azrael Park

Re: Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31103/#review79518 --- On Feb. 17, 2015, 3:44 a.m., Azrael Park wrote: > > -

Re: Review Request 33108: OOZIE-2159 'oozie validate' command should be moved server-side

ache/oozie/servlet/TestV2ValidateServlet.java PRE-CREATION docs/src/site/twiki/DG_CommandLineTool.twiki 9494b22 webapp/src/main/webapp/WEB-INF/web.xml d865d23 Diff: https://reviews.apache.org/r/33108/diff/ Testing --- Unit test. Manual test. Thanks, Azrael Park

Re: Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code

/java/org/apache/oozie/test/ZKXTestCaseWithSecurity.java f9f3e88 zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java ffced02 Diff: https://reviews.apache.org/r/31103/diff/ Testing --- Unit Test. Manual Test. Thanks, Azrael Park

Re: Review Request 33108: OOZIE-2159 'oozie validate' command should be moved server-side

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33108/#review80482 --- On April 15, 2015, 3:13 p.m., Azrael Park wrote: &

Re: Review Request 33108: OOZIE-2159 'oozie validate' command should be moved server-side

tomcat/ssl-web.xml 103e12d docs/src/site/twiki/DG_CommandLineTool.twiki 9494b22 docs/src/site/twiki/WebServicesAPI.twiki 3d97447 webapp/src/main/webapp/WEB-INF/web.xml d865d23 Diff: https://reviews.apache.org/r/33108/diff/ Testing --- Unit test. Manual test. Thanks, Azrael Park

Review Request 33470: OOZIE-2163 Remove CoordinatorStore

/java/org/apache/oozie/test/XDataTestCase.java e885892 core/src/test/java/org/apache/oozie/test/XTestCase.java 27cbdc9 Diff: https://reviews.apache.org/r/33470/diff/ Testing (updated) --- Unit test. Thanks, Azrael Park

Re: Review Request 33470: OOZIE-2163 Remove CoordinatorStore

/apache/oozie/test/XDataTestCase.java e885892 core/src/test/java/org/apache/oozie/test/XTestCase.java 27cbdc9 Diff: https://reviews.apache.org/r/33470/diff/ Testing --- Unit test. Thanks, Azrael Park

Re: Review Request 33108: OOZIE-2159 'oozie validate' command should be moved server-side

tomcat/ssl-web.xml 103e12d docs/src/site/twiki/DG_CommandLineTool.twiki 9494b22 docs/src/site/twiki/WebServicesAPI.twiki 3d97447 webapp/src/main/webapp/WEB-INF/web.xml d865d23 Diff: https://reviews.apache.org/r/33108/diff/ Testing --- Unit test. Manual test. Thanks, Azrael Park

Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

-utils-1/pom.xml 0d10e7a pom.xml b5e0e4e Diff: https://reviews.apache.org/r/21312/diff/ Testing --- Thanks, Azrael Park

Re: Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

/ Testing --- Thanks, Azrael Park

Re: Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

hadooplibs/pom.xml 788788c pom.xml b5e0e4e tools/pom.xml 487783d Diff: https://reviews.apache.org/r/21312/diff/ Testing --- Thanks, Azrael Park

Review Request 22451: OOZIE-1654 Fix typo (inteval to interval)

--- Thanks, Azrael Park

Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand to an XCommand and remove Command

. Manual test done. Thanks, Azrael Park

Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand to an XCommand and remove Command

/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/22491/#comment80480> I removed it already. core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/22491/#comment80481> Yes, comment will be addressed. - Azrael Park

Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand to an XCommand and remove Command

Diff: https://reviews.apache.org/r/22491/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand to an XCommand and remove Command

test done. Thanks, Azrael Park

Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand to an XCommand and remove Command

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22491/#review45603 --- On June 16, 2014, 5:48 a.m., Azrael Park wrote: > > --- > This is an automatically

Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

/org/apache/oozie/action/hadoop/LauncherMapper.java 322f498 sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java ce8a09b Diff: https://reviews.apache.org/r/23225/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Re: Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

/apache/oozie/action/hadoop/TestSqoopActionExecutor.java ce8a09b Diff: https://reviews.apache.org/r/23225/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Review Request 23301: OOZIE-1918 ActionXCommand refactoring

://reviews.apache.org/r/23301/diff/ Testing --- No added new testcase. Done manual test. Thanks, Azrael Park

Review Request 23407: OOZIE-1927 Use StoreStatusFilter for WorkflowsJobGetJPAExecutor

test done. Thanks, Azrael Park

Re: Review Request 23301: OOZIE-1918 ActionXCommand refactoring

--- No added new testcase. Done manual test. Thanks, Azrael Park

Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

/command/wf/SignalXCommand.java 4a7283f core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff Diff: https://reviews.apache.org/r/23968/diff/ Testing --- Done manual test. Thanks, Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

/test/java/org/apache/oozie/util/TestXLog.java 824e5dc Diff: https://reviews.apache.org/r/23968/diff/ Testing --- Done manual test. Thanks, Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

/23968/diff/ Testing --- Done manual test. Thanks, Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

/TestXLog.java 824e5dc Diff: https://reviews.apache.org/r/23968/diff/ Testing --- Done manual test. Thanks, Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

To reply, visit: https://reviews.apache.org/r/23968/#review49595 --- On Aug. 6, 2014, 6:40 a.m., Azrael Park wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

able. log() should use this > > prefix Yes, will fix. - Azrael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23968/#review49873 -------

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

/ Testing --- Done manual test. Thanks, Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

ill use the old prefix Yes, will call resetPrefix. - Azrael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23968/#review50020 --- On Aug

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

; Info.get().getPrefix(). Audit log sets XLog.prefix, so it never uses > > Info.get().getPrefix() Ok - Azrael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23968/#

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

: https://reviews.apache.org/r/23968/diff/ Testing --- Done manual test. Thanks, Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

quired? not required. - Azrael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23968/#review50415 --- On Aug. 11, 2

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

test. Thanks, Azrael Park

Review Request 24837: OOZIE-1779 Add parent-id as a filter option

core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java ff87c10 core/src/test/java/org/apache/oozie/store/TestStoreStatusFilter.java PRE-CREATION Diff: https://reviews.apache.org/r/24837/diff/ Testing --- Unit test done. Manaul test done. Thanks, Azrael Park

Re: Review Request 24837: OOZIE-1779 Add parent-id as a filter option

/oozie/store/TestStoreStatusFilter.java PRE-CREATION Diff: https://reviews.apache.org/r/24837/diff/ Testing --- Unit test done. Manaul test done. Thanks, Azrael Park

Re: Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

https://reviews.apache.org/r/21312/diff/ Testing --- Thanks, Azrael Park

Re: Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

--- Thanks, Azrael Park

Re: Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

e124e24 hadooplibs/hadoop-utils-1/pom.xml dfeb4ff hadooplibs/pom.xml 29c891a pom.xml 835ec19 tools/pom.xml a8c69cc Diff: https://reviews.apache.org/r/21312/diff/ Testing --- Thanks, Azrael Park

Re: Review Request 21312: OOZIE-1830 Change hadoop-1 profile to use 1.2.1

/ Testing --- Thanks, Azrael Park

Review Request 25531: OOZIE-1936 Queuedump command should display queue information for all server.

/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Re: Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

/hadoop/LauncherMapper.java 4923fe3 sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 8686a23 Diff: https://reviews.apache.org/r/23225/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park

Re: Review Request 23225: OOZIE-1890 Make oozie-site empty and reconcile defaults between oozie-default and the code

sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 8686a23 Diff: https://reviews.apache.org/r/23225/diff/ Testing --- Unit test done. Manual test done. Thanks, Azrael Park