Re: logo contest on JIRA

2012-12-11 Thread David Blevins
On Dec 11, 2012, at 12:50 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: a quick word to share a little thought: was the fact to do the logo contest on JIRA a good idea? we have pretty bad stats now mainly because of it ;) Who knows if it was good idea or not :) It seems to be

Extending the logo contest?

2012-12-11 Thread David Blevins
What do people think about extending the logo contest? As these things go, no one participates until other people participate. Once the ball gets rolling, though, it really rolls. Ours just started to roll in the last two weeks. Now we're getting logo submissions on a pretty regular basis.

Re: Extending the logo contest?

2012-12-11 Thread dsh
Take into account that we have upcoming holidays where some might be unavailable ;) Cheers Daniel On Tue, Dec 11, 2012 at 10:37 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: i'd say the 2nd of juanuary then we choose for beginning of february wdyt? Romain Manni-Bucau Twitter:

Re: [VOTE] OpenEJB 4.5.1/TomEE 1.5.1 (staging-132)

2012-12-11 Thread AndyG
+0 Still some minor Win platform test failures. We should disable the tests. Other than that everything looks good to go. -- View this message in context: http://openejb.979440.n4.nabble.com/VOTE-OpenEJB-4-5-1-TomEE-1-5-1-staging-132-tp4659354p4659401.html Sent from the OpenEJB Dev mailing

Re: Fwd: svn commit: r1420061 - in /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb: config/AppInfoBuilder.java util/JarExtractor.java

2012-12-11 Thread AndyG
Here is a really good write up that I subscribe to that in addition to the 'Final fields' section has some really good links to other 'field' related resources. http://www.ibm.com/developerworks/java/library/j-jtp1029/index.html I have also based my use of final fields on the exposure of

Re: Fwd: svn commit: r1420061 - in /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb: config/AppInfoBuilder.java util/JarExtractor.java

2012-12-11 Thread AndyG
Oops, sorry completely misread your question - The answer is almost the same the though. I have avoided subtle bugs by using 'this' I guess that 'this' is more for readability. I'll stop doing it on OpenEJB code if it is considered overkill. Andy. -- View this message in context:

Re: Fwd: svn commit: r1420061 - in /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb: config/AppInfoBuilder.java util/JarExtractor.java

2012-12-11 Thread Romain Manni-Bucau
hmm, didn't find mention of this usage in this doc maybe i was not clear so trying to be a bit more: updating code to use final is IMO a nice update. The update i don't get is why replacing foo() by this.foo(). If the call is ambiguous it is a bad practice and if it is not it makes code a bit

Re: Fwd: svn commit: r1420061 - in /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb: config/AppInfoBuilder.java util/JarExtractor.java

2012-12-11 Thread AndyG
I guess the most obvious subtle bug avoided by 'this' that I can think of is the use of same named method and field variables, often in abstract classes. I have seen the the 'super' being set where the 'this' was intended, and vice versa. -- View this message in context:

Re: Fwd: svn commit: r1420061 - in /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb: config/AppInfoBuilder.java util/JarExtractor.java

2012-12-11 Thread Romain Manni-Bucau
well it sound like a design bug for me, but once again, i'll not revert such a commit ;). Was just curious cause i usually try to avoid this usage. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github:

Re: [VOTE] OpenEJB 4.5.1/TomEE 1.5.1 (staging-132)

2012-12-11 Thread Thiago Veronezi
+1 On Tue, Dec 11, 2012 at 5:20 AM, AndyG andy.gumbre...@orprovision.com wrote: +0 Still some minor Win platform test failures. We should disable the tests. Other than that everything looks good to go. -- View this message in context:

Re: [VOTE] OpenEJB 4.5.1/TomEE 1.5.1 (staging-132)

2012-12-11 Thread Joerg Jans
+1 I just tested our project with the preview of 1.5.1 running on a windows machine. All the problems we encountered with 1.5 are gone. -- View this message in context: http://openejb.979440.n4.nabble.com/VOTE-OpenEJB-4-5-1-TomEE-1-5-1-staging-132-tp4659354p4659428.html Sent from the OpenEJB

Re: Extending the logo contest?

2012-12-11 Thread David Blevins
On Dec 11, 2012, at 2:09 AM, dsh daniel.hais...@gmail.com wrote: Take into account that we have upcoming holidays where some might be unavailable ;) Right, that's why I suggest mid January. Around December 20th to January 3rd is a blackout period. You can see it in our stats like clockwork

Re: [VOTE] OpenEJB 4.5.1/TomEE 1.5.1 (staging-132)

2012-12-11 Thread David Blevins
On Dec 10, 2012, at 5:48 AM, Jean-Louis MONTEIRO jeano...@gmail.com wrote: Binaries Source: http://people.apache.org/~jlmonteiro/staging-132/openejb-4.5.1/ Whoops. I just noticed the OpenEJB Standalone zip/tar are not in the binaries directory. This is a bug in the release-tools I

Re: svn commit: r1420061 - in /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb: config/AppInfoBuilder.java util/JarExtractor.java

2012-12-11 Thread David Blevins
On Dec 11, 2012, at 2:52 AM, AndyG andy.gumbre...@orprovision.com wrote: If I have my way I would prefer a 'mutable' keyword, with the default being 'immutable' (final) ;-). Man after my own heart :) http://blog.dblevins.com/2011/04/final-is-my-favorit-java-keyword.html An update to that