nemux opened a new pull request #60:
URL: https://github.com/apache/openjpa/pull/60
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nemux opened a new pull request #61:
URL: https://github.com/apache/openjpa/pull/61
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
solomax commented on issue #61:
URL: https://github.com/apache/openjpa/pull/61#issuecomment-617506092
Thanks for the contribution!
This is an automated message from the Apache Git Service.
To respond to the message, please lo
vorburger commented on pull request #61:
URL: https://github.com/apache/openjpa/pull/61#issuecomment-619534999
@nemux nice! Keep it coming.
This is an automated message from the Apache Git Service.
To respond to the messa
ilgrosso merged pull request #62:
URL: https://github.com/apache/openjpa/pull/62
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ilgrosso opened a new pull request #62:
URL: https://github.com/apache/openjpa/pull/62
I recently found that, under some circumstances that I am unfortunately not
able to reproduce, I started getting `ArrayIndexOutOfBoundsException`from the
`PrimaryRow` class.
The attached fix is si
rmannibucau commented on pull request #62:
URL: https://github.com/apache/openjpa/pull/62#issuecomment-641227764
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ilgrosso commented on pull request #62:
URL: https://github.com/apache/openjpa/pull/62#issuecomment-641226604
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
eolivelli opened a new pull request #63:
URL: https://github.com/apache/openjpa/pull/63
- implement HerdDBDictionary
- add autodiscovery of HerdDB
This is an automated message from the Apache Git Service.
To respond to the
rmannibucau merged pull request #63:
URL: https://github.com/apache/openjpa/pull/63
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jgrassel opened a new pull request #64:
URL: https://github.com/apache/openjpa/pull/64
OpenJPA's class transformer was designed in a time when ClassLoader access
was synchronized. Because it was assumed that if the ClassLoader caused another
class to load while it was already enhancing a c
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657642869
Will create a trunk PR after this has been reviewed.
This is an automated message from the Apache Git Service.
To r
ilgrosso commented on pull request #63:
URL: https://github.com/apache/openjpa/pull/63#issuecomment-657652349
...no tests at all?
This is an automated message from the Apache Git Service.
To respond to the message, please log
rmannibucau commented on pull request #63:
URL: https://github.com/apache/openjpa/pull/63#issuecomment-657671825
@ilgrosso IT are coming but are IT (for ext db they are only meaningful if
covering 100% of db version otherwise it is like having no test for all other
versions ;)). We also ha
ilgrosso edited a comment on pull request #63:
URL: https://github.com/apache/openjpa/pull/63#issuecomment-657676916
We do have tests for other in-memory dbms, I was thinking to include the new
one.
...and "some test" is always better than "no tests".
--
ilgrosso edited a comment on pull request #63:
URL: https://github.com/apache/openjpa/pull/63#issuecomment-657676916
We do have tests for other in-memory dbms, I was thinking to include the
news one.
...and "some test" is always better than "no tests".
-
ilgrosso commented on pull request #63:
URL: https://github.com/apache/openjpa/pull/63#issuecomment-657676916
We do have treats for other in-memory dbms, I was thinking to include the
news one.
...and "some test" is always better than "no tests".
---
rmannibucau commented on pull request #63:
URL: https://github.com/apache/openjpa/pull/63#issuecomment-657680377
@ilgrosso agree, point was more that IMHO it is more important to make it
its way on master than to get an IT which is not straight forward yet (a mix
between both the DB and ou
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657685084
@jgrassel , for now I'm trying to see in which case we need that. Say me if
I'm wrong but the scope is only about the javaagent (other cases - ie container
deployment enhancemen
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657690775
@rmannibucau This issue was brought to my awareness after Open Liberty's
application classloader was updated to allow multi-threaded concurrency (even
though concurrency was allow
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657693580
@jgrassel can you thread dump (even with a monkey patch) when the issue
occurs? OpenLiberty is supposed to have the EMF ready during CDI boot (I know
there is a chicken egg issu
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657699740
True, OpenLiberty creates the EMF during application start (it has to, in
order to register the Class Transformer [with the application classloader]
before any of the persistent ca
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657701193
Now, I can try to come up with an example to demonstrate it, but I am on a
very tight deadline, so I can agree to delay committing the update to trunk,
but I'm going to insist on t
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657703700
(updated the commit to rename `_tl` to `_isTransformingInLocalThread` based
on a review comment by Albert. Thanks!)
--
jgrassel merged pull request #64:
URL: https://github.com/apache/openjpa/pull/64
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657757931
@jgrassel Hmm, a few things which makes this fix looking very weird to me:
1. fact is it is already synchronized by metadatarepository until
Preload=true (see org.apache.o
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657767799
I asked Albert via company internal slack to review my changes, he's not set
up a link between github and apache yet.
-
jgrassel edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657767799
I asked Albert via company internal slack to review my changes, he's not set
up a link between github and apache yet.
```
Joe Grassel 11:07 AM
Hey, Albert. Hop
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657775964
@rmannibucau
1. `preload=true` is not enabled by default (at least it is not in the 2.2.x
branch.) Therefore the MDR will lazily initialize itself in incrementals that
it f
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657785926
@jgrassel
1. hmm, depends once again the env, with a javaagent it will be triggered on
a new MyEntity() but on other cases it will not. And for javaagent this is not
an
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657785926
@jgrassel
1. hmm, depends once again the env, with a javaagent it will be triggered on
a new MyEntity() but on other cases it will not. And for javaagent this is n
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657789090
This has nothing to do with the temp classloader. The temp classloader
itself doesn't have an enhancer registered to it, it only exists as a means for
the persistence provider imp
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657792504
Personally, I'm not a fan of the "exclude list", because that adds a lot of
unnecessary processing time, as String comparing a jar with hundreds and even
thousands of classes again
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657842754
Okay, here is a maven project that will demonstrate the problem with an
application server using openjpa.
Couple of notes:
1. Yes, you can use the `mvn liberty:start` goal
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657859353
And in the OpenJPA case above, here is a cut of the trace log file showing
EntityA (thread 00a2) being enhanced, but EntityC (thread 00a3) is not:
```
[7/13/20 17:
jgrassel edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657842754
Okay, here is a maven project that will demonstrate the problem with an
application server using openjpa.
Couple of notes:
1. Yes, you can use the `mvn liberty:star
jgrassel edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657842754
Okay, here is a maven project that will demonstrate the problem with an
application server using openjpa.
Couple of notes:
1. Yes, you can use the `mvn liberty:star
struberg commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657993792
I've now read the SE7 documentation about a few times and I think the
ThreadLocal is not enough for this specific case. From the ClassLoader
doc it appears that the lock now got mo
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658034247
@struberg point is that the classloader does it and the transformer is
called under that lock already
@jgrassel will test your sample but today I'm off but I will come back to
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658034247
@struberg point is that the classloader does it and the transformer is
called under that lock already
@jgrassel will test your sample but today I'm off but I will come
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658034247
@struberg point is that the classloader does it and the transformer is
called under that lock already
@jgrassel will test your sample but today I'm off but I will come
rmannibucau opened a new pull request #65:
URL: https://github.com/apache/openjpa/pull/65
Follow up PR of https://github.com/apache/openjpa/pull/64
Goal is to let people test this proposed fix to ensure we didn't miss
anything in the analyzis.
--
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658318212
Created https://github.com/apache/openjpa/pull/65 as a proposed fix on
master if you want to give it a try.
jgrassel commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658319959
I've already stated I'm not a fan of the exclusion list, for something
that's going to be called once for every class that has to be checked to be
enhanced, let alone be enhanced,
jgrassel edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658319959
I've already stated I'm not a fan of the exclusion list, for something
that's going to be called once for every class that has to be checked to be
enhanced, let alone be enh
jgrassel edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658319959
I've already stated I'm not a fan of the exclusion list, for something
that's going to be called once for every class that has to be checked to be
enhanced, let alone be enh
rmannibucau edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658324978
@jgrassel commons is excluded and the jdk as well, just to skip reading the
bytecode (which is more costly than this exclusion list if you benchmark both
options so overa
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658324978
@jgrassel commons is excluded and the jdk as well, just to skip reading the
bytecode (which is more costly than this exclusion list if you benchmark both
options so overall the
jgrassel commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658326420
Yeah, I noticed that commons was excluded after taking a second look through
the change set, my comment update wasn't fast enough. =). I'm not sure I'm
clear on why the ThreadLocal
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658338171
@jgrassel The threadlocal - as the boolean today - just skips the
transformer, so it means that if a class must be enhanced and is loaded while
another is enhanced then it is sk
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658339925
Here's a version of the test bucket that will run with the jpa-2.2 complaint
version of OpenJPA
You'll need to edit the pom.xml file at the project root, and put in the
ful
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658340904
I was able to reproduce the enhancement failure issue with OpenJPA 3.1.0
this way on Open Liberty.
This is an auto
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658349573
@jgrassel thanks a lot, I was able to test it on 3.1.2 too and also checked
the proposed patch in my PR fixes that issue.
--
jgrassel commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658350601
@rmannibucau That optimization sounds like a violation of the
PersistenceUnitInfo contract:
```
/**
* Return a new instance of a ClassLoader that the provider may
* use
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658353355
@jgrassel yes it violates but it is important to have it when startup time
is needed otherwise you basically potentially load all your app twice for
nothing (or load it all in m
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658357931
Ok, glad to hear that it worked with 3.1.2!
This is an automated message from the Apache Git Service.
To respond to
jgrassel edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658357931
Ok, glad to hear that it worked with 3.1.2 (the patch that is)!
This is an automated message from the Apache
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658359342
@jgrassel not with 3.1.2 (:() but with a patched 3.1.3-SNAPSHOT (still
trying to find a good solution we both agree on before merging/pushing)
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658359342
@jgrassel not with 3.1.2 (:() but with a patched 3.1.3-SNAPSHOT (still
trying to find a good solution we both agree on before merging/pushing). Just
meant I can reproduc
struberg commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454594620
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(Met
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
struberg commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658421421
I still wonder if this whole `_transforming` boolean is a bit gone wrong?
A.) it is set in a different method than cleared! For no apparent reason.
This is not per se wrong,
rmannibucau commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454804045
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658559477
@struberg agree on A, B is true but likely slower than this exclusion list
(even if not sexy it is faster than a hashset in most cases and consumes way
less constant mem ;)), C
eolivelli opened a new pull request #66:
URL: https://github.com/apache/openjpa/pull/66
This is a draft PR.
I am trying to run all of the integration tests against HerdDB.
HerdDBDictionary enables aggressive use of delimiters, in order to not have
problems with the the long list of re
rmannibucau commented on pull request #66:
URL: https://github.com/apache/openjpa/pull/66#issuecomment-658586585
This is what does the getColumnAlias in the enclosing class so it looks good
to me, just requires to check all IT on all DB but I'm quite confident.
---
eolivelli closed pull request #66:
URL: https://github.com/apache/openjpa/pull/66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
eolivelli commented on pull request #66:
URL: https://github.com/apache/openjpa/pull/66#issuecomment-658740170
@rmannibucau @struberg I am closing this PR, superseded by #67
This is an automated message from the Apache Git
eolivelli commented on pull request #67:
URL: https://github.com/apache/openjpa/pull/67#issuecomment-659225545
this is not the right way :-(
This is an automated message from the Apache Git Service.
To respond to the message
eolivelli closed pull request #67:
URL: https://github.com/apache/openjpa/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
eolivelli opened a new pull request #68:
URL: https://github.com/apache/openjpa/pull/68
Reopening #66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
eolivelli commented on pull request #66:
URL: https://github.com/apache/openjpa/pull/66#issuecomment-659226910
GitHub does not allow me to reopen this PR, created #68 68
This is an automated message from the Apache Git Servic
eolivelli opened a new pull request #69:
URL: https://github.com/apache/openjpa/pull/69
While working at HerdDBDictionary I figured out that integration tests do
not work because of two problems:
- a bug in SelectImpl#getColumnAlias, in which we are not applying
delimiters to the column
eolivelli commented on pull request #68:
URL: https://github.com/apache/openjpa/pull/68#issuecomment-659466579
sorry for the noise, this patch makes sense only with #69
so I have merged the two patches
This is an automate
eolivelli closed pull request #68:
URL: https://github.com/apache/openjpa/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
eolivelli commented on pull request #69:
URL: https://github.com/apache/openjpa/pull/69#issuecomment-659466960
I will be happy to add tests in case the direction of this patch is good
This is an automated message from the Apa
rmannibucau commented on pull request #69:
URL: https://github.com/apache/openjpa/pull/69#issuecomment-659467892
@eolivelli looks "expected" to me but it needs harnessing for both changes
too IMHO
This is an automated messag
eolivelli commented on pull request #69:
URL: https://github.com/apache/openjpa/pull/69#issuecomment-660118706
@rmannibucau the patch became bigger as soon as I tried to add test cases.
Still it is not complete, I have to add a test case of the
SelectImpl#getColumnAlias case
This
rmannibucau commented on pull request #69:
URL: https://github.com/apache/openjpa/pull/69#issuecomment-660127090
@eolivelli it is ok to fix herddb dict there since it is fully related IMHO.
The first part of the diff is suspicious (schematool diff seems unnecessary and
getColumnNames chang
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456480105
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -329,10 +341,19 @@ public Column getColumn(String name) {
rmannibucau commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456493228
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -312,11 +315,20 @@ public String getResourceName() {
ret
rmannibucau commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456494234
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -329,10 +341,19 @@ public Column getColumn(String name) {
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456499123
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -312,11 +315,20 @@ public String getResourceName() {
retur
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456500957
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -329,10 +341,19 @@ public Column getColumn(String name) {
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456501604
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -312,11 +315,20 @@ public String getResourceName() {
retur
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456502732
##
File path:
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java
##
@@ -2711,7 +2711,7 @@ private String getColumnAlias(Column col, Pat
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456500957
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -329,10 +341,19 @@ public Column getColumn(String name) {
rmannibucau commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456512187
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -312,11 +315,20 @@ public String getResourceName() {
ret
eolivelli commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456514057
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -312,11 +315,20 @@ public String getResourceName() {
retur
rmannibucau commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456519302
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -329,10 +341,19 @@ public Column getColumn(String name) {
rmannibucau commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456519781
##
File path:
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java
##
@@ -2711,7 +2711,7 @@ private String getColumnAlias(Column col, P
rmannibucau commented on a change in pull request #69:
URL: https://github.com/apache/openjpa/pull/69#discussion_r456520863
##
File path: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Table.java
##
@@ -312,11 +315,20 @@ public String getResourceName() {
ret
eolivelli opened a new pull request #70:
URL: https://github.com/apache/openjpa/pull/70
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmannibucau commented on pull request #70:
URL: https://github.com/apache/openjpa/pull/70#issuecomment-660207978
Looks good to me now, only thing to decide is if we keep on push or not
(does not hurt I think and can be good for us).
Waiting for a passing build then I think we can merge.
ilgrosso commented on pull request #70:
URL: https://github.com/apache/openjpa/pull/70#issuecomment-660246008
@eolivelli why "only" `package`? Why not `install`?
@rmannibucau +1 to add it to push as well.
This is an au
eolivelli commented on pull request #70:
URL: https://github.com/apache/openjpa/pull/70#issuecomment-660260140
@ilgrosso thanks for your review
There is not need to 'install'.
With 'install' Maven copies the jar to .m2.
It looks like the build works without it.
Probably '
ilgrosso commented on pull request #70:
URL: https://github.com/apache/openjpa/pull/70#issuecomment-660275467
Agree then, go on with verify
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 336 matches
Mail list logo
