Re: Re[6]: Google Closure Whiteboard

2013-08-02 Thread Andun Sameera
Hi Maxim, Here is the feature table you requested, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF,

Re: Re[6]: Google Closure Whiteboard

2013-08-02 Thread Maxim Solodovnik
Thanks! please also include What is currently missing is the ability to limit WB in size (currently you can scroll endlessly to any direction) I believe there are some more features from my previous email, this is to priority! On Fri, Aug 2, 2013 at 5:53 PM, Andun Sameera andun...@gmail.com

Re: Re[6]: Google Closure Whiteboard

2013-07-26 Thread Andun Sameera
Hi Maxim, The evaluation will begin on 29th. I will fil the form on that day. Is there any comments or instructions to proceed forward? Thanks! On Mon, Jul 22, 2013 at 8:11 AM, Andun Sameera andun...@gmail.com wrote: Thanks Maxim! On Jul 22, 2013 7:51 AM, Maxim Solodovnik

Re: Re[6]: Google Closure Whiteboard

2013-07-21 Thread Maxim Solodovnik
Hello Andun, I'll double check the docs, As I can see right now you should fill you evaluation form in Melange. I'll try to review your code today. And I guess we need to schedule meeting to discuss what should be done next On Mon, Jul 22, 2013 at 1:59 AM, Andun Sameera andun...@gmail.com

Re: Re[6]: Google Closure Whiteboard

2013-07-19 Thread Andun Sameera
Hi Maxim, I have implemented the whiteboard cleaning logic. Thanks! On Tue, Jul 16, 2013 at 11:39 AM, Andun Sameera andun...@gmail.com wrote: OK Maxim! @Andrey, Corrected. Sorry my bad! :) Thanks! On Tue, Jul 16, 2013 at 11:37 AM, Maxim Solodovnik solomax...@gmail.comwrote: Hello

Re: Re[6]: Google Closure Whiteboard

2013-07-15 Thread Maxim Solodovnik
Hello Andun, Can you please tell me what is the license for the images used in this Whiteboard component? Comments: 1) WhiteboardBehavior.respond method: heavy copy/paste should be removed 2) instead of having static getter for all of your elements you can have constructor accepting JSONObject 3)

Re: Re[6]: Google Closure Whiteboard

2013-07-15 Thread Maxim Solodovnik
Additionally: there is no need to perform hashmap.remove(key); hashmap.put(key, value); according to javadoc: http://docs.oracle.com/javase/6/docs/api/java/util/HashMap.html#put(K, V) If the map previously contained a mapping for the key, the old value is replaced. On Tue, Jul 16, 2013 at 12:32

Re: Re[6]: Google Closure Whiteboard

2013-07-15 Thread Andun Sameera
Hi Maxim, I think Andrey knows the licenses level details about images. Other than that I have fixed the things you have asked. You can build the Whiteboard-Wicket https://github.com/andunslg/Whiteboard-Wicket project and run the

Re: Re[6]: Google Closure Whiteboard

2013-07-15 Thread Maxim Solodovnik
Thanks Andun :) Here are couple more comments: 1) WhiteboardBehavior.respond: how the string editedElement looks like? Maybe it is better to create *enum* with element names and use *switch*instead of nested if...else...if 2) WhiteboardBehavior.renderHead: I would recommend JSONArray instead of

Re: Re[6]: Google Closure Whiteboard

2013-07-15 Thread Andun Sameera
Hi Maxim, The editedElement looks like {id: 0, type: PointFree, x: -614, y: 57}. I tried to use a enum with values. But it got bit harder. Thus I have made the else if ladder a simple one with some changes. Also I have done all the changes which you have requested! I need another small

Re: Re[6]: Google Closure Whiteboard

2013-07-08 Thread Andun Sameera
Hi Maxim, I have implemented following, - WhiteboardPanel - WhiteboardBehaviour with Synchronization implemented Now whiterboard working well I think. You can find the code in https://github.com/andunslg/Whiteboard-Wicket and a sample app in

Re: Re[6]: Google Closure Whiteboard

2013-07-07 Thread Andun Sameera
Hi Maxim, Need your assistance in figuring out the whitboard synchronization logic. Currently what we have is this. - WhiteboardBehaviour which can be applied in this format, WhiteboardBehavior whiteboardBehavior=new WhiteboardBehavior(whiteboard); - When this is added to a page, all the