Re: AOO debugging revamp

2017-01-30 Thread Damjan Jovanovic
Thank you. I've now committed the patch with some improvements in r1781019. On Tue, Jan 31, 2017 at 6:55 AM, Patricia Shanahan wrote: > I did some more testing, and it seems to be a Visual Studio weirdness. It > was showing my breakpoint as "no symbols loaded". However, when I ran

Re: AOO debugging revamp

2017-01-30 Thread Patricia Shanahan
I did some more testing, and it seems to be a Visual Studio weirdness. It was showing my breakpoint as "no symbols loaded". However, when I ran a test case that I know goes through that breakpoint, it turned red and worked. On 1/30/2017 8:28 PM, Damjan Jovanovic wrote: That's unusual. It

Re: AOO debugging revamp

2017-01-30 Thread Damjan Jovanovic
That's unusual. It should either fix it for all gbuild modules, or none of them. In the build log for main/sw, is "-DEBUG" passed to the linker? Please send it through if unsure. I haven't had a chance to test it myself as debugging is currently broken with precompiled headers, and my Windows VM

Re: AOO debugging revamp

2017-01-30 Thread Patricia Shanahan
Applying the patch fixed the vcl case, but not the one I really care about, main/sw On 1/29/2017 6:51 PM, Patricia Shanahan wrote: On 1/29/2017 5:59 PM, Damjan Jovanovic wrote: I am trying a Windows rebuild now. In the meanwhile, what debugger are you using? Can you debug any other modules,

Re: AOO debugging revamp

2017-01-29 Thread Patricia Shanahan
On 1/29/2017 5:59 PM, Damjan Jovanovic wrote: I am trying a Windows rebuild now. In the meanwhile, what debugger are you using? Can you debug any other modules, eg. vcl which uses gbuild, or sal which uses dmake? I'm using Visual Studio Community 2013. sal: Yes, at least the breakpoint

Re: AOO debugging revamp

2017-01-29 Thread Damjan Jovanovic
I am trying a Windows rebuild now. In the meanwhile, what debugger are you using? Can you debug any other modules, eg. vcl which uses gbuild, or sal which uses dmake? It's possible that Windows also needs gb_LinkTarget_LDFLAGS += -DEBUG to enable debugging, as per the "ifeq ($(gb_DEBUGLEVEL),2)"

Re: AOO debugging revamp

2017-01-29 Thread Patricia Shanahan
On 1/25/2017 9:35 AM, Damjan Jovanovic wrote: Hi For a while I've noticed how gbuild modules don't have debug symbols unless built with the maximum debug level ("./configure --enable-debug" globally or "build debug=true" per module) which also produces oceans of log messages we usually don't

Re: AOO debugging revamp

2017-01-25 Thread Don Lewis
On 25 Jan, Damjan Jovanovic wrote: > Hi > > For a while I've noticed how gbuild modules don't have debug symbols unless > built with the maximum debug level ("./configure --enable-debug" globally > or "build debug=true" per module) which also produces oceans of log > messages we usually don't

AOO debugging revamp

2017-01-25 Thread Damjan Jovanovic
Hi For a while I've noticed how gbuild modules don't have debug symbols unless built with the maximum debug level ("./configure --enable-debug" globally or "build debug=true" per module) which also produces oceans of log messages we usually don't want. In r1780246, I've finally changed debugging