From: Daniele Di Proietto diproiet...@vmware.com
Non pmd threads have a core_id == UINT32_MAX, while queue ids used by
netdevs range from 0 to the number of CPUs. Therefore core ids cannot
be used directly to select a queue.
This commit introduces a simple mapping to fix the problem: non pmd
-Original Message-
From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
Sent: Thursday, May 28, 2015 5:58 PM
To: Gray, Mark D
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Fix non-pmd thread queue id.
On 28/05/2015 17:16, Gray, Mark D
Hmm, do we install anything else Python-based on hypervisors?
Yes, but they don't use the OVS Python modules. Those scripts build
ovs-vsctl commands[1]. I don't think porting the OVS modules to a
newer Python would impact those.
[1]
What if we apply these to the ovn branch, and then plan to merge ovn
into master only after OVS 2.4 is released?
That's sounds fine to me.
I'll update the related mailing list threads when I hear more back from Citrix.
___
dev mailing list
From: Saloni Jain saloni.j...@tcs.com
This commit enables the eviction mechanism on the basis of importance as
per the openflow specification 1.4.
ovs-ofctl -O OpenFlow14 mod-table switch table evict
Enable eviction on table of switch. Eviction adds a mechanism
enabling the switch to
On 29/05/2015 12:44, Gray, Mark D mark.d.g...@intel.com wrote:
-Original Message-
From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
Sent: Thursday, May 28, 2015 5:58 PM
To: Gray, Mark D
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Fix non-pmd
On Fri, May 29, 2015 at 10:20 AM, Joe Stringer joestrin...@nicira.com wrote:
On 28 May 2015 at 18:39, Jesse Gross je...@nicira.com wrote:
On Wed, May 27, 2015 at 3:18 PM, Andy Zhou az...@nicira.com wrote:
On Wed, May 27, 2015 at 10:48 AM, Jesse Gross je...@nicira.com wrote:
Even though
On Fri, May 29, 2015 at 10:43 AM, Ben Pfaff b...@nicira.com wrote:
I'm seeing the following new warnings from the Geneve patch checked in
recently:
../lib/odp-util.c:2936:30: error: cast from 'uint8_t *' (aka 'unsigned
char *')
to 'struct geneve_opt *' increases required
On Thu, Apr 09, 2015 at 06:40:10PM -0700, Andy Zhou wrote:
Backlogged connection test tests jsonrpc monitor's ability to combine
updates. Adding multiple clients to ensure that non-blocking clients
will get individual updates while blocking clients will get combined
updates.
Signed-off-by:
On Thu, Apr 09, 2015 at 06:40:11PM -0700, Andy Zhou wrote:
jsonrpc-server.c has two main functions. One deals with handling the
jsonrpc connections, the other deals with monitoring the database.
Currently, each jsonrpc connections has its own set of DB monitors.
This can be wasteful if a
On Thu, Apr 09, 2015 at 06:40:16PM -0700, Andy Zhou wrote:
split out per monitoring needs_flush() into
ovsdb_monitor_needs_flush().
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: no change
v2-v3: no change
Acked-by: Ben Pfaff b...@nicira.com
On Thu, Apr 09, 2015 at 06:40:18PM -0700, Andy Zhou wrote:
Add ovsdb_monitor_destory() function to properly cleanup ovsdb_monitor.
It is also responsible for unhook from the replica chain.
The replica destroy callback is now called
ovsdb_monitor_destroy_callback()
Minor variable renaming
On Thu, Apr 09, 2015 at 06:40:20PM -0700, Andy Zhou wrote:
Refactoring ovsdb_monitor_get_initial() to not generate JSON object.
It only collect changes within the ovsdb_monitor().
ovsdb_jsonrpc_monitor_compose_table_update() is then used to generate
JSON object.
This change will also make
On Thu, Apr 09, 2015 at 06:40:21PM -0700, Andy Zhou wrote:
Currently, each ovsdb-monitor points to a single jsonrpc_monitor object.
This means there is 1:1 relationship between them.
In case multiple jsonrpc-monitors need to monitor the same tables and
the columns within them, then can share
For conducting Header Space Analysis (HSA), we convert the wildcarded
OpenFlow flow represented by 'struct match' into an encoded byte array.
To further save memory, we use a sparse array to represent such byte
array in the same way as 'struct miniflow'. So, this commit implements
the structs and
On Thu, May 28, 2015 at 09:10:41PM -0300, Flavio Leitner wrote:
The BuildRequires tells upfront which packages should be
installed in order to build the openvswitch rpm packages.
Signed-off-by: Flavio Leitner f...@redhat.com
Thanks, applied to branch-2.3.
On 28 May 2015 at 18:39, Jesse Gross je...@nicira.com wrote:
On Wed, May 27, 2015 at 3:18 PM, Andy Zhou az...@nicira.com wrote:
On Wed, May 27, 2015 at 10:48 AM, Jesse Gross je...@nicira.com wrote:
Even though userspace does not yet support Geneve options,
the kernel does and there is some
On Tue, Mar 03, 2015 at 01:28:32PM -0800, Ben Pfaff wrote:
There are a couple of cases where OpenFlow 1.0 controllers that use
Nicira extensions can get OFPBMC_BAD_FIELD, so we should have an error
code for it in that protocol.
Reported-by: Soner Sevinc sevi...@vmware.com
Signed-off-by: Ben
Clang complains about the fact that we use a byte array to scan
Geneve attributes into since there are different alignment requirements:
lib/odp-util.c:2936:30: error: cast from 'uint8_t *' (aka 'unsigned char *') to
'struct geneve_opt *' increases required alignment from 1 to 2
On 29 May 2015 at 10:46, Jesse Gross je...@nicira.com wrote:
Clang complains about the fact that we use a byte array to scan
Geneve attributes into since there are different alignment requirements:
lib/odp-util.c:2936:30: error: cast from 'uint8_t *' (aka 'unsigned char *')
to
On Thu, Apr 09, 2015 at 06:40:23PM -0700, Andy Zhou wrote:
jsonrpc_monitor_compose_update() seems to fit better than
jsonrpc_monitor_compose_table_update(), since it composes changes
from all tables. Albeit the original one is named after the
table-updates object described in RFC 7047.
On Thu, Apr 09, 2015 at 06:40:23PM -0700, Andy Zhou wrote:
jsonrpc_monitor_compose_update() seems to fit better than
jsonrpc_monitor_compose_table_update(), since it composes changes
from all tables. Albeit the original one is named after the
table-updates object described in RFC 7047.
Thx a lot for the comments,
- Fixed the sparse warning,
- For the function usage, here is my judge:
The hsbm_complement and hsbm_intersect are the two most called
function.
Actually, I spotted that hsbm_intersect can be made more efficient,
- Also thx for the stylistic suggestions,
On Thu, Apr 09, 2015 at 06:40:14PM -0700, Andy Zhou wrote:
To hide ovsdb_monitor_table object from ovsdb_jsonrpc serve.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: style fixes
v2-v3: no change
Acked-by: Ben Pfaff b...@nicira.com
Acked-by: Jarno Rajahalme jrajaha...@nicira.com
On May 29, 2015, at 10:41 AM, Ben Pfaff b...@nicira.com wrote:
On Tue, Mar 03, 2015 at 01:28:32PM -0800, Ben Pfaff wrote:
There are a couple of cases where OpenFlow 1.0 controllers that use
Nicira extensions can get OFPBMC_BAD_FIELD, so we
On Thu, Apr 09, 2015 at 06:40:15PM -0700, Andy Zhou wrote:
Now it simply calls ovsdb_monitor_compose_table_update(), which
is actually creates the json object.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: no change
v2-v3: no change
s/is
On Thu, Apr 09, 2015 at 06:40:17PM -0700, Andy Zhou wrote:
rename ovsdb_jsonrpc_monitor_get_initial() to
ovsdb_monitor_get_initial()
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: no change
v2-v3: no change
Acked-by: Ben Pfaff b...@nicira.com
On Thu, Apr 09, 2015 at 06:40:19PM -0700, Andy Zhou wrote:
Added new files monitor.[ch] for monitor backend functions.
There is no functional changes.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: rename ovsdb-monitor.[ch] to monitor.[ch]
On Thu, Apr 09, 2015 at 06:40:22PM -0700, Andy Zhou wrote:
With N:1 mappings, multiple jsonrpc server may be servicing the rpc
connection at a different pace. ovsdb-monitor thus needs to maintain
different change sets, depends on connection speed of each rpc
connections. Connections servicing
On Fri, May 29, 2015 at 10:50 AM, Joe Stringer joestrin...@nicira.com wrote:
On 29 May 2015 at 10:46, Jesse Gross je...@nicira.com wrote:
Clang complains about the fact that we use a byte array to scan
Geneve attributes into since there are different alignment requirements:
On Thu, Apr 09, 2015 at 06:40:12PM -0700, Andy Zhou wrote:
To make ovsdb_monitor an opaque to ovsdb_jsonrpc server object.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
I think that the change from |= to = in this commit is going to break
some corner cases
On Thu, Apr 09, 2015 at 06:40:13PM -0700, Andy Zhou wrote:
Change ovsdb_jsonrpc_parse_monitor_request() to make
ovsdb_monitor_table an opaque object.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: style fix
v2-v3: no change
Acked-by: Ben Pfaff
On Fri, May 29, 2015 at 02:51:42PM -0700, Jesse Gross wrote:
On Fri, May 29, 2015 at 10:40 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote:
Don't panic, this is not a remote buffer overflow, only a bug in a program
parsing its input from the
parse_int_string() returns an error if the field overflows, not if there
is a bad hex digit.
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/learn.c| 4 ++--
tests/learn.at | 14 ++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/lib/learn.c b/lib/learn.c
index
On 29 May 2015 at 13:24, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 13, 2015 at 05:56:16PM -0700, Joe Stringer wrote:
Place all of the detected datapath features into a separate structure,
initialized when the dpif_backer is opened and shared with xbridges.
Signed-off-by: Joe Stringer
On 29 May 2015 at 13:26, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 13, 2015 at 05:56:17PM -0700, Joe Stringer wrote:
To be more explicit about which actions require datapath assistance,
split this out into a separate function. While this is fairly trivial
currently, there may be special
On Mon, May 18, 2015 at 04:10:12PM -0700, Jarno Rajahalme wrote:
Bundle add must use the same xid as the embedded message.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Good catch, thanks.
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing
On Mon, May 18, 2015 at 04:10:18PM -0700, Jarno Rajahalme wrote:
Makes add_flow() easier to read and understand.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
On Mon, May 18, 2015 at 04:10:19PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Hmm, ofproto_rule_create() returns ENOMEM instead of an ofperr on error,
we should fix that.
I see a few references to OFPROTO_POSTPONE in function comments too, we
should drop
On Mon, May 18, 2015 at 04:10:23PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 29, 2015 at 10:58 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:11PM -0700, Andy Zhou wrote:
jsonrpc-server.c has two main functions. One deals with handling the
jsonrpc connections, the other deals with monitoring the database.
Currently, each jsonrpc
On Fri, May 29, 2015 at 12:08 PM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:25PM -0700, Andy Zhou wrote:
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
v1-v2: maintain ovsdb_monitor_changes using hmap instead of linked
list.
On Fri, May 29, 2015 at 12:00 PM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:24PM -0700, Andy Zhou wrote:
Currently, each monitor table contains a single hmap 'changes' to
track updates. This patch introduces a new data structure
'ovsdb_monitor_changes' that stores the
On Fri, May 29, 2015 at 09:22:54PM +, Alin Serdean wrote:
Removing a variable which breaks the windows forwarding extension build.
The error:
warning C4189: 'bufContext' : local variable is initialized but not
referencedc:\temp_may\ovs\datapath-windows\ovsext\PacketIO.c
Thanks, I'll apply this in a minute.
On Fri, May 29, 2015 at 01:28:27PM -0700, Alex Wang wrote:
Acked-by: Alex Wang al...@nicira.com
On Fri, May 29, 2015 at 10:39 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Feb 25, 2015 at 08:46:02AM -0800, Ben Pfaff wrote:
The error message
Thanks, applied to master.
On Fri, May 29, 2015 at 11:14:57AM -0700, Jarno Rajahalme wrote:
Acked-by: Jarno Rajahalme jrajaha...@nicira.com
On May 29, 2015, at 10:41 AM, Ben Pfaff b...@nicira.com wrote:
On Tue, Mar 03, 2015 at 01:28:32PM -0800, Ben Pfaff wrote:
There are a couple of
On Mon, May 18, 2015 at 04:10:11PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
I think the correct fix is more like this:
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index 856044d..0e265a7 100644
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
@@ -353,7
On Mon, May 18, 2015 at 04:10:17PM -0700, Jarno Rajahalme wrote:
Pairs well with ofproto_rule_remove__().
I prefer a mid-priced Gewürztraminer with my ofproto_rule_remove__().
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
On Mon, May 18, 2015 at 04:10:22PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 29, 2015 at 10:40 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote:
Don't panic, this is not a remote buffer overflow, only a bug in a program
parsing its input from the command line or a file.
Found by inspection.
Signed-off-by: Ben
On Fri, May 29, 2015 at 11:15 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:15PM -0700, Andy Zhou wrote:
Now it simply calls ovsdb_monitor_compose_table_update(), which
is actually creates the json object.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff
On Fri, May 29, 2015 at 11:03 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:12PM -0700, Andy Zhou wrote:
To make ovsdb_monitor an opaque to ovsdb_jsonrpc server object.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
I think that the change
Send me a F#ckFriends request so we can hook up
My usename is HorNyChik77
y profile is here http://cc4.co/NPAZV SPEAK SOON
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, May 18, 2015 at 04:10:15PM -0700, Jarno Rajahalme wrote:
OpenFlow bundle messages should be decoded and validated at the time
they are added to the bundle. This commit does this for flow mod and
port mod messages.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
It's pretty
On Mon, May 18, 2015 at 04:10:20PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
I see some opportunity for simplification in modify_flows_check__():
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 5c8b1a5..cb53245 100644
--- a/ofproto/ofproto.c
+++
On Fri, May 29, 2015 at 05:07:19PM -0400, Russell Bryant wrote:
On 05/29/2015 04:50 PM, Ben Pfaff wrote:
On Fri, Apr 24, 2015 at 01:06:06PM -0400, Russell Bryant wrote:
This patch creates a new subpackage for OVN, openvswitch-ovn. It also
installs systemd unit files for ovncontroller and
Thanks for review,
On 29 May 2015 at 13:22, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote:
Signed-off-by: Joe Stringer joestrin...@nicira.com
The code in scan_u128() looks wrong to me: I don't see anything that
makes the second call to
On Fri, May 29, 2015 at 3:15 PM, Ben Pfaff b...@nicira.com wrote:
parse_int_string() returns an error if the field overflows, not if there
is a bad hex digit.
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
___
dev
On Mon, May 18, 2015 at 04:10:10PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Looks good, will you backport to 2.3 (if applicable)?
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
On Fri, May 29, 2015 at 03:23:17PM -0700, Jesse Gross wrote:
On Fri, May 29, 2015 at 3:15 PM, Ben Pfaff b...@nicira.com wrote:
parse_int_string() returns an error if the field overflows, not if there
is a bad hex digit.
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: Jesse Gross
On Mon, May 18, 2015 at 04:10:13PM -0700, Jarno Rajahalme wrote:
This makes it possible to tentatively add flows to the classifier
without the datapath seeing them.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
This is nifty.
Here are some suggestions as an incremental diff.
diff
Thx a lot for the explanation,
Really intrigued me a lot~! spent time writing simple example and gdb
monitor it. Now understand what you mean~
Thanks,
Alex Wang,
On Fri, May 29, 2015 at 3:15 PM, Ben Pfaff b...@nicira.com wrote:
On Fri, May 29, 2015 at 02:51:42PM -0700, Jesse Gross wrote:
On Fri, May 29, 2015 at 11:39 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:22PM -0700, Andy Zhou wrote:
With N:1 mappings, multiple jsonrpc server may be servicing the rpc
connection at a different pace. ovsdb-monitor thus needs to maintain
different change sets, depends
On Fri, May 29, 2015 at 11:34 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Apr 09, 2015 at 06:40:21PM -0700, Andy Zhou wrote:
Currently, each ovsdb-monitor points to a single jsonrpc_monitor object.
This means there is 1:1 relationship between them.
In case multiple jsonrpc-monitors need to
On Mon, May 18, 2015 at 04:10:21PM -0700, Jarno Rajahalme wrote:
Split add_flow() to add_flow_begin() which does all the error
checking, and add_flow_finish() which can not fail.
Since we still want to send an error response for an unknown
'buffer_id', send_buffered_packet() now send the
On Mon, May 18, 2015 at 04:10:14PM -0700, Jarno Rajahalme wrote:
OpenFlow 1.4 bundles are easier to implement when it is possible to
mark a rule as 'to_be_removed' and then insert a new, identical rule
with the same priority.
All but one out of the identical rules must be marked as
On Mon, May 18, 2015 at 04:10:16PM -0700, Jarno Rajahalme wrote:
This will make implementing commit in ofproto.c easier.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
On Mon, May 18, 2015 at 04:10:25PM -0700, Jarno Rajahalme wrote:
The new ovs-ofctl 'bundle' command accepts files similar to
'add-flows', but each line can optionally start with 'add', 'modify',
'delete', 'modify_strict', or 'delete_strict' keyword, so that
arbitrary flow table modifications
On Mon, May 18, 2015 at 04:10:28PM -0700, Jarno Rajahalme wrote:
Each rule is now added or deleted in a specific tables version. Flow
tables are versioned with a monotonically increasing 64-bit integer,
where positive values are valid version numbers.
Rule modifications are implemented as
On Mon, May 18, 2015 at 04:10:24PM -0700, Jarno Rajahalme wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
You know, we could make evictions reversible, since after all we have a
way to mark rules as to-be-deleted and then not delete them. I don't
know whether it's worthwhile.
The
On Mon, May 18, 2015 at 04:10:26PM -0700, Jarno Rajahalme wrote:
This patch allows classifier rules to become visible and invisible in
specific versions. A 'version' is defined as a positive monotonically
increasing integer, which never wraps around.
When versioning is not used, the
On Thu, May 28, 2015 at 04:37:14PM -0400, Russell Bryant wrote:
This patch emits a log message that is encountered a lot under normal
circumstances. For example, I'm seeing it almost 20,000 times in a
test run of the OpenStack test suite and hundreds of times while doing
basic tasting under
On Thu, Apr 09, 2015 at 06:40:25PM -0700, Andy Zhou wrote:
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
v1-v2: maintain ovsdb_monitor_changes using hmap instead of linked
list.
v2-v3: no change
The comment here in struct ovsdb_monitor_table
On Fri, Apr 24, 2015 at 01:06:05PM -0400, Russell Bryant wrote:
This patch introduces ovn-ctl, which is similar to ovs-ctl. I opted
for a new script as everything in OVN so far is nicely isolated, so a
new script seemed to make the most sense.
ovn-ctl supports a few different scenarios. If
On Fri, Apr 24, 2015 at 01:06:06PM -0400, Russell Bryant wrote:
This patch creates a new subpackage for OVN, openvswitch-ovn. It also
installs systemd unit files for ovncontroller and ovnnorthd services.
Finally, it installs some template service configuration files into
/etc/sysconfig/.
On 05/29/2015 04:47 PM, Ben Pfaff wrote:
On Fri, Apr 24, 2015 at 01:06:05PM -0400, Russell Bryant wrote:
This patch introduces ovn-ctl, which is similar to ovs-ctl. I opted
for a new script as everything in OVN so far is nicely isolated, so a
new script seemed to make the most sense.
Acked-by: Alex Wang al...@nicira.com
On Fri, May 29, 2015 at 10:40 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote:
Don't panic, this is not a remote buffer overflow, only a bug in a
program
parsing its input from the command line or a file.
On Mon, May 04, 2015 at 05:40:44PM -0400, Russell Bryant wrote:
v1-v2:
- Change systemd units to run ovn-northd and ovn-controller directly
instead of using ovn-ctl. I kept ovn-ctl around anyway as it
seemed useful to provide as an option for integrating with systems
without
On Thu, Apr 09, 2015 at 06:40:27PM -0700, Andy Zhou wrote:
Store ovsdb monitor in global hmap. A newly created ovsdb monitor
object will first search the global hmap for a possible match. If
one is found, the existing ovsdb monitor is used instead.
With this patch, jsonrpc monitor and ovsdb
On Wed, Apr 15, 2015 at 09:01:14AM -0700, Andy Zhou wrote:
Add a set of user space instruction counters to help break down
where instructions are spent.
Here is an example of screen capture of adding a port to database
without any monitoring client.
~/projs/ovs/tutorial$ ovs-appctl -t
On Thu, Apr 09, 2015 at 06:40:28PM -0700, Andy Zhou wrote:
Although multiple jsonrpc monitor can share the same ovsdb monitor, each
change still needs to transalted into json object from scratch. This
can be wastful is mutiple jsonrpc monitors are interested in the
same changes.
Json chche
On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote:
Signed-off-by: Joe Stringer joestrin...@nicira.com
The code in scan_u128() looks wrong to me: I don't see anything that
makes the second call to ovs_scan(), to get the mask, skip past the
value, e.g. by passing s + n to the second
On Mon, Apr 13, 2015 at 05:56:16PM -0700, Joe Stringer wrote:
Place all of the detected datapath features into a separate structure,
initialized when the dpif_backer is opened and shared with xbridges.
Signed-off-by: Joe Stringer joestrin...@nicira.com
It would be nice not to lose the
On Mon, Apr 13, 2015 at 05:56:17PM -0700, Joe Stringer wrote:
To be more explicit about which actions require datapath assistance,
split this out into a separate function. While this is fairly trivial
currently, there may be special cases for upcoming conntrack changes.
Signed-off-by: Joe
On Wed, Feb 25, 2015 at 08:46:02AM -0800, Ben Pfaff wrote:
The error message should not include bytes already copied from the input
string.
Found by inspection.
Signed-off-by: Ben Pfaff b...@nicira.com
This could still use a review.
___
dev
On Wed, Feb 25, 2015 at 09:12:38AM -0800, Ben Pfaff wrote:
Don't panic, this is not a remote buffer overflow, only a bug in a program
parsing its input from the command line or a file.
Found by inspection.
Signed-off-by: Ben Pfaff b...@nicira.com
This could still use a review.
On Thu, Apr 09, 2015 at 06:40:26PM -0700, Andy Zhou wrote:
Add ovsdb_monitor_add_jsonrpc_monitor(). This change will allow
ovsdb_monitor to be reference counted.
Signed-off-by: Andy Zhou az...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
---
v1-v2: style fixes
v2-v3: no change
I get
On 05/29/2015 04:50 PM, Ben Pfaff wrote:
On Fri, Apr 24, 2015 at 01:06:06PM -0400, Russell Bryant wrote:
This patch creates a new subpackage for OVN, openvswitch-ovn. It also
installs systemd unit files for ovncontroller and ovnnorthd services.
Finally, it installs some template service
On Thu, May 14, 2015 at 08:12:32PM +0200, Jiri Benc wrote:
This adds the needed constants from the kernel patch set posted earlier.
Signed-off-by: Jiri Benc jb...@redhat.com
It would be nice to document the type of the new
OVS_TUNNEL_ATTR_OVER_IPV6. (Is it just a flag?) I see that the
On Thu, May 14, 2015 at 08:12:33PM +0200, Jiri Benc wrote:
These functions will be used by the next patch.
Signed-off-by: Jiri Benc jb...@redhat.com
POSIX doesn't guarantee the presence of an s6_addr32 member so this
yields errors from sparse:
../lib/packets.h:712:15: error: no member
Removing a variable which breaks the windows forwarding extension build.
The error:
warning C4189: 'bufContext' : local variable is initialized but not referenced
c:\temp_may\ovs\datapath-windows\ovsext\PacketIO.c
Signed-off-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
Amazing delight will be organized by nice babes
http://cc4.co/YLBOW
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 29, 2015, at 2:22 PM, Alin Serdean aserd...@cloudbasesolutions.com
wrote:
Removing a variable which breaks the windows forwarding extension build.
The error:
warning C4189: 'bufContext' : local variable is initialized but not
referenced
On Thu, May 14, 2015 at 08:12:34PM +0200, Jiri Benc wrote:
Allow configuration of ipv6 tunnel endpoints.
Signed-off-by: Jiri Benc jb...@redhat.com
The OVS coding style, for better or worse, calls for {} to be used even
when there's only a single statement, so there are some missing {} in
On Thu, May 14, 2015 at 08:12:35PM +0200, Jiri Benc wrote:
Signed-off-by: Jiri Benc jb...@redhat.com
Looks good. I wonder whether we want a new netlink attribute type
NL_A_IPV6?
___
dev mailing list
dev@openvswitch.org
On Thu, May 14, 2015 at 08:12:36PM +0200, Jiri Benc wrote:
Add in6_addr counterparts to the existing format and scan functions.
Otherwise we'd need to recast all the time.
Signed-off-by: Jiri Benc jb...@redhat.com
Seems reasonable, thanks.
___
dev
On Thu, May 14, 2015 at 08:12:37PM +0200, Jiri Benc wrote:
Note that because there's been no prerequisite on the outer protocol,
we cannot add it now. Instead, treat the ipv4 and ipv6 dst fields in the way
that either both are null, or at most one of them is non-null.
Signed-off-by: Jiri
97 matches
Mail list logo
