[ovs-dev] [PATCH 4/4] db-ctl-base: make use of user supplied exit function

The user is required to expose the_idl and the_idl_txn global variables, so that memory can be cleaned up on fatal errors. This patch changes to ask user to supply an exit function via ctl_init(). What user needs to do on exit can now remain private. Signed-off-by: Andy Zhou --- lib/db-ctl-base.

[ovs-dev] [PATCH 2/4] db-ctl-base: make cmd_show_table private

Instead of require user to declare a global variable, pass the value via ctl_init(). Signed-off-by: Andy Zhou --- lib/db-ctl-base.c | 34 +- lib/db-ctl-base.h | 17 +++-- utilities/ovs-vsctl.c | 4 ++-- vtep/vtep-ctl.c | 4 ++-- 4 files

[ovs-dev] [PATCH 3/4] db-ctl-base: remove ctl_get_all_commands() function

all_commands currently is some times accessed directly, some times via a function call. Change to always access it directly. Signed-off-by: Andy Zhou --- lib/db-ctl-base.c | 14 -- lib/db-ctl-base.h | 1 - 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/lib/db-ctl-ba

[ovs-dev] [PATCH 1/4] db-ctl-base: remove db_ctl_show_command table

It is not clear why "show" command needs its own command table. Remove it for simplicity. Signed-off-by: Andy Zhou --- lib/db-ctl-base.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 86a87d0..d38bf03 100644 --- a/lib/db

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

Hi Ben, Thanks for the reply. Please help me understand below points: As per openflow specification 1.4, Page 72 "The flag OFPTC_VACANCY_EVENTS control vacancy events in that table (see 7.4.5). If this flag is set, the switch must generate vacancy events for that table. If this flag is unset, th

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

On Mon, Jul 13, 2015 at 08:23:45AM -0700, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 04:19:46PM +0530, Saloni Jain wrote: > > 2. ovs-ofctl -O Openflow14 mod-table  vacancy-   > > -- To be implemented > > OFPTC14_VACANCY_EVENTS is the only set table-mod config property and > > eviction if configu

Re: [ovs-dev] kernel module testing

On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote: > How about automating this using travis and gerrit, so no commit gets in > unless it passes sanity tests? This also simplifies review process as well. Travis doesn't test the kernel module, and as far as I know it can't.

[ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a "logical switch". Each logical switch has a dedicated tunnel key and will keep records of all MACs learned from the owned vlans. So user can just send packet to a "logical switch" and the gateway wi

[ovs-dev] [ovn-controller-vtep V3 7/7] ovn-controller-vtep: Add pipeline module.

This commit adds the pipeline module to ovn-controller-vtep. The module will scan through the Binding table, and create the Ucast_Macs_Remote in vtep database for each logical port's MACs in the same logical datapath (same as logical switch for vtep). Also the module will create the physical loca

[ovs-dev] [ovn-controller-vtep V3 6/7] ovn-controller-vtep: Add binding module.

This commit adds the binding module to ovn-controller-vtep. The module will scan through the Binding table in ovnsb. If there is a binding for the logical port in the vtep gateway chassis's "logical_switches" map, sets the binding's chassis column to the vtep gateway chassis. Signed-off-by: Alex

[ovs-dev] [ovn-controller-vtep V3 4/7] ovn: Add controller for VTEP switch.

This commit lays down the foundation for a new controller in OVN, the ovn-controller-vtep, for controlling the vtep enabled physical switches. Limitation: - How to make controller-vtep connect to OVN_SB? my understanding is that vtep should not know the location of ovnsb. but there is

[ovs-dev] [ovn-controller-vtep V3 5/7] ovn-controller-vtep: Add gateway module.

This commit adds the gateway module to ovn-controller-vtep. The module will register the physical switches to ovnsb as chassis and constantly update the "logical_switches" column in Chassis table. Limitation: - Do not support reading multiple tunnel ips of physical switch. Signed-off-by: Alex W

[ovs-dev] [ovn-controller-vtep V3 1/7] ofproto-macros.at: Make check_logs() check all daemons' log files.

As we have more daemons with OVN that can be tested using ovs autotest framework, it is convenient to extend check_logs() to check the log files of all daemons. Signed-off-by: Alex Wang --- V2->V3: - adopt Ben's suggestion to check for all '*.log's except testsuite.log. - rebase to master. PATC

[ovs-dev] [ovn-controller-vtep V3 3/7] ovn-sbctl: Add ovn-sbctl.

This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. As a side effect, we move the ovn-nbctl/ovn-sbctl related files into ovn/utilities. Signed-off-by: Alex Wang Acked-by: Ben Pfaff --- V2->V3: - rebase to base. - adopt Russell's review comments. - move ovn-nbctl/sbctl re

[ovs-dev] [ovn-controller-vtep V3 0/7] Add ovn controller for VTEP.

This series adds a new ovn controller, ovn-controller-vtep, for VTEP enabled physical switches. The high level architecture is similar to the ovn-controller. Of course the module implementation is vtep specific. To be able to test the ovn-controller-vtep in autotest, this series include the impl

Re: [ovs-dev] [ovn-controller-vtep V2 3/6] ovn: Add controller for VTEP switch.

On Mon, Jul 13, 2015 at 9:40 AM, Russell Bryant wrote: > On 07/05/2015 01:38 AM, Alex Wang wrote: > > This commit lays down the foundation for a new controller in OVN, the > > ovn-controller-vtep, for controlling the vtep enabled physical switches. > > What do you think about OVN NB db integratio

Re: [ovs-dev] kernel module testing

Hi Ben, How about automating this using travis and gerrit, so no commit gets in unless it passes sanity tests? This also simplifies review process as well. Regards, Pritesh > On Jul 13, 2015, at 5:14 PM, Ben Pfaff wrote: > > Lately I've starting hearing about commits breaking the Windows kerne

[ovs-dev] kernel module testing

Lately I've starting hearing about commits breaking the Windows kernel module. If that's happening frequently, then it probably means that developers are not testing their changes before they post them. It's easy to get into that habit not testing, because it saves time and because sometimes one

Re: [ovs-dev] [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

Hi Thomas, On 10 July 2015 at 07:19, Thomas Graf wrote: > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > index ecfa530..05fe46b 100644 > --- a/net/openvswitch/flow_netlink.c > +++ b/net/openvswitch/flow_netlink.c > @@ -1548,11 +1548,45 @@ static struct sw_flow_acti

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when cleaning up the VXLAN tunnel

Acked-by: Alin Gabriel Serdean Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis Trimis: Friday, July 10, 2015 11:27 AM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when cleaning up the VXLAN tunnel Wh

[ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

Several encapsulation formats have the concept of an 'OAM' bit which typically is used with networking tracing tools to distinguish test packets from real traffic. OVS already internally has support for this, however, it doesn't do anything with it and it also isn't exposed for controllers to use.

[ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

There are several implementations of functions that parse/format flags and their binary representation. This factors them out into common routines. In addition to reducing code, it also makes things more consistent across different parts of OVS. Signed-off-by: Jesse Gross --- lib/flow.c

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty wrote: > MSVC 2013 does not like designated initializers when > structs are initialized inside structs. > > Signed-off-by: Gurucharan Shetty This looks fine to me, although there are several other instances of this pattern in other places. Are t

Re: [ovs-dev] [ovn-controller-vtep V2 1/6] ofproto-macros.at: Make check_logs() check all daemons' log files.

Thx for the suggestion, I tested it, Adopted it, sent new version, On Mon, Jul 13, 2015 at 10:42 AM, Ben Pfaff wrote: > On Sat, Jul 04, 2015 at 10:38:34PM -0700, Alex Wang wrote: > > As we have more daemons with OVN that can be tested using ovs autotest > > framework, it is convenient to extend

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

Alin, it is a different one. Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Monday, July 13, 2015 11:58 AM To: Ben Pfaff; Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start mes

[ovs-dev] [ovn-controller-vtep V3 1/6] ofproto-macros.at: Make check_logs() check all log files.

As we have more daemons with OVN that can be tested using ovs autotest framework, it is convenient to extend check_logs() to check all log files (except the testsuite.log). Signed-off-by: Alex Wang --- V2->V3: - adopt Ben's suggestion to check for all '*.log's except testsuite.log. - rebase to m

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

I am biased about the patch since this patch is already in: https://github.com/openvswitch/ovs/commit/216e1c149a5c6d83884db447e16d30e063e1275d Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ben Pfaff Trimis: Monday, July 13, 2015 8:54 PM Către: Sorin Vint

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

Hi Sorin, Thank you for addressing my comments. Can we please use a flag which indicates that the a dump process is in progress rather than setting the whole buffer to zero? Besides of that, everything is good. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.o

Re: [ovs-dev] [PATCH] tests: Skip IPv6 tests if the system does not support IPv6.

On Thu, Jul 09, 2015 at 12:26:35PM -0700, Andy Zhou wrote: > On Thu, Jul 9, 2015 at 8:08 AM, Ben Pfaff wrote: > > This is only for the tests that actually create IPv6 sockets. The tests > > that merely use IPv6 addresses in flow entries, etc., do not depend on > > kernel support. > > > > Reported

Re: [ovs-dev] [ovn-controller-vtep V2 6/6] ovn-controller-vtep: Add pipeline module.

On 07/13/2015 02:03 PM, Alex Wang wrote: > > > On Mon, Jul 13, 2015 at 9:24 AM, Russell Bryant > wrote: > > On 07/05/2015 01:38 AM, Alex Wang wrote: > > This commit adds the pipeline module to ovn-controller-vtep. The > > module will scan through the Bind

Re: [ovs-dev] [ovn-controller-vtep V2 6/6] ovn-controller-vtep: Add pipeline module.

On Mon, Jul 13, 2015 at 9:24 AM, Russell Bryant wrote: > On 07/05/2015 01:38 AM, Alex Wang wrote: > > This commit adds the pipeline module to ovn-controller-vtep. The > > module will scan through the Binding table, and create the > > Ucast_Macs_Remote in vtep database for each logical port's MAC

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

On Fri, Jul 03, 2015 at 03:36:37PM +, Sorin Vinturis wrote: > Changed the dump start message memory representation to be static. > > Signed-off-by: Sorin Vinturis It's been over a week without a review. I hope that someone looks at this soon. ___

Re: [ovs-dev] [PATCH] datapath-windows: update extension information

Acked-by: Eitan Eliahu Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Monday, July 13, 2015 10:18 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: update extension information This patch sets additi

Re: [ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header information

Thanks for addressing the issue! Acked-by: Eitan Eliahu Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Monday, July 13, 2015 9:59 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header inform

Re: [ovs-dev] [ovn-controller-vtep V3 2/6] ovn-sbctl: Add ovn-sbctl.

On Mon, Jul 13, 2015 at 10:50:34AM -0700, Alex Wang wrote: > This commit adds ovn-sbctl to ovn family by using the db-ctl-base > library. > > As a side effect, we move the ovn-nbctl/ovn-sbctl related files > into ovn/utilities. > > Signed-off-by: Alex Wang > Acked-by: Ben Pfaff It doesn't comp

Re: [ovs-dev] [PATCH] datapath-windows: Realease dispatch lock after processing

Alin, it seems that RtlUnicodeStringToAnsiString() can't be called in an elevated IRQL. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Monday, July 13, 2015 10:06 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapa

[ovs-dev] [ovn-controller-vtep V3 2/6] ovn-sbctl: Add ovn-sbctl.

This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. As a side effect, we move the ovn-nbctl/ovn-sbctl related files into ovn/utilities. Signed-off-by: Alex Wang Acked-by: Ben Pfaff --- V2->V3: - rebase to base. - adopt Russell's review comments. - move ovn-nbctl/sbctl re

Re: [ovs-dev] [PATCH 0/5 V6] Add 802.1ad (qinq) support

On 7/13/15 8:05 AM, ravulakollu.ku...@wipro.com wrote: Hi All, I am trying to configure vlan stacking (802.1ad) to few ovs bridge ports, in Normal mode bridge operation. I am using ovs-master code Version 2.3.9 for my experiments. I am seeing no support for stacked vlans both from the configura

Re: [ovs-dev] [ovn-controller-vtep V2 1/6] ofproto-macros.at: Make check_logs() check all daemons' log files.

On Sat, Jul 04, 2015 at 10:38:34PM -0700, Alex Wang wrote: > As we have more daemons with OVN that can be tested using ovs autotest > framework, it is convenient to extend check_logs() to check the log files > of all daemons. > > Signed-off-by: Alex Wang > > --- > PATCH->V2: > - make check_logs(

[ovs-dev] [PATCH] datapath-windows: update extension information

This patch sets additional information about the driver used by various applications. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/.gitignore|1 + datapath-windows/ovsext/ovsext.rc | 104 ++- datapath-windows/ovsext/ovsext.vcxproj |1 + datapath-windows/ovse

[ovs-dev] [PATCH] datapath-windows: Realease dispatch lock after processing

Release the switch context dispatch lock after all possible processing is done over the vport. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Vport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/V

[ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header information

Use tunnel key information on the IP header preceding the VXLAN header. Signed-off-by: Alin Gabriel Serdean --- v2: use separate variable to store the number of transmitted bytes --- datapath-windows/ovsext/Vxlan.c | 13 - datapath-windows/ovsext/Vxlan.h | 1 + 2 files changed, 9 in

Re: [ovs-dev] [PATCH] datapath-windows: Update VXLAN header information

Oops... You're right Eitan, I will add a separate variable for it and respin the patch. Alin. -Mesaj original- De la: Eitan Eliahu [mailto:elia...@vmware.com] Trimis: Monday, July 13, 2015 7:42 PM Către: Alin Serdean; dev@openvswitch.org Subiect: RE: [PATCH] datapath-windows: Update VX

[ovs-dev] [PATCH] datapath-windows: Surpress flow attribute probe

This patch surpresses flow attribute probing in the windows datapath. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 3a6c788..

Re: [ovs-dev] [PATCH] datapath-windows: Update VXLAN header information

Hi Alin, Can you please explain why the FilterID is used to maintain the number of transmitted bytes? The FilterID is sent to WFP when we add a filter so the filter can be deleted later by specifying this ID. Once the ID is modified the removal of the filter will fail. I think we want to use as

Re: [ovs-dev] [ovn-controller-vtep V2 3/6] ovn: Add controller for VTEP switch.

On 07/05/2015 01:38 AM, Alex Wang wrote: > This commit lays down the foundation for a new controller in OVN, the > ovn-controller-vtep, for controlling the vtep enabled physical switches. What do you think about OVN NB db integration for this? I see in the code how the gateways are treated like l

Re: [ovs-dev] [ovn-controller-vtep V2 6/6] ovn-controller-vtep: Add pipeline module.

On 07/05/2015 01:38 AM, Alex Wang wrote: > This commit adds the pipeline module to ovn-controller-vtep. The > module will scan through the Binding table, and create the > Ucast_Macs_Remote in vtep database for each logical port's MACs in > the same logical datapath (same as logical switch for vtep

Re: [ovs-dev] [PATCH] netdev-linux: do not warn when getting stats for netdev with no vport

On Tue, Jul 07, 2015 at 03:38:51PM -0300, Thadeu Lima de Souza Cascardo wrote: > When there is no vport for a given netdev, dpif_netlink_vport_get might return > ENODEV. Do not warn a failure to get port stats when that's the case. > > Signed-off-by: Thadeu Lima de Souza Cascardo Can you give so

Re: [ovs-dev] [PATCH 2/2] debian: rationalize packaging using new debhelper

On Tue, Jul 07, 2015 at 04:04:43PM +0100, James Page wrote: > Newer debhelper versions support overrides, making rules files simplier and > easier to extend. > > Requires some changes in how files are installed (_debian build folder > dropped). > > Signed-off-by: James Page I am frankly nervo

[ovs-dev] [PATCH] datapath-windows: Update VXLAN header information

Use tunnel key information on the IP header preceding the VXLAN header. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Vxlan.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Vxlan.c b/datapath-windows/ovsext/Vxlan.c inde

Re: [ovs-dev] DSCP flag and ECN flag issue

On Mon, Jul 13, 2015 at 05:16:37PM +0530, tech_kals Kals wrote: > When I tried to configure a flow with DSCP flag is set (configuring dscp > value with 16), the flow message comes with ECN is set to 0 (Non > ECN-capable Transport). Could you please let me know whether this is > correct or not? >

Re: [ovs-dev] [PATCH] Fix compiler warning

On Mon, Jul 13, 2015 at 02:15:33PM +, Alin Serdean wrote: > warning C4098: 'dpif_netlink_init_flow_del' : 'void' function returning a > value > > Signed-off-by: Alin Gabriel Serdean Thanks! Applied to master and branch-2.4. ___ dev mailing list d

[ovs-dev] [PATCH 3/4] datapath-windows: Update packet policies

Update netlink attribute parsing to use the appropriate policy array size. This patch also initialize all netlink attributes before parsing them. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) di

[ovs-dev] [PATCH 2/4] datapath-windows: Update flow policies

Update netlink attribute parsing to use the appropriate policy array size. Return NL_ERROR_NOENT which is the equivalent ENOENT if we failed to install, modify or get a flow. This patch also initialize all netlink attributes before parsing them. Clean-up: remove some dead code. Signed-off-by: A

[ovs-dev] [PATCH 4/4] datapath-windows: Update vport policies

Update netlink attribute parsing to use the appropriate policy array size. This patch also initialize all netlink attributes before parsing them. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Vport.c | 109 ++-- 1 file changed, 39 insertions

[ovs-dev] [PATCH 0/4] datapath-windows: Update netlink attribute parsing

Update netlink attribute parsing to use the array size of the appropriate policy. Alin Gabriel Serdean (4): datapath-windows: Update datapath policy datapath-windows: Update flow policies datapath-windows: Update packet policies datapath-windows: Update vport policies datapath-windows/ov

[ovs-dev] [PATCH 1/4] datapath-windows: Update datapath policy

Beside the update to ovsDatapathSetPolicy, the rest of changes are cosmetic, to clarify the fact that when parsing netlink attributes the flow policy array size should be used. This patch also initialize all netlink attributes before parsing them. Signed-off-by: Alin Gabriel Serdean --- datapat

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

On Mon, Jul 13, 2015 at 04:19:46PM +0530, Saloni Jain wrote: > 2. ovs-ofctl -O Openflow14 mod-table  vacancy-   -- > To be implemented > OFPTC14_VACANCY_EVENTS is the only set table-mod config property and eviction > if configured previously will get unset. I don't think it's good for mod-table

Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif.

+1 -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Monday, July 13, 2015 6:16 PM Către: Alin Serdean Cc: Gurucharan Shetty; dev Subiect: Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif. On Mon, Jul 13, 2015 at 02:03:58PM +000

Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif.

On Mon, Jul 13, 2015 at 02:03:58PM +, Alin Serdean wrote: > The patch is valid from the windows datapath point of view: > > Acked-by: Alin Gabriel Serdean Thanks for the review! I applied this to branch-2.4. > I was planning to send a patch on master to disable DPIF_FP_PROBE in > the windo

[ovs-dev] Reply .....ASAP

- This mail is in HTML. Some elements may be ommited in plain text. - Hello Dear, I sent you a business proposal , please let me know if you receive my first email so that i can furnish you with the details ASAP, Thanks. From John Harry. ___ dev mailin

[ovs-dev] [PATCH v3] datapath-windows: Output a packet to two or more VXLAN ports

If we have a flow rule in the following form: actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are VXLAN tunnels with different tunnelling information) A packet which will hit that specific flow will only be sent out encapsulated with the first tunnelling information. This

[ovs-dev] [PATCH v2] datapath-windows: Output a packet to two or more VXLAN ports If we have a flow rule in the following form: actions=strip_vlan, set_tunnel:0x3e9, 15, 16, 17 (Where port 15, 16 and

A packet which will hit that specific flow will only be sent out encapsulated with the first tunnelling information. This patch saves the initial packet vport, source port and NIC index for further use of the currently implemented pipeline and ignores the latter if it is the last tunnelling port.

[ovs-dev] [PATCH] Fix compiler warning

warning C4098: 'dpif_netlink_init_flow_del' : 'void' function returning a value Signed-off-by: Alin Gabriel Serdean --- lib/dpif-netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 6838def..3650682 100644 --- a/lib/dpif-

Re: [ovs-dev] [PATCH] dpif-netlink: Suppress DPIF_FP_PROBE here instead of in ofproto-dpif.

The patch is valid from the windows datapath point of view: Acked-by: Alin Gabriel Serdean I was planning to send a patch on master to disable DPIF_FP_PROBE in the windows datapath, if you wish we could put it on top of 2.4 and completely ditch the special case in userspace for windows. Alin.

Re: [ovs-dev] [PATCH] netdev-dpdk: Add some missing statistics.

Hi, From: Weglicki, MichalX > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > >Do you know how much it is going to impact the vhost throughput? Other than > this the change looks good to me. > > I compared the results based on (OVS head) vs (OVS head + patch)

Re: [ovs-dev] [PATCH 0/5 V6] Add 802.1ad (qinq) support

Hi All, I am trying to configure vlan stacking (802.1ad) to few ovs bridge ports, in Normal mode bridge operation. I am using ovs-master code Version 2.3.9 for my experiments. I am seeing no support for stacked vlans both from the configuration interface perspective and datapath as well. I am t

[ovs-dev] bvmpjqr

‚N“«û•Æ} h7 ^Š±ä¾3ᄛ¬¿º»«ÎŸø”°É9¼ )âš~dìN»°&þááé—æ®CæÝ0Wdl6ƒg„8ë$„K9§ 7É$§ÓÚÉu2ðŸá":êB3¶0Y¤ÀÚ1|Û#Ž8C£x.(½pzZ¥‡#'°A¸´>»pÆ´ùÞ¨çÁkñ° —hY¥[“T¶§Á/…N¾Ÿ{Ö-^†Ï¹‚H°ŽýôÔ½·…_¤] ËzF›bØ׸R¼³®AöS‹Im®±åõžzíö•‹êL±OØc óAÃÀ®9ÞôøÝ6œÞþŗ#W¬ŠûY·p¶gÇe©ºOàÛ5­OMÅ{7ËèÊɕã¶9ƒÙæ¢$«ˆì†¼ÙöÄ ¿<¤¹qN>‚ìœ RøŠÂCÏ —§ï‰!¯ÜÒFñ

[ovs-dev] DSCP flag and ECN flag issue

Hi Ben, When I tried to configure a flow with DSCP flag is set (configuring dscp value with 16), the flow message comes with ECN is set to 0 (Non ECN-capable Transport). Could you please let me know whether this is correct or not? When I tried to configure wildcard flow, ECN flag is set to

Re: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS

Just one small nit think you need to rebase. Could not apply the patch on master. Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean Trimis: Monday, July 13, 2015 2:19 PM Către: Sorin Vinturis; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS

Acked-by: Alin Gabriel Serdean Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis Trimis: Friday, July 10, 2015 11:48 AM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS Solved some spelling

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

Hi Guru, Will take a look into it. Alin. -Mesaj original- De la: Gurucharan Shetty [mailto:shet...@nicira.com] Trimis: Saturday, July 11, 2015 9:08 AM Către: Eitan Eliahu Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported

[ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

Hi Ben, With implementation of vacancy-events along with eviction, following ovs-ofctl table-mod command will be supported in ovs: 1. ovs-ofctl -O Openflow14 mod-table  evict   -- Already supported in ovs master branch OFPTC14_EVICTION is the only set table-mod config property and vacancy-even

Re: [ovs-dev] [db-ctl-base v2 1/3] db-ctl-base: do not expose get_table() API

> nitpick, could we move this deletion to next commit? Make sense. I moved it. > > > Acked-by: Alex Wang > Thanks for the review. Pushed to master. > > >> >> /* ctl_fatal() also logs the error, so it is preferred in this file. */ >> @@ -250,9 +247,8 @@ struct ctl_table_class { >> * entry. */ >>