Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-14 Thread Saloni Jain
Hi Ben, Thanks for the reply. Please help me understand below points: As per openflow specification 1.4, Page 72 The flag OFPTC_VACANCY_EVENTS control vacancy events in that table (see 7.4.5). If this flag is set, the switch must generate vacancy events for that table. If this flag is unset,

Re: [ovs-dev] kernel module testing

2015-07-14 Thread Pritesh Kothari (pritkoth)
On Jul 13, 2015, at 9:40 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote: How about automating this using travis and gerrit, so no commit gets in unless it passes sanity tests? This also simplifies review process as well.

[ovs-dev] [PATCH 4/4] db-ctl-base: make use of user supplied exit function

2015-07-14 Thread Andy Zhou
The user is required to expose the_idl and the_idl_txn global variables, so that memory can be cleaned up on fatal errors. This patch changes to ask user to supply an exit function via ctl_init(). What user needs to do on exit can now remain private. Signed-off-by: Andy Zhou az...@nicira.com ---

[ovs-dev] [PATCH 2/4] db-ctl-base: make cmd_show_table private

2015-07-14 Thread Andy Zhou
Instead of require user to declare a global variable, pass the value via ctl_init(). Signed-off-by: Andy Zhou az...@nicira.com --- lib/db-ctl-base.c | 34 +- lib/db-ctl-base.h | 17 +++-- utilities/ovs-vsctl.c | 4 ++-- vtep/vtep-ctl.c |

[ovs-dev] [PATCH 3/4] db-ctl-base: remove ctl_get_all_commands() function

2015-07-14 Thread Andy Zhou
all_commands currently is some times accessed directly, some times via a function call. Change to always access it directly. Signed-off-by: Andy Zhou az...@nicira.com --- lib/db-ctl-base.c | 14 -- lib/db-ctl-base.h | 1 - 2 files changed, 4 insertions(+), 11 deletions(-) diff

[ovs-dev] [PATCH 1/4] db-ctl-base: remove db_ctl_show_command table

2015-07-14 Thread Andy Zhou
It is not clear why show command needs its own command table. Remove it for simplicity. Signed-off-by: Andy Zhou az...@nicira.com --- lib/db-ctl-base.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 86a87d0..d38bf03

Re: [ovs-dev] [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-14 Thread Thomas Graf
On 07/13/15 at 03:55pm, Joe Stringer wrote: It doesn't look like flow_free() is using this new function to properly free the actions. Also, some of the error cases that hit this code have sf_acts=NULL. Good catch. Will fix in next iteration. ___ dev

Re: [ovs-dev] [PATCH 0/5 V6] Add 802.1ad (qinq) support

2015-07-14 Thread ravulakollu.kumar
Hi Thomas, Thanks for your reply. Seems I was using old patch http://patchwork.openvswitch.org/patch/3686/ (version 3). It would be really helpful if you could let me know the link where I can download version 11 patch code. Also I have few queries like, does version 11 patch includes

[ovs-dev] IS MSTP enabled on OVS 2.3.9

2015-07-14 Thread ravali.burra
Hi Team, I am using ovs-master code Version 2.3.9 for my experiments. Currently what I understood from ovs-vsctl man page we are having commands for the configuring RSTP. Similar way I want to configure MSTP in OVS but I have not seen any supported commands for configuration of MSTP from

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-14 Thread Saloni Jain
Hi Ben, In addition to my previous response, please suggest if vswitchd should query and get the current stored table-configurartion using query_tables_desc() and then modify table-config properties according to user's request. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto:

Re: [ovs-dev] [ovn-controller-vtep V3 5/7] ovn-controller-vtep: Add gateway module.

2015-07-14 Thread Russell Bryant
Awesome work. I plan to do a more in depth review but I had a quick comment about something I thought of last night. On 07/13/2015 11:22 PM, Alex Wang wrote: This commit adds the gateway module to ovn-controller-vtep. The module will register the physical switches to ovnsb as chassis and

Re: [ovs-dev] [PATCH] netdev-linux: do not warn when getting stats for netdev with no vport

2015-07-14 Thread Thadeu Lima de Souza Cascardo
On Mon, Jul 13, 2015 at 09:02:17AM -0700, Ben Pfaff wrote: On Tue, Jul 07, 2015 at 03:38:51PM -0300, Thadeu Lima de Souza Cascardo wrote: When there is no vport for a given netdev, dpif_netlink_vport_get might return ENODEV. Do not warn a failure to get port stats when that's the case.

Re: [ovs-dev] [ovn-controller-vtep V3 7/7] ovn-controller-vtep: Add pipeline module.

2015-07-14 Thread Liran Schour
dev dev-boun...@openvswitch.org wrote on 14/07/2015 06:22:43 AM: This commit adds the pipeline module to ovn-controller-vtep. The module will scan through the Binding table, and create the Ucast_Macs_Remote in vtep database for each logical port's MACs in the same logical datapath (same as

[ovs-dev] another provider network idea (was: [RFC] ovn: physical network integraiton (WIP))

2015-07-14 Thread Ben Pfaff
I think that the various issues with trying to treat a provider network as a logical network are going to difficult to resolve. I think that they reflect a conceptual difference between OVN logical networks and provider networks. OVN knows the hosts on a logical network and where they reside,

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-14 Thread Gurucharan Shetty
On Mon, Jul 13, 2015 at 2:12 PM, Jesse Gross je...@nicira.com wrote: On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty shet...@nicira.com wrote: MSVC 2013 does not like designated initializers when structs are initialized inside structs. Signed-off-by: Gurucharan Shetty gshe...@nicira.com

Re: [ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-14 Thread Gurucharan Shetty
On Sat, Jul 11, 2015 at 9:56 AM, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 10, 2015 at 09:26:07PM -0700, Gurucharan Shetty wrote: MSVC 2013 does not like designated initializers when structs are initialized inside structs. Signed-off-by: Gurucharan Shetty gshe...@nicira.com Ugh.

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-14 Thread Jesse Gross
On Tue, Jul 14, 2015 at 8:18 AM, Gurucharan Shetty shet...@nicira.com wrote: On Mon, Jul 13, 2015 at 2:12 PM, Jesse Gross je...@nicira.com wrote: On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty shet...@nicira.com wrote: MSVC 2013 does not like designated initializers when structs are

Re: [ovs-dev] another provider network idea

2015-07-14 Thread Russell Bryant
On 07/14/2015 10:59 AM, Ben Pfaff wrote: I think that the various issues with trying to treat a provider network as a logical network are going to difficult to resolve. I think that they reflect a conceptual difference between OVN logical networks and provider networks. OVN knows the hosts

Re: [ovs-dev] [ovn-controller-vtep V3 5/7] ovn-controller-vtep: Add gateway module.

2015-07-14 Thread Alex Wang
On Tue, Jul 14, 2015 at 6:25 AM, Russell Bryant rbry...@redhat.com wrote: Awesome work. I plan to do a more in depth review but I had a quick comment about something I thought of last night. On 07/13/2015 11:22 PM, Alex Wang wrote: This commit adds the gateway module to

Re: [ovs-dev] [ovn-controller-vtep V3 7/7] ovn-controller-vtep: Add pipeline module.

2015-07-14 Thread Alex Wang
On Tue, Jul 14, 2015 at 7:19 AM, Liran Schour lir...@il.ibm.com wrote: dev dev-boun...@openvswitch.org wrote on 14/07/2015 06:22:43 AM: This commit adds the pipeline module to ovn-controller-vtep. The module will scan through the Binding table, and create the Ucast_Macs_Remote in vtep

Re: [ovs-dev] [ovn-controller-vtep V3 5/7] ovn-controller-vtep: Add gateway module.

2015-07-14 Thread Russell Bryant
On 07/14/2015 11:58 AM, Alex Wang wrote: On Tue, Jul 14, 2015 at 6:25 AM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: Awesome work. I plan to do a more in depth review but I had a quick comment about something I thought of last night. On 07/13/2015

Re: [ovs-dev] another provider network idea (was: [RFC] ovn: physical network integraiton (WIP))

2015-07-14 Thread Ben Pfaff
Please don't drop the list. On Tue, Jul 14, 2015 at 11:24:36AM -0400, Aaron Conole wrote: On Tue, Jul 14, 2015 at 07:59:48AM -0700, Ben Pfaff wrote: I think that the various issues with trying to treat a provider network as a logical network are going to difficult to resolve. I think that

Re: [ovs-dev] [ovn-controller-vtep V3 5/7] ovn-controller-vtep: Add gateway module.

2015-07-14 Thread Alex Wang
On Tue, Jul 14, 2015 at 9:10 AM, Russell Bryant rbry...@redhat.com wrote: On 07/14/2015 11:58 AM, Alex Wang wrote: On Tue, Jul 14, 2015 at 6:25 AM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: Awesome work. I plan to do a more in depth review but I had a

Re: [ovs-dev] [PATCH] INSTALL.Windows.md: Update the minimum required compiler.

2015-07-14 Thread Eitan Eliahu
Acked-by: Eitan Eliahu elia...@vmware.com It would be good if we could verify that the driver is compiled and run when compiled with VS Update 4 and Winddk 8.1. Thanks Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty Sent: Tuesday,

[ovs-dev] [PATCH] INSTALL.Windows.md: Update the minimum required compiler.

2015-07-14 Thread Gurucharan Shetty
MSVC 2013 update 4 was released in Nov 2014. Its release notes says that it has fixed the problem wherein using designated initializers to initialize unions within structs would fail to compile. Using designated initializers is useful in OVS and so this commit updates the minimum required

Re: [ovs-dev] [PATCH] Revert ofctrl: Don't use designated initializers.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 01:04:36PM -0700, Gurucharan Shetty wrote: On Tue, Jul 14, 2015 at 12:50 PM, Ben Pfaff b...@nicira.com wrote: This reverts commit 0b090f2263807e25be14f90a287c4bfdee2d82ec. When that commit was applied, we did not know of a fix for the MSVC bug that it avoided, but

[ovs-dev] [PATCH] ovn-nb: Add per-port IP addresses to routers.

2015-07-14 Thread Ben Pfaff
A router needs one IP address per port, not just one for the whole router. Reported-by: Gal Sagie gal.sa...@gmail.com Reported-at: http://openvswitch.org/pipermail/dev/2015-July/057242.html Signed-off-by: Ben Pfaff b...@nicira.com --- ovn/ovn-nb.ovsschema | 1 - ovn/ovn-nb.xml | 13

[ovs-dev] [PATCH] Revert ofctrl: Don't use designated initializers.

2015-07-14 Thread Ben Pfaff
This reverts commit 0b090f2263807e25be14f90a287c4bfdee2d82ec. When that commit was applied, we did not know of a fix for the MSVC bug that it avoided, but now we know that sufficiently new MSVC 2013 supports this feature. CC: Gurucharan Shetty shet...@nicira.com Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] Revert ofctrl: Don't use designated initializers.

2015-07-14 Thread Gurucharan Shetty
On Tue, Jul 14, 2015 at 12:50 PM, Ben Pfaff b...@nicira.com wrote: This reverts commit 0b090f2263807e25be14f90a287c4bfdee2d82ec. When that commit was applied, we did not know of a fix for the MSVC bug that it avoided, but now we know that sufficiently new MSVC 2013 supports this feature.

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 07, 2015 at 10:30:05PM -0700, Jesse Gross wrote: The kernel implementation of Geneve options stores the TLV option data in the flow exactly as received, without any further parsing. This is then translated to known options for the purposes of matching on flow setup (which will then

Re: [ovs-dev] OVN - L3 Design

2015-07-14 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 04:23:09PM +0300, Gal Sagie wrote: First, i think everyone would love to hear if there are any plans or any first ideas regarding the L3 design. Second, i would like to talk about what currently is available in the schema and how it differs from Openstack Neutron.

Re: [ovs-dev] [PATCH] Add 'name' field to Logical Router

2015-07-14 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 09:26:10AM -0400, Russell Bryant wrote: On 07/08/2015 02:44 AM, Gal Sagie wrote: Adding a name identifier will increase convinence for Openstack (or Other CMS) that want to identify the logical router (or store the CMS id in the router name) Signed-off-by: Gal

Re: [ovs-dev] [PATCH] Add 'name' field to Logical Router

2015-07-14 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 09:44:33AM +0300, Gal Sagie wrote: Adding a name identifier will increase convinence for Openstack (or Other CMS) that want to identify the logical router (or store the CMS id in the router name) Signed-off-by: Gal Sagie gal.sa...@gmail.com Signed-off-by: Gal Sagie

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 08:27:15AM -0700, Jesse Gross wrote: On Tue, Jul 14, 2015 at 8:18 AM, Gurucharan Shetty shet...@nicira.com wrote: On Mon, Jul 13, 2015 at 2:12 PM, Jesse Gross je...@nicira.com wrote: On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty shet...@nicira.com wrote: MSVC

Re: [ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 08:20:28AM -0700, Gurucharan Shetty wrote: On Sat, Jul 11, 2015 at 9:56 AM, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 10, 2015 at 09:26:07PM -0700, Gurucharan Shetty wrote: MSVC 2013 does not like designated initializers when structs are initialized inside

[ovs-dev] [PATCH] automake: Cleanup to allow make distcheck to succeed.

2015-07-14 Thread Aaron Conole
For some time, it seems that the distcheck make target has not functioned properly. This patch works around the automake imposed distcheck read-only directory, as well as signaling to travis-ci that sudo is required (which is required for new github forks as of 2015-01-01). Tested on

Re: [ovs-dev] OVN - QoS (Neutron API)

2015-07-14 Thread Ben Pfaff
On Thu, Jul 09, 2015 at 01:14:23PM +0300, Gal Sagie wrote: Hello all, As of Liberty, neutron will support a QoS API which can be configured on the logical ports. (Currently only bandwidth limiting will be supported) I would like to offer to implement this back-to-back in Neutron OVN

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-14 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote: Now that performance critical code already inlines miniflows and minimasks, we can simplify struct miniflow by always dynamically allocating miniflows and minimasks to the correct size. This changes the struct minimatch to

Re: [ovs-dev] [PATCH 1/2] ovn: Minor cleanups in physical component comments.

2015-07-14 Thread Justin Pettit
There's only this one patch in this series. I forgot to clean that up before I sent it. --Justin On Jul 14, 2015, at 5:31 PM, Justin Pettit jpet...@nicira.com wrote: Signed-off-by: Justin Pettit jpet...@nicira.com --- ovn/controller/physical.c | 11 ++- 1 files changed, 6

Re: [ovs-dev] [PATCH] ovs-ofctl.8: Specify correct variable in snoop description.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 05:26:12PM -0700, Justin Pettit wrote: Signed-off-by: Justin Pettit jpet...@nicira.com Acked-by: Ben Pfaff b...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] need more customers?

2015-07-14 Thread Jonathan
Hey, We want to help you to grow business fast. We offer email marketing services and we can generate you more business and leads. We only look long term cooperation which can grow your business sales 2-4 times than what it is now. Please reply today so i can go over options for you. Thanks,

Re: [ovs-dev] [v2 2/2] ovsdb: Add per transaction commit instruction counter

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 03:57:15PM -0700, Ben Pfaff wrote: On Wed, Jul 08, 2015 at 02:17:57PM -0700, Andy Zhou wrote: Measure user space only instruction counters for commit each transaction. This measurement is mainly useful for tuning OVSDB internal implementation, such as how OVSDB

Re: [ovs-dev] [v2 1/2] perf-counter: simplify the performance macro

2015-07-14 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 02:17:56PM -0700, Andy Zhou wrote: Replace the original PERF_FUNCTION_BEGIN and PERF_FUNCTION_END pair with a single PERF macro. This design is also more flexible, removing the restriction of have only one measurement per function. The next patch will make use of this

[ovs-dev] [PATCH 1/2] ovn: Minor cleanups in physical component comments.

2015-07-14 Thread Justin Pettit
Signed-off-by: Justin Pettit jpet...@nicira.com --- ovn/controller/physical.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c index dce0c2f..9e7f2f4 100644 --- a/ovn/controller/physical.c +++

Re: [ovs-dev] [v2 2/2] ovsdb: Add per transaction commit instruction counter

2015-07-14 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 02:17:57PM -0700, Andy Zhou wrote: Measure user space only instruction counters for commit each transaction. This measurement is mainly useful for tuning OVSDB internal implementation, such as how OVSDB scales over number of client connections. A simple usage

[ovs-dev] [PATCH] ovs-ofctl.8: Specify correct variable in snoop description.

2015-07-14 Thread Justin Pettit
Signed-off-by: Justin Pettit jpet...@nicira.com --- utilities/ovs-ofctl.8.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index e3436af..4c91720 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@

Re: [ovs-dev] OVN - L3 Design

2015-07-14 Thread Gal Sagie
This is just an example of a basic L3 design and where it needs the IP: 1) Traffic is sent to the default gw (logical router) (L2) (every metadata (logical switch) has a default flow that identifies the router default gw) Since i assume we going to implement *distributed virtual routing*: 2)

Re: [ovs-dev] [RFC PATCH v2 4/7] match: Single malloc minimatch.

2015-07-14 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 10:35:22AM -0700, Jarno Rajahalme wrote: Allocate the miniflow and minimask in struct minimatch at once, so that they are consecutive in memory. This halves the number of allocations, and allows smaller minimatches to share the same cache line. After this a

Re: [ovs-dev] [RFC PATCH v2 7/7] dpif-netdev: Bug fix and performance improvement.

2015-07-14 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 10:35:25AM -0700, Jarno Rajahalme wrote: MINIFLOW_FOR_EACH_IN_MAPS and NETDEV_FLOW_KEY_FOR_EACH_IN_MAPqS had a bug where tunnel metadata values remaining after the processing of the tnl_map was not advanced correctly. Is this a bug introduced only by the previous commit

Re: [ovs-dev] OVN - L3 Design

2015-07-14 Thread Gal Sagie
Thanks for taking care of the first item. For the second, it depends and has two uses i could think of: 1) For port security, as discussed in another thread we will need to add the mac-ip pairs, but this of course can be resolved by adding this to the port_security field. 2) To construct

Re: [ovs-dev] [RFC PATCH v2 6/7] flow: Split miniflow's map.

2015-07-14 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 10:35:24AM -0700, Jarno Rajahalme wrote: Use two maps in miniflow to allow for expansion of struct flow past 512 bytes. We now have one map for tunnel related fields, and another for the rest of the packet metadata and actual packet header fields. This split has the

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-14 Thread Ben Pfaff
On Thu, Jul 09, 2015 at 03:22:46PM -0400, Kyle Upton wrote: Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo that caused problems when building debian packages. Signed-off-by: Kyle Upton kup...@baymicrosystems.com Thanks, applied to master and backported to branch-2.4 and

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-14 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 10:35:23AM -0700, Jarno Rajahalme wrote: miniflow_clone() and minimask_clone() are no longer used, remove them from the API. Now that miniflow data is always inlined, it makes sense to rename miniflow_clone_inline() miniflow_clone(). Signed-off-by: Jarno Rajahalme