Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 12:26:20PM +0530, Saloni Jain wrote: So what I think that instead of ovs-ofctl table-mod to use an OFPMP_TABLE_DESC request to obtain the current configuration, then modify it according to the user's request, ovs-vswitchd should query and store the current

Re: [ovs-dev] [PATCH] netdev-linux: do not warn when getting stats for netdev with no vport

2015-07-16 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 12:28:16PM -0300, Thadeu Lima de Souza Cascardo wrote: On Mon, Jul 13, 2015 at 09:02:17AM -0700, Ben Pfaff wrote: On Tue, Jul 07, 2015 at 03:38:51PM -0300, Thadeu Lima de Souza Cascardo wrote: When there is no vport for a given netdev, dpif_netlink_vport_get might

Re: [ovs-dev] kernel module testing

2015-07-16 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote: On Jul 13, 2015, at 9:40 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote: How about automating this using travis and gerrit, so no commit gets in

[ovs-dev] [RFC v2 00/11] OVN support for Neutron provider networks

2015-07-16 Thread Russell Bryant
v1-v2: - The first path I took with this tried to model a provider network as an OVN logical switch. This patch takes a different approach suggested by Ben Pfaff where each connection to a provider network is modeled as a 2-port OVN logical switch. More details below. - This

[ovs-dev] [RFC v2 02/11] ovn: Add bridge mappings to ovn-controller.

2015-07-16 Thread Russell Bryant
Add a new OVN configuration entry in the Open_vSwitch database called ovn-bridge-mappings. This allows the configuration of mappings between a physical network name and an OVS bridge that provides connectivity to that network. For example, if you wanted to configure physnet1 to map to br-eth0

[ovs-dev] [RFC v2 01/11] ovn: Convert tabs to spaces in ovn-sb.xml.

2015-07-16 Thread Russell Bryant
This file used mixed indentation. Fix it up to be consistent. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/ovn-sb.xml | 74 +- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml

[ovs-dev] [RFC v2 05/11] ovn: Set up some bridge mappings in ovs-sandbox.

2015-07-16 Thread Russell Bryant
A recent patch added a new OVN configuration option called ovn-bridge-mappings. Create some bridges and configure ovn-bridge-mappings to make testing this part of OVN easier. This setup will not interfere with anything unless you try to create networks that make use of it. Signed-off-by:

[ovs-dev] [RFC v2 04/11] ovn: Add patch ports for ovn bridge mappings.

2015-07-16 Thread Russell Bryant
While parsing the OVN bridge mapping configuration, ensure that patch ports exist between the OVN integration bridge and the physical network bridge. If they do not exist, create them automatically. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/controller/ovn-controller.c | 107

[ovs-dev] [RFC v2 03/11] ovn: Drop unnecessary br_int local variable.

2015-07-16 Thread Russell Bryant
When getting the initial configuration, go ahead and store br_int in the controller context. This is already done in the main loop, but a future patch wants to use br_int from the controller context sooner in the code. Signed-off-by: Russell Bryant rbry...@redhat.com ---

[ovs-dev] [RFC v2 09/11] ovn: Get/set lport type and options in ovn-nbctl.

2015-07-16 Thread Russell Bryant
A recent patch added type and options columns to the Logical_Port table in OVN_Northbound. This patch allows you to get and set those columns with ovn-nbctl. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/ovn-nbctl.8.xml | 24 ++-- ovn/ovn-nbctl.c | 111

[ovs-dev] [RFC v2 07/11] lib: Add smap_equal().

2015-07-16 Thread Russell Bryant
Add a method to determine of two smaps are equal (have the exact same set of key-value pairs). Signed-off-by: Russell Bryant rbry...@redhat.com --- lib/smap.c | 34 ++ lib/smap.h | 2 ++ 2 files changed, 36 insertions(+) diff --git a/lib/smap.c b/lib/smap.c

[ovs-dev] [RFC v2 06/11] ovn-northd: Make column comparisons more generic.

2015-07-16 Thread Russell Bryant
The logic in parents_equal() and tags_equal() is useful for other columns, so convert them into more generic functions that can be reused. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/northd/ovn-northd.c | 31 --- 1 file changed, 20 insertions(+), 11

[ovs-dev] [RFC v2 08/11] ovn: Add type and options to logical port.

2015-07-16 Thread Russell Bryant
We have started discussing the use of the logical port abstraction in OVN to represent special types of connections into an OVN logical switch. This patch proposes some schema updates to reflect these special types of logical ports. A logical port can have a type and a set of options specific to

Re: [ovs-dev] [RFC v2 01/11] ovn: Convert tabs to spaces in ovn-sb.xml.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 06:06:09PM -0400, Russell Bryant wrote: This file used mixed indentation. Fix it up to be consistent. Signed-off-by: Russell Bryant rbry...@redhat.com Applied to master, thanks! ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [branch 2.1] ipfix, sflow: Fix a race.

2015-07-16 Thread Alex Wang
On Thu, Jul 16, 2015 at 4:03 PM, Jarno Rajahalme jrajaha...@nicira.com wrote: Alex, Not a review, but a comment: Isn’t it unnecessary to use atomics when the refcount is protected with a mutex? That's very true, now atomics is unnecessary. Also, in general, a thread should not release

Re: [ovs-dev] [PATCH v3 2/3] flow: Make compile with MSVC.

2015-07-16 Thread Jarno Rajahalme
On Jul 16, 2015, at 4:43 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jul 16, 2015 at 03:15:53PM -0700, Jarno Rajahalme wrote: MSVC does not like zero sized arrays in structs. Hence, remove the 'values' member from struct miniflow and add back the getters miniflow_values() and

Re: [ovs-dev] [PATCH] INSTALL.Windows.md: Update the minimum required compiler.

2015-07-16 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 11:57:09AM -0700, Gurucharan Shetty wrote: MSVC 2013 update 4 was released in Nov 2014. Its release notes says that it has fixed the problem wherein using designated initializers to initialize unions within structs would fail to compile. Using designated initializers

Re: [ovs-dev] [PATCH] ovn-nb: Add per-port IP addresses to routers.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 04:40:03PM +0300, Gal Sagie wrote: On Wed, Jul 15, 2015 at 1:08 AM, Ben Pfaff b...@nicira.com wrote: A router needs one IP address per port, not just one for the whole router. Reported-by: Gal Sagie gal.sa...@gmail.com Reported-at:

Re: [ovs-dev] [PATCH] [OVN] Add QoS to NB schema

2015-07-16 Thread Gal Sagie
These features are not yet designed in OpenStack API, for Liberty (the next release) its going to be only bandwidth limit, but they certainly will be added to the next release as there is a high demand for them. I can start trying to propose them, but i think at this point its a waste of time if

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 01:12:34PM -0700, Jarno Rajahalme wrote: I think the right fix here is to eliminate the ‘values’ field and reintroduce the miniflow_get_values() getter. I’ll post a patch to that effect as part of the v3 of the rest of the series. Good idea. I've often found that

Re: [ovs-dev] ovn-nb - Add 'name' to logical router port

2015-07-16 Thread Russell Bryant
On 07/16/2015 04:23 PM, Gal Sagie wrote: Similar to logical port, its convinent to use a 'name' field for the logical router port Signed-off-by: Gal Sagie gal.sagie@g gal.sa...@huawei.commail.com This still isn't quite right. ;-) -- Russell Bryant

Re: [ovs-dev] [PATCH 4/4] ovn: Fix extra token detection.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 10:18:29PM -0700, Joe Stringer wrote: This code attempts to first check whether another error was detected for the string it is parsing, then if it's not at the end of the tokens, report an error. However, 'errorp' is always a valid pointer to a 'char *', so the first

Re: [ovs-dev] [ovn-controller-vtep V3 3/7] ovn-sbctl: Add ovn-sbctl.

2015-07-16 Thread Alex Wang
On Wed, Jul 15, 2015 at 3:48 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 13, 2015 at 08:22:39PM -0700, Alex Wang wrote: This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. As a side effect, we move the ovn-nbctl/ovn-sbctl related files into ovn/utilities.

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-16 Thread Saloni Jain
Hi Ben, According Open vSwitch Manual: ovs-vswitchd can perform all configured bridging and switching locally, or  it can be configured to communicate with one or more external Open#8208;Flow controllers.  The switch is typically configured to connect  to  a primary   controller  that  takes  

[ovs-dev] [ovn-controller-vtep V4 6/6] ovn-controller-vtep: Add pipeline module.

2015-07-16 Thread Alex Wang
This commit adds the pipeline module to ovn-controller-vtep. The module will scan through the Binding table, and create the Ucast_Macs_Remote in vtep database for each logical port's MACs in the same logical datapath (in ovn-sb database). Also the module will create the physical locators to each

[ovs-dev] [ovn-controller-vtep V4 4/6] ovn-controller-vtep: Add gateway module.

2015-07-16 Thread Alex Wang
This commit adds the gateway module to ovn-controller-vtep. The module will register the physical switches to ovnsb as chassis and constantly update the vtep_logical_switches column in Chassis table. Limitation: - Do not support reading multiple tunnel ips of physical switch. Signed-off-by:

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Simon Horman
On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: From: Pravin Shelar pshe...@nicira.com Removes all of the OVS specific GRE code and makes OVS use a GRE net_device. Signed-off-by: Pravin B Shelar pshe...@nicira.com [snip] @@ -115,6 +117,8 @@ static bool log_ecn_error = true;

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 03:53:27PM -0700, Jesse Gross wrote: On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: There are several implementations of functions that parse/format flags and their binary

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 01:35:14AM +, Alin Serdean wrote: Hi Jarno, This is breaking the windows build (https://ci.appveyor.com/project/blp/ovs/build/1.0.459): lib/classifier.c(1355) : error C2229: struct 'unnamed-tag' has an illegal zero-sized array. The problem is the following

[ovs-dev] [ovn-controller-vtep V4 5/6] ovn-controller-vtep: Add binding module.

2015-07-16 Thread Alex Wang
This commit adds the binding module to ovn-controller-vtep. The module will scan through the Binding table in ovnsb. If there is a binding for a logical port in the vtep gateway chassis's vtep_logical_switches map, sets the binding's chassis column to the vtep gateway chassis. Signed-off-by:

[ovs-dev] [ovn-controller-vtep V4 1/6] ovn-sb: Remove the Gateway table from the ovn-sb schema.

2015-07-16 Thread Alex Wang
In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a logical switch. Each logical switch has a dedicated tunnel key and will keep records of all MACs learned from the owned vlans. So user can just send packet to a logical switch and the gateway will

[ovs-dev] [ovn-controller-vtep V4 2/6] ovn-sbctl: Add ovn-sbctl.

2015-07-16 Thread Alex Wang
This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. As a side effect, we move the ovn-nbctl/ovn-sbctl related files into ovn/utilities. Signed-off-by: Alex Wang al...@nicira.com Acked-by: Ben Pfaff b...@nicira.com --- V3-V4: - mention ovn-sbctl should never be used in

[ovs-dev] [ovn-controller-vtep V4 3/6] ovn: Add controller for VTEP gateway.

2015-07-16 Thread Alex Wang
This commit lays down the foundation for a new controller in OVN, the ovn-controller-vtep, for controlling the vtep enabled gateways. Limitation: - How to make controller-vtep connect to OVN_SB? my understanding is that vtep should not know the location of ovnsb. but there is no

Re: [ovs-dev] [PATCH v2] ofproto: Implement OF1.4 Set/Get asynchronous configuration messages.

2015-07-16 Thread niti Rohilla
Hi Ben, Thanks for the review. All the comments have been incorporated in Version 3 of the patch. I am not having any issues with make check. All the test cases in testsuite are executing successfully on the latest master code. Thanks Niti Rohilla On Wed, Jul 15, 2015 at 9:49 PM, Ben Pfaff

Re: [ovs-dev] [PATCH] ovn-nb: Add per-port IP addresses to routers.

2015-07-16 Thread Russell Bryant
On 07/14/2015 06:08 PM, Ben Pfaff wrote: A router needs one IP address per port, not just one for the whole router. Reported-by: Gal Sagie gal.sa...@gmail.com Reported-at: http://openvswitch.org/pipermail/dev/2015-July/057242.html Signed-off-by: Ben Pfaff b...@nicira.com ---

Re: [ovs-dev] [ovn-controller-vtep V4 1/6] ovn-sb: Remove the Gateway table from the ovn-sb schema.

2015-07-16 Thread Russell Bryant
On 07/16/2015 03:56 AM, Alex Wang wrote: In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a logical switch. Each logical switch has a dedicated tunnel key and will keep records of all MACs learned from the owned vlans. So user can just send

[ovs-dev] [PATCH] ovn - Add 'name' field to Logical Router port

2015-07-16 Thread Gal Sagie
Similar to logical port, its convinent to use a 'name' field for the logical router port Signed-off-by: Gal Sagie gal.sa...@huawei.com --- ovn/ovn-nb.ovsschema | 1 + ovn/ovn-nb.xml | 9 + 2 files changed, 10 insertions(+) diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema

Re: [ovs-dev] [ovn-controller-vtep V4 2/6] ovn-sbctl: Add ovn-sbctl.

2015-07-16 Thread Russell Bryant
On 07/16/2015 03:56 AM, Alex Wang wrote: +static void +usage(void) +{ +printf(\ +%s: ovs-vswitchd management utility\n\ +\n\ +for debugging and testing only, never use it in production\n\ +\n\ +usage: %s [OPTIONS] COMMAND [ARG...]\n\ +\n\ +SouthBound DB commands:\n\ + show

Re: [ovs-dev] [ovn-controller-vtep V4 3/6] ovn: Add controller for VTEP gateway.

2015-07-16 Thread Russell Bryant
On 07/16/2015 03:56 AM, Alex Wang wrote: This commit lays down the foundation for a new controller in OVN, the ovn-controller-vtep, for controlling the vtep enabled gateways. Limitation: - How to make controller-vtep connect to OVN_SB? my understanding is that vtep should not know

Re: [ovs-dev] [PATCH] ovn - Add 'name' field to Logical Router port

2015-07-16 Thread Russell Bryant
On 07/16/2015 07:51 AM, Gal Sagie wrote: Similar to logical port, its convinent to use a 'name' field for the logical router port Signed-off-by: Gal Sagie gal.sa...@huawei.com The patch seems fine to me, so: Acked-by: Russell Bryant rbry...@redhat.com However, your Signed-off-by email

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Thomas Graf
On 07/16/15 at 05:59pm, Simon Horman wrote: On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: static void ipgre_tap_setup(struct net_device *dev) { ether_setup(dev); - dev-netdev_ops = gre_tap_netdev_ops; dev-priv_flags |= IFF_LIVE_ADDR_CHANGE;

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the Gateway table from the ovn-sb schema.

2015-07-16 Thread Russell Bryant
On 07/16/2015 01:09 AM, Alex Wang wrote: I'd like to see and try out your change. At the same time, I do want to have my vtep controller code reviewed. I think I'll first adopt your suggestion and rename the column to vtep_logical_switches and repost the series to have it reviewed.

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-16 Thread Jesse Gross
On Wed, Jul 15, 2015 at 10:52 PM, Joe Stringer joestrin...@nicira.com wrote: On 15 July 2015 at 17:41, Jesse Gross je...@nicira.com wrote: On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer joestrin...@nicira.com wrote: On 15 July 2015 at 15:53, Jesse Gross je...@nicira.com wrote: On Wed, Jul 15,

Re: [ovs-dev] [PATCH 2/4] db-ctl-base: make cmd_show_table private

2015-07-16 Thread Alex Wang
On Mon, Jul 13, 2015 at 11:48 PM, Andy Zhou az...@nicira.com wrote: Instead of require user to declare a global variable, pass the value via ctl_init(). Signed-off-by: Andy Zhou az...@nicira.com --- lib/db-ctl-base.c | 34 +- lib/db-ctl-base.h | 17

Re: [ovs-dev] [PATCH 3/4] db-ctl-base: remove ctl_get_all_commands() function

2015-07-16 Thread Alex Wang
Thx for making it consistent, Acked-by: Alex Wang al...@nicira.com On Mon, Jul 13, 2015 at 11:48 PM, Andy Zhou az...@nicira.com wrote: all_commands currently is some times accessed directly, some times via a function call. Change to always access it directly. Signed-off-by: Andy Zhou

Re: [ovs-dev] [PATCH] [OVN] Add QoS to NB schema

2015-07-16 Thread Ben Pfaff
Could you extend the proposal to include those features then? At the moment it is a skeleton. On Thu, Jul 16, 2015 at 02:11:12AM +0300, Gal Sagie wrote: Yes, there are currently plans for marking (DSCP) and flow classification profiles. And other ideas like connections limiting. On Wed,

[ovs-dev] [PATCH v3] ofproto: Implement OF1.4 Set/Get asynchronous configuration messages.

2015-07-16 Thread niti1489
From: Niti niti.rohi...@tcs.com This patch adds support for Openflow1.4 set/get asynchronous configuration messages. OpenVSwitch already supports set/get asynchronous configuration messages for Openflow1.3. In this patch OFPT_SET_ASYNC_CONFIG message allows the controllers to set the

Re: [ovs-dev] [ovn-controller-vtep V4 1/6] ovn-sb: Remove the Gateway table from the ovn-sb schema.

2015-07-16 Thread Alex Wang
On Thu, Jul 16, 2015 at 6:25 AM, Russell Bryant rbry...@redhat.com wrote: On 07/16/2015 03:56 AM, Alex Wang wrote: In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a logical switch. Each logical switch has a dedicated tunnel key and will

Re: [ovs-dev] [ovn-controller-vtep V4 3/6] ovn: Add controller for VTEP gateway.

2015-07-16 Thread Alex Wang
On Thu, Jul 16, 2015 at 6:41 AM, Russell Bryant rbry...@redhat.com wrote: On 07/16/2015 03:56 AM, Alex Wang wrote: This commit lays down the foundation for a new controller in OVN, the ovn-controller-vtep, for controlling the vtep enabled gateways. Limitation: - How to make

Re: [ovs-dev] [PATCH] ovn - Add 'name' field to Logical Router port

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 08:49:44AM -0400, Russell Bryant wrote: On 07/16/2015 07:51 AM, Gal Sagie wrote: Similar to logical port, its convinent to use a 'name' field for the logical router port Signed-off-by: Gal Sagie gal.sa...@huawei.com The patch seems fine to me, so: Acked-by:

Re: [ovs-dev] [ovn-controller-vtep V4 2/6] ovn-sbctl: Add ovn-sbctl.

2015-07-16 Thread Alex Wang
On Thu, Jul 16, 2015 at 6:38 AM, Russell Bryant rbry...@redhat.com wrote: On 07/16/2015 03:56 AM, Alex Wang wrote: +static void +usage(void) +{ +printf(\ +%s: ovs-vswitchd management utility\n\ +\n\ +for debugging and testing only, never use it in production\n\ +\n\ +usage:

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the Gateway table from the ovn-sb schema.

2015-07-16 Thread Alex Wang
On Thu, Jul 16, 2015 at 6:56 AM, Russell Bryant rbry...@redhat.com wrote: On 07/16/2015 01:09 AM, Alex Wang wrote: I'd like to see and try out your change. At the same time, I do want to have my vtep controller code reviewed. I think I'll first adopt your suggestion and rename the

Re: [ovs-dev] [PATCH 1/4] db-ctl-base: remove db_ctl_show_command table

2015-07-16 Thread Alex Wang
Thx for the cleanup, I found myself wondering the same question, Acked-by: Alex Wang al...@nicira.com On Mon, Jul 13, 2015 at 11:48 PM, Andy Zhou az...@nicira.com wrote: It is not clear why show command needs its own command table. Remove it for simplicity. Signed-off-by: Andy Zhou

Re: [ovs-dev] [PATCH] acinclude: Require libfuse only for DPDK with vhost-cuse.

2015-07-16 Thread Pravin Shelar
On Thu, Jun 25, 2015 at 7:46 AM, Daniele Di Proietto diproiet...@vmware.com wrote: DPDK with vhost-user doesn't require libfuse, so we shouldn't link OVS with libfuse unless DPDK is built with vhost-cuse support. CC: Rapelly, Varun vrape...@sonusnet.com Signed-off-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH 1/4] ofp-parse: Fix typo in consistency check.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 10:18:26PM -0700, Joe Stringer wrote: This check in parse_ofp_str__() attempted to detect inconsistencies between matches and actions, or inconsistencies within the actions. In this case, ofpacts_check() would effectively zero the usable_protocols and return 0 (ie, OK).

Re: [ovs-dev] [ovn-controller-vtep V3 3/7] ovn-sbctl: Add ovn-sbctl.

2015-07-16 Thread Alex Wang
I sent out a V4 series here: http://openvswitch.org/pipermail/dev/2015-July/057570.html On Thu, Jul 16, 2015 at 1:43 PM, Ben Pfaff b...@nicira.com wrote: On Wed, Jul 15, 2015 at 11:02:29PM -0700, Alex Wang wrote: On Wed, Jul 15, 2015 at 3:48 PM, Ben Pfaff b...@nicira.com wrote: On Mon,

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-16 Thread Alin Serdean
Won't work with changing [0] to []. We need to shift the [0] to be the last member of a struct. I have no idea about the implications that it will have but something like would work: diff --git a/lib/classifier.c b/lib/classifier.c index 2ed8697..9f58d43 100644 --- a/lib/classifier.c +++

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-16 Thread Jarno Rajahalme
I think the right fix here is to eliminate the ‘values’ field and reintroduce the miniflow_get_values() getter. I’ll post a patch to that effect as part of the v3 of the rest of the series. Jarno On Jul 16, 2015, at 12:18 PM, Alin Serdean aserd...@cloudbasesolutions.com wrote: Won't

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-07-16 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 10:38:42AM -0700, Jesse Gross wrote: On Mon, Jun 22, 2015 at 10:11 AM, Ben Pfaff b...@nicira.com wrote: On Thu, Jun 11, 2015 at 09:43:58AM -0700, Neil McKee wrote: If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an OVS_ACTION_ATTR_USERSPACE action,

Re: [ovs-dev] kernel module testing

2015-07-16 Thread Kyle Mestery
On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote: On Jul 13, 2015, at 9:40 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Jul 14, 2015 at 12:34:14AM +, Pritesh Kothari (pritkoth) wrote:

Re: [ovs-dev] [PATCH] [OVN] Add QoS to NB schema

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 09:47:19PM +0300, Gal Sagie wrote: If i understand your concern right, you worry that the NB schema is getting too big. I can't think of a better way to do this both use full and smaller, if you feel that we don't want to support QoS at this point, thats fine. but this

Re: [ovs-dev] [PATCH 2/4] vtep-ctl: Remove extraneous NULL pointer check.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 10:18:27PM -0700, Joe Stringer wrote: OVS will exit if the allocations in this function fail, so this check is pointless. Found by MIT STACK analyzer. Signed-off-by: Joe Stringer joestrin...@nicira.com Acked-by: Ben Pfaff b...@nicira.com

[ovs-dev] ovn-nb - Add 'name' to logical router port

2015-07-16 Thread Gal Sagie
Similar to logical port, its convinent to use a 'name' field for the logical router port Signed-off-by: Gal Sagie gal.sagie@g gal.sa...@huawei.commail.com --- ovn/ovn-nb.ovsschema | 1 + ovn/ovn-nb.xml | 9 + 2 files changed, 10 insertions(+) diff --git a/ovn/ovn-nb.ovsschema

Re: [ovs-dev] [ovn-controller-vtep V3 3/7] ovn-sbctl: Add ovn-sbctl.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 11:02:29PM -0700, Alex Wang wrote: On Wed, Jul 15, 2015 at 3:48 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 13, 2015 at 08:22:39PM -0700, Alex Wang wrote: This commit adds ovn-sbctl to ovn family by using the db-ctl-base library. As a side effect, we

Re: [ovs-dev] [v3 1/3] perf-counter: initialize perf counter shash before use

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 03:47:33PM -0700, Andy Zhou wrote: Private variable perf_counters needs to be initialized before use. Otherwise, perf_counter_init() call will cause crashes. Signed-off-by: Andy Zhou az...@nicira.com Acked-by: Ben Pfaff b...@nicira.com

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the Gateway table from the ovn-sb schema.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 09:40:08PM -0700, Alex Wang wrote: On Wed, Jul 15, 2015 at 1:10 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 13, 2015 at 08:22:38PM -0700, Alex Wang wrote: In a gateway like the VTEP L2 gateway, physical vlans belonging to the same logical network form a

Re: [ovs-dev] [PATCH 3/4] ovs-vsctl: Remove redundant checks.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 10:18:28PM -0700, Joe Stringer wrote: In several places, br is dereferenced just before a check such as if (br ...). These checks may be optimised out, and they provide no additional safety, so this patch removes them. Found by MIT STACK analyzer. Signed-off-by:

Re: [ovs-dev] [v3 3/3] ovsdb: Add per transaction commit instruction counter

2015-07-16 Thread Ben Pfaff
Tests pass for me now with v3, so please push these when you are satisfied with them. Thank you! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Fix detection of vhost_cuse in dpdk rte_config.h

2015-07-16 Thread Ben Pfaff
On Mon, Jul 06, 2015 at 05:41:38PM -0400, Mussar, Gary wrote: Fix detection of vhost_cuse in dpdk rte_config.h Dpdk allows users to create a config that includes other config files and then override values. Eg. defconfig_x86_64-native_vhost_cuse-linuxapp-gcc:

Re: [ovs-dev] [PATCH] ovn-nb: Add per-port IP addresses to routers.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 04:36:58PM +0300, Gal Sagie wrote: The change looks good to me. Thanks, I applied this to master. The question i have is how will public network be configured/connected to the logical router in OVN? (In neutron router can only be connected to one public network) This

[ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-07-16 Thread Daniele Di Proietto
It has been observed that some DPDK device (e.g intel xl710) report an high number of queues but make some of them available only for special functions (SRIOV). Therefore the queues will be counted in rte_eth_dev_info_get(), but rte_eth_tx_queue_setup() will fail. This commit works around the

[ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

2015-07-16 Thread Daniele Di Proietto
netdev_dpdk_set_multiq() should not set the number of configured rxq and txq if the driver initialization fails (meaning that the driver failed to setup the queues). Otherwise, on a subsequent call to netdev_dpdk_set_multiq(), the code may believe that the queues have already been setup and

Re: [ovs-dev] [PATCH] ovn - Add 'name' field to Logical Router port

2015-07-16 Thread Gal Sagie
I will re-send with gal.sa...@gmail.com On Thu, Jul 16, 2015 at 7:07 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jul 16, 2015 at 08:49:44AM -0400, Russell Bryant wrote: On 07/16/2015 07:51 AM, Gal Sagie wrote: Similar to logical port, its convinent to use a 'name' field for the logical

Re: [ovs-dev] [PATCH] automake: Cleanup to allow make distcheck to succeed.

2015-07-16 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 10:09:41PM -0400, Aaron Conole wrote: For some time, it seems that the distcheck make target has not functioned properly. This patch works around the automake imposed distcheck read-only directory, as well as signaling to travis-ci that sudo is required (which is

Re: [ovs-dev] [branch 2.1] ipfix, sflow: Fix a race.

2015-07-16 Thread Jarno Rajahalme
Alex, Not a review, but a comment: Isn’t it unnecessary to use atomics when the refcount is protected with a mutex? Also, in general, a thread should not release the last reference if other threads can still find the object. Why does this happen here? Jarno On Jul 16, 2015, at 3:48 PM,

Re: [ovs-dev] [RFC v2 04/11] ovn: Add patch ports for ovn bridge mappings.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 06:06:12PM -0400, Russell Bryant wrote: While parsing the OVN bridge mapping configuration, ensure that patch ports exist between the OVN integration bridge and the physical network bridge. If they do not exist, create them automatically. Signed-off-by: Russell

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-16 Thread Jarno Rajahalme
On Jul 16, 2015, at 4:33 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote: I've seen core files appear and then be automatically removed as the test case was successful. Such success is highly doubtful, so fail the test cases if any core

Re: [ovs-dev] [PATCH v3 3/3] flow: Split miniflow's map.

2015-07-16 Thread Jarno Rajahalme
On Jul 16, 2015, at 4:44 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jul 16, 2015 at 03:15:54PM -0700, Jarno Rajahalme wrote: Use two maps in miniflow to allow for expansion of struct flow past 512 bytes. We now have one map for tunnel related fields, and another for the rest of the

[ovs-dev] [branch 2.1] ipfix, sflow: Fix a race.

2015-07-16 Thread Alex Wang
In ovs 2.1, the unref functions for ipfix and sflow are called in ofproto/ofproto-dpif-upcall.c without the protection of any lock. If the unprotected call of unref function removes the last reference, and at the same time, other thread is trying to ref the same struct, the race could cause

Re: [ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote: I've seen core files appear and then be automatically removed as the test case was successful. Such success is highly doubtful, so fail the test cases if any core files exist at the end of the test. Signed-off-by: Jarno

[ovs-dev] [RFC v2 10/11] ovn: Fix uninit access warning from valgrind.

2015-07-16 Thread Russell Bryant
While running ovn-controller under valgrind, I noticed several variations of the same warning. Switching this allocation from malloc to zalloc resolves it. For reference, some examples from valgrind are: ==8487== Conditional jump or move depends on uninitialised value(s) ==8487==at

Re: [ovs-dev] About one abort in vswitchd

2015-07-16 Thread Alex Wang
Sorry for this very delayed reply, I think I found the issue, in branch 2.1.* Will send out a fix soon, At the same time, it branch = 2.3 do not have this issue due to the use of ovs-rcu... And since branch 2.3 is the LTS branch, I would really recommend you to switch to 2.3+ Thanks, Alex

[ovs-dev] [RFC v2 11/11] ovn: Add localnet logical port type.

2015-07-16 Thread Russell Bryant
Introduce a new logical port type called localnet. A logical port with this type also has an option called network_name. A localnet logical port represents a connection to a locally accessible network. ovn-controller will use the ovn-bridge-mappings configuration to figure out which patch port

[ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

2015-07-16 Thread Jarno Rajahalme
I've seen core files appear and then be automatically removed as the test case was successful. Such success is highly doubtful, so fail the test cases if any core files exist at the end of the test. Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com --- tests/ofproto-macros.at |6 +-

[ovs-dev] [PATCH v3 2/3] flow: Make compile with MSVC.

2015-07-16 Thread Jarno Rajahalme
MSVC does not like zero sized arrays in structs. Hence, remove the 'values' member from struct miniflow and add back the getters miniflow_values() and miniflow_get_values(). Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com --- lib/classifier-private.h | 19 ++-

[ovs-dev] [PATCH v3 3/3] flow: Split miniflow's map.

2015-07-16 Thread Jarno Rajahalme
Use two maps in miniflow to allow for expansion of struct flow past 512 bytes. We now have one map for tunnel related fields, and another for the rest of the packet metadata and actual packet header fields. This split has the benefit that for non-tunneled packets the overhead should be minimal.

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-07-16 Thread Pravin Shelar
On Thu, Jul 16, 2015 at 1:36 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 22, 2015 at 10:38:42AM -0700, Jesse Gross wrote: On Mon, Jun 22, 2015 at 10:11 AM, Ben Pfaff b...@nicira.com wrote: On Thu, Jun 11, 2015 at 09:43:58AM -0700, Neil McKee wrote: If new optional attribute

Re: [ovs-dev] [PATCH v3 3/3] flow: Split miniflow's map.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 03:15:54PM -0700, Jarno Rajahalme wrote: Use two maps in miniflow to allow for expansion of struct flow past 512 bytes. We now have one map for tunnel related fields, and another for the rest of the packet metadata and actual packet header fields. This split has the

Re: [ovs-dev] [RFC v2 02/11] ovn: Add bridge mappings to ovn-controller.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 06:06:10PM -0400, Russell Bryant wrote: Add a new OVN configuration entry in the Open_vSwitch database called ovn-bridge-mappings. This allows the configuration of mappings between a physical network name and an OVS bridge that provides connectivity to that network.

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Pravin Shelar
On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf tg...@suug.ch wrote: On 07/16/15 at 05:59pm, Simon Horman wrote: On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: static void ipgre_tap_setup(struct net_device *dev) { ether_setup(dev); - dev-netdev_ops =

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-16 Thread Jarno Rajahalme
On Jul 16, 2015, at 1:21 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jul 16, 2015 at 01:12:34PM -0700, Jarno Rajahalme wrote: I think the right fix here is to eliminate the ‘values’ field and reintroduce the miniflow_get_values() getter. I’ll post a patch to that effect as part of the v3

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-16 Thread Jarno Rajahalme
I posted a v3 of the patch series that includes a fix for this. However, I don’t have the MSVC environment set up, so I’d be grateful if you could test it out. Thanks, Jarno On Jul 15, 2015, at 5:16 PM, Gurucharan Shetty shet...@nicira.com wrote: tomorrow is fine, thank Jarno! On

Re: [ovs-dev] [RFC v2 02/11] ovn: Add bridge mappings to ovn-controller.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 04:55:11PM -0700, Ben Pfaff wrote: On Thu, Jul 16, 2015 at 06:06:10PM -0400, Russell Bryant wrote: Add a new OVN configuration entry in the Open_vSwitch database called ovn-bridge-mappings. This allows the configuration of mappings between a physical network name

[ovs-dev] [PATCH v4] flow: Split miniflow's map.

2015-07-16 Thread Jarno Rajahalme
Use two maps in miniflow to allow for expansion of struct flow past 512 bytes. We now have one map for tunnel related fields, and another for the rest of the packet metadata and actual packet header fields. This split has the benefit that for non-tunneled packets the overhead should be minimal.

Re: [ovs-dev] [PATCH 1/2] Include datapath actions with sampled-packet upcall to userspace.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 04:12:25PM -0700, Pravin Shelar wrote: On Thu, Jul 16, 2015 at 1:36 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 22, 2015 at 10:38:42AM -0700, Jesse Gross wrote: On Mon, Jun 22, 2015 at 10:11 AM, Ben Pfaff b...@nicira.com wrote: On Thu, Jun 11, 2015 at

Re: [ovs-dev] [PATCH v3 2/3] flow: Make compile with MSVC.

2015-07-16 Thread Ben Pfaff
On Thu, Jul 16, 2015 at 03:15:53PM -0700, Jarno Rajahalme wrote: MSVC does not like zero sized arrays in structs. Hence, remove the 'values' member from struct miniflow and add back the getters miniflow_values() and miniflow_get_values(). Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com