Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Elzur, Uri
+1 on starting w MD Type = 1 Not sure I understand the concern expressed with " implementations that don't implement TLVs will become deployed and then when there is a use for them it's no longer possible." - why will it not be possible to add MD Type=2 later? Thx Uri (“Oo-Ree”) C:

Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs

2016-07-13 Thread Nithin Raju
-Original Message- From: dev on behalf of Yin Lin Date: Wednesday, July 13, 2016 at 8:21 PM To: "dev@openvswitch.org" Cc: Yin Lin Subject: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs

Re: [ovs-dev] [PATCH 1/2] tests: Ignore proxy configuration in kernel testsuite.

2016-07-13 Thread Ben Pfaff
On Wed, Jul 06, 2016 at 06:02:45AM -0700, Jarno Rajahalme wrote: > > > On Jul 1, 2016, at 8:30 PM, Ben Pfaff wrote: > > > > On Tue, Jun 21, 2016 at 09:57:15AM -0700, Jarno Rajahalme wrote: > >> Add '--noproxy' parameter to 'wget' so that the test cases do not try > >> to use a

[ovs-dev] [PATCH 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-13 Thread Ansis Atteka
There are two issues that this patch fixes: 1. it was impossible to set skb mark at all through NXM_NX_PKT_MARK register for tunnel packets; AND 2. ipsec_xxx tunnels would not be marked with the default IPsec mark (broken by d23df9a87 "lib/odp: Use masked set actions."). This patch also

[ovs-dev] [PATCH 1/2] IPsec: refactor out some code in OVS_MONITOR_IPSEC_START macro

2016-07-13 Thread Ansis Atteka
This OVS_MONITOR_IPSEC_START macro will be helpful in the next patch where it will be used also from tests/tunnel.at file to test that skb marking happens correctly. Otherwise, without ovs-monitor-ipsec running the ovs-vswitchd would refuse to configure ipsec_XXX tunnels. Signed-off-by: Ansis

Re: [ovs-dev] [PATCH] ovn-controller: Clean up bindings handling.

2016-07-13 Thread Mickey Spiegel
>To: dev@openvswitch.org >From: Russell Bryant >Sent by: "dev" >Date: 07/13/2016 02:53PM >Subject: [ovs-dev] [PATCH] ovn-controller: Clean up bindings handling. > >Remove the global set of logical port IDs called 'all_lports'. This is >no longer used for anything after conntrack ID assignment

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Li, Johnson
> > Please see previous comments in this thread, such as this one: > http://openvswitch.org/pipermail/dev/2016-July/074980.html > We are trying to remove the dependency on Simon's patch set, but we have similar implementation for the datapath, this is duplicated effort. So we have to wait for

[ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs

2016-07-13 Thread Yin Lin
Signed-off-by: Yin Lin --- datapath-windows/ovsext/Flow.c | 2 +- datapath-windows/ovsext/Vport.c | 3 ++- datapath-windows/ovsext/Vport.h | 5 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c

Re: [ovs-dev] [PATCH] OVN-Tutorial: Update sample output.

2016-07-13 Thread Ryan Moats
"dev" wrote on 07/07/2016 02:16:29 PM: > From: Russell Bryant > To: dev@openvswitch.org > Date: 07/07/2016 02:16 PM > Subject: [ovs-dev] [PATCH] OVN-Tutorial: Update sample output. > Sent by: "dev" > > A previous patch

Re: [ovs-dev] [PATCH v2] ovs-pki: Use SHA-512 instead of SHA-1 as message digest.

2016-07-13 Thread Ryan Moats
"dev" wrote on 07/01/2016 08:05:40 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff , Kurt Roeckx , > 828...@bugs.debian.org > Date: 07/01/2016 08:06 PM > Subject: [ovs-dev] [PATCH v2] ovs-pki: Use SHA-512

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Yang, Yi
On Wed, Jul 13, 2016 at 07:22:39PM -0700, Jesse Gross wrote: > >> > >> In any case, I don't think this is a fundamental issue, just a matter > >> of timing. Since the premise of the original question was that MD type > >> 2 shouldn't be too much additional work and the series is currently > >>

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jesse Gross
On Wed, Jul 13, 2016 at 6:38 PM, Yang, Yi wrote: > On Wed, Jul 13, 2016 at 09:59:34AM -0700, Jesse Gross wrote: >> On Wed, Jul 13, 2016 at 7:55 AM, Jiri Benc wrote: >> > On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote: >> >> I think history tells us

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Yang, Yi
On Wed, Jul 13, 2016 at 09:59:34AM -0700, Jesse Gross wrote: > On Wed, Jul 13, 2016 at 7:55 AM, Jiri Benc wrote: > > On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote: > >> I think history tells us how this will end - similar to IPv4 options, > >> implementations that don't

Re: [ovs-dev] [PATCH] Add support for 802.1ad (QinQ tunneling)

2016-07-13 Thread Xiao Liang
As far as I know, Eric and Tom are working on the kernel patch set and would submit a new version to net-next. Kernel patches usually go to netdev first and then backported to OVS tree. Meanwhile, this userspace patch works with current kernel module, with a limitation that inner VLAN header can

Re: [ovs-dev] [PATCH] ofproto: ofp_packet_out messages in bundles

2016-07-13 Thread André Mantas
Thanks for the review. I'm not sure if I will be able to address your second point tho. Would this be a problem? As for the third point, would ofproto.c be a good place for the helper function? Something like: static enum ofperr ofproto_extract_packet_out(struct ofproto *p, const struct

Re: [ovs-dev] [PATCH] system-traffic: Remove datapath specific tests and macro.

2016-07-13 Thread William Tu
Hi Joe, I agree that this check is kind of redundant. Please remove this line. Thank you~ William On Wed, Jul 13, 2016 at 4:57 PM, Joe Stringer wrote: > On 1 July 2016 at 09:45, William Tu wrote: >> We generally try to keep the testsuite independent of the

[ovs-dev] [PATCH 5/5] ofp-actions: Remove XXX comment for write-actions in ofpacts_format().

2016-07-13 Thread Ben Pfaff
I don't know why this was here. The write_actions instruction works fine. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index aa681c0..8e41f7c 100644 --- a/lib/ofp-actions.c +++

[ovs-dev] [PATCH 4/5] ofp-actions: Translate OF1.1+ mod_nw_ttl action to OF1.0 properly.

2016-07-13 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- NEWS | 4 ++-- lib/ofp-actions.c| 4 +++- tests/ofp-actions.at | 18 ++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 15fa165..6496dc1 100644 --- a/NEWS +++ b/NEWS @@ -22,8 +22,8

[ovs-dev] [PATCH 3/5] ofp-actions: Translate mod_nw_ecn action to OF1.1 properly.

2016-07-13 Thread Ben Pfaff
Also, translate OF1.2+ "set_field" on OXM_OF_IP_ECN properly to OF1.1 "mod_nw_ecn". Signed-off-by: Ben Pfaff --- NEWS | 3 +++ lib/ofp-actions.c| 28 +++- tests/ofp-actions.at | 40

[ovs-dev] [PATCH 1/5] ofp-actions: Add extension to support "group" action in OF1.0.

2016-07-13 Thread Ben Pfaff
From time to time it confuses users that "group" actions disappear when using OpenFlow 1.0. Signed-off-by: Ben Pfaff --- NEWS | 1 + lib/ofp-actions.c| 12 tests/ofp-actions.at | 3 +++ utilities/ovs-ofctl.8.in | 6 -- 4 files

[ovs-dev] [PATCH 2/5] ofp-actions: Translate OF1.0 "enqueue" actions for OF1.1+.

2016-07-13 Thread Ben Pfaff
Previously, the OF1.0 "enqueue" action was simply omitted when actions were translated into OpenFlow 1.1 or later, which do not have a similar action. This commit translates this action into an equivalent sequence of actions. Signed-off-by: Ben Pfaff --- NEWS | 1

[ovs-dev] [PATCH 0/5] Improve version compatibility for OpenFlow actions

2016-07-13 Thread Ben Pfaff
This series started out by adding an extension to support "group" actions in OF1.0, because a number of users had been confused by these actions just disappearing. I think I'd been bit by that myself a few times. Then I noticed a number of other XXX markers in the action code, so the rest of the

Re: [ovs-dev] [PATCH] system-traffic: Remove datapath specific tests and macro.

2016-07-13 Thread Joe Stringer
On 1 July 2016 at 09:45, William Tu wrote: > We generally try to keep the testsuite independent of the underlying > datapath. This patch removes the datapath-specific tests and macros. > > Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/141642065 > Signed-off-by:

[ovs-dev] [PATCH 2/9] datapath-windows: Add supported netlink family protocols to NetlinkProto.h

2016-07-13 Thread Sairam Venugopal
The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER protocols for netlink communication. Define these two protocols in the datapath. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Netlink/NetlinkProto.h | 3 +++ 1 file changed, 3 insertions(+)

[ovs-dev] [PATCH 1/9] datapath-windows: Rename OVS_EVENT_ENTRY to OVS_VPORT_EVENT_ENTRY

2016-07-13 Thread Sairam Venugopal
OVS_EVENT_ENTRY currently handles only Vport related events. Updating the name of the struct to OVS_VPORT_EVENT_ENTRY. This will assist in introducing other structs to manage other events. Remove OVS_EVENT_STATUS since it's currently not in use. Signed-off-by: Sairam Venugopal

[ovs-dev] [PATCH 7/9] datapath-windows: Add support for multiple event queue in Event.c

2016-07-13 Thread Sairam Venugopal
Update Event.c to have multiple event queues and mechanism to retrieve the associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry similar to OvsPostVportEvent and OvsRemoveVportEventEntry. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Event.c |

[ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-13 Thread Sairam Venugopal
Define new Conntrack events (new and delete) and add support for subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and store it as part of OVS_EVENT_SUBSCRIBE structure. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Datapath.c | 21

[ovs-dev] [PATCH 6/9] datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it reusable

2016-07-13 Thread Sairam Venugopal
Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating netlink messages from other files. Also define the function in Conntrack.h to make it accessible. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 32

[ovs-dev] [PATCH 3/9] datapath-windows: Explicitly name vport related event to vportEvent

2016-07-13 Thread Sairam Venugopal
Update the datapath to refer to events as vportEvents. This will aid in the introduction of other events. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Datapath.c | 3 ++- datapath-windows/ovsext/Event.c| 10 +- datapath-windows/ovsext/Event.h|

[ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-13 Thread Sairam Venugopal
When userspace tries to resubscribe to an existing queue, return STATUS_INVALID_PARAMETER since it's not supported. The current bug overwrites status to STATUS_SUCCESS. The second bug fix is around releasing the EventQueue lock if an open instance couldn't be found. The current version returns

[ovs-dev] [PATCH 0/9] Add support for sending Conntrack events

2016-07-13 Thread Sairam Venugopal
Send out events when a Conntrack entry is created or destroyed. The events can be listened using the netlink multicast subscription. Also fix few bugs in Event.c around event handling. Sairam Venugopal (9): datapath-windows: Rename OVS_EVENT_ENTRY to OVS_VPORT_EVENT_ENTRY datapath-windows:

[ovs-dev] [PATCH 9/9] datapath-windows: Post Conntrack delete and new events

2016-07-13 Thread Sairam Venugopal
Post Conntrack delete and create events when entries are deleted or created. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 12 1 file changed, 12 insertions(+) diff --git a/datapath-windows/ovsext/Conntrack.c

[ovs-dev] [PATCH 8/9] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

2016-07-13 Thread Sairam Venugopal
OvsReadEventCmdHandler must now reflect the right event being read. If the event is a Conntrack related event, then convert the entry to netlink format and send it to userspace. If it's Vport event, retain the existing workflow. Signed-off-by: Sairam Venugopal ---

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jan Scheurich
The push_nsh action creates a non-Ethernet packet in the OF pipeline, which is not at all supported by OVS prior to Simon's patch. It is not good enough to promise that an SFC controller will always send a push_eth action right next to fix this. A new action in OVS must be sane in the sense

Re: [ovs-dev] Backport Request for 2.5.0

2016-07-13 Thread Ben Pfaff
On Tue, Jul 05, 2016 at 11:39:06AM -0400, Aaron Conole wrote: > Hello, > > I'd like to request for the following 5 commits to be backported to > 2.5.0, if it's appropriate: > > 314ce6479a8380e2aeaa53eb5bab96a23c06d62d - ovs-tcpdump: Add a tcpdump >

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-13 Thread Cathy Zhang
Hi Russell, To add on Farhad's point, with current neutron and nova, we cannot create a multi-tenant VNF. Currently, nova checks whether the neutron port belongs to the same tenant as the VM itself. You attach a network interface (neutron port) to a VM using nova interface-attach, if the

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-13 Thread Cathy Zhang
Hi Kyle, This is what I thought was going on. So basically, networking-sfc is currently not providing multi-tenancy for VNFs using the chain, and you need to build chains (and VNFs) per-tenant. Cathy> If the "VLAN-aware-VM" feature of Neutron allows sub-ports of a VM (i.e. the VNF) to be

Re: [ovs-dev] (no subject)

2016-07-13 Thread Dane Mccall
Please find attached the minutes of the Project Progress Review Meeting, for your reference, action & records Best regards, Dane Mccall ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn-controller: Clean up bindings handling.

2016-07-13 Thread Russell Bryant
Remove the global set of logical port IDs called 'all_lports'. This is no longer used for anything after conntrack ID assignment was moved out of binding.c. Remove the global smap of logical port IDs to ovsrec_interface records. We can't persist references to these records, as we may be holding

Re: [ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

2016-07-13 Thread Russell Bryant
On Wed, Jul 13, 2016 at 2:08 PM, Ben Pfaff wrote: > On Wed, Jul 13, 2016 at 01:50:58PM -0400, Russell Bryant wrote: > > Adjust the field width for a couple of elements in the output of the > > lflow-list sub-command of ovn-sbctl. We now have a table ID of 10, so > > set a field

[ovs-dev] Document

2016-07-13 Thread Meghan Hunter
Please find the attached file (scanned invoice) Best regards, Meghan Hunter ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto: Fix consistent hashing

2016-07-13 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 09:15:40AM +0300, Liran Schour wrote: > Hashing will not be consistent as long as we use for hashing the index of the > bucket in the list (for remove/insert of buckets not from/to the end of the > bucket list). > Use bucket_id for hashing instead. > > Signed-off-by: Liran

[ovs-dev] [PATCH v2] ovn-northd: Combine two NAT loops into one.

2016-07-13 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- ovn/northd/ovn-northd.c | 47 ++- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index b1c2c6c..52e3229 100644 ---

Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-13 Thread Lance Richardson
> > diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at > > index c296f0e..c978137 100644 > > --- a/tests/ovn-controller-vtep.at > > +++ b/tests/ovn-controller-vtep.at > > @@ -225,8 +225,9 @@ AT_CHECK([sed -n 's/^.*\(|WARN|.*\)$/\1/p' > > ovn-controller-vtep.log | sed 's/([[-

[ovs-dev] Document

2016-07-13 Thread Terri Callahan
Please find the relevant documents attached Best regards, Terri Callahan ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

2016-07-13 Thread Aaron Rosen
Yea I totally agree. In the latest patch I sent out it skips these tests if the user doesn't have the ovs python lib installed. I'll try and see what I can do to fix this. On Wed, Jul 13, 2016 at 10:56 AM, Ben Pfaff wrote: > On Mon, Jul 04, 2016 at 12:17:54PM -0700, Aaron Rosen

Re: [ovs-dev] Architecture documents (connection manager)

2016-07-13 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 09:08:25AM -0400, Danushka Menikkumbura wrote: > I am trying to understand the internals of connection manager. I need to > change it a bit for my research work. Are there any documents on its > architecture?. I am going through the code but its not that productive it >

Re: [ovs-dev] (no subject)

2016-07-13 Thread Tobias Parker
Please find attached the minutes of the Project Progress Review Meeting, for your reference, action & records Best regards, Tobias Parker ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] sset: New functionsset_from_delimited_string().

2016-07-13 Thread Ben Pfaff
On Tue, Jul 05, 2016 at 09:32:31PM -0500, Ryan Moats wrote: > "dev" wrote on 06/24/2016 11:30:39 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 06/24/2016 11:31 PM > > Subject: [ovs-dev] [PATCH v2]

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: XPS (Transmit Packet Steering) implementation.

2016-07-13 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 03:53:00PM +0300, Ilya Maximets wrote: > Hi, Daniele. > Thanks for review. > > On 13.07.2016 04:15, Daniele Di Proietto wrote: > > Thanks for the patch. > > > > This is not a complete review, but I have some preliminary comments. > > > > If I understand correctly

Re: [ovs-dev] [PATCH] ovn-northd: Use ovs_be32 for an IP address in find_lrp_member_ip().

2016-07-13 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 01:10:01PM -0700, Guru Shetty wrote: > On 13 July 2016 at 13:02, Ben Pfaff wrote: > > > Fixes a number of warnings from "sparse". > > > > Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical > > router port.") > > Signed-off-by: Ben

Re: [ovs-dev] [PATCH v3 0/3] XPS implementation (Second part of XPS patch-set).

2016-07-13 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 08:06:03AM +0300, Ilya Maximets wrote: > First two patches "Is being held until the list moderator can review > it for approval." > > Could anyone approve them? > > 'fat-rwlock's are very suspicious. We won't tolerate fat-shaming around here...

Re: [ovs-dev] [ovn-ipv6 24/26] [RFC] ovn-northd: Implement basic IPv6 routing.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:54PM -0700, Justin Pettit wrote: > Future commits will add support for dynamic IPv6/MAC bindings. > > TODO: > - ovn-northd man page needs updated flows. > - Add unit tests. I hope it's OK if I defer reviewing this and the remaining patches until the non-RFC

Re: [ovs-dev] [PATCH] ovn-northd: Use ovs_be32 for an IP address in find_lrp_member_ip().

2016-07-13 Thread Guru Shetty
On 13 July 2016 at 13:02, Ben Pfaff wrote: > Fixes a number of warnings from "sparse". > > Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical > router port.") > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- >

Re: [ovs-dev] [ovn-ipv6 23/26] ovn: Rename "nd" action to "nd_adv".

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:53PM -0700, Justin Pettit wrote: > Rename "nd" to "nd_adv" to be more descriptive and consistent with other > ND messages and actions. This commit also fixes some minor > documentation issues and limits the action to responding to Neighbor > Solicitation messages. >

Re: [ovs-dev] [ovn-ipv6 22/26] ovn-controller: Tighten "nd" definition, add "nd_sol" and "nd_adv".

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:52PM -0700, Justin Pettit wrote: > According to RFC 4861, Neighbor Discovery messages should only match > when the Hop Limit is 255 to prevent off-link senders from sending ND > messages. This commit limits matching to that Hop Limit. > > It also introduces Neighbor

Re: [ovs-dev] [ovn-ipv6 21/26] ovn-util: Add solicited node addresses to ipv6_netaddr.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:51PM -0700, Justin Pettit wrote: > Every IPv6 host has a link-local solicited node multicast address for > neighbor discovery. This commit defines the solicited node address for > each IPv6 address added to a logical switch or router port. > > Signed-off-by: Justin

[ovs-dev] [PATCH] ovn-northd: Use ovs_be32 for an IP address in find_lrp_member_ip().

2016-07-13 Thread Ben Pfaff
Fixes a number of warnings from "sparse". Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical router port.") Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c

Re: [ovs-dev] [ovn-ipv6 20/26] packets: Add in6_is_lla() function.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:50PM -0700, Justin Pettit wrote: > This will have a caller in a future commit. > > Signed-off-by: Justin Pettit > +static inline bool > +in6_is_lla(struct in6_addr *addr) > +{ > +return addr->s6_addr32[0] == htonl(0xfe80) &&

Re: [ovs-dev] [ovn-ipv6 20/26] packets: Add in6_is_lla() function.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:50PM -0700, Justin Pettit wrote: > This will have a caller in a future commit. > > Signed-off-by: Justin Pettit I figured out what lla means, but would you mind adding a comment? > +static inline bool > +in6_is_lla(struct in6_addr *addr) > +{ The

Re: [ovs-dev] [ovn-ipv6 19/26] packets: Define RSO flags.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:49PM -0700, Justin Pettit wrote: > Use #define's as opposed to magic numbers. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [ovn-ipv6 18/26] packets: Rename "rco_flags" to "rso_flags".

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:48PM -0700, Justin Pettit wrote: > I presume the flags are supposed to map to neighbor discovery > advertisement "Router", "Solicited", and "Override" flags, which would > be "rso" instead of "rco". > > Signed-off-by: Justin Pettit After a little

Re: [ovs-dev] [ovn-ipv6 17/26] packets: Introduce xor and is_zero functions on IPv6 addresses.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:47PM -0700, Justin Pettit wrote: > These will have callers later. > > Signed-off-by: Justin Pettit > lib/packets.c | 38 ++ > lib/packets.h | 3 +++ > 2 files changed, 41 insertions(+) > > diff --git

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:46PM -0700, Justin Pettit wrote: > Rename "compose_nd" and "compose_na" to "compose_nd_sol" and > "compose_nd_adv", respecively, to be clearer about their functionality. > Also change the source and destination IPv6 addresses to take > "struct in6_addr" arguments,

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-13 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 07:26:29PM +0800, Zong Kai Li wrote: > On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit wrote: > > Rename "compose_nd" and "compose_na" to "compose_nd_sol" and > > "compose_nd_adv", respecively, to be clearer about their functionality. > > Also change the

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-13 Thread Cathy Zhang
Hi Kyle, -Original Message- From: Kyle Mestery [mailto:mest...@mestery.com] Sent: Wednesday, July 13, 2016 8:12 AM To: Cathy Zhang Cc: Russell Bryant; dev@openvswitch.org; John McDowall Subject: Re: [ovs-dev] SFC-Summary: MultiTenant > > Cathy> From networking-sfc point of view, there

Re: [ovs-dev] [PATCH] Add support for 802.1ad (QinQ tunneling)

2016-07-13 Thread Carl Baldwin
On Sat, Jun 25, 2016 at 4:13 AM, Xiao Liang wrote: > Hi, > > I'm looking for QinQ support in OVS for some time. And found patches[1-3] > by Thomas, and Gayathri. What I want is to use QinQ tunneling in neutron > networking, which needs vlan_mode configuration of ports (as in

Re: [ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

2016-07-13 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 01:50:58PM -0400, Russell Bryant wrote: > Adjust the field width for a couple of elements in the output of the > lflow-list sub-command of ovn-sbctl. We now have a table ID of 10, so > set a field width of 2 to keep output aligned. Table names have grown to > a max of 19

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

2016-07-13 Thread Ben Pfaff
On Mon, Jul 04, 2016 at 12:17:54PM -0700, Aaron Rosen wrote: > On Sun, Jul 3, 2016 at 12:04 PM, Ben Pfaff wrote: > > > On Thu, Jun 30, 2016 at 02:27:19PM -0700, Aaron Rosen wrote: > > > This patch exposes the c function expr_parse_string() to be called via > > > python. The

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jesse Gross
Please see previous comments in this thread, such as this one: http://openvswitch.org/pipermail/dev/2016-July/074980.html On Wed, Jul 13, 2016 at 10:06 AM, Brady Allen Johnson wrote: > Is the current implementation really dependent on Simon's patch? > > I

[ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

2016-07-13 Thread Russell Bryant
Adjust the field width for a couple of elements in the output of the lflow-list sub-command of ovn-sbctl. We now have a table ID of 10, so set a field width of 2 to keep output aligned. Table names have grown to a max of 19 characters, so update the field width to keep output aligned. Finally,

Re: [ovs-dev] [PATCH V7] windows: Added lockf function and lock PID file

2016-07-13 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Wednesday, July 13, 2016 8:35 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V7] windows: Added lockf function

[ovs-dev] [PATCH V7] windows: Added lockf function and lock PID file

2016-07-13 Thread Paul Boca
If the PID file isn't locked then appctl.py detects it as stale and bails out without doing anything. Because of this lots of Python tests fail. Also this protects the PID file from being overwritten. I used only shared lock, in order to be compatible with Python tests, which try to acquire the

[ovs-dev] [PATCH v3] ovsdb: Weak references performance fix

2016-07-13 Thread Rodriguez Betancourt, Esteban
Prevents the cloning of rows with outgoing or incoming weak references when those rows aren't being modified. It improves the OVSDB Server performance when many rows with weak references are involved in a transaction. Signed-off-by: Esteban Rodriguez Betancourt --- In the

[ovs-dev] [PATCH v2 2/2] system-ovn.at: Add a OVN load-balancing unit test.

2016-07-13 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- tests/system-ovn.at | 125 1 file changed, 125 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index b4cbc85..13f380f 100644 --- a/tests/system-ovn.at +++

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Brady Allen Johnson
Is the current implementation really dependent on Simon's patch? I understood that the current implementation is for ethernet+NSH and VXLAN+ethernet+NSH which doesnt require Simon's patch. Simon's patch would be needed for VXLAN-GPE+NSH, which is not in this implementation. Maybe the authors

[ovs-dev] [PATCH v2 1/2] system-ovn.at: Add a OVN NAT test using OVN gateway.

2016-07-13 Thread Gurucharan Shetty
This unit test adds a basic OVN NAT test that tests north-south DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network namespaces connected to br-int using veth pairs to act as logical ports. This test does not cover multi-host scenarios, so there is a gap. But userspace OVN tests do

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jesse Gross
On Wed, Jul 13, 2016 at 7:55 AM, Jiri Benc wrote: > On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote: >> I think history tells us how this will end - similar to IPv4 options, >> implementations that don't implement TLVs will become deployed and >> then when there is a use

Re: [ovs-dev] [PATCH 4/4] system-ovn.at: Add a OVN load-balancing unit test.

2016-07-13 Thread Guru Shetty
On 12 July 2016 at 17:57, Joe Stringer wrote: > On 11 July 2016 at 23:35, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > --- > > Looks good, thanks. Only comment is if you add this file to > check-system-userspace then it should also

Re: [ovs-dev] [PATCH 3/4] system-ovn.at: Add a OVN NAT test using OVN gateway.

2016-07-13 Thread Guru Shetty
On 12 July 2016 at 17:56, Joe Stringer wrote: > On 11 July 2016 at 23:35, Gurucharan Shetty wrote: > > This unit test adds a basic OVN NAT test that tests north-south > > DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network > > namespaces connected to

Re: [ovs-dev] SFC ACL and Flow Classifier

2016-07-13 Thread Ryan Moats
"dev" wrote on 07/12/2016 09:54:46 PM: > From: Farhad Sunavala > To: "dev@openvswitch.org" > Date: 07/12/2016 09:55 PM > Subject: [ovs-dev] SFC ACL and Flow Classifier > Sent by: "dev" > > Hi

Re: [ovs-dev] [ovn-ipv6 06/26] ovn: Renumber logical field registers to the newly extended registers.

2016-07-13 Thread Zong Kai Li
>On Wed, Jul 13, 2016 at 6:19 PM, Zong Kai Li wrote: > Hi, Justin. I tried your patches one by one. P1~P5 are OK. > But something wrong seems happened to P6. > In my OpenStack integrated environment, after using P6, I cannot ping > VM dhcp netns. And later when I dump ovs

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-13 Thread Kyle Mestery
On Tue, Jul 12, 2016 at 6:17 PM, Stephen Wong wrote: > It isn't. For networking-sfc, at least for OVS driver (the default), the > MPLS label is popped before the packet reaches the VNF. > > But Russell did bring up a great solution for supporting multi-tenancy on >

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-13 Thread Kyle Mestery
On Tue, Jul 12, 2016 at 6:57 PM, Cathy Zhang wrote: > Hi Kyle/Russell, > > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Kyle Mestery > Sent: Tuesday, July 12, 2016 9:19 AM > To: Russell Bryant > Cc: dev@openvswitch.org; John

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Thomas F Herbert
On 7/13/16 10:55 AM, Jiri Benc wrote: On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote: I think history tells us how this will end - similar to IPv4 options, implementations that don't implement TLVs will become deployed and then when there is a use for them it's no longer possible.

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-13 Thread Alin Serdean
> -Mesaj original- > De la: Paul Boca > Trimis: Wednesday, July 13, 2016 11:24 AM > Către: Alin Serdean ; > dev@openvswitch.org > Subiect: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python > daemon to Windows > > Hi Alin, > > It was easier for me

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jiri Benc
On Wed, 13 Jul 2016 07:35:59 -0700, Jesse Gross wrote: > I think history tells us how this will end - similar to IPv4 options, > implementations that don't implement TLVs will become deployed and > then when there is a use for them it's no longer possible. Since I > don't want OVS to have a half

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jesse Gross
On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson wrote: > I wanted to mention though, currently the type 2 metadata (MD2) isnt a top > priority for us. It looks like its already been investigated how to use some > existing OVS TLV code to implement this, so

[ovs-dev] new catalogue

2016-07-13 Thread prt
Hi, I found the last catalogue of you favourite stuff, you can read it here My Best, p...@prt.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Architecture documents (connection manager)

2016-07-13 Thread Danushka Menikkumbura
Hi all, I am trying to understand the internals of connection manager. I need to change it a bit for my research work. Are there any documents on its architecture?. I am going through the code but its not that productive it seems just to start with. Thanks, Danushka

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: XPS (Transmit Packet Steering) implementation.

2016-07-13 Thread Ilya Maximets
Hi, Daniele. Thanks for review. On 13.07.2016 04:15, Daniele Di Proietto wrote: > Thanks for the patch. > > This is not a complete review, but I have some preliminary comments. > > If I understand correctly 'port_mutex' is converted to rwlock because > we want the pmd threads in

[ovs-dev] [PATCH v4] dpif-netdev: XPS (Transmit Packet Steering) implementation.

2016-07-13 Thread Ilya Maximets
If CPU number in pmd-cpu-mask is not divisible by the number of queues and in a few more complex situations there may be unfair distribution of TX queue-ids between PMD threads. For example, if we have 2 ports with 4 queues and 6 CPUs in pmd-cpu-mask such distribution is possible:

[ovs-dev] [PATCH v4] XPS implementation (Second part of XPS patch-set).

2016-07-13 Thread Ilya Maximets
This is the second part of XPS patch-set which contains XPS itself. Version 4: * Dropped rwlock related patches. * Added pointer from 'struct tx_port' to 'struct dp_netdev_port' to avoid locking of 'dp->ports'. This works because as long as a port is in a pmd

Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-13 Thread Lance Richardson
- Original Message - > From: "Darrell Ball" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Tuesday, July 12, 2016 7:05:18 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in > "binding 1" test case

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Brady Allen Johnson
Johnson Li, Thanks for the second version of the patch. As project lead for both the OpenDaylight SFC and the OPNFV SFC projects, I am very interested in this functionality being merged into OVS. In OPNFV SFC, we have done extensive testing with previous forked versions of the OVS NSH

Re: [ovs-dev] (no subject)

2016-07-13 Thread Gilbert Charles
Please find attached the reference letter. King regards, Gilbert Charles ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Letter

2016-07-13 Thread Lawanda Patterson
Please find attached the reference letter. King regards, Lawanda Patterson ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Scan

2016-07-13 Thread Mable Lawrence
The reference letter you requested is attached. King regards, Mable Lawrence ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Letter

2016-07-13 Thread Gina Burns
The reference letter you requested is attached. King regards, Gina Burns ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Jan Scheurich
First of all, Ericsson fully supports the initiative to provide support for NSH encapsulation in OVS. Based on earlier RFC patch sets and mailing list discussions the solution should be based on the following principles: A. Align with existing OpenFlow paradigms and OVS implementation

  1   2   >