[ovs-dev] [PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder

2016-07-25 Thread Zong Kai LI
It missed comma as constant seperator in match string for ND responder. Signed-off-by: Zong Kai LI --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index a3d1672..8e5c5c5 100644 --- a/ovn/northd/ovn-

[ovs-dev] About " openvswitch " Name

2016-07-25 Thread neil
(Please forward this to your CEO or President, because this is urgent. ) Dear President & CEO, This email is from China IPR Office, which mainly deal with trademark and domain name registration internationally. We received an application from RMZJ Industries Ltd. They want to register "open

Re: [ovs-dev] [PATCH 0/6] Remove some compat code for Linux older than 3.10

2016-07-25 Thread pravin shelar
On Thu, Jul 21, 2016 at 11:14 AM, Thadeu Lima de Souza Cascardo wrote: > The following patches remove compatibility code for Linux versions older than > Linux 3.10. > series applied. Thanks, Pravin. ___ dev mailing list dev@openvswitch.org http://openv

Re: [ovs-dev] [PATCH v2 0/7] Windows: Add support for sending Conntrack events

2016-07-25 Thread Yin Lin
Cannot find patch 6. Can you send it out again? On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > Add support for sending out Conntrack events on Windows (if subscribed). > This meant adding support for handling multiple event queues. > > v2: Address review comments and squashed the 9 s

Re: [ovs-dev] OVSDB replication related memory leak

2016-07-25 Thread Andy Zhou
On Mon, Jul 25, 2016 at 8:26 AM, William Tu wrote: > Hi, > > Valgrind reports definitely memory leak in the testcase > 1826: ovsdb-server.at:1081 insert monitored table, update excluded > table > Can someone take at look? Thank you~ > > ==52969== 144 (48 direct, 96 indirect) bytes in 1 blocks

Re: [ovs-dev] [PATCH v2 7/7] datapath-windows: Post Conntrack delete and new events

2016-07-25 Thread Yin Lin
Acked-By: Yin Lin On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > Post Conntrack delete and create events when entries are deleted or > created. > > v2: Added Acked-By > > Signed-off-by: Sairam Venugopal > Acked-by: Paul Boca > Acked-by: Alin Gabriel Serdean > --- > datapath-wind

Re: [ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for multiple event queue in Event.c

2016-07-25 Thread Yin Lin
Acked-By: Yin Lin On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > Update Event.c to have multiple event queues and mechanism to retrieve the > associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry > similar to OvsPostVportEvent and OvsRemoveVportEventEntry. > > v2: Add

Re: [ovs-dev] [PATCH v2 4/7] datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it reusable

2016-07-25 Thread Yin Lin
Acked-By: Yin Lin On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating > netlink messages from other files. Also define the function in Conntrack.h > to make it accessible. > > v2: Added Acked-By > > Signed-off-by: Sair

Re: [ovs-dev] [PATCH v2 3/7] datapath-windows: Define new multicast conntrack events and netlink protocol

2016-07-25 Thread Yin Lin
Acked-By: Yin Lin On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER > protocols for netlink communication. Define these two protocols in the > datapath. > > Define new Conntrack events (new and delete) and add support

Re: [ovs-dev] [PATCH v2 2/7] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-25 Thread Yin Lin
Acked-By: Yin Lin On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > When userspace tries to resubscribe to an existing queue, return > STATUS_INVALID_PARAMETER since it's not supported. The current bug > overwrites status to STATUS_SUCCESS. > > The second bug fix is around releasing th

Re: [ovs-dev] [PATCH v2 1/7] datapath-windows: Explicitly name vport related event to vportEvent

2016-07-25 Thread Yin Lin
Acked-By: Yin Lin On Mon, Jul 25, 2016 at 5:04 PM, Sairam Venugopal wrote: > OVS_EVENT_ENTRY currently handles only Vport related events. Updating the > name of the struct to OVS_VPORT_EVENT_ENTRY. Remove OVS_EVENT_STATUS since > it's currently not in use. Update the datapath to refer to events

Re: [ovs-dev] [PATACH]ovn: fix bug of dropping flows building in build_lrouter_flows

2016-07-25 Thread Ryan Moats
"dev" wrote on 07/25/2016 08:49:38 PM: > From: Dongjun > To: "dev@openvswitch.org" > Date: 07/25/2016 08:45 PM > Subject: [ovs-dev] [PATACH]ovn: fix bug of dropping flows building > in build_lrouter_flows > Sent by: "dev" > > In build_lrouter_flows, it says that:" Drop ip traffic to this route

[ovs-dev] dev@openvswitch.org

2016-07-25 Thread Automatic Email Delivery Software
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-25 Thread Daniele Di Proietto
Thanks for the patch. I haven't been able to apply this without the XPS patch. This looks like a perfect chance to add more tests to pmd.at. I can do it if you want I started taking a look at this patch and I have a few comments inline. I'll keep looking at it tomorrow Thanks, Daniele On

Re: [ovs-dev] [PATCH v3 2/3] util: Expose function nullable_string_is_equal.

2016-07-25 Thread Daniele Di Proietto
Nice! Applied to master, thanks On 15/07/2016 04:54, "Ilya Maximets" wrote: >Implementation of 'nullable_string_is_equal()' moved to util.c and >reused inside dpif-netdev. > >Signed-off-by: Ilya Maximets >--- > lib/dpif-netdev.c| 14 ++ > lib/util.c |

Re: [ovs-dev] [PATCH v3 1/3] bridge: Pass interface's configuration to datapath.

2016-07-25 Thread Daniele Di Proietto
Thanks for the patch It looks good to me, a few minor comments inline On 15/07/2016 04:54, "Ilya Maximets" wrote: >This commit adds functionality to pass value of 'other_config' column >of 'Interface' table to datapath. > >This may be used to pass not directly connected with netdev options and

[ovs-dev] [PATACH]ovn: fix bug of dropping flows building in build_lrouter_flows

2016-07-25 Thread Dongjun
In build_lrouter_flows, it says that:" Drop ip traffic to this router, unless the router ip is used as SNAT ip. " But there is a bug, the "continue" only effect the inner loop, dropping flows is still built. Example: Dropping flow c8726aed-0dd0-41b6-bb8c-13ca1e2164c9 should not be exist for "c

[ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-25 Thread Pravin B Shelar
Most of patch iron out USE_UPSTREAM_TUNNEL case where datapath directly use upstream tunneling modules. Signed-off-by: Pravin B Shelar --- acinclude.m4 | 7 +++--- datapath/linux/compat/geneve.c | 4 ++-- datapath/linux/compat/include/linux

[ovs-dev] [PATCH 1/2] rhel: Fix ifup-ovs to delete ports first.

2016-07-25 Thread Flavio Leitner
When ifdown isn't executed (system didn't shut down properly), ports remain in the openvswitch's database. In that case, an inconsitency is left behind when the ifcfg was modified because ovs-vsctl won't do anything to update existing port's configuration in the database. The ifup/ifdown will ope

[ovs-dev] [PATCH 2/2] rhel: Allow openvswitch to get parent information

2016-07-25 Thread Flavio Leitner
Updates SELinux to allow ovs-vsctl to get parent process information and log that to the database: record 241: 2016-07-26 00:59:47.418 "ovs-vsctl (invoked by /bin/bash (pid 1589)): ovs-vsctl -t 10 -- --if-exist ... Jul 25 12:57:35 localhost.localdomain audit[830]: AVC avc: denied { search } for

[ovs-dev] [PATCH 0/2] rhel: Fix ifup-ovs to delete ports first

2016-07-25 Thread Flavio Leitner
The configuration is stored on ifcfg files, so it makes sense to start fresh every time, but that uncovers a SELinux issue where ovs-vsctl fails to get parent information. The first patch fixes the config issue. The second patch fixes the SELinux issue. Thanks, Flavio Leitner (2): rhel: Fix i

[ovs-dev] [PATCH 3/3] datapath: compat: simplify ip_local_out().

2016-07-25 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 8368c6a..de9c8e1 100644 --- a/datapath/linux/compat/gso.c +++ b/datapath/linux/compat/

[ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-25 Thread Pravin B Shelar
OVS compat layer can handle tunnel GSO packets. but it does keep skb encapsulation on for packet handled in GSO. This can confuse some NIC drivers. I have seen this issue on intel devices: i40e :42:00.0: TX driver issue detected, PF reset issued Following patch resets this bit in case compa

[ovs-dev] [PATCH 0/3] datapath: tunneling fixes.

2016-07-25 Thread Pravin B Shelar
First two patches fixes to issues related to geneva and vxlan tunnel. Third patch is just code improvement. Pravin B Shelar (3): datapath: compat: fix udp checksum calculation datapath: compat: unset skb encapsulation bit datapath: compat: simplify ip_local_out(). datapath/linux/compat/gso

[ovs-dev] [PATCH 1/3] datapath: compat: fix udp checksum calculation

2016-07-25 Thread Pravin B Shelar
In upstream linux kernel networking stack udp_set_csum() is called with only udp header applied but in case of compat layer it can be called with IP header. So following patch take the offset into account. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/udp.c | 3 ++- 1 file changed, 2

Re: [ovs-dev] [PATCH] rhel/openvswitch.spec: Add SELinux policy.

2016-07-25 Thread Flavio Leitner
On Mon, Jul 25, 2016 at 02:09:26PM -0700, Joe Stringer wrote: > Commit 9b897c9125ef ("rhel: provide our own SELinux custom policy > package") added the SELinux policy to the fedora packaging as a > subpackage. This patch makes the corresponding change to > openvswitch.spec, so that users of that sp

[ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers. Signed-off-

[ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
This patch removes the json extension build system changes since they aren't even related to the serialization change, which is pure-Python. Terry Wilson (1): JSON serialization via Python's json lib python/ovs/json.py | 106 + tests/json.at

[ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for multiple event queue in Event.c

2016-07-25 Thread Sairam Venugopal
Update Event.c to have multiple event queues and mechanism to retrieve the associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry similar to OvsPostVportEvent and OvsRemoveVportEventEntry. v2: Added Acked-By Signed-off-by: Sairam Venugopal Acked-by: Paul Boca Acked-by: Alin Gabrie

[ovs-dev] [PATCH v2 3/7] datapath-windows: Define new multicast conntrack events and netlink protocol

2016-07-25 Thread Sairam Venugopal
The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER protocols for netlink communication. Define these two protocols in the datapath. Define new Conntrack events (new and delete) and add support for subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and store it as part of

[ovs-dev] [PATCH v2 7/7] datapath-windows: Post Conntrack delete and new events

2016-07-25 Thread Sairam Venugopal
Post Conntrack delete and create events when entries are deleted or created. v2: Added Acked-By Signed-off-by: Sairam Venugopal Acked-by: Paul Boca Acked-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Conntrack.c | 12 1 file changed, 12 insertions(+) diff --git a/datapath

[ovs-dev] [PATCH v2 4/7] datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it reusable

2016-07-25 Thread Sairam Venugopal
Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating netlink messages from other files. Also define the function in Conntrack.h to make it accessible. v2: Added Acked-By Signed-off-by: Sairam Venugopal Acked-By: Yin Lin Acked-by: Alin Gabriel Serdean --- datapath-windows/ovse

[ovs-dev] [PATCH v2 1/7] datapath-windows: Explicitly name vport related event to vportEvent

2016-07-25 Thread Sairam Venugopal
OVS_EVENT_ENTRY currently handles only Vport related events. Updating the name of the struct to OVS_VPORT_EVENT_ENTRY. Remove OVS_EVENT_STATUS since it's currently not in use. Update the datapath to refer to events as vportEvents. This will aid in the introduction of other events. v2: Squash 1/9 a

[ovs-dev] [PATCH v2 0/7] Windows: Add support for sending Conntrack events

2016-07-25 Thread Sairam Venugopal
Add support for sending out Conntrack events on Windows (if subscribed). This meant adding support for handling multiple event queues. v2: Address review comments and squashed the 9 series patch to 7. The following gives an overview of the design: 1. Currently we only support subscribing/unsubsc

[ovs-dev] [PATCH v2 6/7] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

2016-07-25 Thread Sairam Venugopal
OvsReadEventCmdHandler must now reflect the right event being read. If the event is a Conntrack related event, then convert the entry to netlink format and send it to userspace. If it's Vport event, retain the existing workflow. v2: Address review comments from Alin Serdean (Not default values to

[ovs-dev] [PATCH v2 2/7] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-25 Thread Sairam Venugopal
When userspace tries to resubscribe to an existing queue, return STATUS_INVALID_PARAMETER since it's not supported. The current bug overwrites status to STATUS_SUCCESS. The second bug fix is around releasing the EventQueue lock if an open instance couldn't be found. The current version returns bac

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-25 Thread Flavio Leitner
On Mon, Jul 25, 2016 at 06:22:59PM +, Daniele Di Proietto wrote: > Fair point, I guess this looks more like a bug fix than a new features. > > After discussing offline with Ben and having another set of eyes on > the changes I backported this to branch-2.5. Thanks guys! fbl > > Thanks, >

Re: [ovs-dev] [PATCH] selinux: Allow ovs-ctl force-reload-kmod.

2016-07-25 Thread Flavio Leitner
On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrote: > When invoking ovs-ctl force-reload-kmod via '/etc/init.d/openvswitch > force-reload-kmod', spurious errors would output related to 'hostname' > and 'ip', and the system's selinux audit log would complain about some > of the invocations

Re: [ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
Sigh. And of course I had libopenvswitch installed on the system as well and removing it breaks building the extensions with the above patch. This is the kind of thing that would be much easier if the Python lib was its own project with its own test suite and it could just always assume libopenvswi

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Set pmd thread priority

2016-07-25 Thread Daniele Di Proietto
I agree with Mark's comments, other than that this looks good to me. If you agree with the comments would you mind sending an updates version? Thanks, Daniele 2016-07-19 7:04 GMT-07:00 Kavanagh, Mark B : > > > > Hi Bhanu, > > Thanks for the patch - some comments inline. > > Cheers, > Mark > >

Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD

2016-07-25 Thread Daniele Di Proietto
Thanks for the patch This needs a little bit of rebasing, I did it myself to review, but it'd be nice to have an updated version. I like the simplification that this brings especially to the fast path. If we merge this before we merge the DPDK 16.07 we won't have to deal with the vid change. Th

Re: [ovs-dev] [PATCH 2/4] netdev-dpdk: Consistent naming for vhost functions

2016-07-25 Thread Daniele Di Proietto
Looks like every caller of NETDEV_DPDK_CLASS() passes NULL as INIT param. Maybe we can remove that? Acked-by: Daniele Di Proietto 2016-07-15 7:26 GMT-07:00 Ciara Loftus : > A mix of vhost_user_ and vhost_ is used when naming vhost functions. The > 'user_' has been dropped for consistency. Also

Re: [ovs-dev] [PATCH 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-25 Thread Daniele Di Proietto
Acked-by: Daniele Di Proietto 2016-07-15 7:26 GMT-07:00 Ciara Loftus : > This commit removes the 'dpdkvhostcuse' port type from the userspace > datapath. vhost-cuse ports are quickly becoming obsolete as the > vhost-user port type begins to support a greater feature-set thanks to > the addition

Re: [ovs-dev] [PATCH 8/9] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

2016-07-25 Thread Sairam Venugopal
Will address this in v2. Thanks, Sairam On 7/22/16, 6:20 PM, "Alin Serdean" wrote: >Just one comment inlined. > > > >> -Mesaj original- > >> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > >> Venugopal > >> Trimis: Thursday, July 14, 2016 2:39 AM > >> Către: dev@openv

Re: [ovs-dev] [PATCH] Windows: daemon-windows lockfile

2016-07-25 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 7/25/16, 2:58 PM, "Alin Serdean" wrote: >_get_osfhandle returns an errno value not a GetLastErrorValue. >(https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_e >n-2Dus_library_ks2530z6-28v-3Dvs.120-29.aspx&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67L >KIiDJ

Re: [ovs-dev] [PATCH] move ovn/lib/.h to include/ovn

2016-07-25 Thread Aaron Rosen
FYI: this patch is rebased on top of (patch below) which is not yet merged into ovs. commit ee61acf6202c6575033ea050b63271af49936da5 Author: Terry Wilson Date: Fri Jul 22 21:57:20 2016 -0500 JSON serialization via Python's json lib There is no particularly good reason to use our own P

Re: [ovs-dev] [PATCH v4] ovn: expose c validator to python

2016-07-25 Thread Aaron Rosen
Note: this patch is rebased on top of : [PATCH] move ovn/lib/.h to include/ovn On Mon, Jul 25, 2016 at 3:07 PM, Aaron Rosen wrote: > This patch exposes the c function expr_parse_string() to be called via > python. The motivation for this is so that clients interfacing with > ovn can call this m

Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls

2016-07-25 Thread Nirapada Ghosh
Ryan Moats/Omaha/IBM wrote on 07/25/2016 01:44:44 PM: > From: Ryan Moats/Omaha/IBM > To: Nirapada Ghosh/San Jose/IBM@IBMUS > Cc: "Ben Pfaff" , dev@openvswitch.org > Date: 07/25/2016 01:44 PM > Subject: Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls > > Nirapada Ghosh/San J

[ovs-dev] [PATCH v4] ovn: expose c validator to python

2016-07-25 Thread Aaron Rosen
This patch exposes the c function expr_parse_string() to be called via python. The motivation for this is so that clients interfacing with ovn can call this method in order to validate the data they are writting to ovn. Previously, there were several bugs in the neutron/ovn integration that went u

[ovs-dev] [PATCH] move ovn/lib/.h to include/ovn

2016-07-25 Thread Aaron Rosen
This patch is done to enable in tree building of the ovn-utils python wrapper. This is similar to what was done in: ee89ea7b477bb4fd05137de03b2e8443807ed9f4 Signed-off-by: Aaron Rosen --- include/automake.mk | 1 + include/ovn/actions.h | 141 include/ovn/aut

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-25 Thread Yin Lin
Hi Sai, After looking at your follow up patches, I feel it's better to rename OVS_MCAST_EVENT_ENTRIES as OVS_MCAST_EVENT_TYPE, and rename OVS_MCAST_EVENT_ENTRIES_MAX as OVS_MCAST_EVENT_TYPES_MAX. At first glance, event_entries_max seems to suggest the maximum number of events in a queue, which is

[ovs-dev] [PATCH] Windows: daemon-windows lockfile

2016-07-25 Thread Alin Serdean
_get_osfhandle returns an errno value not a GetLastErrorValue. (https://msdn.microsoft.com/en-us/library/ks2530z6(v=vs.120).aspx) Signed-off-by: Alin Gabriel Serdean --- lib/daemon-windows.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/daemon-windows.c b/lib/daemon-win

Re: [ovs-dev] [PATCH 7/9] datapath-windows: Add support for multiple event queue in Event.c

2016-07-25 Thread Alin Serdean
Thanks a lot for the info. It would be nice to have it in the initial cover letter just to know the broader idea about the intent :). From the code I could see the direction you want to go with it, but I wanted some confirmation. Acked-by: Alin Gabriel Serdean > -Mesaj original- > De l

[ovs-dev] [PATCH] rhel/openvswitch.spec: Add SELinux policy.

2016-07-25 Thread Joe Stringer
Commit 9b897c9125ef ("rhel: provide our own SELinux custom policy package") added the SELinux policy to the fedora packaging as a subpackage. This patch makes the corresponding change to openvswitch.spec, so that users of that specfile can generate the selinux policy package without having to build

Re: [ovs-dev] [ovs-dev,ovn-controller] Physical: persist tunnels

2016-07-25 Thread Flavio Fernandes
> On Jul 25, 2016, at 12:28 PM, Ryan Moats wrote: > > While commit ab39371d68842b7e4000cc5d8718e6fc04e92795 > (ovn-controller: Handle physical changes correctly) addressed > unit test failures, it did so at the cost of performance: [1] > notes that ovn-controller cpu usage is now pegged at 100%.

Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls

2016-07-25 Thread Ryan Moats
Nirapada Ghosh/San Jose/IBM wrote on 07/25/2016 03:32:29 PM: > From: Nirapada Ghosh/San Jose/IBM > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: "Ben Pfaff" , dev@openvswitch.org > Date: 07/25/2016 03:32 PM > Subject: Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls > > Hi Ryan, > > Th

Re: [ovs-dev] [PATCH 7/9] datapath-windows: Add support for multiple event queue in Event.c

2016-07-25 Thread Sairam Venugopal
I added the padding to keep the sizeof(OVS_CT_EVENT_ENTRY) == sizeof(OVS_VPORT_EVENT_ENTRY) I should have sent this as part of Patch 0. This is the general idea: 1. Currently we only support subscribing/unsubscribing to Vport related events. Even for VPORT, we only care about the VPORT-Down even

Re: [ovs-dev] [PATACH]netdev-dpdk: remove duplicated code in netdev_dpdk_get_status

2016-07-25 Thread Daniele Di Proietto
Thanks for the patch! I had to manually unwrap some long lines. Could you maybe use git send-email next time? Anyway, I added you to AUTHORS and applied this to master Thanks, Daniele 2016-07-25 1:37 GMT-07:00 : > From caeb84217c38ccd0b2076689fd36b578c00678ad Mon Sep 17 00:00:00 2001 > From:

Re: [ovs-dev] [PATCH] netdev-dpdk: Apply batch truncation API.

2016-07-25 Thread Daniele Di Proietto
Applied to master, thanks 2016-07-25 8:14 GMT-07:00 William Tu : > Instead of looping into each packet and check whether to truncate, the > patch moves it out of the loop and uses batch API. If truncation is > not set, checking 'trunc' in 'struct dp_packet_batch' at per-batch basis > can skip th

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-25 Thread Vinod, Chegu
Thanks Daniele ! Vinod -Original Message- From: Daniele Di Proietto [mailto:diproiet...@vmware.com] Sent: Monday, July 25, 2016 11:23 AM To: Loftus, Ciara ; Vinod, Chegu ; Flavio Leitner Cc: kris...@redhat.com; ovs-dev ; Phillips, John ; Ben Pfaff Subject: Re: Backport Request: dpif-

Re: [ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-25 Thread Numan Siddique
On Mon, Jul 25, 2016 at 10:10 PM, Russell Bryant wrote: > > On Thu, Jul 21, 2016 at 6:21 AM, Numan Siddique > wrote: > >> When python IDL calls the "notify" function after processing the "update2" >> message from ovsdb-server, it is suppose to send the old values of the >> updated columns as the

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-25 Thread Daniele Di Proietto
Fair point, I guess this looks more like a bug fix than a new features. After discussing offline with Ben and having another set of eyes on the changes I backported this to branch-2.5. Thanks, Daniele On 25/07/2016 02:29, "Loftus, Ciara" wrote: >> >> Thanks Flavio for checking and Daniel f

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-25 Thread Sairam Venugopal
I will update the current one and make a note to update VPORT usage as well. On 7/22/16, 5:59 PM, "Alin Serdean" wrote: >It looks like a mistake was done when setting them up, don't know if it >such a good idea to propagate it. > >Thanks, >Alin. > >> -Mesaj original- >> De la: Sairam Ven

[ovs-dev] [PATCH v2 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-25 Thread Aaron Conole
Currently, openvswitch.service calls out to start openvswitch-nonetwork.service. However, openvswitch-nonetwork.service will be called ovsdb-server, so that it is a bit more reflective of the dependencies. This commit does make the file a bit of a misnomer as currently the ovsdb-server SERVICE wi

[ovs-dev] [PATCH v2 0/3] redhat: Improve the systemd integration

2016-07-25 Thread Aaron Conole
These patches make adjustments to the way systemd is done so that we have: * one daemon started per service * services which correspond to actual daemon names * a single 'dummy' service to start all at once * some convenient information to poll from systemd. These have been tested on Fedora 23 an

[ovs-dev] [PATCH v2 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-25 Thread Aaron Conole
This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras Acked-by: Ben Pfaff Acked-by: Flavio Fernandes

[ovs-dev] [PATCH v2 3/3] rhel: Improved Systemd Integration

2016-07-25 Thread Aaron Conole
This commit builds upon some of the recent ovs-ctl changes to build a more integrated systemd setup. A new service (ovs-vswitchd) is added to track the ovs-vswitchd, and ovsdb-server service is reserved for the ovsdb-server daemon. The systemd scripts still use ovs-ctl to actually initialize the

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

2016-07-25 Thread Daniele Di Proietto
2016-07-25 9:57 GMT-07:00 Thadeu Lima de Souza Cascardo : > On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote: > > I would prefer if dpctl kept using the datapath types. The translation > > from database types to datapath type should happen in ofproto, dpctl is > > supposed to b

[ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers. Signed-off-

[ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
I noticed that with the previous patch, in testing 'make install' with patch to move json.h, I had forgotten to remove the installed headers. Removing the installed headers revealed that this patch still didn't build properly from a separate build directory. This time it *should* work. Terry Wilso

Re: [ovs-dev] [RFC 0/5] netdev_open conflicting types

2016-07-25 Thread Thadeu Lima de Souza Cascardo
On Fri, Jul 22, 2016 at 01:10:33PM -0700, Ben Pfaff wrote: > On Mon, Jul 18, 2016 at 02:00:20PM -0300, Thadeu Lima de Souza Cascardo wrote: > > This series is a proposal to fix some users of netdev_open and > > introduce a new behavior for netdev_open when called with a different > > type than the

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-25 Thread Daniele Di Proietto
On 25/07/2016 09:16, "Ben Pfaff" wrote: >On Mon, Jul 25, 2016 at 03:44:01PM +, Gray, Mark D wrote: >> >> >> > -Original Message- >> > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff >> > Sent: Saturday, July 23, 2016 5:00 PM >> > To: dev@openvswitch.org >>

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

2016-07-25 Thread Thadeu Lima de Souza Cascardo
On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote: > I would prefer if dpctl kept using the datapath types. The translation > from database types to datapath type should happen in ofproto, dpctl is > supposed to be used to interact with the datapath directly. > > What do you guy

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-25 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: > Flow key handleing changes: > - Add VLAN header array in struct flow, to record multiple 802.1q VLAN > headers. > - Add dpif multi-VLAN capability probing. If datapath supports multi-VLAN, > increase the maximum depth of nested OVS_K

Re: [ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-25 Thread Russell Bryant
On Thu, Jul 21, 2016 at 6:21 AM, Numan Siddique wrote: > When python IDL calls the "notify" function after processing the "update2" > message from ovsdb-server, it is suppose to send the old values of the > updated columns as the last parameter. But the recent commit "897c8064" > sends the update

Re: [ovs-dev] [PATCH] rhel: Fix ifup-ovs to delete bonds first.

2016-07-25 Thread Flavio Leitner
On Mon, Jul 25, 2016 at 01:08:01PM -0300, Flavio Leitner wrote: > When ifdown isn't executed (system didn't shut down properly), > bond interfaces remain in the openvswitch's database. In that > case, an inconsitency is left behind when the ifcfg was modified > because ovs-vsctl won't do anything

[ovs-dev] [PATCH ovn-controller] Physical: persist tunnels

2016-07-25 Thread Ryan Moats
While commit ab39371d68842b7e4000cc5d8718e6fc04e92795 (ovn-controller: Handle physical changes correctly) addressed unit test failures, it did so at the cost of performance: [1] notes that ovn-controller cpu usage is now pegged at 100%. Root cause of this is that while the storage for tunnels is p

[ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

2016-07-25 Thread nickcooper-zhangtonghao
If the logical router ports without 'peer' or the port named peer is not created, it is unnecessary to insert the ports into the southbound Port_Binding table. Similarly, if logical switch ports of type 'router' don't contain 'router-port' value, these ports will not be inserted. This patch may o

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-25 Thread Gray, Mark D
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Monday, July 25, 2016 5:15 PM > To: Gray, Mark D > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] release-process.md: Document OVS release > process and propose a schedule. > > On Mon, Jul 25, 2016 at 03:45:2

Re: [ovs-dev] How can i modify Flow table in Openvswitch??

2016-07-25 Thread Ben Pfaff
On Mon, Jul 25, 2016 at 05:26:32PM +0900, Nam Bong Ha wrote: > i want to modify Flow table in Openvswitch. > > i know that there are two types of Flow table. > (ex. hash-based flow table, wildcard-aware flow table) > > i want to change the Matching filed in Flow table > (ex. existing Matching fil

[ovs-dev] [PATCH] ovn-northd: Only peer router ports to other router ports.

2016-07-25 Thread nickcooper-zhangtonghao
Deletion of a logical router port, which may be an other router peer, result in a WARN, because the "ports" variable still contains the logical port deleted. This port exists but should not have been initialized fully. nbsp == NULL, nbrp == NULL It is necessary to check 'nbsp'. A router port's "

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-25 Thread Ben Pfaff
On Mon, Jul 25, 2016 at 03:44:01PM +, Gray, Mark D wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > > Sent: Saturday, July 23, 2016 5:00 PM > > To: dev@openvswitch.org > > Subject: [ovs-dev] releasing 2.6: branch Aug 1, rele

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-25 Thread Ben Pfaff
On Mon, Jul 25, 2016 at 03:45:25PM +, Gray, Mark D wrote: > > +Open vSwitch makes releases at the following six-month cadence, which > > +of course is subject to change. > > + > > +time > > +(months) approx datesevent > > + - -

[ovs-dev] [PATCH] rhel: Fix ifup-ovs to delete bonds first.

2016-07-25 Thread Flavio Leitner
When ifdown isn't executed (system didn't shut down properly), bond interfaces remain in the openvswitch's database. In that case, an inconsitency is left behind when the ifcfg was modified because ovs-vsctl won't do anything to update existing bond's configuration in the database. The ifup/ifdow

Re: [ovs-dev] [PATCH v3] Windows: Local named pipe implementation

2016-07-25 Thread Paul Boca
Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Monday, July 25, 2016 5:29 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v3] Windows: Local named pipe implementation > > Currently in the case of comman

Re: [ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

2016-07-25 Thread Ryan Moats
Ryan Moats/Omaha/IBM@IBMUS wrote on 07/24/2016 02:33:19 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: dev@openvswitch.org > Cc: Ryan Moats/Omaha/IBM@IBMUS > Date: 07/24/2016 02:33 PM > Subject: [PATCH] ovn-controller: Add incremental processing for > multicast groups > > The various fixes in handli

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-25 Thread Gray, Mark D
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Saturday, July 23, 2016 5:00 PM > To: dev@openvswitch.org > Subject: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15 > > The proposed Open vSwitch release schedule calls for branchi

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-25 Thread Gray, Mark D
> +Open vSwitch makes releases at the following six-month cadence, which > +of course is subject to change. > + > +time > +(months) approx datesevent > + - - > +T Apr 1 Oct 1release cycle for version x.y begins > +T +

[ovs-dev] OVSDB replication related memory leak

2016-07-25 Thread William Tu
Hi, Valgrind reports definitely memory leak in the testcase 1826: ovsdb-server.at:1081 insert monitored table, update excluded table Can someone take at look? Thank you~ ==52969== 144 (48 direct, 96 indirect) bytes in 1 blocks are definitely lost in loss record 306 of 373 ==52969==at 0x4C

[ovs-dev] (no subject)

2016-07-25 Thread Abdalla, Maisa
Kontaktieren Sie uns: jessmaar...@outlook.com Wir bieten Darlehen zu einem Zinssatz von 2 % jährlich. Unser Darlehen ist erschwinglich und stressfrei. Kredit für alle Zwecke. Kontaktieren Sie uns: jessmaar...@outlook.com Vielen Dank == Contact us:

[ovs-dev] [PATCH] netdev-dpdk: Apply batch truncation API.

2016-07-25 Thread William Tu
Instead of looping into each packet and check whether to truncate, the patch moves it out of the loop and uses batch API. If truncation is not set, checking 'trunc' in 'struct dp_packet_batch' at per-batch basis can skip the per-packet checking overhead. Signed-off-by: William Tu --- lib/netdev

Re: [ovs-dev] [PATCH] [PATCH v1] ovs-dev: add set type for ovs.idl.data.Datum.from_python

2016-07-25 Thread Russell Bryant
On Thu, Jul 21, 2016 at 2:17 AM, Zong Kai LI wrote: > ovs.db.idl.Datum.from_python fails to handle set type value, while set > type is also a common iterable sequence, just like list and tuple. > No reason IDL caller must to turn set type parameters to list or tuple > type. Otherwise, they will f

Re: [ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-25 Thread Aaron Conole
Flaviof writes: > On Wed, Jul 20, 2016 at 4:21 PM, Aaron Conole wrote: > > This commit allows the ovs-ctl command to spawn daemons without the > internal process monitor. This is useful when integrating with, > ex. systemd, which provides its own monitoring facilities. > > Signed-off-by: Aa

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak reported by valgrind.

2016-07-25 Thread William Tu
Looks good to me, thanks for fixing it! Acked-by: William Tu On Mon, Jul 25, 2016 at 1:00 AM, Liran Schour wrote: > Destroy shash on destroy of session's condition structure. > Reported here: http://openvswitch.org/pipermail/dev/2016-July/075968.html > > Signed-off-by: Liran Schour > --- > ov

Re: [ovs-dev] [PATCH V9] windows: Added lockf function and lock PID file

2016-07-25 Thread Guru Shetty
On 25 July 2016 at 05:50, Paul Boca wrote: > If the PID file isn't locked then appctl.py detects it as stale and > bails out without doing anything. Because of this lots of Python tests > fail. > Also this protects the PID file from being overwritten. > > I used only shared lock, in order to be c

Re: [ovs-dev] [PATCH] [PATCH v1] ovs python: add set type forfrom_python

2016-07-25 Thread Richard Theis
"dev" wrote on 07/25/2016 07:58:03 AM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Zong Kai LI > Cc: dev@openvswitch.org > Date: 07/25/2016 07:58 AM > Subject: Re: [ovs-dev] [PATCH] [PATCH v1] ovs python: add set type > forfrom_python > Sent by: "dev" > > "dev" wrote on 07/19/2016 03:59:39 AM:

Re: [ovs-dev] [PATCH] ovn-controller: Handle physical changes correctly

2016-07-25 Thread Ryan Moats
Liran Schour/Haifa/IBM wrote on 07/25/2016 02:44:42 AM: > From: Liran Schour/Haifa/IBM > To: Ryan Moats > Cc: dev@openvswitch.org > Date: 07/25/2016 02:44 AM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Handle physical > changes correctly > > > From: Ryan Moats > > To: dev@openvswitch.org >

Re: [ovs-dev] [PATCH] [PATCH v1] ovs python: add set type forfrom_python

2016-07-25 Thread Ryan Moats
"dev" wrote on 07/19/2016 03:59:39 AM: > From: Zong Kai LI > To: dev@openvswitch.org > Date: 07/19/2016 04:03 AM > Subject: [ovs-dev] [PATCH] [PATCH v1] ovs python: add set type for from_python > Sent by: "dev" > > In method from_python, when parameter 'value' is in list type or tuple > type, i

[ovs-dev] [PATCH V9] windows: Added lockf function and lock PID file

2016-07-25 Thread Paul Boca
If the PID file isn't locked then appctl.py detects it as stale and bails out without doing anything. Because of this lots of Python tests fail. Also this protects the PID file from being overwritten. I used only shared lock, in order to be compatible with Python tests, which try to acquire the lo

Re: [ovs-dev] (no subject)

2016-07-25 Thread Tyrell May
Deep apology for my late reply Upon your request, Company credit account is attached to this email. *** Yours faithfully, Tyrell May BT GROUP Phone: +1 (212) 440-04-39 ID: c75b4ef42e75851be9dff87a0756a20644d77deed57f ___ dev mailing list dev@openvswit

  1   2   >