Re: [ovs-dev] FW: OpenVSwitch Ext 112 Git Repository

2016-06-03 Thread Jean Tourrilhes
Vasundhara G wrote: > > Well, I was thinking about the big picture behind this > implementation, have searched a lot on internet but could not sum up > my findings. My implementation was just testing the OpenFlow feature EXT-112 is correct, nothing more, nothing less. It just tests that y

Re: [ovs-dev] OpenVSwitch Ext 112 Git Repository

2016-05-09 Thread Jean Tourrilhes
On Mon, May 09, 2016 at 10:23:17AM +0530, Vasundhara G wrote: > Hi Jean, > > I am interested in developing Ext 112 'Packet Type Aware Pipeline' > in Open VSwitch and have come across your code in GitHub. Oh, that's great. First, please be aware that Niti Rohilla recently was also

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Jean Tourrilhes
On Fri, Feb 26, 2016 at 12:38:05PM -0800, Ben Pfaff wrote: > > I had to look up EXT-427 to find out what we're talking about. EXT-427 > extends OFPT_PACKET_OUT in OF1.5 to allow the controller to specify the > values of arbitrary metadata fields. Yes, this would be valuable and > I'd be happy to

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Jean Tourrilhes
On Fri, Feb 26, 2016 at 09:05:41AM -0800, Jean Tourrilhes wrote: > > Yes, it's at : > https://github.com/jean2/openvswitch/commits/jean/ext-112 I forgot, I did also integrate with Lori's code : https://github.com/jean2/openvswitch/c

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Jean Tourrilhes
On Fri, Feb 26, 2016 at 02:50:37PM +0530, niti Rohilla wrote: > Thanks for the information Lori. > > Hi Jean, > > I am planning to implement and contribute the "Packet Type aware pipeline > [EXT-112]" to OpenVSwitch. That's great ! I can only encourage you ! > I got to know that you hav

Re: [ovs-dev] [PATCH v8] Implement OFPT_TABLE_STATUS Message.

2016-01-15 Thread Jean Tourrilhes
Saloni Jain wrote : > > If current vacancy is same as remaining space(free space), the two > statements of the specifications are contradictory. Why and how ? I prototyped the spec and I saw no trouble with those statements : https://github.com/jean2/ofsoftswitch13/commits/jean/ex

Re: [ovs-dev] Query regarding OF1.5 Egress tables (EXT-306)

2015-08-19 Thread Jean Tourrilhes
On Wed, Aug 19, 2015 at 01:18:37PM +0530, niti Rohilla wrote: > Thanks Jean. > > >Capabilities are not modified by the ofp_table_mod messages, > >either the implementation is capable, or it is not, and this does not > >dynamically change. Don't confuse with the 'config' field in > >ofp_table_desc

Re: [ovs-dev] Query regarding OF1.5 Egress tables (EXT-306)

2015-08-18 Thread Jean Tourrilhes
On Tue, Aug 18, 2015 at 05:40:34PM +0530, niti Rohilla wrote: > Hi Jean, > > Thanks for your reply. Based on your reply please validate our > understanding. > > 1. From all the commands only OFPTFC_MODIFY needs to be implemented and > only for a single table in a request. This command is used to

Re: [ovs-dev] Query regarding OF1.5 Egress tables (EXT-306)

2015-08-17 Thread Jean Tourrilhes
niti Rohilla wrote : > > 2) Page no. 145 of Openflow Specification 1.5.1. > The command OFPTFC_REPLACE configures the entire pipeline, and the set of > flow tables in the pipeline must match the set in the request, or an error > must be returned (see 7.5.4.14). The capability of all flow tables in

Re: [ovs-dev] OFPMT_TABLE_FEATURES is supported in OVS or not

2015-03-11 Thread Jean Tourrilhes
tech_kals Kals wrote : > > Switch can maintain any number of flow tables. But, the controller will > come to know about it only through "OFPMT_TABLE_FEATURES". That's incorrect. Currently, the main method for hardware switches is to use an out-of-band mechanism. If you look at any

Re: [ovs-dev] Hybrid VLAN capability

2015-03-09 Thread Jean Tourrilhes
On Mon, Mar 09, 2015 at 07:54:09AM +, Ken Ajiro wrote: > > > For implementing it if I use Egress Tables, > I understand that I should use following table. > Is my understanding correct? > > First egress == 200 Egress Tables is currently not implemented in OVS. Once Egress Tabl

Re: [ovs-dev] Hybrid VLAN capability

2015-03-06 Thread Jean Tourrilhes
On Fri, Mar 06, 2015 at 10:27:22AM -0800, Ben Pfaff wrote: > > Another possibility is to use the "conjunctive match" feature in > (upcoming) OVS 2.4. With this feature, you can effectively construct > flows that say, > >(in_port in {set_A}) and (vlan_id in {set_B}),actions=... > > by adding

Re: [ovs-dev] Hybrid VLAN capability

2015-03-06 Thread Jean Tourrilhes
Ken Ajiro wrote : > > To isolate the L2 domain equivalent to VLAN, > I think that following flow entries will be needed. > > in_port=1,vlan_id=100,actions=output:2,output:7,output:8 > in_port=1,vlan_id=110,actions=output:2,output:7,output:8 > in_port=1,vlan_id=120,actions=output:2,output:7,ou

Re: [ovs-dev] [PATCH] OpenFlow 1.5 is final, so change OF1.5 draft references to just say OF1.5.

2015-02-25 Thread Jean Tourrilhes
On Wed, Feb 25, 2015 at 11:43:58AM -0800, Ben Pfaff wrote: > On Wed, Feb 25, 2015 at 09:36:12AM -0800, Jean Tourrilhes wrote: > > On Tue, Feb 24, 2015 at 09:02:50PM -0800, Ben Pfaff wrote: > > > Reported-by: Jean Tourrilhes > > > Signed-off-by: Ben Pfaff > > &

Re: [ovs-dev] [PATCH] OpenFlow 1.5 is final, so change OF1.5 draft references to just say OF1.5.

2015-02-25 Thread Jean Tourrilhes
On Tue, Feb 24, 2015 at 09:02:50PM -0800, Ben Pfaff wrote: > Reported-by: Jean Tourrilhes > Signed-off-by: Ben Pfaff Signed-off-by: Jean Tourrilhes Regards, Jean ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [PATCH 3/3] EXT-233: Test that actset_output tracks changes to the action-set.

2014-11-03 Thread Jean Tourrilhes
On Mon, Nov 03, 2014 at 05:14:05PM -0800, Ben Pfaff wrote: > From: Jean Tourrilhes > > Signed-off-by: Jean Tourrilhes Actually, you don't need this testcase if you modify your own testcase as such : https://github.com/jean2/openvswitch/commit/efdcb83abcaccf8d78be14d79f

Re: [ovs-dev] [PATCH] tests: Add another test for extended registers.

2014-07-29 Thread Jean Tourrilhes
Hi, Unfortunately, I don't really have time to test the code, but from here it looks good and make sense. Have fun... Jean Acked-by: Jean Tourrilhes On Tue, Jul 29, 2014 at 09:27:23AM -0700, Ben Pfaff wrote: > ONF-JIRA: EXT-244 > Suggested-by: Jean

Re: [ovs-dev] ovs - rate limiter proposal - question

2014-07-16 Thread Jean Tourrilhes
On Wed, Jul 16, 2014 at 01:00:44PM +0200, Attila Czébán wrote: > Dear Jean, > > I read the following documentation about the rate limiter API. > http://openvswitch.org/pipermail/dev/2011-January/005639.html > I have some questions about it. > > We have an SDN testbed at Budapest University of Tec

Re: [ovs-dev] [PATCH] meta-flow: Use correct OF1.2+ errors for invalid fields in actions.

2013-08-22 Thread Jean Tourrilhes
r the register operations. It feels like some of the set-field operations may benefit from even more detailed error reporting, but that's beyond standard OpenFlow... > Reported-by: Jean Tourrilhes > Signed-off-by: Ben Pfaff All errors seems appropriate. Acked-by: Jean Tou

Re: [ovs-dev] [PATCH] nicira-ext: Correct and improve nx_flow_update_abbrev comment.

2012-10-11 Thread Jean Tourrilhes
> to normal, unabbreviated notifications, so say that explicitly. > > Reported-by: Jean Tourrilhes > Signed-off-by: Ben Pfaff My name is Jean Tourrilhes and I approve this message. Ack-by: Jean Tourrilhes > --- > include/openflow/nicira-ext.h |8 > 1 file chan

Re: [ovs-dev] [PATCH 2/3] flow: Adds ethernet mask fields to flow_wildcards

2012-05-16 Thread Jean Tourrilhes
Joe Stringer wrote : > > With OpenFlow 1.1, there is no equivalent ofp_flow_wildcards flags > for ethernet masking; this is replaced by the eth_{src,dst}_mask. To > support this fully, will we set the appropriate > FWW_DL_DST/FWW_ETH_MCAST bits in the wildcards_t when translating > from OF11+? Or

Re: [ovs-dev] IPv6 rewrite support

2011-06-23 Thread Jean Tourrilhes
On Thu, Jun 23, 2011 at 01:25:46AM -0700, Justin Pettit wrote: > You are correct that we don't have support for rewriting. Do you > have a use-case? As you know, OpenFlow has support for IPv4 address > rewriting, but I haven't found great use-cases for that. NAT comes > to mind, but that often c

[ovs-dev] IPv6 rewrite support

2011-06-22 Thread Jean Tourrilhes
Hi guys, I was looking at IPv6 support in OVS. Unless I missed something obvious, there does not seem to be any support for rewriting fields of the IPv6 header. Is it something you have given any thoughts ? Thanks in advance... Jean

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate_actions() more judiciously.

2011-06-07 Thread Jean Tourrilhes
On Tue, Jun 07, 2011 at 11:36:03AM -0700, Ethan Jackson wrote: > > Have you seen an actual performance improvement? I'll report on that when I'm in a position to have meaningful data. > This feels like premature optimization to me. Correct. > Ethan Jean ___

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate_actions() more judiciously.

2011-06-07 Thread Jean Tourrilhes
On Tue, Jun 07, 2011 at 11:31:50AM -0700, Ben Pfaff wrote: > On Tue, Jun 07, 2011 at 11:25:53AM -0700, Jean Tourrilhes wrote: > > -bool send_flow_removed; /* Send a flow removed message? */ > > +int send_flow_removed:1, /* Send a flow removed message? */ > >

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate_actions() more judiciously.

2011-06-07 Thread Jean Tourrilhes
On Tue, Jun 07, 2011 at 09:25:49AM -0700, Ben Pfaff wrote: > On Mon, Jun 06, 2011 at 06:20:02PM -0700, Jean Tourrilhes wrote: > > Just for curiosity, I've implemented the patch along the line > > of Ben suggestions, see below. I'm wondering if the compiler is smart >

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate_actions() more judiciously.

2011-06-06 Thread Jean Tourrilhes
On Thu, Jun 02, 2011 at 04:06:41PM -0700, Ben Pfaff wrote: > > OK. Ethan, let's drop it for now, with an eye to reviving it later if > need be. Hi guys, Just for curiosity, I've implemented the patch along the line of Ben suggestions, see below. I'm wondering if the compiler is

Re: [ovs-dev] [branch-1.1 0/3] Fix ovs-controller --wildcard and normalization warnings.

2011-06-06 Thread Jean Tourrilhes
On Mon, Jun 06, 2011 at 09:49:00AM -0700, Ben Pfaff wrote: > > Jean, we had a thread last week about fixing up ovs-controller and > normalization warnings on branch-1.1 last week, but it seemed to die off > without any conclusion. Maybe the series of patches that I ended up with > was confusing,

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate_actions() more judiciously.

2011-06-02 Thread Jean Tourrilhes
On Thu, Jun 02, 2011 at 03:55:05PM -0700, Ben Pfaff wrote: > On Thu, Jun 02, 2011 at 03:50:44PM -0700, Ethan Jackson wrote: > > > One idea is to make validate_actions() return a flag indicating > > > whether there was a resubmit action. ?Only ofproto-dpif.c really uses > > > that function anyway. >

Re: [ovs-dev] Problem : do_xlate_actions() called excessively ?

2011-06-02 Thread Jean Tourrilhes
On Thu, Jun 02, 2011 at 03:46:35PM -0700, Ben Pfaff wrote: > > I tend not to worry about these things until I actually see a problem. > I know that you take a more proactive view. I like to understand things, so that I can evaluate those things properly. I have not done any test and deepe

Re: [ovs-dev] Problem : do_xlate_actions() called excessively ?

2011-06-02 Thread Jean Tourrilhes
On Thu, Jun 02, 2011 at 12:55:33PM -0700, Ben Pfaff wrote: > On Thu, Jun 02, 2011 at 11:16:53AM -0700, Jean Tourrilhes wrote: > > I was looking at various things and I found that > > do_xlate_actions() in ofproto.c was called way more often than I was > > expecting. I&

[ovs-dev] Problem : do_xlate_actions() called excessively ?

2011-06-02 Thread Jean Tourrilhes
Hi, I was looking at various things and I found that do_xlate_actions() in ofproto.c was called way more often than I was expecting. I'm using 1.1.0. I set the following flows : ./ovs-ofctl add-flow tcp:127.0.0.1:6634 "priority=32769,idle_timeout=0,ip,nw_dst=15.144.110.1,

Re: [ovs-dev] [PATCH] learning-switch: Wildcard more fields to avoid normalization warnings.

2011-06-01 Thread Jean Tourrilhes
On Wed, Jun 01, 2011 at 01:59:50PM -0700, Ben Pfaff wrote: > On Wed, Jun 01, 2011 at 01:38:17PM -0700, Jean Tourrilhes wrote: > > On Wed, Jun 01, 2011 at 09:34:22AM -0700, Ben Pfaff wrote: > > > FWW_NW_TOS and some other L3 fields weren't wildcarded, but should have >

Re: [ovs-dev] [PATCH] learning-switch: Wildcard more fields to avoid normalization warnings.

2011-06-01 Thread Jean Tourrilhes
On Wed, Jun 01, 2011 at 09:34:22AM -0700, Ben Pfaff wrote: > FWW_NW_TOS and some other L3 fields weren't wildcarded, but should have > been. It's better to start with all fields wildcarded and then unwildcard > the ones that shouldn't be. Problems : 1) By default, the controller d

Re: [ovs-dev] [PATCH 1.1.0] Fix controller wildcard support

2011-05-27 Thread Jean Tourrilhes
On Fri, May 27, 2011 at 09:12:38AM -0700, Ben Pfaff wrote: > On Wed, May 25, 2011 at 02:19:07PM -0700, Jean Tourrilhes wrote: > > I tried to use ovs-controller in the 1.1.0 branch, and the > > support for was broken. I fixed it and I also improved it so that you > > an spe