[jira] [Resolved] (OWB-859) Remove checkstyle double-checked locking rule

[ https://issues.apache.org/jira/browse/OWB-859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved OWB-859. --- Resolution: Fixed Fix Version/s: 1.2.0 Assignee: Mark Struberg > Remove checkstyle d

[jira] [Resolved] (OWB-858) AnnotatedTypeImpl not thread safe

[ https://issues.apache.org/jira/browse/OWB-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved OWB-858. --- Resolution: Fixed Fix Version/s: 1.2.0 Assignee: Mark Struberg works for now. We can sti

Re: [VOTE] take2 - Release OWB-1.2.0

I've closed both issues as they are working. Please feel free to open an issue for owb-1.2.1 and implement it. This is also no mandated reason to -1 a release [1]. Please let's get 1.2.0 out of the door and ship an improved 1.2.1 in a month or so. LieGrue, strub [1] http://www.apache.org/

Re: [VOTE] take2 - Release OWB-1.2.0

+1 LieGrue, strub - Original Message - > From: Mark Struberg > To: openwebbeans-dev ; openwebbeans-user > > Cc: > Sent: Sunday, 12 May 2013, 1:39 > Subject: [VOTE] take2 - Release OWB-1.2.0 > > I'd like to call a 2nd take to VOTE on releasing Apache OpenWebBeans-1.2.0 . > > This i

Re: [VOTE] take2 - Release OWB-1.2.0

I said yesterday which solution id like to see, i have no computer before tonight so i didnt impl it and wanted some discussion before choosing... It is a reason for a -1 since it is a place id like to see stable code (it is a place well have a bunch of issue because of old extensions). Le 12 mai

Re: [VOTE] take2 - Release OWB-1.2.0

Sorry, I forgot to add that this is also a VOTE on our new checkstyle-rules-1.3. Those are contained in the same staging repo and  you can find the source release zip here: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-004/org/apache/openwebbeans/build-tools/checkstyle

Re: [VOTE] take2 - Release OWB-1.2.0

Romain, the previous code had a synchronized block for writes but none for reads. This was broken. The new solution is not perfect but definitely better. LieGrue, strub - Original Message - > From: Romain Manni-Bucau > To: Mark Struberg ; dev@openwebbeans.apache.org > Cc: > Sent: S

Re: [VOTE] take2 - Release OWB-1.2.0

Sure, the last synchro is fine but using a "copyonwrite" set (array iterator) would be more efficient and thread safe...hashset are not and the copy done in get"set" method can still fail So the bug is still here IMO Le 12 mai 2013 10:56, "Mark Struberg" a écrit : > Romain, the previous code

[jira] [Created] (OWB-860) Type variable not bound in generic bean type

Harald Wellmann created OWB-860: --- Summary: Type variable not bound in generic bean type Key: OWB-860 URL: https://issues.apache.org/jira/browse/OWB-860 Project: OpenWebBeans Issue Type: Bug

Re: [VOTE] take2 - Release OWB-1.2.0

This time +1 from here :) Am 12.05.13 09:32 schrieb "Mark Struberg" unter : >+1 > >LieGrue, >strub > > > >- Original Message - >> From: Mark Struberg >> To: openwebbeans-dev ; openwebbeans-user >> >> Cc: >> Sent: Sunday, 12 May 2013, 1:39 >> Subject: [VOTE] take2 - Release OWB-1.2.0 >>

Re: [VOTE] take2 - Release OWB-1.2.0

That would be a good change. I mentioned on IRC yesterday that the new code is technically still not thread-safe as the lists themselves are not thread-safe (your point). Mark's first remark was that the lists are not updated after initialization. If that's true we could even get by with simp

Re: [VOTE] take2 - Release OWB-1.2.0

Unmodifiable != thread safe Le 12 mai 2013 18:37, "David Blevins" a écrit : > That would be a good change. I mentioned on IRC yesterday that the new > code is technically still not thread-safe as the lists themselves are not > thread-safe (your point). > > Mark's first remark was that the lists

Re: AnnotatedTypeImpl and thread safety

Further updated so that the hashsets are not modified outside the AnnotatedTypeImpl.State constructor. Dug around and the only usage of the AnnotatedTypeImpl.addAnnotatedMethod(..) and similar methods was if someone attempted to construct an AnnotatedFieldImpl, etc. and not pass in a declaringT

Re: AnnotatedTypeImpl and thread safety

Looked into that this morning. It occurred to me that would definitely make it thread-safe, but alone doesn't give us the right logic for AnnotatedType.getMethods(), etc. which are supposed to return a complete list not a list being updated. So we'd still need to block getMethods() calls until

Re: AnnotatedTypeImpl and thread safety

If you guarantee me unmodifiableSet itertors are thread safe i'm happy otherwise please use a copyonwriteset then it'll not say anything more Le 12 mai 2013 20:15, "David Blevins" a écrit : > Looked into that this morning. > > It occurred to me that would definitely make it thread-safe, but alone

Re: [VOTE] take2 - Release OWB-1.2.0

+1 regards, gerhard 2013/5/12 Mark Struberg > I'd like to call a 2nd take to VOTE on releasing Apache OpenWebBeans-1.2.0 > . > > This is the first release of the OpenWebBeans-1.2.x branch. > This release changed many internal mechanics but still targets > the CDI-1.0 specification. > > Please

[jira] [Commented] (OWB-803) Forever loop when abstract decorator does not implement invoked method

[ https://issues.apache.org/jira/browse/OWB-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655609#comment-13655609 ] Mark Struberg commented on OWB-803: --- I think this should work already. Can you please retes

[jira] [Updated] (OWB-803) Forever loop when abstract decorator does not implement invoked method

[ https://issues.apache.org/jira/browse/OWB-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg updated OWB-803: -- Fix Version/s: (was: 1.1.9) 1.2.0 > Forever loop when abstract decorator does n

Re: AnnotatedTypeImpl and thread safety

We should be good. UnmodifiableSet + iterator are just a wrappers and HashSet is thread-safe for read-only usage. They're now populated in the constructor as local variables, so outside the constructor no one has a reference to them. If we revert back to the code where the hashsets are exposed

Re: AnnotatedTypeImpl and thread safety

just checked impl (in java7) and it sounds fine for me, thanks David! *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://g

Build failed in Jenkins: OpenWebBeans-trunk #935

See Changes: [dblevins] OWB-858: Further improvement to the type-safety of AnnotatedTypeImpl [struberg] upgrade webbeans-cdi to the next SNAPSHOT -- Started by an SCM change Building remotely

Build failed in Jenkins: OpenWebBeans-trunk-deploy #65

See Changes: [dblevins] OWB-858: Further improvement to the type-safety of AnnotatedTypeImpl [struberg] upgrade webbeans-cdi to the next SNAPSHOT -- Started by an SCM change Building rem