[GitHub] [openwebbeans] cocorossello opened a new pull request #29: [OWB-1341] Event bus: IN_PROGRESS phase should not be sent to transac…

2020-07-23 Thread GitBox
cocorossello opened a new pull request #29: URL: https://github.com/apache/openwebbeans/pull/29 …tionService This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [openwebbeans] rmannibucau merged pull request #29: [OWB-1341] Event bus: IN_PROGRESS phase should not be sent to transac…

2020-07-23 Thread GitBox
rmannibucau merged pull request #29: URL: https://github.com/apache/openwebbeans/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [openwebbeans] cocorossello opened a new pull request #30: Vetoed package test

2020-07-27 Thread GitBox
cocorossello opened a new pull request #30: URL: https://github.com/apache/openwebbeans/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [openwebbeans] struberg commented on a change in pull request #30: Vetoed package test

2020-07-27 Thread GitBox
struberg commented on a change in pull request #30: URL: https://github.com/apache/openwebbeans/pull/30#discussion_r460814308 ## File path: webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java ## @@ -1401,12 +1401,16 @@ else if (packageVetoed)

[GitHub] [openwebbeans] cocorossello commented on a change in pull request #30: Vetoed package test

2020-07-27 Thread GitBox
cocorossello commented on a change in pull request #30: URL: https://github.com/apache/openwebbeans/pull/30#discussion_r460820184 ## File path: webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java ## @@ -1401,12 +1401,16 @@ else if (packageVetoed)

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #30: Vetoed package test

2020-07-29 Thread GitBox
rmannibucau commented on a change in pull request #30: URL: https://github.com/apache/openwebbeans/pull/30#discussion_r460915298 ## File path: webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java ## @@ -1400,13 +1400,13 @@ else if (packageVetoed)

[GitHub] [openwebbeans] tandraschko merged pull request #30: Vetoed package test

2020-07-29 Thread GitBox
tandraschko merged pull request #30: URL: https://github.com/apache/openwebbeans/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [openwebbeans] asfgit merged pull request #24: Update shadow plugin to 5.2.0

2020-08-03 Thread GitBox
asfgit merged pull request #24: URL: https://github.com/apache/openwebbeans/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [openwebbeans] a-rekkusu opened a new pull request #31: OWB-1346 prevent scanning of generated proxies

2020-08-24 Thread GitBox
a-rekkusu opened a new pull request #31: URL: https://github.com/apache/openwebbeans/pull/31 added @Vetoed annotation to generated proxy classes This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [openwebbeans] rmannibucau commented on pull request #31: OWB-1346 prevent scanning of generated proxies

2020-08-24 Thread GitBox
rmannibucau commented on pull request #31: URL: https://github.com/apache/openwebbeans/pull/31#issuecomment-679228948 Hi @a-rekkusu , Can you add a test to this PR to ensure it is readable by plain reflection (>> so it is properly handled by our vetoing logic)?

[GitHub] [openwebbeans] a-rekkusu commented on pull request #31: OWB-1346 prevent scanning of generated proxies

2020-08-24 Thread GitBox
a-rekkusu commented on pull request #31: URL: https://github.com/apache/openwebbeans/pull/31#issuecomment-679230379 Hi @rmannibucau , will do it tomorrow, thanks! This is an automated message from the Apache Git Servi

[GitHub] [openwebbeans] a-rekkusu commented on pull request #31: OWB-1346 prevent scanning of generated proxies

2020-08-25 Thread GitBox
a-rekkusu commented on pull request #31: URL: https://github.com/apache/openwebbeans/pull/31#issuecomment-679898455 @rmannibucau the test is there now, please take a look This is an automated message from the Apache Git Servi

[GitHub] [openwebbeans] tandraschko merged pull request #31: OWB-1346 prevent scanning of generated proxies

2020-08-25 Thread GitBox
tandraschko merged pull request #31: URL: https://github.com/apache/openwebbeans/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [openwebbeans] a-rekkusu opened a new pull request #32: OWB-1346 fixed rat error / missing apache header

2020-08-25 Thread GitBox
a-rekkusu opened a new pull request #32: URL: https://github.com/apache/openwebbeans/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [openwebbeans] tandraschko merged pull request #32: OWB-1346 fixed rat error / missing apache header

2020-08-25 Thread GitBox
tandraschko merged pull request #32: URL: https://github.com/apache/openwebbeans/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [openwebbeans-peeco] a-rekkusu opened a new pull request #1: initial project push

2020-08-31 Thread GitBox
a-rekkusu opened a new pull request #1: URL: https://github.com/apache/openwebbeans-peeco/pull/1 please let me know if some ASF guidelines are missing I added the license header to all files except the native-image configs as they are json files, and classic comments don't work there

[GitHub] [openwebbeans-peeco] tandraschko merged pull request #1: initial project push

2020-09-01 Thread GitBox
tandraschko merged pull request #1: URL: https://github.com/apache/openwebbeans-peeco/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [openwebbeans-peeco] tandraschko commented on pull request #1: initial project push

2020-09-01 Thread GitBox
tandraschko commented on pull request #1: URL: https://github.com/apache/openwebbeans-peeco/pull/1#issuecomment-684522366 Thanks Alex. Thats fine for now. We will probably later add some stuff like checkstyle plugins and so on ---

[GitHub] [openwebbeans-meecrowave] bmarwell opened a new pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.

2021-04-27 Thread GitBox
bmarwell opened a new pull request #15: URL: https://github.com/apache/openwebbeans-meecrowave/pull/15 Jira: https://issues.apache.org/jira/browse/MEECROWAVE-289 [x] signed the CLA -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [openwebbeans-meecrowave] bmarwell opened a new pull request #16: (DOC) add PR template

2021-04-27 Thread GitBox
bmarwell opened a new pull request #16: URL: https://github.com/apache/openwebbeans-meecrowave/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t

[GitHub] [openwebbeans-meecrowave] rmannibucau commented on pull request #16: (DOC) add PR template

2021-04-27 Thread GitBox
rmannibucau commented on pull request #16: URL: https://github.com/apache/openwebbeans-meecrowave/pull/16#issuecomment-828173771 Hi @bmarwell , I know it is a common ASF template but I personally hate this verbose checklist increasing a lot the contribution entry cost so I would min

[GitHub] [openwebbeans-meecrowave] rmannibucau commented on a change in pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.

2021-04-27 Thread GitBox
rmannibucau commented on a change in pull request #15: URL: https://github.com/apache/openwebbeans-meecrowave/pull/15#discussion_r621844841 ## File path: meecrowave-specs-api/pom.xml ## @@ -206,6 +206,126 @@ + + jakarta +

[GitHub] [openwebbeans-meecrowave] bmarwell commented on a change in pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.

2021-05-04 Thread GitBox
bmarwell commented on a change in pull request #15: URL: https://github.com/apache/openwebbeans-meecrowave/pull/15#discussion_r626268261 ## File path: meecrowave-specs-api/pom.xml ## @@ -206,6 +206,126 @@ + + jakarta +

[GitHub] [openwebbeans] melloware opened a new pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-05-09 Thread GitBox
melloware opened a new pull request #33: URL: https://github.com/apache/openwebbeans/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-05-09 Thread GitBox
rmannibucau commented on a change in pull request #33: URL: https://github.com/apache/openwebbeans/pull/33#discussion_r628897340 ## File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties ## @@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusio

[GitHub] [openwebbeans] melloware commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-05-10 Thread GitBox
melloware commented on a change in pull request #33: URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629286820 ## File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties ## @@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionP

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-05-10 Thread GitBox
rmannibucau commented on a change in pull request #33: URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629309692 ## File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties ## @@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusio

[GitHub] [openwebbeans] melloware commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-05-10 Thread GitBox
melloware commented on a change in pull request #33: URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629324468 ## File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties ## @@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionP

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-05-10 Thread GitBox
rmannibucau commented on a change in pull request #33: URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629337241 ## File path: webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties ## @@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusio

[GitHub] [openwebbeans] stephenc opened a new pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-13 Thread GitBox
stephenc opened a new pull request #34: URL: https://github.com/apache/openwebbeans/pull/34 https://github.com/eclipse/jetty.project/blob/4204526d2fdad355e233f6bf18a44bfe028ee00b/jetty-server/src/main/java/org/eclipse/jetty/server/session/Session.java#L467-L478 -- This is an automated me

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-13 Thread GitBox
rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r631830461 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] stephenc commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-13 Thread GitBox
stephenc commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r631905399 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIsExp

[GitHub] [openwebbeans] jtnord commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
jtnord commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632471170 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIsExpir

[GitHub] [openwebbeans] jtnord commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
jtnord commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632471170 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIsExpir

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632478148 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] tandraschko commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
tandraschko commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632486753 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632489637 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] tandraschko commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
tandraschko commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632491866 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] stephenc commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
stephenc commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632492164 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIsExp

[GitHub] [openwebbeans] jtnord commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
jtnord commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632493311 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIsExpir

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632495176 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632500938 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] jtnord commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
jtnord commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632493311 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIsExpir

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #34: Workaround Jetty ISE for invalidating sessions

2021-05-14 Thread GitBox
rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632689634 ## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ## @@ -593,9 +593,17 @@ protected boolean sessionIs

[GitHub] [openwebbeans] RealCLanger opened a new pull request #35: Improve handling of lineSeparator in ViolationMessageBuilder

2021-07-19 Thread GitBox
RealCLanger opened a new pull request #35: URL: https://github.com/apache/openwebbeans/pull/35 Call System.lineSeparator() instead of System.getProperty("line.separator") to avoid a potential bottleneck when multiple threads concurrently build violation messages and then have to synchroniz

[GitHub] [openwebbeans] rmannibucau merged pull request #35: Improve handling of lineSeparator in ViolationMessageBuilder

2021-07-19 Thread GitBox
rmannibucau merged pull request #35: URL: https://github.com/apache/openwebbeans/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [openwebbeans] RealCLanger commented on pull request #35: Improve handling of lineSeparator in ViolationMessageBuilder

2021-07-19 Thread GitBox
RealCLanger commented on pull request #35: URL: https://github.com/apache/openwebbeans/pull/35#issuecomment-882332169 @rmannibucau Thanks for merging this so quickly! Do you have any idea when this will be part of an openwebbeans release and eventually hit TomEE 8.0.*? -- This is an auto

[GitHub] [openwebbeans] rmannibucau commented on pull request #35: Improve handling of lineSeparator in ViolationMessageBuilder

2021-07-19 Thread GitBox
rmannibucau commented on pull request #35: URL: https://github.com/apache/openwebbeans/pull/35#issuecomment-882350217 @RealCLanger guess OWB can be released anytime soon - just don't forget it is holidays time but no big blocker. On TomEE side I'm not 100% sure but it will be trivial to up

[GitHub] [openwebbeans] rmannibucau commented on pull request #35: Improve handling of lineSeparator in ViolationMessageBuilder

2021-07-20 Thread GitBox
rmannibucau commented on pull request #35: URL: https://github.com/apache/openwebbeans/pull/35#issuecomment-882350217 @RealCLanger guess OWB can be released anytime soon - just don't forget it is holidays time but no big blocker. On TomEE side I'm not 100% sure but it will be trivial to up

[GitHub] [openwebbeans] stephenc commented on pull request #34: Workaround Jetty ISE for invalidating sessions

2021-08-16 Thread GitBox
stephenc commented on pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#issuecomment-899366169 Fixed in Jetty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [openwebbeans] stephenc closed pull request #34: Workaround Jetty ISE for invalidating sessions

2021-08-16 Thread GitBox
stephenc closed pull request #34: URL: https://github.com/apache/openwebbeans/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [openwebbeans] BuZZ-dEE opened a new pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-07 Thread GitBox
BuZZ-dEE opened a new pull request #36: URL: https://github.com/apache/openwebbeans/pull/36 Avoids memory leak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [openwebbeans] BuZZ-dEE opened a new pull request #37: OWB-1389 Remove destroyed instance from memory

2021-09-07 Thread GitBox
BuZZ-dEE opened a new pull request #37: URL: https://github.com/apache/openwebbeans/pull/37 (cherry picked from commit aa54458253c6144d1defe45f5af858d964659190) Avoids memory leak -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-07 Thread GitBox
rmannibucau commented on a change in pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#discussion_r703639699 ## File path: webbeans-tomcat7/src/main/java/org/apache/webbeans/web/tomcat7/TomcatInstanceManager.java ## @@ -60,10 +60,15 @@ public void destroyIn

[GitHub] [openwebbeans] BuZZ-dEE commented on a change in pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-07 Thread GitBox
BuZZ-dEE commented on a change in pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#discussion_r703642109 ## File path: webbeans-tomcat7/src/main/java/org/apache/webbeans/web/tomcat7/TomcatInstanceManager.java ## @@ -60,10 +60,15 @@ public void destroyInsta

[GitHub] [openwebbeans] rmannibucau commented on a change in pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-07 Thread GitBox
rmannibucau commented on a change in pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#discussion_r703648338 ## File path: webbeans-tomcat7/src/main/java/org/apache/webbeans/web/tomcat7/TomcatInstanceManager.java ## @@ -60,10 +60,15 @@ public void destroyIn

[GitHub] [openwebbeans] BuZZ-dEE commented on a change in pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-07 Thread GitBox
BuZZ-dEE commented on a change in pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#discussion_r703655854 ## File path: webbeans-tomcat7/src/main/java/org/apache/webbeans/web/tomcat7/TomcatInstanceManager.java ## @@ -60,10 +60,15 @@ public void destroyInsta

[GitHub] [openwebbeans] struberg merged pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-12 Thread GitBox
struberg merged pull request #36: URL: https://github.com/apache/openwebbeans/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [openwebbeans] struberg commented on pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-12 Thread GitBox
struberg commented on pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#issuecomment-917582298 txs for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [openwebbeans] BuZZ-dEE opened a new pull request #38: OWB-1389 Remove destroyed instance from memory (in master branch)

2021-09-13 Thread GitBox
BuZZ-dEE opened a new pull request #38: URL: https://github.com/apache/openwebbeans/pull/38 https://github.com/apache/openwebbeans/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [openwebbeans] BuZZ-dEE commented on pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-13 Thread GitBox
BuZZ-dEE commented on pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#issuecomment-918067706 @struberg i think, this is also useful for the master branch https://github.com/apache/openwebbeans/pull/38 -- This is an automated message from the Apache Git Service. To r

[GitHub] [openwebbeans] BuZZ-dEE edited a comment on pull request #36: OWB-1389 Remove destroyed instance from memory

2021-09-13 Thread GitBox
BuZZ-dEE edited a comment on pull request #36: URL: https://github.com/apache/openwebbeans/pull/36#issuecomment-918067706 @struberg thank you for merging. i think, this is also useful for the master branch https://github.com/apache/openwebbeans/pull/38 -- This is an automated message fro

[GitHub] [openwebbeans] tandraschko merged pull request #37: OWB-1389 Remove destroyed instance from memory (backport from cdi-2.0 to owb_1.7.x)

2021-09-24 Thread GitBox
tandraschko merged pull request #37: URL: https://github.com/apache/openwebbeans/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [openwebbeans] tandraschko merged pull request #38: OWB-1389 Remove destroyed instance from memory (in master branch)

2021-09-24 Thread GitBox
tandraschko merged pull request #38: URL: https://github.com/apache/openwebbeans/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [openwebbeans] tandraschko merged pull request #33: OWB-1298: Exclude Mojarra 2.3

2021-09-24 Thread GitBox
tandraschko merged pull request #33: URL: https://github.com/apache/openwebbeans/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [openwebbeans] tandraschko closed pull request #23: OWB-1300 - test and fix for ClassCastException in org.apache.webbeans…

2021-09-24 Thread GitBox
tandraschko closed pull request #23: URL: https://github.com/apache/openwebbeans/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [openwebbeans] tandraschko commented on pull request #23: OWB-1300 - test and fix for ClassCastException in org.apache.webbeans…

2021-09-24 Thread GitBox
tandraschko commented on pull request #23: URL: https://github.com/apache/openwebbeans/pull/23#issuecomment-926428596 2 years without response, lets close this for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [openwebbeans] dependabot[bot] opened a new pull request, #40: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/servletinjection

2022-05-12 Thread GitBox
dependabot[bot] opened a new pull request, #40: URL: https://github.com/apache/openwebbeans/pull/40 Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.1

[GitHub] [openwebbeans] dependabot[bot] opened a new pull request, #39: Bump junit from 4.11 to 4.13.1 in /webbeans-tomcat7/src/it/servletinjection

2022-05-12 Thread GitBox
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/openwebbeans/pull/39 Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.1

[GitHub] [openwebbeans] dependabot[bot] opened a new pull request, #41: Bump junit from 4.12 to 4.13.1 in /webbeans-web/src/it/forward/b

2022-05-12 Thread GitBox
dependabot[bot] opened a new pull request, #41: URL: https://github.com/apache/openwebbeans/pull/41 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.1

[GitHub] [openwebbeans] dependabot[bot] opened a new pull request, #42: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/module

2022-05-12 Thread GitBox
dependabot[bot] opened a new pull request, #42: URL: https://github.com/apache/openwebbeans/pull/42 Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.1

[GitHub] [openwebbeans] dependabot[bot] opened a new pull request, #43: Bump commons-io from 2.6 to 2.7 in /webbeans-jetty9

2022-05-12 Thread GitBox
dependabot[bot] opened a new pull request, #43: URL: https://github.com/apache/openwebbeans/pull/43 Bumps commons-io from 2.6 to 2.7. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:commons-io&package

[GitHub] [openwebbeans-meecrowave-examples] dependabot[bot] opened a new pull request, #10: Bump vaadin-bom from 10.0.16 to 10.0.19 in /servlet-vaadin-v10

2022-05-13 Thread GitBox
dependabot[bot] opened a new pull request, #10: URL: https://github.com/apache/openwebbeans-meecrowave-examples/pull/10 Bumps vaadin-bom from 10.0.16 to 10.0.19. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=c

[GitHub] [openwebbeans-meecrowave-examples] dependabot[bot] opened a new pull request, #11: Bump vaadin-bom from 8.8.2 to 8.14.1 in /servlet-vaadin-v08

2022-05-13 Thread GitBox
dependabot[bot] opened a new pull request, #11: URL: https://github.com/apache/openwebbeans-meecrowave-examples/pull/11 Bumps vaadin-bom from 8.8.2 to 8.14.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.

[GitHub] [openwebbeans] dependabot[bot] commented on pull request #43: Bump commons-io from 2.6 to 2.7 in /webbeans-jetty9

2022-05-24 Thread GitBox
dependabot[bot] commented on PR #43: URL: https://github.com/apache/openwebbeans/pull/43#issuecomment-1135785355 Looks like commons-io:commons-io is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [openwebbeans] dependabot[bot] closed pull request #43: Bump commons-io from 2.6 to 2.7 in /webbeans-jetty9

2022-05-24 Thread GitBox
dependabot[bot] closed pull request #43: Bump commons-io from 2.6 to 2.7 in /webbeans-jetty9 URL: https://github.com/apache/openwebbeans/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [openwebbeans-meecrowave] rmannibucau commented on pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.

2022-08-22 Thread GitBox
rmannibucau commented on PR #15: URL: https://github.com/apache/openwebbeans-meecrowave/pull/15#issuecomment-1221934506 Is it still needed? Just spotted it was not merged :s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [openwebbeans-meecrowave] bmarwell commented on pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.

2022-08-22 Thread GitBox
bmarwell commented on PR #15: URL: https://github.com/apache/openwebbeans-meecrowave/pull/15#issuecomment-1221996616 Not at the moment, thanks for asking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [openwebbeans] struberg commented on pull request #44: Support transitive InterceptorBinding on annotated types

2022-10-11 Thread GitBox
struberg commented on PR #44: URL: https://github.com/apache/openwebbeans/pull/44#issuecomment-1274413392 @jeanouii what is not working as you'd expect right now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [openwebbeans] struberg closed pull request #39: Bump junit from 4.11 to 4.13.1 in /webbeans-tomcat7/src/it/servletinjection

2022-10-11 Thread GitBox
struberg closed pull request #39: Bump junit from 4.11 to 4.13.1 in /webbeans-tomcat7/src/it/servletinjection URL: https://github.com/apache/openwebbeans/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [openwebbeans] struberg closed pull request #41: Bump junit from 4.12 to 4.13.1 in /webbeans-web/src/it/forward/b

2022-10-11 Thread GitBox
struberg closed pull request #41: Bump junit from 4.12 to 4.13.1 in /webbeans-web/src/it/forward/b URL: https://github.com/apache/openwebbeans/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [openwebbeans] struberg closed pull request #42: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/module

2022-10-11 Thread GitBox
struberg closed pull request #42: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/module URL: https://github.com/apache/openwebbeans/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [openwebbeans] struberg closed pull request #40: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/servletinjection

2022-10-11 Thread GitBox
struberg closed pull request #40: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/servletinjection URL: https://github.com/apache/openwebbeans/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [openwebbeans] dependabot[bot] commented on pull request #42: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/module

2022-10-11 Thread GitBox
dependabot[bot] commented on PR #42: URL: https://github.com/apache/openwebbeans/pull/42#issuecomment-1274423573 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, le

[GitHub] [openwebbeans] dependabot[bot] commented on pull request #41: Bump junit from 4.12 to 4.13.1 in /webbeans-web/src/it/forward/b

2022-10-11 Thread GitBox
dependabot[bot] commented on PR #41: URL: https://github.com/apache/openwebbeans/pull/41#issuecomment-1274423564 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, le

[GitHub] [openwebbeans] dependabot[bot] commented on pull request #39: Bump junit from 4.11 to 4.13.1 in /webbeans-tomcat7/src/it/servletinjection

2022-10-11 Thread GitBox
dependabot[bot] commented on PR #39: URL: https://github.com/apache/openwebbeans/pull/39#issuecomment-1274423584 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, le

[GitHub] [openwebbeans] dependabot[bot] commented on pull request #40: Bump junit from 4.11 to 4.13.1 in /webbeans-jetty9/src/it/servletinjection

2022-10-11 Thread GitBox
dependabot[bot] commented on PR #40: URL: https://github.com/apache/openwebbeans/pull/40#issuecomment-1274423597 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, le

[GitHub] [openwebbeans-meecrowave] bvfalcon opened a new pull request, #17: fix: MEECROWAVE-323 - incorrect filename

2022-10-13 Thread GitBox
bvfalcon opened a new pull request, #17: URL: https://github.com/apache/openwebbeans-meecrowave/pull/17 Bug with erroneous automatic renaming file solved - [MEECROWAVE-323](https://issues.apache.org/jira/browse/MEECROWAVE-323). I have used the solution [from johnzon](https://github.c

[GitHub] [openwebbeans-meecrowave] rmannibucau merged pull request #17: fix: MEECROWAVE-323 - incorrect filename

2022-10-13 Thread GitBox
rmannibucau merged PR #17: URL: https://github.com/apache/openwebbeans-meecrowave/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [openwebbeans-meecrowave] rmannibucau commented on pull request #17: fix: MEECROWAVE-323 - incorrect filename

2022-10-13 Thread GitBox
rmannibucau commented on PR #17: URL: https://github.com/apache/openwebbeans-meecrowave/pull/17#issuecomment-1278101388 Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [openwebbeans] tt0suzy opened a new pull request, #45: Fixed non determininstic(flaky) tests in BeanCacheKeyUnitTest.java

2022-10-27 Thread GitBox
tt0suzy opened a new pull request, #45: URL: https://github.com/apache/openwebbeans/pull/45 Hi, I am from the Software Testing research group at the University of Illinois. We want to inform that the tests org.apache.webbeans.test.annotation.binding.BeanCacheKeyUnitTest.testEquals2Annota

[GitHub] [openwebbeans] rmannibucau commented on pull request #45: Fixed non determininstic(flaky) tests in BeanCacheKeyUnitTest.java

2022-10-27 Thread GitBox
rmannibucau commented on PR #45: URL: https://github.com/apache/openwebbeans/pull/45#issuecomment-1294521925 Hi @tt0suzy , AFAIK the order is deterministic _per run_ so code is fine and we don't need the overhead of the sort at runtime. -- This is an automated message from the Apache Git

[GitHub] [openwebbeans] tt0suzy closed pull request #45: Fixed non determininstic(flaky) tests in BeanCacheKeyUnitTest.java

2022-11-18 Thread GitBox
tt0suzy closed pull request #45: Fixed non determininstic(flaky) tests in BeanCacheKeyUnitTest.java URL: https://github.com/apache/openwebbeans/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [openwebbeans-meecrowave] dependabot[bot] opened a new pull request, #18: Bump gradle-core from 3.1 to 6.0 in /meecrowave-gradle-plugin

2022-12-21 Thread GitBox
dependabot[bot] opened a new pull request, #18: URL: https://github.com/apache/openwebbeans-meecrowave/pull/18 Bumps gradle-core from 3.1 to 6.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.gradle:gradle

[GitHub] [openwebbeans] jgallimore opened a new pull request, #46: Try/catch so we don't fail if @New is missing

2023-01-20 Thread GitBox
jgallimore opened a new pull request, #46: URL: https://github.com/apache/openwebbeans/pull/46 The `@New` annotation has been deprecated for while, and removed in CDI 4. This PR allows OWB to skip rather than fail with an error if `@New` is not available on the classpath. -- This is an a

[GitHub] [openwebbeans] jeanouii commented on pull request #46: Try/catch so we don't fail if @New is missing

2023-01-20 Thread GitBox
jeanouii commented on PR #46: URL: https://github.com/apache/openwebbeans/pull/46#issuecomment-1398254784 Thanks @jgallimore LGTM. I'll create a JIRA issue for it and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [openwebbeans] jeanouii merged pull request #46: Try/catch so we don't fail if @New is missing

2023-01-20 Thread GitBox
jeanouii merged PR #46: URL: https://github.com/apache/openwebbeans/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openwebbeans

[GitHub] svenruppert opened a new pull request #1: added vaadin examples, extended pom.xml files..

2018-06-29 Thread GitBox
svenruppert opened a new pull request #1: added vaadin examples, extended pom.xml files.. URL: https://github.com/apache/openwebbeans-meecrowave-examples/pull/1 This is an automated message from the Apache Git Service. To re

[GitHub] struberg commented on a change in pull request #1: added vaadin examples, extended pom.xml files..

2018-06-29 Thread GitBox
struberg commented on a change in pull request #1: added vaadin examples, extended pom.xml files.. URL: https://github.com/apache/openwebbeans-meecrowave-examples/pull/1#discussion_r199122593 ## File path: servlet-vaadin-v10/pom.xml ## @@ -0,0 +1,118 @@ + + +http://maven.

[GitHub] struberg closed pull request #1: added vaadin examples, extended pom.xml files..

2018-06-29 Thread GitBox
struberg closed pull request #1: added vaadin examples, extended pom.xml files.. URL: https://github.com/apache/openwebbeans-meecrowave-examples/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

  1   2   >