Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/233
---
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r176910542
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,9 +1194,8 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i) {
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r176909659
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,9 +1194,8 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i) {
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r176910052
--- Diff: c++/src/ColumnReader.cc ---
@@ -336,8 +336,7 @@ namespace orc {
}
}
int64_t writerTime = secsBuffer[i] +
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257375
--- Diff: c++/src/Vector.cc ---
@@ -436,4 +438,8 @@ namespace orc {
+ static_cast(
(data.capacity() + nanoseconds.capacity()) *
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257358
--- Diff: c++/src/ColumnPrinter.cc ---
@@ -710,7 +713,10 @@ namespace orc {
writeString(buffer, "null");
} else {
int64_t
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257368
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,12 +1194,11 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i) {
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257109
--- Diff: c++/src/ColumnPrinter.cc ---
@@ -710,7 +713,10 @@ namespace orc {
writeString(buffer, "null");
} else {
int64_t nanos =
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256695
--- Diff: c++/src/Vector.cc ---
@@ -436,4 +438,8 @@ namespace orc {
+ static_cast(
(data.capacity() +
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256539
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,12 +1194,11 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues;
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256428
--- Diff: c++/src/ColumnPrinter.cc ---
@@ -710,7 +713,10 @@ namespace orc {
writeString(buffer, "null");
} else {
int64_t
GitHub user wgtmac reopened a pull request:
https://github.com/apache/orc/pull/233
ORC-322: [C++] Fix writing & reading timestamp
Currently C++ and Java version have different behaviors in reading and
writing values of timestamp type. This patch ensures C++ reader/printer will
Github user wgtmac closed the pull request at:
https://github.com/apache/orc/pull/233
---
GitHub user wgtmac opened a pull request:
https://github.com/apache/orc/pull/233
ORC-322: [C++] Fix writing & reading timestamp
Currently C++ and Java version have different behaviors in reading and
writing values of timestamp type. This patch ensures C++ reader/printer will
14 matches
Mail list logo
