pgaref commented on a change in pull request #475:
URL: https://github.com/apache/orc/pull/475#discussion_r411489293
##
File path: java/bench/core/pom.xml
##
@@ -112,6 +112,10 @@
org.apache.maven.plugins
maven-compiler-plugin
+
+
pgaref commented on a change in pull request #475:
URL: https://github.com/apache/orc/pull/475#discussion_r411491070
##
File path: java/core/src/java/org/apache/orc/Reader.java
##
@@ -237,6 +241,12 @@ public Options schema(TypeDescription schema) {
return this;
}
pgaref commented on a change in pull request #475:
URL: https://github.com/apache/orc/pull/475#discussion_r411523965
##
File path: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java
##
@@ -160,11 +189,152 @@ public boolean fileUsedProlepticGregorian() {
}
}
pgaref commented on issue #475:
URL: https://github.com/apache/orc/pull/475#issuecomment-616680910
> All of the calls were static methods on IOUtils, so it seemed better to
remove them unless there is a huge performance impact.
Let me dig deeper on this and I will create a follow-up
omalley opened a new pull request #502:
URL: https://github.com/apache/orc/pull/502
This fix:
- ports HIVE-22480 to the current ORC code base
- fixes seeking to a row in a broken file
- adds a test for ORC-569
- adds a test for HIVE-22480 with a new pre-ORC-569 example file
-
jcamachor commented on issue #502:
URL: https://github.com/apache/orc/pull/502#issuecomment-617263094
LGTM, thanks @omalley
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
jcamachor removed a comment on issue #502:
URL: https://github.com/apache/orc/pull/502#issuecomment-617263228
LGTM, thanks @omalley
This is an automated message from the Apache Git Service.
To respond to the message, please
jcamachor commented on issue #502:
URL: https://github.com/apache/orc/pull/502#issuecomment-617263228
LGTM, thanks @omalley
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
pavibhai opened a new pull request #503:
URL: https://github.com/apache/orc/pull/503
This is fix for [ORC-622](https://issues.apache.org/jira/browse/ORC-622)
Fixed the TreeReaderFactory and ConvertTreeReaderFactory
Made RecordReaderImpl use RootReader instead of TreeReader
remov
tedxu opened a new pull request #504:
URL: https://github.com/apache/orc/pull/504
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
shameersss1 opened a new pull request #505:
URL: https://github.com/apache/orc/pull/505
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
omalley opened a new pull request #506:
URL: https://github.com/apache/orc/pull/506
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on a change in pull request #506:
URL: https://github.com/apache/orc/pull/506#discussion_r421284102
##
File path: java/tools/src/java/org/apache/orc/tools/Driver.java
##
@@ -116,6 +116,8 @@ public static void main(String[] args) throws Exception {
dongjoon-hyun opened a new pull request #507:
URL: https://github.com/apache/orc/pull/507
After ORC-599 (Bumping up guava to 28.1-jre), `orc-tools` uber jar fails due
to `ClassNotFoundException`. This PR aims to add back to `orc-tools`.
```
$ mvn package -DskipTests
$ java -jar too
dongjoon-hyun commented on pull request #506:
URL: https://github.com/apache/orc/pull/506#issuecomment-625147721
I found that `orc-tools` uber jar has been broken due to ORC-599 and make a
PR to fix it. Could you review that, please?
- https://github.com/apache/orc/pull/507
---
dongjoon-hyun edited a comment on pull request #506:
URL: https://github.com/apache/orc/pull/506#issuecomment-625147721
I found that `orc-tools` uber jar has been broken due to ORC-599 and made a
PR to fix it. Could you review that, please?
- https://github.com/apache/orc/pull/507
omalley commented on pull request #506:
URL: https://github.com/apache/orc/pull/506#issuecomment-625354549
Sorry about that! I wrote and tested the patch on branch 1.5, so it worked.
Thanks for fixing master.
This is an auto
dongjoon-hyun commented on pull request #506:
URL: https://github.com/apache/orc/pull/506#issuecomment-625360508
Thank you, @omalley .
This is an automated message from the Apache Git Service.
To respond to the message, pleas
omalley commented on pull request #503:
URL: https://github.com/apache/orc/pull/503#issuecomment-625499062
Ok, I started
[tweaking](https://github.com/omalley/orc/commit/e73bdbdb00ca43f679fc994e7f6988d7b6a45fec)
this.
I hope that is ok, Pavan.
I'd propose:
* making BatchRe
pgaref opened a new pull request #509:
URL: https://github.com/apache/orc/pull/509
Change-Id: Ib5859eeaef4123c363fb6a8fb5430ac9ef364611
This is an automated message from the Apache Git Service.
To respond to the message, plea
pgaref commented on pull request #475:
URL: https://github.com/apache/orc/pull/475#issuecomment-629834289
Consolidating ORC-577 work and using recently released storage-api 2.7.2
that included FilterContext
This is an automa
pgaref edited a comment on pull request #475:
URL: https://github.com/apache/orc/pull/475#issuecomment-629834289
Consolidating ORC-577 work and using recently released storage-api 2.7.2
that introduced FilterContext as part of VRB
--
jcamachor merged pull request #475:
URL: https://github.com/apache/orc/pull/475
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tobodner opened a new pull request #510:
URL: https://github.com/apache/orc/pull/510
Consuming Apache ORC in a C++ project as CMake submodule (via
add_subdirectory) currently causes two issues:
* A warning about CMake policy CMP0048 not being set, which cannot be
suppressed from the out
igaztanaga opened a new pull request #511:
URL: https://github.com/apache/orc/pull/511
Zstd's "Simple API" is used which initializes the compression/decompression
context each time. This includes time to initialize all
compression/decompression tables. Using the "Explicit context" API impr
autumnust opened a new pull request #512:
URL: https://github.com/apache/orc/pull/512
Issues are described in ORC-638.
The factor "3" is chosen based on heuristic.
The better approach is to create averageListElementSize in columnVector in
hive-storage-api, but as the users of `C
julianmenzler opened a new pull request #513:
URL: https://github.com/apache/orc/pull/513
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wgtmac merged pull request #511:
URL: https://github.com/apache/orc/pull/511
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
wgtmac merged pull request #513:
URL: https://github.com/apache/orc/pull/513
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
wgtmac removed a comment on pull request #510:
URL: https://github.com/apache/orc/pull/510#issuecomment-641712276
@tobodner
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
wgtmac commented on pull request #510:
URL: https://github.com/apache/orc/pull/510#issuecomment-641712276
@tobodner
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wgtmac merged pull request #510:
URL: https://github.com/apache/orc/pull/510
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
igaztanaga opened a new pull request #514:
URL: https://github.com/apache/orc/pull/514
According to zlib documentation of DeflateInit2:
_"This is another version of deflateInit with more compression options. The
fields **next_in**, zalloc, zfree and opaque must be initialized before
electrum opened a new pull request #515:
URL: https://github.com/apache/orc/pull/515
Aircompressor no longer depends on Slice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
omalley closed pull request #515:
URL: https://github.com/apache/orc/pull/515
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bmaidics opened a new pull request #516:
URL: https://github.com/apache/orc/pull/516
When using Hive LLAP in a cloud environment, we observed a bunch of
(>10) non-useful logs:
`impl.OrcCodecPool: Got brand-new codec ZLIB`
I think the log level here can be reduced to DEBUG
bmaidics closed pull request #516:
URL: https://github.com/apache/orc/pull/516
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
prasanthj commented on pull request #516:
URL: https://github.com/apache/orc/pull/516#issuecomment-646098832
@bmaidics is there Jira for this ticket under ORC project?
This is an automated message from the Apache Git Service
prasanthj edited a comment on pull request #516:
URL: https://github.com/apache/orc/pull/516#issuecomment-646098832
@bmaidics is there Jira for this PR under ORC project?
This is an automated message from the Apache Git Serv
omalley closed pull request #512:
URL: https://github.com/apache/orc/pull/512
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
omalley closed pull request #516:
URL: https://github.com/apache/orc/pull/516
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
nikitamikhaylov opened a new pull request #517:
URL: https://github.com/apache/orc/pull/517
You have clang-6 in your CI, but that is too old.
This is an automated message from the Apache Git Service.
To respond to the messag
dongjoon-hyun commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-657783235
Hi, @nikitamikhaylov . Thank you for your first contribution.
Does this PR include all fixes for clang-10?
Th
nikitamikhaylov commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-657784463
> Hi, @nikitamikhaylov . Thank you for your first contribution.
>
> Does this PR include all fixes for clang-10?
After that fixes I've successfully compiled it wit
dongjoon-hyun commented on a change in pull request #517:
URL: https://github.com/apache/orc/pull/517#discussion_r453929349
##
File path: c++/test/TestBloomFilter.cc
##
@@ -152,9 +152,9 @@ namespace orc {
// test strings
bloomFilter.reset();
-const char * emptyS
williamhyun opened a new pull request #518:
URL: https://github.com/apache/orc/pull/518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on pull request #518:
URL: https://github.com/apache/orc/pull/518#issuecomment-657895735
You are added to the Apache ORC contributor group and ORC-646 is assigned to
you.
This is an automated message
dongjoon-hyun commented on pull request #518:
URL: https://github.com/apache/orc/pull/518#issuecomment-657895909
This is merged via
https://github.com/apache/orc/commit/0f33183e116789e6b37e38039d2746f6b59a4f0e
This is an aut
dongjoon-hyun closed pull request #518:
URL: https://github.com/apache/orc/pull/518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nikitamikhaylov commented on a change in pull request #517:
URL: https://github.com/apache/orc/pull/517#discussion_r454279531
##
File path: c++/test/TestBloomFilter.cc
##
@@ -152,9 +152,9 @@ namespace orc {
// test strings
bloomFilter.reset();
-const char * empt
dongjoon-hyun commented on a change in pull request #517:
URL: https://github.com/apache/orc/pull/517#discussion_r454476361
##
File path: c++/test/TestBloomFilter.cc
##
@@ -152,9 +152,9 @@ namespace orc {
// test strings
bloomFilter.reset();
-const char * emptyS
dongjoon-hyun commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-658275200
@nikitamikhaylov . Apache ORC has a dockerized testing environment like the
following. When I run this this PR on clang9 on Ubuntu 20.04, this didn't pass
the test. So, I'm wond
shameersss1 commented on pull request #505:
URL: https://github.com/apache/orc/pull/505#issuecomment-658563394
@omalley @prasanthj ping for review
This is an automated message from the Apache Git Service.
To respond to the me
dongjoon-hyun edited a comment on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-658275200
@nikitamikhaylov . Apache ORC has a dockerized testing environment like the
following. When I ran this PR on clang9 on Ubuntu 20.04, this didn't pass the
test. So, I'm wo
dongjoon-hyun opened a new pull request #519:
URL: https://github.com/apache/orc/pull/519
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun commented on pull request #519:
URL: https://github.com/apache/orc/pull/519#issuecomment-659162096
Hi, @omalley . Could you review this PR when you have some time?
This is an automated message from the Apache Gi
dongjoon-hyun commented on pull request #519:
URL: https://github.com/apache/orc/pull/519#issuecomment-659570078
Hi, @jcamachor and @prasanthj .
Could you review this PR when you have some time?
This is an automated messag
dongjoon-hyun merged pull request #519:
URL: https://github.com/apache/orc/pull/519
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on pull request #519:
URL: https://github.com/apache/orc/pull/519#issuecomment-659824927
For a record, this is merged according to the +1 at ORC-647 comment.
This is an automated message from the Apach
dongjoon-hyun commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-659831415
For this PR, ORC-647 added macOS 10.15 test to Travis CI with `clang12`.
Could you rebase this PR to the master?
```
$ clang --version
90Apple clang version 12.0.0 (
dongjoon-hyun opened a new pull request #520:
URL: https://github.com/apache/orc/pull/520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun commented on pull request #520:
URL: https://github.com/apache/orc/pull/520#issuecomment-659898636
Could you review this please, @omalley and @jcamachor ?
This is an automated message from the Apache Git Service
dongjoon-hyun merged pull request #520:
URL: https://github.com/apache/orc/pull/520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on pull request #520:
URL: https://github.com/apache/orc/pull/520#issuecomment-660419910
GitHub Action starts to working.
https://user-images.githubusercontent.com/9700541/87844241-45bb0c00-c870-11ea-8488-fad98e7a7a7e.png";>
--
pgaref commented on pull request #478:
URL: https://github.com/apache/orc/pull/478#issuecomment-662460357
Hey @dongjoon-hyun @jcamachor could you please take a look?
Now that ORC-577 is merged this could be pretty useful.
Thanks!
-
dongjoon-hyun commented on pull request #478:
URL: https://github.com/apache/orc/pull/478#issuecomment-663572043
cc @omalley
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun commented on pull request #521:
URL: https://github.com/apache/orc/pull/521#issuecomment-665163759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dongjoon-hyun edited a comment on pull request #521:
URL: https://github.com/apache/orc/pull/521#issuecomment-665167638
You are added to Apache Orc contributor group and ORC-649 is assigned to
you. Welcome!
This is an automa
ArvinZheng opened a new pull request #522:
URL: https://github.com/apache/orc/pull/522
fix [ORC-644](https://issues.apache.org/jira/browse/ORC-644)
This is an automated message from the Apache Git Service.
To respond to the m
ArvinZheng opened a new pull request #521:
URL: https://github.com/apache/orc/pull/521
fix https://issues.apache.org/jira/browse/ORC-649
This is an automated message from the Apache Git Service.
To respond to the message, ple
ArvinZheng commented on pull request #522:
URL: https://github.com/apache/orc/pull/522#issuecomment-664807829
hi @omalley , mind taking a look at this PR? Thanks.
This is an automated message from the Apache Git Service.
To r
dongjoon-hyun merged pull request #521:
URL: https://github.com/apache/orc/pull/521
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ArvinZheng commented on pull request #521:
URL: https://github.com/apache/orc/pull/521#issuecomment-664807650
hi @omalley , mind taking a look at this PR? Thanks.
This is an automated message from the Apache Git Service.
To r
nehaljwani opened a new pull request #523:
URL: https://github.com/apache/orc/pull/523
The name of the module is FindZSTD.cmake and not Findzstd.cmake
This is an automated message from the Apache Git Service.
To respond to th
nehaljwani opened a new pull request #524:
URL: https://github.com/apache/orc/pull/524
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun closed pull request #523:
URL: https://github.com/apache/orc/pull/523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on pull request #523:
URL: https://github.com/apache/orc/pull/523#issuecomment-667615890
+1, LGTM.
Thank you for your first contribution, @nehaljwani . This is merged.
This is an automated message f
dongjoon-hyun commented on pull request #523:
URL: https://github.com/apache/orc/pull/523#issuecomment-667616025
I want to add you to the Apache ORC contributor group and assign ORC-650 to
you. What is your Apache JIRA id? If you don't have yet, please make one and
let me know.
-
nehaljwani commented on pull request #523:
URL: https://github.com/apache/orc/pull/523#issuecomment-667617045
Thank you @dongjoon-hyun ! I have created an account with the username:
nehaljwani
This is an automated message f
dongjoon-hyun opened a new pull request #525:
URL: https://github.com/apache/orc/pull/525
### What changes were proposed in this pull request?
### Why are the changes needed?
### How was this patch tested?
--
dongjoon-hyun commented on pull request #523:
URL: https://github.com/apache/orc/pull/523#issuecomment-667629359
Thank you, @nehaljwani . I added you to the group and assigned ORC-650 to
you. Welcome, @nehaljwani ! :)
This i
pgaref commented on pull request #525:
URL: https://github.com/apache/orc/pull/525#issuecomment-667649637
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongjoon-hyun commented on pull request #525:
URL: https://github.com/apache/orc/pull/525#issuecomment-667705588
Thank you, @pgaref .
This is an automated message from the Apache Git Service.
To respond to the message, please
dongjoon-hyun merged pull request #525:
URL: https://github.com/apache/orc/pull/525
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun opened a new pull request #526:
URL: https://github.com/apache/orc/pull/526
### What changes were proposed in this pull request?
### Why are the changes needed?
### How was this patch tested?
--
dongjoon-hyun closed pull request #517:
URL: https://github.com/apache/orc/pull/517
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-667712507
I closed this PR because there is no evidence that build is broken in
clang-10. Please free free to reopen this with the evidence.
-
dongjoon-hyun commented on pull request #526:
URL: https://github.com/apache/orc/pull/526#issuecomment-667722768
Hi, @omalley and @wgtmac .
Could you review this PR, please?
This is an automated message from the Apache Git
dongjoon-hyun closed pull request #493:
URL: https://github.com/apache/orc/pull/493
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on pull request #493:
URL: https://github.com/apache/orc/pull/493#issuecomment-667724755
According to the above discussion, I close this PR for now.
Thank you, @Rajpratik71 and @omalley .
This is an
dongjoon-hyun merged pull request #526:
URL: https://github.com/apache/orc/pull/526
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nikitamikhaylov commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668709736
> I closed this PR because there is no evidence that build is broken in
clang-10. Please free free to reopen this with the evidence.
@dongjoon-hyun Here you are:
https:
nikitamikhaylov edited a comment on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668709736
> I closed this PR because there is no evidence that build is broken in
clang-10. Please free free to reopen this with the evidence.
@dongjoon-hyun Here you are:
dongjoon-hyun commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668825060
It's unnecessarily insulting to me.
> Do you know C++?
As you said, the followings are just esthetic changes.
> Every statement is separated by ; and ; after { means
dongjoon-hyun edited a comment on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668825060
It's unnecessarily insulting to me.
> Do you know C++?
As you said, the followings are just esthetic changes.
> Every statement is separated by ; and ; after
dongjoon-hyun edited a comment on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668825060
It's unnecessarily insulting to me.
> Do you know C++?
As you said, the followings are just esthetic changes.
> Every statement is separated by ; and ; after
dongjoon-hyun commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668826414
Please include your comment on the PR description as `**BEFORE**` section.
- https://github.com/apache/orc/pull/517#issuecomment-668709736
Also, please include the log a
nikitamikhaylov commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668881610
I'm sorry, I didn't mean to offend you with a comment about C++. 😔
For some strange reason I had no notification for comments from this PR.
Will do everything tomorrow.
nikitamikhaylov edited a comment on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-668881610
I'm sorry, I didn't mean to offend you with a comment about C++. 😔
For some strange reason I had no notification for comments from this PR.
Will do everything tom
nikitamikhaylov commented on pull request #517:
URL: https://github.com/apache/orc/pull/517#issuecomment-669054366
:(
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
1 - 100 of 4428 matches
Mail list logo
