Re: [PR] Fix containers inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java [pdfbox]

2024-04-01 Thread via GitHub
cinsttool commented on code in PR #188: URL: https://github.com/apache/pdfbox/pull/188#discussion_r1546241225 ## fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java: ## @@ -161,15 +159,15 @@ private void render() }); } -private List handleType1C

Re: [PR] Fix containers inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java [pdfbox]

2024-04-01 Thread via GitHub
lehmi commented on code in PR #188: URL: https://github.com/apache/pdfbox/pull/188#discussion_r1546231761 ## fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java: ## @@ -161,15 +159,15 @@ private void render() }); } -private List handleType1Comma

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832812#comment-17832812 ] ASF subversion and git services commented on PDFBOX-5660: - Commi

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832810#comment-17832810 ] ASF subversion and git services commented on PDFBOX-5660: - Commi

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832811#comment-17832811 ] ASF subversion and git services commented on PDFBOX-5660: - Commi

Re: [PR] Fix containers inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java [pdfbox]

2024-04-01 Thread via GitHub
cinsttool commented on PR #188: URL: https://github.com/apache/pdfbox/pull/188#issuecomment-2029547059 > > I'm undecided about the first one, I like the second, I don't like the third one because the code looks much more complex. I assume you're hard-coding the usage of the 3-set. >

Re: [PR] Fix containers inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java [pdfbox]

2024-04-01 Thread via GitHub
cinsttool commented on PR #188: URL: https://github.com/apache/pdfbox/pull/188#issuecomment-2029482338 > I'm undecided about the first one, I like the second, I don't like the third one because the code looks much more complex. I assume you're hard-coding the usage of the 3-set. Yes,

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832786#comment-17832786 ] ASF subversion and git services commented on PDFBOX-5660: - Commi

[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832787#comment-17832787 ] ASF subversion and git services commented on PDFBOX-5660: - Commi

Re: [PR] Fix containers inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java [pdfbox]

2024-04-01 Thread via GitHub
THausherr commented on PR #188: URL: https://github.com/apache/pdfbox/pull/188#issuecomment-2029457536 I'm undecided about the first one, I like the second, I don't like the third one because the code looks much more complex. I assume you're hard-coding the usage of the 3-set. -- This is

[PR] Fix containers inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java [pdfbox]

2024-04-01 Thread via GitHub
cinsttool opened a new pull request, #188: URL: https://github.com/apache/pdfbox/pull/188 Hi, We find that there exist container inefficiencies in Type1CharString.java, COSWriterCompressionPool.java, and ShadedTriangle.java. In particular, at line 301 of Type1CharString.java, t