Re: [mp2] pools that go out of scope aren't a problem anymore?

2004-12-01 Thread Joe Schaefer
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes: > my $pool; > sub handler { > my $r = shift; > $pool ||= $r->pool; #XXX: Yes, bad bad bad, but still... > APR::Table::make($pool, 10); #bam! > } > > The problem in this case is that apache destroyed the request pool at > the end of the first

Re: t/perl/ithreads.t revisited

2004-12-01 Thread Philippe M. Chiasson
Stas Bekman wrote: Steve Hay wrote: Next I want you to try cutting off things from startup files and httpd.conf, to find whether it's some unrelated module that is loaded that causes the problem. I suspect that because the sister test t/perl/ithreads2.t doesn't fail, and it runs exactly the same

Re: [mp2] pools that go out of scope aren't a problem anymore?

2004-12-01 Thread Philippe M. Chiasson
Stas Bekman wrote: Stas Bekman wrote: I've rebuit with --enable-pool-debug CPPFLAGS="-DAPR_BUCKET_DEBUG", but also apr1/httpd2.1 % ~/perl/5.8.x/bin/perl -MApache2 -MAPR::Pool -MAPR::Table -wle ' $t= APR::Table::make(APR::Pool->new, 10); $t->set($_=>$_), print "Set $_" for 1..20' Segment

Re: plans for mp2.0.0 release schedule

2004-12-01 Thread Philippe M. Chiasson
Stas Bekman wrote: There are a few issues left, which are hopefully will be resolved shortly. I'd like to hear your opinion on RC1...N...release schedule. I see it as follows: Get RC1 out in a few days (even while we still have a few issues left, but those are all new features (mostly not affect

Re: plans for mp2.0.0 release schedule

2004-12-01 Thread David Wheeler
On Dec 1, 2004, at 7:31 PM, Stas Bekman wrote: Your thoughts? +1 David smime.p7s Description: S/MIME cryptographic signature

plans for mp2.0.0 release schedule

2004-12-01 Thread Stas Bekman
There are a few issues left, which are hopefully will be resolved shortly. I'd like to hear your opinion on RC1...N...release schedule. I see it as follows: Get RC1 out in a few days (even while we still have a few issues left, but those are all new features (mostly not affecting the API), which

Re: Apache::SizeLimit name change?

2004-12-01 Thread David Wheeler
On Dec 1, 2004, at 2:34 PM, Stas Bekman wrote: But of course you could just keep it Apache::SizeLimit and save people the trouble changing their habits. I'm in favor of this suggestion. Cheers, David - To unsubscribe, e-mail: [EMA

Re: svn commit: r109383 - /perl/modperl/trunk/Changes /perl/modperl/trunk/Makefile.PL

2004-12-01 Thread Stas Bekman
Philippe M. Chiasson wrote: [... Yes, I just looked at the patch and didn't quite see the whole context of the code. I guess it makes sense the way it is. :) Remind me please why did we add this wrapper? I think it used to be something more complex but now it's really just $self->{MP_USE_STATIC}

Re: svn commit: r109383 - /perl/modperl/trunk/Changes /perl/modperl/trunk/Makefile.PL

2004-12-01 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: [EMAIL PROTECTED] wrote: else { +unless ($build->{MP_USE_STATIC}) { This one check has been standardized as $build->should_build_apache(); Right, but since: sub should_build_apache { my ($self) = @_; return $self->{MP_USE_STATIC

svn commit: r109391 - /perl/modperl/trunk/todo/release

2004-12-01 Thread stas
Author: stas Date: Wed Dec 1 14:47:07 2004 New Revision: 109391 URL: http://svn.apache.org/viewcvs?view=rev&rev=109391 Log: shrink the baby Modified: perl/modperl/trunk/todo/release Modified: perl/modperl/trunk/todo/release Url: http://svn.apache.org/viewcvs/perl/modperl/trunk/todo/release?

Re: [mp2] make test problems when configuring against source

2004-12-01 Thread Stas Bekman
Stas Bekman wrote: Randy Kobes wrote: I think whatever is best for Unix would be fine for Win32. Win32 installations are pretty standard, so specifying one of MP_AP_PREFIX (the top-level installed directory) or the path to the installed Apache.exe (or the path to an installed apxs, if it exists) wo

Re: Apache::SizeLimit name change?

2004-12-01 Thread Stas Bekman
Perrin Harkins wrote: On Wed, 2004-12-01 at 17:25 -0500, Stas Bekman wrote: may be Apache::Monitor::Size (as Limit sort of conflicts with Monitor in action-wise). On the other hand it's more than a monitor, since it takes actions since monitors normally don't (e.g. Apache::VMonitor). if you agre

Re: svn commit: r109383 - /perl/modperl/trunk/Changes /perl/modperl/trunk/Makefile.PL

2004-12-01 Thread Stas Bekman
Philippe M. Chiasson wrote: [EMAIL PROTECTED] wrote: else { +unless ($build->{MP_USE_STATIC}) { This one check has been standardized as $build->should_build_apache(); Right, but since: sub should_build_apache { my ($self) = @_; return $self->{MP_USE_STATIC} ? 1 : 0; } if you

Re: Apache::SizeLimit name change?

2004-12-01 Thread Perrin Harkins
On Wed, 2004-12-01 at 17:25 -0500, Stas Bekman wrote: > may be Apache::Monitor::Size (as Limit sort of conflicts with Monitor in > action-wise). On the other hand it's more than a monitor, since it takes > actions since monitors normally don't (e.g. Apache::VMonitor). if you > agree with that lo

Re: Apache::SizeLimit name change?

2004-12-01 Thread Stas Bekman
Perrin Harkins wrote: Should we change the name of the new Apache::SizeLimit to Apache::Monitor::SizeLimit, as described in the naming conventions doc, or do you think it's better to keep it as is to avoid confusion? may be Apache::Monitor::Size (as Limit sort of conflicts with Monitor in action-w

Apache::SizeLimit name change?

2004-12-01 Thread Perrin Harkins
Should we change the name of the new Apache::SizeLimit to Apache::Monitor::SizeLimit, as described in the naming conventions doc, or do you think it's better to keep it as is to avoid confusion? - Perrin - To unsubscribe, e-mail

Re: svn commit: r109383 - /perl/modperl/trunk/Changes /perl/modperl/trunk/Makefile.PL

2004-12-01 Thread Philippe M. Chiasson
[EMAIL PROTECTED] wrote: Author: stas Date: Wed Dec 1 14:00:15 2004 New Revision: 109383 URL: http://svn.apache.org/viewcvs?view=rev&rev=109383 Log: If none of MP_APXS, MP_AP_PREFIX and MP_USE_STATIC were specified when configuring Makefile.PL, we now prompt for APXS path first and only if that fa

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Stas Bekman
Joe Orton wrote: On Wed, Dec 01, 2004 at 10:43:22AM -0500, Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: One needs to go through a deprecation cycle before any backwards compatibility in the same generation of the project can be dropped. Heh, a search for "deprecation cycle" on marc'

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Stas Bekman
Joe Schaefer wrote: Joe Orton <[EMAIL PROTECTED]> writes: On Wed, Dec 01, 2004 at 10:43:22AM -0500, Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: One needs to go through a deprecation cycle before any backwards compatibility in the same generation of the project can be dropped. Heh,

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Joe Schaefer
Joe Orton <[EMAIL PROTECTED]> writes: > On Wed, Dec 01, 2004 at 10:43:22AM -0500, Joe Schaefer wrote: >> Stas Bekman <[EMAIL PROTECTED]> writes: >> >> > One needs to go through a deprecation cycle before any backwards >> > compatibility in the same generation of the project can be dropped. >> >>

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Geoffrey Young
>>so, if I understand the debate, it's whether this ability should remain >>solely with mod_proxy, or whether other modules should be allowed to decide >>whether they should set 'ProxyRequest On' at runtime. >> >>is that right? > > > Yup. I guess I could go either way. part of me thinks that

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Joe Orton
On Wed, Dec 01, 2004 at 10:43:22AM -0500, Joe Schaefer wrote: > Stas Bekman <[EMAIL PROTECTED]> writes: > > > One needs to go through a deprecation cycle before any backwards > > compatibility in the same generation of the project can be dropped. > > Heh, a search for "deprecation cycle" on marc'

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Joe Orton
On Wed, Dec 01, 2004 at 10:59:22AM -0500, Geoffrey Young wrote: ... > now, I _think_ joes argument is that for the second part the server should > be required to set 'ProxyRequest On' in httpd.conf, which indicates the > arrangement the client and server have agreed upon. Yes, that's an accurate s

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Geoffrey Young
>> Well, convince me that it's useful decide it dynamically. If the client >> is not configured to use the server as a forward proxy, and the server >> is not configured up-front to act as a forward proxy, when does it make >> sense to treat a request as being "forward proxied"? >> Whether or not

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > One needs to go through a deprecation cycle before any backwards > compatibility in the same generation of the project can be dropped. Heh, a search for "deprecation cycle" on marc's [EMAIL PROTECTED] archives comes up empty. -- Joe Schaefer --

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Stas Bekman
Joe Orton wrote: On Wed, Dec 01, 2004 at 09:40:54AM -0500, Stas Bekman wrote: Joe Orton wrote: On Fri, Nov 26, 2004 at 04:37:49PM -0500, Stas Bekman wrote: I can't recall whether this was discussed before, but t/modules/proxy.t fails with httpd-2.1. Is anybody following the mod_proxy changes? I'

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Joe Orton
On Wed, Dec 01, 2004 at 09:40:54AM -0500, Stas Bekman wrote: > Joe Orton wrote: > >On Fri, Nov 26, 2004 at 04:37:49PM -0500, Stas Bekman wrote: > > > >>I can't recall whether this was discussed before, but t/modules/proxy.t > >>fails with httpd-2.1. Is anybody following the mod_proxy changes? > >

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Stas Bekman
Joe Orton wrote: On Fri, Nov 26, 2004 at 04:37:49PM -0500, Stas Bekman wrote: I can't recall whether this was discussed before, but t/modules/proxy.t fails with httpd-2.1. Is anybody following the mod_proxy changes? I'll note that this may get fixed such that it only works for enabling a reverse-

Re: t/modules/proxy.t fails with httpd-2.1

2004-12-01 Thread Joe Orton
On Fri, Nov 26, 2004 at 04:37:49PM -0500, Stas Bekman wrote: > I can't recall whether this was discussed before, but t/modules/proxy.t > fails with httpd-2.1. Is anybody following the mod_proxy changes? I'll note that this may get fixed such that it only works for enabling a reverse-proxy "decisi