Re: [mp2] directive/setupenv.t test on Win32

2004-12-11 Thread Randy Kobes
On Sat, 11 Dec 2004, Stas Bekman wrote: > Right, to make it a good test we need to know what env var exist but > wasn't passed. And since in t/directive/setupenv.t we can actually access > %ENV which should be a complete copy of shell env, it's easier to make a > more sensible test. > > So for exa

[RELEASE CANDIDATE] mod_perl-2.0.0 RC1

2004-12-11 Thread Philippe M. Chiasson
a long awaited release candidate for mod_perl 2.0.0 is now available for testing. please grab the candidate from: http://www.apache.org/~gozer/mp2/mod_perl-2.0.0/mod_perl-2.0.0-RC1.tar.gz MD5: d069e5d442ae7d75cd4a366fb65ab125 SHA1: ad4537a9799a5b812136863f9c95d94c13a52d04 and report back successes

Re: [Patch mp2] PerlConfigRequire & PerlPostConfigRequire ( was: a new directive: PerlStartupFile? )

2004-12-11 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: After some talk about exactly what to call these directive, here is a patch. It's late, so it doesn't include docs or tests, but it should give a good idea of what's required to get this working. PerlConfigRequire is basically just PerlRequire with

Re: PerlInterpreter and USE_ITHREADS

2004-12-11 Thread Stas Bekman
Randy Kobes wrote: In APR__Pool.h and Apache__ServerUtil.h, should the PerlInterpreter structure member be surrounded by an #ifdef USE_ITHREADS: Index: xs/APR/Pool/APR__Pool.h ==

PerlInterpreter and USE_ITHREADS

2004-12-11 Thread Randy Kobes
In APR__Pool.h and Apache__ServerUtil.h, should the PerlInterpreter structure member be surrounded by an #ifdef USE_ITHREADS: Index: xs/APR/Pool/APR__Pool.h === --- xs/APR/Pool/A

Re: version syntax for mp2

2004-12-11 Thread Stas Bekman
[CC'ing John Peacock] John, I think we need your help here, see the story below. But in short we want to start using triplet versioning for modperl 2.0.x and we don't want to require version.pm, since so far we don't have any external dependencies. Can we do that? mp2 requires 5.6.1+. Thanks.

Re: moving mpxs_cleanup_t and mpxs_cleanup_run to modperl_common_util

2004-12-11 Thread Stas Bekman
Randy Kobes wrote: Heh, I did that part too and but gave up on the modperl_opt_interp_unselect :) I forgot to mention that I've stopped there, because I won't have been able to see any problems, since on linux the linker doesn't complain about missing but unused symbols. What I don't get is how

Re: [mp2] directive/setupenv.t test on Win32

2004-12-11 Thread Stas Bekman
Randy Kobes wrote: On Sat, 11 Dec 2004, Stas Bekman wrote: Randy Kobes wrote: On Win32, the last subtest of t/directive/setupenv.t tests that $env{HOME} doesn't exist. However, as we've discussed before in some other contexts, for some reason Win32 does pass, in particular, the HOME environment va

Re: version syntax for mp2

2004-12-11 Thread Stas Bekman
[subject change] Philippe M. Chiasson wrote: [...] Now versioning. First of all mp2 is going to be 2.0.x, since it looks like Apache 2.2 might be different enough that modperl-2.2.x will appear. We can't give interim RCs $VERSION = 2.0.0 since once we release 2.0 we can't change any API, with RC

Re: [mp2] directive/setupenv.t test on Win32

2004-12-11 Thread Randy Kobes
On Sat, 11 Dec 2004, Stas Bekman wrote: > Randy Kobes wrote: > > On Win32, the last subtest of t/directive/setupenv.t tests > > that $env{HOME} doesn't exist. However, as we've discussed > > before in some other contexts, for some reason Win32 does > > pass, in particular, the HOME environment var

Re: [Patch mp2] PerlConfigRequire & PerlPostConfigRequire ( was: a new directive: PerlStartupFile? )

2004-12-11 Thread Stas Bekman
Philippe M. Chiasson wrote: After some talk about exactly what to call these directive, here is a patch. It's late, so it doesn't include docs or tests, but it should give a good idea of what's required to get this working. PerlConfigRequire is basically just PerlRequire with an immediate perl

Re: [mp2] Apache::SizeLimit compilation failure on OS X with trunk

2004-12-11 Thread Stas Bekman
Christian Hansen wrote: Apache::SizeLimit does not recognize OS X (darwin) and dies at compilation phase. waiting 120 seconds for server to start: .[Sat Dec 11 10:56:10 2004] [info] 7 Apache:: modules loaded [Sat Dec 11 10:56:10 2004] [info] 0 APR:: modules loaded [Sat Dec 11 10:56:10 2004] [inf

Re: [mp2] directive/setupenv.t test on Win32

2004-12-11 Thread Stas Bekman
Randy Kobes wrote: On Win32, the last subtest of t/directive/setupenv.t tests that $env{HOME} doesn't exist. However, as we've discussed before in some other contexts, for some reason Win32 does pass, in particular, the HOME environment variable, if it's set. I have HOME set, and consequently, this

Re: [mp2] callback returning bogus error code don't log the error

2004-12-11 Thread Stas Bekman
OK, so I've committed a change which does the following for open_logs|post_config: - if there is an error in running the handler, it gets logged as before - otherwise if the return code is not OK, an appropriate error is logged as well --

[mp2] Apache::SizeLimit compilation failure on OS X with trunk

2004-12-11 Thread Christian Hansen
Apache::SizeLimit does not recognize OS X (darwin) and dies at compilation phase. waiting 120 seconds for server to start: .[Sat Dec 11 10:56:10 2004] [info] 7 Apache:: modules loaded [Sat Dec 11 10:56:10 2004] [info] 0 APR:: modules loaded [Sat Dec 11 10:56:10 2004] [info] base server + 29 vhost