Github user samarthjain closed the pull request at:
https://github.com/apache/phoenix/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/232#discussion_r102769336
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/tuple/PositionBasedMultiKeyValueTuple.java
---
@@ -0,0 +1,86
Github user samarthjain commented on the issue:
https://github.com/apache/phoenix/pull/232
@jtaylor-sfdc @twdsilva please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user samarthjain opened a pull request:
https://github.com/apache/phoenix/pull/232
Pull request for merging the encode columns branch to 4.x-HBase-0.98
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/phoenix
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/commit/11c0c3b7b40f34f130554363a85ef0de7edd31a3#commitcomment-20281443
hey Thomas, can you tell me more about the test failure that this fixes. My
local test run was successful. Did it fail after
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74842947
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -10,10 +10,7 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74842182
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SubqueryUsingSortMergeJoinIT.java
---
@@ -66,16 +66,16 @@
@RunWith
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74841351
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanAfterManualSplitIT.java
---
@@ -43,7 +43,7 @@
import
Github user samarthjain commented on the issue:
https://github.com/apache/phoenix/pull/189
This looks great now @prakul. Did you also make the changes for the test
classes where there are member variables for storing table names? The best way
to handle those would be to declare
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74808858
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -482,20 +482,22 @@ public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74678543
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -23,6 +23,7 @@
import static
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74652145
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java ---
@@ -76,24 +76,18 @@
import com.google.common.collect.Maps
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651889
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -354,27 +355,29 @@ public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651475
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -515,22 +531,27 @@ public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74651437
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
@@ -461,14 +472,19 @@ public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74637772
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertBigValuesIT.java ---
@@ -62,7 +62,7 @@ public void testIntegerPK() throws Exception
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74636561
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantIdTypeIT.java ---
@@ -74,7 +74,8 @@ public TenantIdTypeIT(String dataType, String
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74631717
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ---
@@ -39,10 +39,10 @@
import
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74523807
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanQueryIT.java ---
@@ -246,15 +248,15 @@ public void testVarCharXIntInQuery() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74523759
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SkipScanQueryIT.java ---
@@ -111,10 +113,10 @@ private void initSelectAfterUpsertTable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74335513
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SpooledTmpFileDeleteIT.java
---
@@ -38,11 +38,12 @@
-public class
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74335011
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorIT.java
---
@@ -65,7 +65,7 @@
public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74313800
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ReverseScanIT.java ---
@@ -52,11 +52,11 @@
import com.google.common.collect.Maps
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74313609
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ReverseScanIT.java ---
@@ -52,11 +52,11 @@
import com.google.common.collect.Maps
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312995
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RegexpSubstrFunctionIT.java
---
@@ -33,13 +33,15 @@
import org.junit.Test
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312941
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/RegexpReplaceFunctionIT.java
---
@@ -33,13 +33,15 @@
import org.junit.Test
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312842
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryIT.java
---
@@ -148,7 +148,7 @@ public void testToDateOnString() throws Exception
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312676
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -61,7 +61,7 @@
protected static final String tenantId
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312374
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
---
@@ -1066,7 +1065,7 @@ public void testAddPKColumn
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312396
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
---
@@ -1106,7 +1105,7 @@ public void testDropKVColumn
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74312230
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRuntimeIT.java ---
@@ -95,53 +96,62 @@ private static Filter
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74311348
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/LnLogFunctionEnd2EndIT.java
---
@@ -33,10 +33,12 @@
/**
* End to end tests
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74310790
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinMoreIT.java ---
@@ -43,7 +43,7 @@
import com.google.common.collect.Maps
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74310422
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExtendedQueryExecIT.java ---
@@ -51,7 +51,7 @@ public void testToDateFunctionBind() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74310182
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExpFunctionEnd2EndIT.java
---
@@ -34,21 +34,26 @@
/**
* End to end tests
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74309672
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicColumnIT.java ---
@@ -59,16 +59,18 @@
*/
-public class
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74307945
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DateTimeIT.java ---
@@ -18,20 +18,7 @@
package org.apache.phoenix.end2end
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74308894
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ---
@@ -72,7 +72,7 @@ public DerivedTableIT(String[] indexDDL, String
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74307236
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CSVCommonsLoaderIT.java ---
@@ -45,15 +45,15 @@
import
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74308491
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DateTimeIT.java ---
@@ -57,12 +44,13 @@
import org.junit.Test
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74306317
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -61,7 +61,7 @@
protected static final String tenantId
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74306178
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseQueryIT.java ---
@@ -90,7 +90,8 @@ public BaseQueryIT(String indexDDL
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74305946
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseHBaseManagedTimeTableReuseIT.java
---
@@ -47,6 +48,10 @@
@NotThreadSafe
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74304816
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1052,16 +1057,20 @@ private static void deletePriorSequences(long ts
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74304218
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AppendOnlySchemaIT.java ---
@@ -274,36 +285,15 @@ public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r73924877
--- Diff: pom.xml ---
@@ -226,6 +226,7 @@
maven-failsafe-plugin
${maven-failsafe-plugin.version
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r73924704
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -2063,5 +2080,35 @@ protected static void
populateMultiCFTestTable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r73924614
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -2063,5 +2080,35 @@ protected static void
populateMultiCFTestTable
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209605592
This looks great now @ankitsinghal. I am +1 once you have addressed the
last review comments. Thanks a lot for your patience and diligence!
---
If your project
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59608279
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2387,8 +2452,27 @@ public Void call() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59607658
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -77,6 +79,7 @@ public SQLException newException
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59607039
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/IllegalOperationException.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-209161997
Thanks for the updated request, @ankitsinghal. Almost there! Can you tell
me more about what would happen in the following scenario if the name space
feature
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59307776
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableKey.java ---
@@ -26,7 +28,8 @@
public PTableKey(PName tenantId, String
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/153#issuecomment-208573524
@ankitsinghal - thanks for adding the upgrade util test. I have a
question/suggestion: we should probably disallow users to execute create and
use schema
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/158#issuecomment-207594418
@churrodog - can you please post a rebased patch on the jira. The current
patch doesn't apply on master. Thanks!
---
If your project is set up for it, you can
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/158#issuecomment-207591521
Thanks @churrodog. Nice work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59082461
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -265,12 +332,18 @@ public SingleTableColumnResolver
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58990926
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/tx/TxCheckpointIT.java ---
@@ -96,6 +97,7 @@ public void testUpsertSelectDoesntSeeUpsertedData
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58990747
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java ---
@@ -632,6 +645,16 @@ public static ExecutionCommand parseArgs
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58990594
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java
---
@@ -63,6 +64,10 @@ public static
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58990540
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableKey.java ---
@@ -26,7 +28,8 @@
public PTableKey(PName tenantId, String
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58989689
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -631,7 +664,7 @@ private boolean
addIndexesFromPhysicalTable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58989498
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
@@ -133,11 +135,13 @@
// latency and client-side
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58989392
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2387,8 +2452,27 @@ public Void call() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58988872
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/ipc/controller/MetadataRpcController.java
---
@@ -36,7 +37,16
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58987883
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
---
@@ -190,14 +190,8 @@ public void testSchemaMetadataScan
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58986201
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -265,12 +332,18 @@ public SingleTableColumnResolver
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/158#issuecomment-206989941
The pull request looks great @churrodog. Just a couple of minor nits. I
will get this committed once you have the changes in.
---
If your project is set up
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/158#discussion_r58903054
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java
---
@@ -94,6 +85,20 @@ private long allocateBytes(long minBytes
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/158#discussion_r58902469
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java ---
@@ -69,35 +76,38 @@ private static void sleepFor(long time
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/158#discussion_r58902347
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java ---
@@ -19,19 +19,26 @@
import static
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58597202
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58594903
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58594707
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469369
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469290
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469125
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469055
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58468877
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58468394
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58468008
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean truncateStats
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58467711
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -897,4 +941,86 @@ public static boolean hasRowTimestampColumn(PTable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58467374
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -897,4 +941,86 @@ public static boolean hasRowTimestampColumn(PTable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58465875
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -825,9 +825,25 @@ protected static void ensureTableCreated(String url
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58465248
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -265,12 +332,18 @@ public SingleTableColumnResolver
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58118836
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -3201,4 +3367,155 @@ private
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58118513
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -3201,4 +3367,155 @@ private
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58117768
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -3201,4 +3367,155 @@ private
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58117686
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -3201,4 +3367,155 @@ private
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58117457
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2910,6 +3026,16 @@ private static
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58116856
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -3201,4 +3367,155 @@ private
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57373598
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -958,6 +973,32 @@ private boolean
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57373401
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -958,6 +973,32 @@ private boolean
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57373091
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -634,15 +642,19 @@ private PMetaData
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57372836
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PSchemaKey.java ---
@@ -0,0 +1,67 @@
+/*
--- End diff --
Where
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57372367
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3301,4 +3356,86 @@ private PTable getParentOfView(PTable view
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57371949
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1115,6 +1212,24 @@ private PFunction
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57371653
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -544,7 +556,28 @@ private MetaDataMutationResult updateCache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57371542
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/PSchema.java
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 192 matches
Mail list logo
