Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64124279
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -165,6 +165,9 @@ public RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64124199
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -292,6 +294,119 @@ private static void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64123714
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64123637
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2455,6 +2409,19 @@ public Void call() throws
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-219630101
Looks very good, @chrajeshbabu! Thanks so much for this. Are you ok making
the changes I mentioned?
---
If your project is set up for it, you can reply to this
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63469708
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2455,6 +2409,19 @@ public Void call() throws
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63469452
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
---
@@ -667,4 +651,28 @@ public static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63469161
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -707,16 +702,17 @@ public void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63468900
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-219617896
James as we discussed I have made a patch working with older versions of
HBase first and handled review comments here. Will create new pull request with
that
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463623
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -160,6 +163,9 @@ public void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463618
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
---
@@ -116,7 +117,10 @@ public void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463584
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1016,7 +1016,7 @@ private MutationState
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463462
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java ---
@@ -297,4 +297,28 @@ public boolean checkAndDelete(byte[] row,
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463482
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -861,7 +871,12 @@ public Put
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463350
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -202,7 +207,10 @@ protected
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463302
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62710798
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
---
@@ -116,7 +117,10 @@ public void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62710902
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -160,6 +163,9 @@ public void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62700523
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1016,7 +1016,7 @@ private MutationState
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62699657
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
@@ -198,8 +198,14 @@ private void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62699243
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -861,7 +871,12 @@ public Put
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62698174
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java ---
@@ -297,4 +297,28 @@ public boolean checkAndDelete(byte[] row,
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62698009
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -202,7 +207,10 @@ protected
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62697744
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -165,6 +165,9 @@ public RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r62696240
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception {
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-218194916
How about a version that doesn't depend on HBASE-15600 so that we can
continue to support older versions of HBase (and can do a 4.8 release)? What
we've typically
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/168
PHOENIX-1734 Local index improvements(Rajeshbabu)
This is the patch for new implementation of local index where we store
local index data in the separate column families in the same table
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/135#issuecomment-160852616
Couple of other comments:
- You'll need to add code during installation of 4.7.0 (in
ConnectionQueryServicesImpl.init()) that takes care of removing old
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096442
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte[][]
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096395
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java ---
@@ -873,7 +873,7 @@ public void initTable() throws Exception {
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096275
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
---
@@ -186,7 +186,9 @@ private void testDeleteRange(boolean autoCommit,
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096413
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -80,6 +81,9 @@ public Reader
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096617
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -158,6 +162,10 @@ public
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096509
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java ---
@@ -873,7 +873,7 @@ public void initTable() throws Exception {
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096498
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -158,6 +162,10 @@ public
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096704
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte[][]
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46111214
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -158,6 +162,10 @@ public
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46111265
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte[][]
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46085683
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
---
@@ -186,7 +186,9 @@ private void testDeleteRange(boolean autoCommit,
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46085787
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte[][]
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46085765
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -80,6 +81,9 @@ public Reader
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46085866
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -158,6 +162,10 @@ public
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46085722
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java ---
@@ -873,7 +873,7 @@ public void initTable() throws Exception {
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/135
PHOENIX-1734 Local index improvements
Patch supports storing local indexing data in the same data table.
1) Removed code used HBase internals in balancer, split and merge.
2) Create
45 matches
Mail list logo
