[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-102079613 thanks everyone, sorry I have had little connectivity the last couple of days. I will adress new feedback right away --- If your project is set up for it, you can rep

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-102078845 @ddraj - I left feedback and it was never responded to or implemented. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user ddraj commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-101949365 Ping @JamesRTaylor @mravi .. Any more inputs for @nmaillard ? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-100843474 Have made the changes per the first feedback, let me know if there is anything else --- If your project is set up for it, you can reply to this email and have your re

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r30007221 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/PhoenixHiveConfiguration.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache So

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r30007211 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/PhoenixHiveConfiguration.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache So

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r30007153 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConfigurationUtil.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r30006953 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixStorageHandler.java --- @@ -0,0 +1,147 @@ +/* + * Copyright 2010 The Apache Softwar

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r30006906 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordReader.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r30006897 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConnectionUtil.java --- @@ -0,0 +1,161 @@ +/* + * Copyright 2010 The Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-100526103 @mravi - would you mind giving this a review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-100526094 This is looking good, @nmaillard. Still some copy/paste code that we should aim to cleanup. Also, take care that no exceptions are swallowed. Wrap checked exception

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994962 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/PhoenixUtil.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994951 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/PhoenixUtil.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994945 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/PhoenixUtil.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994928 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConnectionUtil.java --- @@ -0,0 +1,161 @@ +/* + * Copyright 2010 The Apach

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994905 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixStorageHandler.java --- @@ -0,0 +1,147 @@ +/* + * Copyright 2010 The Apache

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994876 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConnectionUtil.java --- @@ -0,0 +1,161 @@ +/* + * Copyright 2010 The Apach

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29994860 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordReader.java --- @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache S

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29261031 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveTypeUtil.java --- @@ -0,0 +1,151 @@ +/* + * Copyright 2010 The Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29259215 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixSerde.java --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29096976 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveTypeUtil.java --- @@ -0,0 +1,151 @@ +/* + * Copyright 2010 The Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29096970 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConfigurationUtil.java --- @@ -0,0 +1,275 @@ +/* + * Licensed to the Apach

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29096962 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixSerde.java --- @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29044634 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConnectionUtil.java --- @@ -0,0 +1,161 @@ +/* + * Copyright 2010 The Apache S

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29044389 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordReader.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Soft

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29038991 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixOutputCommitter.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache So

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29038931 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputFormat.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29038603 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputSplit.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Softwa

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29030806 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordWriter.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29030493 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user nmaillard commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29030194 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordWriter.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user ddraj commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29026147 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordWriter.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user ddraj commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29026068 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordWriter.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on the pull request: https://github.com/apache/phoenix/pull/74#issuecomment-95799980 Thanks a lot for the patch @nmaillard . Couple of additional minor fixes 1) Couple of classes have your name as the author. Please remove it. 2) Certain classes have

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023563 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/PhoenixHiveConfiguration.java --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache So

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023552 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConnectionUtil.java --- @@ -0,0 +1,161 @@ +/* + * Copyright 2010 The Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023545 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConfigurationUtil.java --- @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Softw

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023526 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java --- @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023421 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordReader.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023429 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordWriter.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023418 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixOutputFormat.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023417 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputFormat.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache So

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023409 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixOutputCommitter.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Softwa

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023412 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixOutputFormat.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user mravi commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29023350 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputFormat.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user ddraj commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29018370 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixRecordReader.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user ddraj commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29017940 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputSplit.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software F

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

Github user ddraj commented on a diff in the pull request: https://github.com/apache/phoenix/pull/74#discussion_r29012278 --- Diff: phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputFormat.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software

[GitHub] phoenix pull request: Phoenix 331- Phoenix-Hive initial commit

GitHub user nmaillard opened a pull request: https://github.com/apache/phoenix/pull/74 Phoenix 331- Phoenix-Hive initial commit You can merge this pull request into a Git repository by running: $ git pull https://github.com/nmaillard/phoenix PHOENIX-331 Alternatively you can