[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481895#comment-14481895 ] Hudson commented on PHOENIX-1580: - FAILURE: Integrated in Phoenix-master #666 (See [htt

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481635#comment-14481635 ] Alicia Ying Shu commented on PHOENIX-1580: -- Never mind. > Support UNION ALL >

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481634#comment-14481634 ] Alicia Ying Shu commented on PHOENIX-1580: -- Never mind. > Support UNION ALL >

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481626#comment-14481626 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Based on V9 or V8 pa

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481584#comment-14481584 ] James Taylor commented on PHOENIX-1580: --- Yes, [~ayingshu] - please implement PHOEN

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481528#comment-14481528 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Please let me know i

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481423#comment-14481423 ] Hudson commented on PHOENIX-1580: - FAILURE: Integrated in Phoenix-master #665 (See [htt

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396353#comment-14396353 ] Maryann Xue commented on PHOENIX-1580: -- Thanks for the patch for PHOENIX-1809, Jame

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396320#comment-14396320 ] James Taylor commented on PHOENIX-1580: --- FYI, I've already done PHOENIX-1809. I wa

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396269#comment-14396269 ] Maryann Xue commented on PHOENIX-1580: -- Sure, I'll do PHOENIX-1809 before this one.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396268#comment-14396268 ] Maryann Xue commented on PHOENIX-1580: -- I fixed that in my second patch (v4). The e

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396010#comment-14396010 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] > Support UNION ALL

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395910#comment-14395910 ] Maryann Xue commented on PHOENIX-1580: -- And just to answer your previous question.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395863#comment-14395863 ] James Taylor commented on PHOENIX-1580: --- Yes, your patch applied. Maryann is going

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395577#comment-14395577 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] I can also work on Un

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395576#comment-14395576 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Did my latest patch

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395528#comment-14395528 ] Alicia Ying Shu commented on PHOENIX-1580: -- Here is the place we can set flags

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395507#comment-14395507 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Added another Phoeni

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395481#comment-14395481 ] James Taylor commented on PHOENIX-1580: --- [~ayingshu] - please just rebase your pat

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395476#comment-14395476 ] Maryann Xue commented on PHOENIX-1580: -- This is what I put in ParseNodeFactory.sele

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395469#comment-14395469 ] Maryann Xue commented on PHOENIX-1580: -- [~jamestaylor] Was going to either wait for

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395458#comment-14395458 ] James Taylor commented on PHOENIX-1580: --- Patch doesn't apply to master if I do the

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395407#comment-14395407 ] James Taylor commented on PHOENIX-1580: --- [~maryannxue] - would you mind taking a l

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395401#comment-14395401 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor], [~maryannxue], Subm

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395390#comment-14395390 ] James Taylor commented on PHOENIX-1580: --- No, that's ok. That one wasn't correct ei

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395290#comment-14395290 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] It looks ok before t

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395286#comment-14395286 ] James Taylor commented on PHOENIX-1580: --- No, that's not correct. The inner query p

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395264#comment-14395264 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] I made the changes.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395218#comment-14395218 ] James Taylor commented on PHOENIX-1580: --- Here's the complete MergeSortTopNResultIt

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395208#comment-14395208 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] In MergeSortTopNResu

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395169#comment-14395169 ] Alicia Ying Shu commented on PHOENIX-1580: -- If I took off the NULL check, the f

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395170#comment-14395170 ] Alicia Ying Shu commented on PHOENIX-1580: -- If I took off the NULL check, the f

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395156#comment-14395156 ] James Taylor commented on PHOENIX-1580: --- I'm trying to find out which tests specif

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395141#comment-14395141 ] James Taylor commented on PHOENIX-1580: --- Please share the code of the fix you made

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395126#comment-14395126 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor], [~maryannxue] Here

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395106#comment-14395106 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] I made the changes.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395101#comment-14395101 ] James Taylor commented on PHOENIX-1580: --- It's a 3 line fix. You could have fixed i

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395092#comment-14395092 ] Alicia Ying Shu commented on PHOENIX-1580: -- Filed PHOENIX-1808 to fix explain p

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395082#comment-14395082 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] For the explain issu

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395083#comment-14395083 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] For the explain issu

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394964#comment-14394964 ] James Taylor commented on PHOENIX-1580: --- I've found a less brittle way (as sometim

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394955#comment-14394955 ] Maryann Xue commented on PHOENIX-1580: -- String comparison should be used to compare

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394949#comment-14394949 ] Maryann Xue commented on PHOENIX-1580: -- Thanks for the information, [~jamestaylor]!

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394947#comment-14394947 ] Maryann Xue commented on PHOENIX-1580: -- Catch with the specific Exception class ins

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394924#comment-14394924 ] James Taylor commented on PHOENIX-1580: --- FYI, [~maryannxue] - if a RuntimeExceptio

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394922#comment-14394922 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Appreciate your revi

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394921#comment-14394921 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Appreciate your revi

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394907#comment-14394907 ] Maryann Xue commented on PHOENIX-1580: -- Filed PHOENIX-1807 for subquery support of

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394890#comment-14394890 ] Maryann Xue commented on PHOENIX-1580: -- +1 to [~jamestaylor]'s comment "You shouldn

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394782#comment-14394782 ] James Taylor commented on PHOENIX-1580: --- A couple more comments in this test: {cod

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394775#comment-14394775 ] James Taylor commented on PHOENIX-1580: --- bq. Need to check null otherwise tests co

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394168#comment-14394168 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor], [~maryannxue], Than

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394167#comment-14394167 ] Alicia Ying Shu commented on PHOENIX-1580: -- I assume nPlans * 30 and nPlans * 1

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394023#comment-14394023 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] Do you mean removing

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394019#comment-14394019 ] James Taylor commented on PHOENIX-1580: --- Always good when you construct any kind o

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394012#comment-14394012 ] Maryann Xue commented on PHOENIX-1580: -- [~ayingshu] Could you please make sure that

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393999#comment-14393999 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Sorry about this. Do

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393984#comment-14393984 ] James Taylor commented on PHOENIX-1580: --- Still didn't do this, [~ayingshu] (third

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393981#comment-14393981 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Replaced the last pa

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393885#comment-14393885 ] James Taylor commented on PHOENIX-1580: --- [~ayingshu] - the plans member variable c

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393836#comment-14393836 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] found out that the r

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393626#comment-14393626 ] James Taylor commented on PHOENIX-1580: --- I see - yes that's not right. Put that in

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393608#comment-14393608 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] It is a regression w

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393396#comment-14393396 ] James Taylor commented on PHOENIX-1580: --- Would you mind posting a query and sample

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393386#comment-14393386 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Filed PHOENIX-1804 f

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393307#comment-14393307 ] James Taylor commented on PHOENIX-1580: --- That's a good suggestion, [~maryannxue] a

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393290#comment-14393290 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] iterators.explain(st

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393292#comment-14393292 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] iterators.explain(st

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393266#comment-14393266 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] do you mind being mor

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393229#comment-14393229 ] Maryann Xue commented on PHOENIX-1580: -- One minor change to the explain plan maybe,

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393212#comment-14393212 ] James Taylor commented on PHOENIX-1580: --- Good question, [~ayingshu]. Keep your imp

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393154#comment-14393154 ] Alicia Ying Shu commented on PHOENIX-1580: -- So I recommend you implement explai

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393155#comment-14393155 ] Alicia Ying Shu commented on PHOENIX-1580: -- So I recommend you implement explai

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393020#comment-14393020 ] James Taylor commented on PHOENIX-1580: --- Thanks for the revisions, [~ayingshu]. He

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392964#comment-14392964 ] James Taylor commented on PHOENIX-1580: --- No, that change is fine. I made a change

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392960#comment-14392960 ] Devaraj Das commented on PHOENIX-1580: -- Did a quick browse of the last patch. Is th

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392322#comment-14392322 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Uploaded a modified

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392279#comment-14392279 ] Alicia Ying Shu commented on PHOENIX-1580: -- Yes. I have Explain test in my unit

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392232#comment-14392232 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] Thanks a lot for the

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392143#comment-14392143 ] Maryann Xue commented on PHOENIX-1580: -- Sure, [~jamestaylor]. Will get it done by t

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392124#comment-14392124 ] James Taylor commented on PHOENIX-1580: --- Looks good, [~ayingshu]. Some minor stuff

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392080#comment-14392080 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor], [~maryannxue]: Than

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391977#comment-14391977 ] Alicia Ying Shu commented on PHOENIX-1580: -- Yes. I added more data for Order by

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391973#comment-14391973 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] Thanks for the patch.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391974#comment-14391974 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] Thanks for the patch.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391963#comment-14391963 ] James Taylor commented on PHOENIX-1580: --- Thanks, [~maryannxue]. No problem on the

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391937#comment-14391937 ] Maryann Xue commented on PHOENIX-1580: -- [~ayingshu] Could you please update your te

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391880#comment-14391880 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor], [~maryannxue] Thank

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391754#comment-14391754 ] Maryann Xue commented on PHOENIX-1580: -- I checked other test cases. And indeed, the

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391725#comment-14391725 ] Maryann Xue commented on PHOENIX-1580: -- I am very sure I can pass all your test cas

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391708#comment-14391708 ] James Taylor commented on PHOENIX-1580: --- You can add this check in ParseNodeRewrit

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391684#comment-14391684 ] Devaraj Das commented on PHOENIX-1580: -- [~aliciashu] please investigate what could

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391631#comment-14391631 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] After applying your p

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391241#comment-14391241 ] James Taylor commented on PHOENIX-1580: --- One more thing is you don't need this che

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391229#comment-14391229 ] James Taylor commented on PHOENIX-1580: --- Thanks for the patch, [~ayingshu]. I thin

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391008#comment-14391008 ] Devaraj Das commented on PHOENIX-1580: -- [~aliciashu], the question is what's the ri

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391006#comment-14391006 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~jamestaylor] [~maryannxue] Thanks

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390990#comment-14390990 ] Alicia Ying Shu commented on PHOENIX-1580: -- [~maryannxue] Thanks for the help.

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390765#comment-14390765 ] Maryann Xue commented on PHOENIX-1580: -- And didn't you by any chance find it weird

[jira] [Commented] (PHOENIX-1580) Support UNION ALL

[ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390667#comment-14390667 ] Maryann Xue commented on PHOENIX-1580: -- [~ayingshu] Having an outer select has NOTH

  1   2   >