Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-16 Thread Daniel Dai
> On Jan. 16, 2014, 12:42 a.m., Daniel Dai wrote: > > Excellent job! > > > > The only thing I find is we still need getLoadCaster in > > AbstractAccumuloStorage.java > > > > @Override > > public LoadCaster getLoadCaster() throws IOException { > > return caster; > > } > > > > I can

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-16 Thread Josh Elser
> On Jan. 16, 2014, 12:42 a.m., Daniel Dai wrote: > > Excellent job! > > > > The only thing I find is we still need getLoadCaster in > > AbstractAccumuloStorage.java > > > > @Override > > public LoadCaster getLoadCaster() throws IOException { > > return caster; > > } > > > > I can

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-15 Thread Daniel Dai
> On Jan. 16, 2014, 12:42 a.m., Daniel Dai wrote: > > Excellent job! > > > > The only thing I find is we still need getLoadCaster in > > AbstractAccumuloStorage.java > > > > @Override > > public LoadCaster getLoadCaster() throws IOException { > > return caster; > > } > > > > I can

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-15 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/#review31974 --- Ship it! Excellent job! The only thing I find is we still need get

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-14 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/ --- (Updated Jan. 15, 2014, 12:44 a.m.) Review request for pig. Changes ---

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-13 Thread Daniel Dai
On Jan. 11, 2014, 1:56 a.m., Josh Elser wrote: > > That much better, thanks. > > > > Caster is added. But for AccumuloBinaryConverter, we shall retain the data > > in binary style. Eg, toBytes(Integer), we shall not convert the integer > > into String, then get bytes from string, but retain in

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-13 Thread Josh Elser
On Jan. 11, 2014, 1:56 a.m., Josh Elser wrote: > > That much better, thanks. > > > > Caster is added. But for AccumuloBinaryConverter, we shall retain the data > > in binary style. Eg, toBytes(Integer), we shall not convert the integer > > into String, then get bytes from string, but retain in

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-10 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/#review31537 --- build.xml R

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-10 Thread Josh Elser
> On Jan. 8, 2014, 11:27 p.m., Daniel Dai wrote: > > Thanks Josh, this is a very well written code to make Accumulo available to > > Pig. I can make it work locally. I have two major comment: > > 1. Bear in mind, Pig is good to manipulate tuple, Ok for map, and horrible > > for bag. A columnar

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-10 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/ --- (Updated Jan. 10, 2014, 7:20 p.m.) Review request for pig. Bugs: PIG-3573

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-10 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/ --- (Updated Jan. 10, 2014, 7:18 p.m.) Review request for pig. Changes --- I

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-09 Thread Daniel Dai
> On Jan. 8, 2014, 11:27 p.m., Daniel Dai wrote: > > Thanks Josh, this is a very well written code to make Accumulo available to > > Pig. I can make it work locally. I have two major comment: > > 1. Bear in mind, Pig is good to manipulate tuple, Ok for map, and horrible > > for bag. A columnar

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-09 Thread Josh Elser
> On Jan. 8, 2014, 11:27 p.m., Daniel Dai wrote: > > Thanks Josh, this is a very well written code to make Accumulo available to > > Pig. I can make it work locally. I have two major comment: > > 1. Bear in mind, Pig is good to manipulate tuple, Ok for map, and horrible > > for bag. A columnar

Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2014-01-08 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/#review31404 --- Thanks Josh, this is a very well written code to make Accumulo avail

Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo

2013-12-30 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16533/ --- Review request for pig. Bugs: PIG-3573 https://issues.apache.org/jira/brows