There were many in test code but lots in non-test code too. I don’t think
there are serious problems. But with all of the warnings it’s too easy to miss
significant ones or add more.
Changing “Use of a raw type” from warning to info drops the warnings from 235
to 85.
Then changing “Unchecked
Hi Dale,
I'm seeing similar Problems as with Edgent here ;-)
If the reported problems are actual problems, we should fix them and find ways
to prevent them in the future by making IntelliJ report them too.
However my trust in reports of Eclipe is not too high. Is Sonar reporting them
too?
Ch
Sonar[1] reports 158 code smells but those don’t seem to include any of the
categories of the 235 noted below. Not sure what to make of that.
At least an overwhelming number of the 235 are legitimate. E.g., one should
use a generic type in a generic way instead of as a raw type; there are in f
Hi together,
I suggest using sonar here as the leading system as these IDE warnings are
often not very helpful (and times very different from IDE to IDE). There are
some plugins for Eclipse and Idea to display sonar warnings inline.
A plus feature in sonar: You can here discuss these issues (in
dlaboss opened a new pull request #5: Cleanup warnings
URL: https://github.com/apache/incubator-plc4x/pull/5
- raw type usage
- unchecked type conversions
- unneeded @SuppressWarnings
- old junit5 cruft
This is an aut
dlaboss opened a new pull request #6: cleanup sonar edgent complaints
URL: https://github.com/apache/incubator-plc4x/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on Gi
asfgit closed pull request #5: Cleanup warnings
URL: https://github.com/apache/incubator-plc4x/pull/5
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork)
asfgit closed pull request #6: cleanup sonar edgent complaints
URL: https://github.com/apache/incubator-plc4x/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull reques
Hi,
> Sonar[1] reports 158 code smells but those don’t seem to include any of the
> categories of the 235 noted below. Not sure what to make of that.
It could be that some rules have been turned off? I’m also seeing some sonar
cube one that are legitimate issues but nothing too serious. Some o
Hi,
> I'd be inclined to do a bunch of the cleanup myself if I had some degree of
> confidence that the project was committed to their elimination. A project
> policy of not delivering code that adds more is sufficient IMO (not sure
> tooling enforcement is necessary). Can IntelliJ be configur
dlaboss opened a new pull request #7: cleanup some warnings (in Eclipse)
URL: https://github.com/apache/incubator-plc4x/pull/7
- remove pom: Version is duplicate of parent version
- suppress pom: Overriding version for maven-enforcer-plugin
- remove pom: Duplicating managed version for
asfgit closed pull request #7: cleanup some warnings (in Eclipse)
URL: https://github.com/apache/incubator-plc4x/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull req
dlaboss opened a new pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8
- raw type usage
- missing javadoc tags
This is an automated message from
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833605
##
File path:
plc4j/utils/raw-sockets/src/main/java/org/apache/plc4x/java/utils/rawsockets/RawSocket.
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833246
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcReadRequest.java
###
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832548
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResp
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r17087
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/items/ResponseItem.java
###
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833373
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcWriteReq
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833305
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteRequest.java
##
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833183
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcWriteReq
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170831995
##
File path:
examples/dummy-driver/src/main/java/org/apache/plc4x/java/examples/dummydriver/netty/Du
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833285
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcReadResponse.java
##
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833353
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResp
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833513
##
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##
@
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832428
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResp
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833320
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteResponse.java
#
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833118
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResp
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833397
##
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##
@
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832627
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResp
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832166
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteResponse.java
#
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833578
##
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##
@
31 matches
Mail list logo
