Trying to fix the timeout issues ...

2023-03-17 Thread Christofer Dutz
Hi all, I would like to address the timeout handling in our Java driver core next. Unfortunately, I am a bit unsure how to address that. Usually, I would whip up a Unit-Test that causes the error and then to fix it. However, I don’t quite know how to produce the problem that people are describin

Adding encoding to our addresses

2023-03-17 Thread Christofer Dutz
Hi all, so multiple times it has come up in the past, that depending on different target devices, there sometimes is the need to customize how we handle PlcValues. Some cases where a different String encoding was required, sometimes a different endianness. So, I would like to pick up Lukasz id

Re: Update to the connection-cache

2023-03-17 Thread youlin he
I'm just pointing out the problem with the connection pool about the PR 818. My current test environment only has read and write. If you think this PR is valuable, I will take the time to continue to improve. Christofer Dutz 于2023年3月17日周五 14:56写道: > Hi all, > > I think I‘ve finally managed to sp

Re: Adding encoding to our addresses

2023-03-17 Thread youlin he
I think this is good idea Christofer Dutz 于2023年3月17日周五 15:28写道: > Hi all, > > so multiple times it has come up in the past, that depending on different > target devices, there sometimes is the need to customize how we handle > PlcValues. Some cases where a different String encoding was required

Re: Trying to fix the timeout issues ...

2023-03-17 Thread Łukasz Dywicki
Hey Chris, We do have one, fairly basic Plc4xNettyWrapperTest which covers timeout handling. The PR I made https://github.com/apache/plc4x/pull/822 was spotted by this test and showed that we had behavior change. One thing which I still haven't found answer to is how to bind lifecycle of time

Re: Trying to fix the timeout issues ...

2023-03-17 Thread youlin he
PR 822 can handle base netty timeout very well. But CachedConnection should have it's own timeout handle This is not the same. Most of the connection problems are caused by the base netty connection that not deal bery well. @Łukasz Dywicki have fixed response timeout problem。 Like I pointed ou

Re: Trying to fix the timeout issues ...

2023-03-17 Thread Cesar Garcia
Hello everyone, For the S7HA version I used a different path for the timeout implementation. / NIOChannel B PLC4X -> EmbeddedChannel -> \ NIOChannel A Channels A and B have timeout monitoring (

AW: Update to the connection-cache

2023-03-17 Thread Christofer Dutz
Hi Youlin, Well, it not being complete was only one part … so the reason you needed to change the API in order to get it working was due to the fact that you were closing the connection on error instantly. My approach just marks the connection as broken and closes it when it’s supposed to be cl

AW: Trying to fix the timeout issues ...

2023-03-17 Thread Christofer Dutz
Hi all, I mean … I would feel more comfortable, if we came up with a test that demonstrates the current implementations weaknesses. This way we can prove another implementation addresses that issue. Otherwise it just feels like we’re swapping one option with another without any idea if this rea

Re: AW: Trying to fix the timeout issues ...

2023-03-17 Thread Łukasz Dywicki
If you have a look on test I pointed - its current weakness is that timeout do not occur if you do not have data packet incoming from network pipe. Present implementation simply needs working network to spot timeout which contradicts the timeout concept in general: https://github.com/apache/p

Re: AW: Trying to fix the timeout issues ...

2023-03-17 Thread Cesar Garcia
Hello, Indeed, it is a solution focused on the S7-400H(F)[1], also applicable to the S7-1500H (but since I don't have the hardware, I'm not saying it works). :-) >From the video you can see that there are two PLCs in parallel, which generates the HA for the entire hardware. For the tests I have