[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1478]'

2023-06-03 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1478]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1478/;>PLC4X/PLC4X/develop [develop] [1478]"

Re: [PR] Add support of PlcDINT for BigInteger in PlcValueHandler (plc4x)

2023-06-03 Thread via GitHub
splatch commented on PR #962: URL: https://github.com/apache/plc4x/pull/962#issuecomment-1575227300 @chrisdutz if you're ok with changes (PlcLINT is in place) I'd proceed with merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)

2023-06-03 Thread via GitHub
splatch commented on PR #822: URL: https://github.com/apache/plc4x/pull/822#issuecomment-1575226211 This PR was open for quite long time. I'm going to address @spnettec review comments in separate change set. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)

2023-06-03 Thread via GitHub
splatch merged PR #822: URL: https://github.com/apache/plc4x/pull/822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [D] [Java] How should we handle "loggers"? (plc4x)

2023-06-03 Thread Cesar Garcia
Hello, Totally agree on equalizing the use of logs (log, LOG, logger, LOGGER), and so on... If there is a best practice that does not imply adding more libraries to the existing ones, we should evaluate it. Kind regards, El sáb, 3 jun 2023 a las 17:18, Łukasz Dywicki () escribió: > The static

Re: [D] [Java] How should we handle "loggers"? (plc4x)

2023-06-03 Thread Łukasz Dywicki
The static logger declaration is still a thing made by (older/elder? ;)) java developers, mainly because log4j 1.x/commons-logging/jul loggers were advised to be made like that. With switch to slf4j static is no longer mandatory/strongly recommended. Most of code I make myself rely on logger

[BUILD-UNSTABLE]: Job 'PLC4X/PLC4X/develop [develop] [1477]'

2023-06-03 Thread Apache Jenkins Server
BUILD-UNSTABLE: Job 'PLC4X/PLC4X/develop [develop] [1477]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1477/;>PLC4X/PLC4X/develop [develop] [1477]"

[BUILD-UNSTABLE]: Job 'PLC4X/PLC4X/develop [develop] [1476]'

2023-06-03 Thread Apache Jenkins Server
BUILD-UNSTABLE: Job 'PLC4X/PLC4X/develop [develop] [1476]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1476/;>PLC4X/PLC4X/develop [develop] [1476]"