[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695037266 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/RecordPlc4xWriter.java ## @@ -37,12 +38,3

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695038086 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -89,8 +90,8 @@ publi

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695038305 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -130,7 +131,16 @@ pu

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695038549 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -130,7 +131,16 @@ pu

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695038773 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -130,7 +131,16 @@ pu

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695040451 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -145,5 +155,100 @@ p

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695040735 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695041046 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695041344 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695041793 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695042927 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695043274 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695043410 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695043518 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695044025 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/util/Plc4xSchemaTest.java ## @@ -0,0 +1,125 @@ +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695044678 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/util/Plc4xSchemaTest.java ## @@ -0,0 +1,125 @@ +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695044938 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/util/Plc4xSchemaTest.java ## @@ -0,0 +1,125 @@ +

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695046111 ## File path: plc4j/integrations/apache-nifi/README.md ## @@ -0,0 +1,56 @@ +# PLC4X Apache NiFi Integration + +## Plc4xSinkProcessor + +## Plc4xSourcePr

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695046379 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-nar/pom.xml ## @@ -72,88 +72,101 @@ - org.apache.plc4x - plc4j-nifi-plc4x-

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695046737 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -31,46 +32,66 @@ L

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695047070 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -89,13 +110,13 @@

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695047459 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -31,46 +32,66 @@ L

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695048076 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -89,13 +110,13 @@

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695049184 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessor.java ## @@ -0,0 +1,20

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695050230 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/Plc4xReadResponseRecordSet.java ## @@ -0,

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695050683 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/Plc4xReadResponseRecordSet.java ## @@ -0,

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695052067 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -0,0 +1,149 @@ +pack

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695052321 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -0,0 +1,149 @@ +pack

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-08-24 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695053036 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -0,0 +1,149 @@ +pack

[GitHub] [plc4x] chrisdutz merged pull request #264: S7event

2021-09-02 Thread GitBox
chrisdutz merged pull request #264: URL: https://github.com/apache/plc4x/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz merged pull request #258: changed delimiter of opc ua from : to ;

2021-09-02 Thread GitBox
chrisdutz merged pull request #258: URL: https://github.com/apache/plc4x/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz merged pull request #252: plc4x: major dependency updates

2021-09-02 Thread GitBox
chrisdutz merged pull request #252: URL: https://github.com/apache/plc4x/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] dependabot[bot] opened a new pull request #269: Bump milo.version from 0.6.1 to 0.6.3

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #269: URL: https://github.com/apache/plc4x/pull/269 Bumps `milo.version` from 0.6.1 to 0.6.3. Updates `sdk-server` from 0.6.1 to 0.6.3 Updates `sdk-core` from 0.6.1 to 0.6.3 Updates `stack-core` from 0.6.1 to 0.6.3 Updates `st

[GitHub] [plc4x] dependabot[bot] commented on pull request #250: build(deps): bump milo.version from 0.5.4 to 0.6.1

2021-09-02 Thread GitBox
dependabot[bot] commented on pull request #250: URL: https://github.com/apache/plc4x/pull/250#issuecomment-911714130 Superseded by #269. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [plc4x] dependabot[bot] closed pull request #250: build(deps): bump milo.version from 0.5.4 to 0.6.1

2021-09-02 Thread GitBox
dependabot[bot] closed pull request #250: URL: https://github.com/apache/plc4x/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] chrisdutz commented on pull request #265: Subscriptions for ADS in PLC4J

2021-09-02 Thread GitBox
chrisdutz commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-911714529 Hi @splatch ... did you manage to review this PR? Was investing quite some time today to get dangling PRs back to develop -- This is an automated message from the Apache Git S

[GitHub] [plc4x] chrisdutz commented on pull request #257: Feature/nifi record

2021-09-02 Thread GitBox
chrisdutz commented on pull request #257: URL: https://github.com/apache/plc4x/pull/257#issuecomment-911715342 What's the current state of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [plc4x] sruehl commented on pull request #251: build(deps): bump junit.jupiter.version from 5.7.0 to 5.7.2

2021-09-02 Thread GitBox
sruehl commented on pull request #251: URL: https://github.com/apache/plc4x/pull/251#issuecomment-911715445 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] sruehl commented on pull request #245: build(deps): bump karaf-maven-plugin from 4.3.0 to 4.3.2

2021-09-02 Thread GitBox
sruehl commented on pull request #245: URL: https://github.com/apache/plc4x/pull/245#issuecomment-911716003 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] sruehl commented on pull request #247: build(deps): bump zookeeper from 3.4.13 to 3.7.0

2021-09-02 Thread GitBox
sruehl commented on pull request #247: URL: https://github.com/apache/plc4x/pull/247#issuecomment-911715792 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] sruehl commented on pull request #246: build(deps): bump gmavenplus-plugin from 1.6.2 to 1.12.1

2021-09-02 Thread GitBox
sruehl commented on pull request #246: URL: https://github.com/apache/plc4x/pull/246#issuecomment-911715930 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] dependabot[bot] closed pull request #247: build(deps): bump zookeeper from 3.4.13 to 3.7.0

2021-09-02 Thread GitBox
dependabot[bot] closed pull request #247: URL: https://github.com/apache/plc4x/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] dependabot[bot] opened a new pull request #270: Bump zookeeper from 3.4.13 to 3.4.14

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #270: URL: https://github.com/apache/plc4x/pull/270 Bumps zookeeper from 3.4.13 to 3.4.14. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.zookeeper:zookeepe

[GitHub] [plc4x] dependabot[bot] commented on pull request #247: build(deps): bump zookeeper from 3.4.13 to 3.7.0

2021-09-02 Thread GitBox
dependabot[bot] commented on pull request #247: URL: https://github.com/apache/plc4x/pull/247#issuecomment-911716357 Superseded by #270. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [plc4x] sruehl merged pull request #245: build(deps): bump karaf-maven-plugin from 4.3.0 to 4.3.2

2021-09-02 Thread GitBox
sruehl merged pull request #245: URL: https://github.com/apache/plc4x/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #270: Bump zookeeper from 3.4.13 to 3.4.14

2021-09-02 Thread GitBox
sruehl merged pull request #270: URL: https://github.com/apache/plc4x/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #269: Bump milo.version from 0.6.1 to 0.6.3

2021-09-02 Thread GitBox
sruehl merged pull request #269: URL: https://github.com/apache/plc4x/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #246: build(deps): bump gmavenplus-plugin from 1.6.2 to 1.12.1

2021-09-02 Thread GitBox
sruehl merged pull request #246: URL: https://github.com/apache/plc4x/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on pull request #251: build(deps): bump junit.jupiter.version from 5.7.0 to 5.7.2

2021-09-02 Thread GitBox
sruehl commented on pull request #251: URL: https://github.com/apache/plc4x/pull/251#issuecomment-911721815 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] sruehl merged pull request #251: build(deps): bump junit.jupiter.version from 5.7.0 to 5.7.2

2021-09-02 Thread GitBox
sruehl merged pull request #251: URL: https://github.com/apache/plc4x/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] chrisdutz commented on pull request #268: PLC4X-311 Handling of compact answers for ADS read requests.

2021-09-02 Thread GitBox
chrisdutz commented on pull request #268: URL: https://github.com/apache/plc4x/pull/268#issuecomment-911741668 I'll ask my contacts at Beckhoff about some information for this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [plc4x] guszylk commented on pull request #257: Feature/nifi record

2021-09-02 Thread GitBox
guszylk commented on pull request #257: URL: https://github.com/apache/plc4x/pull/257#issuecomment-911742741 > What's the current state of this PR? Hi @chrisdutz, @ottobackwards, we are working to change what otto says in his comments. We will confirm the changes next week. Sorry for

[GitHub] [plc4x] splatch commented on pull request #268: PLC4X-311 Handling of compact answers for ADS read requests.

2021-09-02 Thread GitBox
splatch commented on pull request #268: URL: https://github.com/apache/plc4x/pull/268#issuecomment-911828965 I have not tested it yet, however I located integration tests where we have ADS payloads where I could fit it. I planned to take care of it this week, but got stuck in other thing

[GitHub] [plc4x] chrisdutz commented on pull request #257: Feature/nifi record

2021-09-02 Thread GitBox
chrisdutz commented on pull request #257: URL: https://github.com/apache/plc4x/pull/257#issuecomment-911832429 No worries, I was just a bit lost in a lot of separate discussion threads here. I know how things can be ... I'm currently just barely able to free some time for PLC4X for the las

[GitHub] [plc4x] dependabot[bot] opened a new pull request #271: build(deps): bump logback.version from 1.2.3 to 1.2.5

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #271: URL: https://github.com/apache/plc4x/pull/271 Bumps `logback.version` from 1.2.3 to 1.2.5. Updates `logback-classic` from 1.2.3 to 1.2.5 Updates `logback-core` from 1.2.3 to 1.2.5 Dependabot will resolve any conflicts with

[GitHub] [plc4x] dependabot[bot] opened a new pull request #272: build(deps): bump FastInfoset from 1.2.18 to 2.0.0

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #272: URL: https://github.com/apache/plc4x/pull/272 Bumps FastInfoset from 1.2.18 to 2.0.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.sun.xml.fastinfoset:Fast

[GitHub] [plc4x] dependabot[bot] opened a new pull request #273: build(deps): bump netty.version from 4.1.54.Final to 4.1.67.Final

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #273: URL: https://github.com/apache/plc4x/pull/273 Bumps `netty.version` from 4.1.54.Final to 4.1.67.Final. Updates `netty-transport` from 4.1.54.Final to 4.1.67.Final Commits https://github.com/netty/netty/commit/b785fa9eedab659b3a

[GitHub] [plc4x] dependabot[bot] opened a new pull request #274: build(deps): bump zkclient from 0.10 to 0.11

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #274: URL: https://github.com/apache/plc4x/pull/274 Bumps [zkclient](https://github.com/sgroschupf/zkclient) from 0.10 to 0.11. Changelog Sourced from https://github.com/sgroschupf/zkclient/blob/master/CHANGELOG.markdown";>zkclient's chang

[GitHub] [plc4x] dependabot[bot] opened a new pull request #275: build(deps): bump royale.version from 0.9.7 to 0.9.8

2021-09-02 Thread GitBox
dependabot[bot] opened a new pull request #275: URL: https://github.com/apache/plc4x/pull/275 Bumps `royale.version` from 0.9.7 to 0.9.8. Updates `compiler-jx` from 0.9.7 to 0.9.8 Changelog Sourced from https://github.com/apache/royale-compiler/blob/develop/RELEASE_NOTES.md";>co

[GitHub] [plc4x] dependabot[bot] closed pull request #273: build(deps): bump netty.version from 4.1.54.Final to 4.1.67.Final

2021-09-06 Thread GitBox
dependabot[bot] closed pull request #273: URL: https://github.com/apache/plc4x/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] dependabot[bot] commented on pull request #273: build(deps): bump netty.version from 4.1.54.Final to 4.1.67.Final

2021-09-06 Thread GitBox
dependabot[bot] commented on pull request #273: URL: https://github.com/apache/plc4x/pull/273#issuecomment-913443329 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [plc4x] splatch commented on pull request #265: Subscriptions for ADS in PLC4J

2021-09-06 Thread GitBox
splatch commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-913578335 @rmeister I've just did a test run of subscribe logic with TC 2 and it didn't fly. Test code I made is following: ``` String fieldString = ".BYTE_DAT:BYTE"; System.ou

[GitHub] [plc4x] NiklasMerz opened a new pull request #276: Change PLC4GO docs read syntax

2021-09-06 Thread GitBox
NiklasMerz opened a new pull request #276: URL: https://github.com/apache/plc4x/pull/276 According to [this doc](https://github.com/apache/plc4x/blob/d767dc9b9160/plc4go/examples/read/hello_world_plc4go_read.go) the new syntax is `Add query`. `AddField` does not work for me after f

[GitHub] [plc4x] sruehl merged pull request #271: build(deps): bump logback.version from 1.2.3 to 1.2.5

2021-09-06 Thread GitBox
sruehl merged pull request #271: URL: https://github.com/apache/plc4x/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on pull request #276: Change PLC4GO docs read syntax

2021-09-06 Thread GitBox
sruehl commented on pull request #276: URL: https://github.com/apache/plc4x/pull/276#issuecomment-913761797 LTGM, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl merged pull request #276: Change PLC4GO docs read syntax

2021-09-06 Thread GitBox
sruehl merged pull request #276: URL: https://github.com/apache/plc4x/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on pull request #276: Change PLC4GO docs read syntax

2021-09-06 Thread GitBox
sruehl commented on pull request #276: URL: https://github.com/apache/plc4x/pull/276#issuecomment-913762518 as this is still a draft (which I didn't notice at first) I guess there will be more commits -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [plc4x] sruehl commented on pull request #276: Change PLC4GO docs read syntax

2021-09-06 Thread GitBox
sruehl commented on pull request #276: URL: https://github.com/apache/plc4x/pull/276#issuecomment-913762703 github concurrency 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [plc4x] NiklasMerz commented on pull request #276: Change PLC4GO docs read syntax

2021-09-06 Thread GitBox
NiklasMerz commented on pull request #276: URL: https://github.com/apache/plc4x/pull/276#issuecomment-913762884 I just marked it ready after my test was successful :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [plc4x] dependabot[bot] opened a new pull request #277: build(deps): bump scala-library from 2.10.7 to 2.13.6

2021-09-07 Thread GitBox
dependabot[bot] opened a new pull request #277: URL: https://github.com/apache/plc4x/pull/277 Bumps [scala-library](https://github.com/scala/scala) from 2.10.7 to 2.13.6. Release notes Sourced from https://github.com/scala/scala/releases";>scala-library's releases. Scala 2.

[GitHub] [plc4x] sruehl commented on pull request #265: Subscriptions for ADS in PLC4J

2021-09-08 Thread GitBox
sruehl commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-915435782 for reference here is the implementation that was working before the mspec refactoring https://github.com/apache/plc4x/blob/release/0.6.0/plc4j/drivers/ads/src/main/java/org/apache/p

[GitHub] [plc4x] dependabot[bot] opened a new pull request #278: build(deps): bump groovy.version from 3.0.8 to 3.0.9

2021-09-08 Thread GitBox
dependabot[bot] opened a new pull request #278: URL: https://github.com/apache/plc4x/pull/278 Bumps `groovy.version` from 3.0.8 to 3.0.9. Updates `groovy-test-junit5` from 3.0.8 to 3.0.9 Commits See full diff in https://github.com/apache/groovy/commits";>compare view

[GitHub] [plc4x] chrisdutz closed pull request #272: build(deps): bump FastInfoset from 1.2.18 to 2.0.0

2021-09-09 Thread GitBox
chrisdutz closed pull request #272: URL: https://github.com/apache/plc4x/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] dependabot[bot] commented on pull request #272: build(deps): bump FastInfoset from 1.2.18 to 2.0.0

2021-09-09 Thread GitBox
dependabot[bot] commented on pull request #272: URL: https://github.com/apache/plc4x/pull/272#issuecomment-915822119 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

[GitHub] [plc4x] chrisdutz commented on pull request #272: build(deps): bump FastInfoset from 1.2.18 to 2.0.0

2021-09-09 Thread GitBox
chrisdutz commented on pull request #272: URL: https://github.com/apache/plc4x/pull/272#issuecomment-915822268 Manually applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [plc4x] chrisdutz closed pull request #274: build(deps): bump zkclient from 0.10 to 0.11

2021-09-09 Thread GitBox
chrisdutz closed pull request #274: URL: https://github.com/apache/plc4x/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz commented on pull request #274: build(deps): bump zkclient from 0.10 to 0.11

2021-09-09 Thread GitBox
chrisdutz commented on pull request #274: URL: https://github.com/apache/plc4x/pull/274#issuecomment-915822417 Manually applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [plc4x] dependabot[bot] commented on pull request #274: build(deps): bump zkclient from 0.10 to 0.11

2021-09-09 Thread GitBox
dependabot[bot] commented on pull request #274: URL: https://github.com/apache/plc4x/pull/274#issuecomment-915822440 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

[GitHub] [plc4x] dependabot[bot] commented on pull request #275: build(deps): bump royale.version from 0.9.7 to 0.9.8

2021-09-09 Thread GitBox
dependabot[bot] commented on pull request #275: URL: https://github.com/apache/plc4x/pull/275#issuecomment-915822600 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a depende

[GitHub] [plc4x] chrisdutz commented on pull request #275: build(deps): bump royale.version from 0.9.7 to 0.9.8

2021-09-09 Thread GitBox
chrisdutz commented on pull request #275: URL: https://github.com/apache/plc4x/pull/275#issuecomment-915822579 Manually applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [plc4x] chrisdutz closed pull request #275: build(deps): bump royale.version from 0.9.7 to 0.9.8

2021-09-09 Thread GitBox
chrisdutz closed pull request #275: URL: https://github.com/apache/plc4x/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] dependabot[bot] opened a new pull request #279: build(deps): bump jna from 5.8.0 to 5.9.0

2021-09-09 Thread GitBox
dependabot[bot] opened a new pull request #279: URL: https://github.com/apache/plc4x/pull/279 Bumps [jna](https://github.com/java-native-access/jna) from 5.8.0 to 5.9.0. Changelog Sourced from https://github.com/java-native-access/jna/blob/master/CHANGES.md";>jna's changelog.

[GitHub] [plc4x] dependabot[bot] opened a new pull request #280: build(deps): bump nifi.version from 1.13.2 to 1.14.0

2021-09-09 Thread GitBox
dependabot[bot] opened a new pull request #280: URL: https://github.com/apache/plc4x/pull/280 Bumps `nifi.version` from 1.13.2 to 1.14.0. Updates `nifi` from 1.13.2 to 1.14.0 Updates `nifi-api` from 1.13.2 to 1.14.0 Updates `nifi-utils` from 1.13.2 to 1.14.0 Updates `

[GitHub] [plc4x] dependabot[bot] opened a new pull request #281: build(deps): bump bit-io from 1.4.3 to 2.0.5

2021-09-09 Thread GitBox
dependabot[bot] opened a new pull request #281: URL: https://github.com/apache/plc4x/pull/281 Bumps bit-io from 1.4.3 to 2.0.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.jinahya:bit-io&package-

[GitHub] [plc4x] dependabot[bot] commented on pull request #281: build(deps): bump bit-io from 1.4.3 to 2.0.5

2021-09-10 Thread GitBox
dependabot[bot] commented on pull request #281: URL: https://github.com/apache/plc4x/pull/281#issuecomment-916693027 OK, I won't notify you about com.github.jinahya:bit-io again, unless you re-open this PR or update it yourself. 😢 -- This is an automated message from the Apache Git Servi

[GitHub] [plc4x] dependabot[bot] closed pull request #281: build(deps): bump bit-io from 1.4.3 to 2.0.5

2021-09-10 Thread GitBox
dependabot[bot] closed pull request #281: URL: https://github.com/apache/plc4x/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] chrisdutz commented on pull request #281: build(deps): bump bit-io from 1.4.3 to 2.0.5

2021-09-10 Thread GitBox
chrisdutz commented on pull request #281: URL: https://github.com/apache/plc4x/pull/281#issuecomment-916693012 @dependabot ignore this dependency (We can't update) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [plc4x] dependabot[bot] opened a new pull request #282: build(deps): bump jaxb-runtime from 2.3.3 to 3.0.2

2021-09-10 Thread GitBox
dependabot[bot] opened a new pull request #282: URL: https://github.com/apache/plc4x/pull/282 Bumps jaxb-runtime from 2.3.3 to 3.0.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.glassfish.jaxb:jaxb-runt

[GitHub] [plc4x] splatch commented on pull request #265: Subscriptions for ADS in PLC4J

2021-09-15 Thread GitBox
splatch commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-919948651 @rmeister Hey, hope you have returned from your vacations. Can you confirm which TwinCat version you tested above logic with? At this moment I can't get this PR working with TC2.

[GitHub] [plc4x] rmeister commented on pull request #265: Subscriptions for ADS in PLC4J

2021-09-15 Thread GitBox
rmeister commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-919974766 @splatch Hey, well I wish it was vacation :sweat_smile:. I'll be away for at least two more weeks. I left the Beckhoff PLC at the office, so I can not repeat my test, but I can say

[GitHub] [plc4x] splatch merged pull request #241: PLC4X-294 / PLC4X-296 Reorganization of stack configurer / events support in public api

2021-09-16 Thread GitBox
splatch merged pull request #241: URL: https://github.com/apache/plc4x/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pl

[GitHub] [plc4x] splatch commented on pull request #241: PLC4X-294 / PLC4X-296 Reorganization of stack configurer / events support in public api

2021-09-16 Thread GitBox
splatch commented on pull request #241: URL: https://github.com/apache/plc4x/pull/241#issuecomment-921018939 I merged this PR so I can continue on develop these changes should land in 0.9 release. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [plc4x] splatch commented on pull request #268: PLC4X-311 Handling of compact answers for ADS read requests.

2021-09-16 Thread GitBox
splatch commented on pull request #268: URL: https://github.com/apache/plc4x/pull/268#issuecomment-921022174 Given comments on PLC4X-311 issue in JIRA I consider this fix as unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [plc4x] splatch closed pull request #268: PLC4X-311 Handling of compact answers for ADS read requests.

2021-09-16 Thread GitBox
splatch closed pull request #268: URL: https://github.com/apache/plc4x/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pl

[GitHub] [plc4x] ottobackwards opened a new pull request #283: update readme to jdk 11

2021-09-20 Thread GitBox
ottobackwards opened a new pull request #283: URL: https://github.com/apache/plc4x/pull/283 we should list what jdks we know work in ci etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [plc4x] ottlukas merged pull request #283: update readme to jdk 11

2021-10-06 Thread GitBox
ottlukas merged pull request #283: URL: https://github.com/apache/plc4x/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@p

[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735653618 ## File path: plc4j/integrations/apache-nifi/README.md ## @@ -0,0 +1,56 @@ +# PLC4X Apache NiFi Integration + +## Plc4xSinkProcessor + +## Plc4xSourceProcesso

[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735657004 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -31,46 +32,66 @@ License

[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735668827 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessor.java ## @@ -0,0 +1,201 @@ +

[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735680252 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ## @@ -89,8 +90,8 @@ public stat

<    2   3   4   5   6   7   8   9   10   11   >