Jenkins build is back to normal : POI » POI-DSL-1.17 #490

See - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org

Build failed in Jenkins: POI » POI-DSL-1.17 #489

See Changes: [PJ Fanning] [bug-66503] Add flag for Excel 4 macros in composite documents. Thanks to M. P. Halpin [PJ Fanning] [bug-66532] more performant way to iterate over codepoints. [PJ Fanning]

Build failed in Jenkins: POI » POI-DSL-Windows-1.8 #738

See Changes: [PJ Fanning] [bug-66503] Add flag for Excel 4 macros in composite documents. Thanks to M. P. Halpin [PJ Fanning] [bug-66532] more performant way to iterate over codepoints. [PJ

[GitHub] [poi] pjfanning commented on pull request #436: Add flag for Excel 4 macros in composite documents

pjfanning commented on PR #436: URL: https://github.com/apache/poi/pull/436#issuecomment-1474554346 I added this but then reverted it due to https://github.com/apache/poi/actions/runs/4452719179/jobs/7820620683 Causes issues like this: ``` Caused by:

[GitHub] [poi] pjfanning commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474516597 I added https://github.com/apache/poi/commit/0275daa5deae2e0069badd1f46268abb43fbc3dc - not exactly what is in your PR. Could you try this out in your benchmark? -- This is an automated

[GitHub] [poi] pjfanning commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474422688 thanks - looks good. Let me look over this but it looks like this should be safe to merge over the coming days. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [poi] rascmatt commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

rascmatt commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474419787 https://github.com/rascmatt/poi-benchmark The (updated) benchmark with code and results. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [poi] rascmatt commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

rascmatt commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140725467 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[GitHub] [poi] rascmatt commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

rascmatt commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140725183 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[GitHub] [poi] pjfanning commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140652528 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[GitHub] [poi] pjfanning commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474345524 > Following you will find the results of a JMH benchmark I ran with 3 different versions. Unfortunately I was unable to get JMH running with Gradle, so I ran this in an external Maven

[GitHub] [poi] pjfanning commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140653374 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[GitHub] [poi] pjfanning commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140652528 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[GitHub] [poi] rascmatt commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

rascmatt commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140650040 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[GitHub] [poi] pjfanning commented on a diff in pull request #443: [Bug-66532] Improve performance of SheetDataWriter

pjfanning commented on code in PR #443: URL: https://github.com/apache/poi/pull/443#discussion_r1140647602 ## poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java: ## @@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws IOException {

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #4 from Matthias Raschhofer --- Thank you for your comments. I'm happy to use git, however I thought it was readonly and I should provide patches here. I opened a pull request in git (https://github.com/apache/poi/pull/443). I

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #3 from Matthias Raschhofer --- Created attachment 38525 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38525=edit Benchmark The attached file contains a benchmark comparing the performance of the proposed patch against

[GitHub] [poi] rascmatt commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

rascmatt commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474314063 The following is a JMH benchmark I ran with 3 different versions. Unfortunately I was unable to get JMH running with Gradle, so I ran this in an external Maven Project. The latest

[GitHub] [poi] rascmatt opened a new pull request, #443: [Bug-66532] Improve performance of SheetDataWriter

rascmatt opened a new pull request, #443: URL: https://github.com/apache/poi/pull/443 Simplify loop and avoid code point to string conversions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #2 from PJ Fanning --- https://github.com/apache/poi/pull/405 is an unreleased perf change that may improve perf time of existing code. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 66532] [PATCH] Improve performance of SheetDataWriter

https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 --- Comment #1 from PJ Fanning --- It's hard to read this patch on my phone but a quick look makes me think there is a bug with use of string length - the number of chars as opposed the number of codepoints. I'm very reluctant to take this

[Bug 66532] New: [PATCH] Improve performance of SheetDataWriter

https://bz.apache.org/bugzilla/show_bug.cgi?id=66532 Bug ID: 66532 Summary: [PATCH] Improve performance of SheetDataWriter Product: POI Version: unspecified Hardware: All OS: All Status: NEW Severity: