Re: [VOTE] PIP-378 Add ServiceUnitStateTableView abstraction (ExtensibleLoadMangerImpl only)

2024-09-16 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Sep 16, 2024 at 8:17 AM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Mon, Sep 16, 2024 at 3:06 AM Lari Hotari wrote: > > > > +1 (binding) > > > > -Lari > > > > On Sun, 15 Sept 2024 at 21:34, Heesung Sohn wrote: > > > > > > Hi all, > > > > > >

Re: [DISCUSS] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering

2024-09-15 Thread PengHui Li
Hi Lari, I recommend creating a new implementation rather than directly replacing the existing one. This approach aligns with how we’ve handled several proposals in the past and allows us to maintain stability while introducing improvements - PIP-192: New Pulsar Broker Load Balancer - PIP-195: Ne

Re: [VOTE] PIP-374: Visibility of messages in receiverQueue for the consumers

2024-09-05 Thread PengHui Li
+1 binding Regards Penghui On Wed, Sep 4, 2024 at 19:55 Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Sep 4, 2024 at 2:15 PM Baodi Shi wrote: > > > > +1(binding) > > > > Thanks, > > Baodi Shi > > > > Bhat, Vinay 于2024年9月4日周三 12:22写道: > > > > > > Hi All, > > > > > > I want to

Re: [VOTE] PIP-376 Make topic policies pluggable

2024-09-04 Thread PengHui Li
+1 Thanks Penghui On Wed, Sep 4, 2024 at 20:14 Lari Hotari wrote: > +1 (binding) > > -Lari > > On 2024/09/05 02:53:22 Yunze Xu wrote: > > Hi all, > > > > I want to start a vote on PIP-376 Make topic policies pluggable. > > > > Proposal link: https://github.com/streamnative/pulsar/pull/307 > > D

Re: [DISCUSS] PIP-376 Make topic policies service pluggable

2024-09-03 Thread PengHui Li
Thanks for driving the proposal. I support this proposal and left a few comments on the PR Regards, Penghui On Tue, Sep 3, 2024 at 8:54 AM Enrico Olivelli wrote: > Nice write up ! > > I generally support this proposal, we should have clearer APIs for the > components we want to allow users to

Re: [VOTE] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation

2024-08-15 Thread PengHui Li
+1 (binding) Sorry for the late response on the mailing list. Regards, Penghui On Thu, Aug 15, 2024 at 7:44 PM Yubiao Feng wrote: > The vote is approved with 4 binding votes and close now. > > Votes: > - Hang Chen (binding) > - Jiwei Guo (binding) > - Lari Hotari (bindi

Re: [VOTE] Reactive Java client for Apache Pulsar 0.5.7 Candidate 1

2024-08-14 Thread PengHui Li
+1 (binding) - Checked the signature - Verified the checksum Regards, Penghui On Wed, Aug 14, 2024 at 10:09 AM Lari Hotari wrote: > +1 (binding) > > Validated source artifacts > - checked sha512 checksum > - checked signature > > Validated binaries > - ran sample app > > -Lari > > On 2024/08/1

Re: [VOTE] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation

2024-08-12 Thread PengHui Li
Hi Yubiao, Thanks for driving the improvements to Pulsar. The motivation and the high-level solution look good to me. I just left some comments on the proposal for the details. The major idea for resolving this issue is to separate the user-facing topic auto-creation and topic auto-creation by da

Re: [VOTE] Release Apache Pulsar 3.0.6 based on 3.0.6-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 30

Re: [VOTE] Release Apache Pulsar 3.2.4 based on 3.2.4-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 30

Re: [VOTE] Release Apache Pulsar 3.3.1 based on 3.3.1-candidate-1

2024-07-31 Thread PengHui Li
+1 (binding) - Checked the signature of the binary release artifacts - Start Pulsar standalone - Verified Produce and Consume - Verified Pulsar Function and Stateful Function - Verified the Cassandra connector - Ran the perf test with 100 topics and batch disabled Regards, Penghui On Tue, Jul 3

Re: [VOTE] PIP-366: Support to specify different config for Configuration and Local Metadata Store

2024-07-22 Thread PengHui Li
+1 (binding) Thanks for driving the proposal. Regards, Penghui On Sun, Jul 21, 2024 at 6:46 PM Kai Wang wrote: > Hi all, I want to start a vote on PIP-366: Support to specify different > config for Configuration and Local Metadata Store. > > You can find the proposal at https://github.com/apac

Re: [VOTE] Reactive Java client for Apache Pulsar 0.5.6 Candidate 1

2024-06-17 Thread PengHui Li
+1 (binding) - Verified checksum - Verified signatures Thanks, Penghui On Sun, Jun 16, 2024 at 8:29 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source > - Verified the binaries > > Thanks, > Yunze > > On Sun, Jun 16, 2024 at 3:23 AM Chris Bono wrote

Re: [VOTE] PIP-355: Enhancing Broker-Level Metrics for Pulsar

2024-06-10 Thread PengHui Li
+1 (binding) Regards, Penghui On Sat, Jun 1, 2024 at 5:05 AM Dragos Misca wrote: > +1 non-binding > > Thank you, > Dragos > > > On May 30, 2024, at 5:47 PM, Hang Chen wrote: > > > > Hi, all > > > > I would like to start the voting thread for PIP-355: Enhancing > > Broker-Level Metrics for Puls

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-06 Thread PengHui Li
+1 (binding) Regards, Penghui On Thu, Jun 6, 2024 at 3:25 PM thetumbled wrote: > The vote is approved with 3 binding votes and close now. > Votes: > - Kai Wang(non-binding) > - Yunze Xu(binding) > - guo jiwei(binding) > - Yubiao Feng(binding) > > Thank you all for verifying and voting! > Wenzhi

Re: [VOTE] PIP-357: Correct the conf name in load balance module.

2024-06-05 Thread PengHui Li
Hi Wenzhi, Thanks for driving the proposal. The old configuration name should not be removed directly. It might break users when they upgrade to the new cluster. Instead, we can move it to the `Deprecated settings` section and use `-1` as the default value. If the user sets it to a positive numbe

Re: [VOTE] Release Apache Pulsar 3.3.0 based on 3.3.0-candidate-3

2024-05-28 Thread PengHui Li
+1 (binding) - Build from source - Checked the signatures - Run standalone - Verified the Cassandra connector - Verified the Stateful function - Run pulsar-perf with 100 topics and batch disabled Regards, Penghui On Wed, May 29, 2024 at 8:32 AM PengHui Li wrote: > Sorry for the confus

Re: [VOTE] Release Apache Pulsar 3.3.0 based on 3.3.0-candidate-3

2024-05-28 Thread PengHui Li
Sorry for the confusion. After checking more details, the fix makes more sense. For more cases, user think it's a bug if you can grant permission to a non-existent topic. I will verify this release today. Thanks, Penghui On Tue, May 28, 2024 at 4:33 PM PengHui Li wrote: > Hi Cong, &g

Re: [VOTE] Release Apache Pulsar 3.3.0 based on 3.3.0-candidate-3

2024-05-28 Thread PengHui Li
Hi Cong, Thanks for driving the release. This PR https://github.com/apache/pulsar/pull/22547 has changed the behavior of permission operations on a topic. The issue is it will break the user's case which relies on the lazy auto-creation of the topic. They can grant permission to the topic but the

Re: [VOTE] PIP-354: apply topK mechanism to ModularLoadManagerImpl

2024-05-26 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, May 27, 2024 at 10:24 AM Kai Wang wrote: > +1 (non-binding) > > Thanks, > Kai >

Re: [VOTE] Release Apache Pulsar 3.2.3 based on 3.2.3-candidate-1

2024-05-17 Thread PengHui Li
+1 (binding) - Build from the source code - Checked the signatures - Start the standalone - Run the perf tests Penghui On Wed, May 15, 2024 at 1:33 PM guo jiwei wrote: > +1 (binding) > > - Build from source > - Checked the signatures > - Start standalone > - Verified producers and consumers >

Re: [VOTE] PIP-347: add role field in consumer's stat

2024-05-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Tue, May 14, 2024 at 5:50 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno mar 14 mag 2024 alle ore 11:31 太上玄元道君 ha > scritto: > > > +1 nonbinding > > > > Thanks, > > Tao Jiuming > > > > thetumbled 于2024年5月14日 周二17:26写道: > > > > > Hi, Pulsar Co

Re: [VOTE] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-08 Thread PengHui Li
+1 (binding) Regards, Penghui On Wed, May 8, 2024 at 6:58 PM Zixuan Liu wrote: > +1 (non-binding) > > Thanks, > Zixuan > > Yubiao Feng 于2024年5月8日周三 18:22写道: > > > +1 (binding) > > > > Thanks > > Yubiao Feng > > > > On Tue, May 7, 2024 at 11:25 AM Hang Chen wrote: > > > > > Hi guys, > > >

Re: [VOTE] PIP-348: Trigger offload on topic load stage

2024-05-08 Thread PengHui Li
+1 (binding) Penghui On Wed, May 8, 2024 at 8:27 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno mer 8 mag 2024 alle ore 12:51 Zike Yang ha > scritto: > > > +1 (binding) > > > > Thanks, > > Zike Yang > > > > On Wed, May 8, 2024 at 6:22 PM Yubiao Feng > > wrote: > > > > > > +

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-06 Thread PengHui Li
For the backlog quota check, I think we also need the same capacity. For configurable. I think the reason is users can have their plugins running with the broker which relies on the Pulsar topic. They don't want the application to change the TTL or backlog policies for some subscription/cursor. Bu

Re: [DISCUSS] PIP-349: Add systemCursorNames ignore list for TTL check

2024-05-05 Thread PengHui Li
LGTM, Regards, Penghui On Mon, May 6, 2024 at 2:02 PM Lari Hotari wrote: > LGTM, very useful. Thanks for driving this. > > -Lari > > On 2024/05/04 16:01:41 Hang Chen wrote: > > Hi guys, > > I proposed a new proposal to improve the TTL impact on system > > cursors. Please help take a look, t

Re: [DISCUSS] Apache Pulsar 3.3.0 release

2024-04-28 Thread PengHui Li
+1 Thanks for driving the release. Penghui On Sun, Apr 28, 2024 at 8:17 PM Cong Zhao wrote: > Hi community, > It has been more than three months since the release of 3.2.0. we now > have more than 280 commits > < > https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A3.3.0+is%3Amerged+

[DISCUSS] Cherry-pick topic load failed count metrics to release branches

2024-04-22 Thread PengHui Li
Hi, all I would like to start a discussion to cherry-pick https://github.com/apache/pulsar/pull/19236 to the release branches - branch-3.0 - branch-2.11 - branch-2.10 The topic load is a critical operation in Pulsar. If the topic not able to be loaded, the producer or consumer will not able to c

[ANNOUNCE] Zike Yang as a new PMC member in Apache Pulsar

2024-04-11 Thread PengHui Li
The Apache Pulsar Project Management Committee (PMC) has invited Zike Yang https://github.com/RobertIndie to join the PMC, and we are pleased to announce that he has accepted. Zike Yang is actively driving the Golang client release, contributing to multiple Pulsar repos, Golang client, CPP Client,

[ANNOUNCE] Baodi Shi as a new PMC member in Apache Pulsar

2024-04-11 Thread PengHui Li
The Apache Pulsar Project Management Committee (PMC) has invited Baodi Shi https://github.com/shibd to join the PMC, and we are pleased to announce that he has accepted. Baodi Shi is actively driving the NodeJS client release, contributing to multiple Pulsar repos, Nodejs client, CPP Client, Pytho

Re: [DISCUSS] cherry-pick #22034 Create new ledger after the current ledger is closed

2024-04-11 Thread PengHui Li
It sounds good to me. Regards, Penghui On Thu, Apr 11, 2024 at 9:05 PM Baodi Shi wrote: > Hi, xiangying. > > I agree with cherry-picking the historical branch. This change in behavior > is as expected, and it can indeed be understood as a bug. > > We can cherry-pick them all together after fixi

Re: [VOTE] Release Apache Pulsar 3.2.2 based on 3.2.2-candidate-1

2024-04-01 Thread PengHui Li
+1 (binding) - Build from source - Checked the signatures - Start standalone - Verified producers and consumers - Verified Cassandra connect - Verified Stateful function Regards, Penghui On Mon, Apr 1, 2024 at 3:49 PM guo jiwei wrote: > +1 (binding) > > - Built from source > - Checked the sign

Re: [VOTE] Pulsar Client C++ Release 3.5.1 Candidate 1

2024-03-31 Thread PengHui Li
+1 (binding) - Verified the signatures - Built from source on macOS m2 pro - Ran the producer and consumer Regards, Penghui On Mon, Apr 1, 2024 at 9:45 AM guo jiwei wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Ran the tests > > Regards > Ji

[DISCUSS] cherry-pick #21816 resolving the metrics missing issue for time-based backlog

2024-03-25 Thread PengHui Li
Hi all, I want to start a discussion to cherry-pick #21816[0] to release branches. This PR added the metrics for the time-based backlog, which is introduced in 2.8.0 [1]. However, there has always been a lack of relevant indicators to assist users in daily monitoring work. It becomes a blocker for

Re: [DISCUSS] Broken builds and CI Failures in Maintenance Branches; improving maintenance strategy to address root causes

2024-03-25 Thread PengHui Li
Hi, Lari Thanks for driving the discussion, and I agree that the cherry-picking is the pain especially when we need to maintain old branches for a long time. Frankly, my first impression is to target the bug fix to branch-3.0, but the features and improvements to the master branch will burden the

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-25 Thread PengHui Li
er add entries complete, add a index to `ManagedLedgerIndex` and > store the index to ML. What do you think? > > Thanks, > Tao Jiuming > > > > PengHui Li 于2024年3月25日周一 15:17写道: > > > Hi, Jiuming > > > > I'm sorry for not getting back to you sooner. &g

Re: [VOTE] PIP-344: Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)

2024-03-25 Thread PengHui Li
Hi, Yubiao It's better to list the names of the 3 bindings. Thanks, Penghui On Mon, Mar 25, 2024 at 4:58 PM Yubiao Feng wrote: > Close the vote with 3(binding). > > Thanks > Yubiao Feng > > On Sat, Mar 16, 2024 at 6:28 AM Yubiao Feng > wrote: > > > Hi All > > > > This thread is to start a vo

Re: [RESULT] [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-25 Thread PengHui Li
on > * PengHui > * Matteo > > Non-Binding +1s: > * Dao Jun > * Apurva > * Asaf > * Zixuan > > > Thanks, > Matteo > > > -- > Matteo Merli > > > > On Thu, Mar 14, 2024 at 11:54 PM Zixuan Liu wrote: > > > +1 (non-binding) > &g

Re: [VOTE] Pulsar Client Python Release 3.5.0 Candidate 2

2024-03-25 Thread PengHui Li
+1 (binding) - Checked the signature - Installed the wheel on macOS with Python 3.12 - Run the consume and produce examples Regards, Penghui On Fri, Mar 22, 2024 at 11:55 PM Yunze Xu wrote: > This is the 2nd release candidate for Apache Pulsar Client Python, > version 3.5.0. > > It fixes the f

Re: Suggestions on GitHub labels and issue templates

2024-03-25 Thread PengHui Li
The labels updates: - Removed the `java` label. We only have a few legacy PRs labeled with `java`. - Changed `component/*` to `area/*` - Deprecated `question` label - Changed `PIP` to `type/PIP` - Changed `flaky-test` to `type/flaky-test` On Mon, Mar 25, 2024 at 3:17 PM PengHui Li wrote: >

Re: Suggestions on GitHub labels and issue templates

2024-03-25 Thread PengHui Li
Yes, the PR is welcome. Best, Penghui On Mon, Mar 25, 2024 at 3:08 PM Kiryl Valkovich wrote: > Hi PengHui, > Sure. If the PR is welcome here, I’ll submit it in a few days. > > > Best, > Kiryl > > > On Mar 25, 2024, at 6:07 AM, PengHui Li wrote: > > >

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-25 Thread PengHui Li
Hi, Jiuming I'm sorry for not getting back to you sooner. First, I support the motivation to optimize this case because it could be a significant blocker for users who want infinite data retention, which is a BIG differentiator with Apache Kafka. And, I really saw the cases with high publish thro

Re: [DISCUSS] Release Pulsar Node.js client v1.11.0

2024-03-24 Thread PengHui Li
+1 Regards, Penghui On Mon, Mar 25, 2024 at 10:54 AM Baodi Shi wrote: > Hi all, > > I would like to propose releasing the Pulsar Node.js client v1.11.0 > > Due to Node.js's dependency on the CPP client, and considering that CPP > client version 3.5.0 has introduced many features and fixed numer

Re: Suggestions on GitHub labels and issue templates

2024-03-24 Thread PengHui Li
Hi Kiryl, Thanks for your suggestions, and they are looking good to me I'll follow your suggestions on renaming or deprecating the labels. For the label automation, do you want to push a PR to add it? Regards, Penghui On Mon, Mar 18, 2024 at 9:39 PM Kiryl Valkovich wrote: > Comment with bett

Re: [VOTE] PIP-344: Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)

2024-03-20 Thread PengHui Li
+1 (binding) Regards. Penghui On Sat, Mar 16, 2024 at 6:28 AM Yubiao Feng wrote: > Hi All > > This thread is to start a vote for PIP-344. > > PIP: https://github.com/apache/pulsar/pull/22182 > Discussion thread: > https://lists.apache.org/thread/z693blcxoqk0mj0rzyt1k7nvy72j18t5 > > Thanks > Yub

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread PengHui Li
+1 (binding) - Checked the signature - Tested the pre-build binaries on Mac (m2 pro) Regards, Penghui On Thu, Mar 14, 2024 at 9:12 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Upgrade the dependency of the python client and veri

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika wrote: > +1 (non-binding) > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang > wrote: > > > +1 (non-binding) > > > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao > > wrote: > > > > > +1 (binding) > > > > > > Best, > > >

Re: [VOTE] PIP-332: peek messages from topic subscription with offset value

2024-03-13 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Mar 11, 2024 at 12:17 PM Yunze Xu wrote: > +1 (binding) > > The proposal overall LGTM. But since the PIP itself and its > implementation are coupled in the same PR, I left minor comments in > that PR directly, which does not affect my +1. > > Thanks, > Yunz

Re: [VOTE] Pulsar Release 3.0.3 Candidate 1

2024-03-09 Thread PengHui Li
+1 (binding) - Checked the signatures - Build from the source - Checked the bookkeeper JNI libs org.apache.bookkeeper-circe-checksum-*.jar and org.apache.bookkeeper-cpu-affinity-*.jar - Verified the Cassandra connector - Verified the Stateful Function - Verified the Trino connector - Tested perfor

Re: [VOTE] Pulsar Release 2.10.6 Candidate 2

2024-03-08 Thread PengHui Li
+1 (binding) - Checked the signatures - Build from the source - Checked the bookkeeper JNI libs org.apache.bookkeeper-circe-checksum-*.jar and org.apache.bookkeeper-cpu-affinity-*.jar - Verified the Cassandra connector - Verified the Stateful Function - Verified the Trino connector - Tested perfor

Re: [VOTE] Pulsar Release 2.11.4 Candidate 1

2024-03-07 Thread PengHui Li
+1 (binding) - Checked the signatures - Build from the source - Checked the bookkeeper JNI libs org.apache.bookkeeper-circe-checksum-*.jar and org.apache.bookkeeper-cpu-affinity-*.jar - Verified the Cassandra connector - Verified the Stateful Function - Verified the Trino connector - Tested perfor

Re: [VOTE] Pulsar Release 3.2.1 Candidate 2

2024-03-07 Thread PengHui Li
+1 (binding) - Checked the signatures - Build from the source - Checked the bookkeeper JNI libs org.apache.bookkeeper-circe-checksum-*.jar and org.apache.bookkeeper-cpu-affinity-*.jar - Verified the Cassandra connector - Verified the Stateful Function - Verified the Trino connector - Tested perfor

Re: [VOTE] Pulsar Release 3.1.3 Candidate 2

2024-03-07 Thread PengHui Li
+1 (binding) - Checked the signatures - Build from the source - Checked the bookkeeper JNI libs org.apache.bookkeeper-circe-checksum-*.jar and org.apache.bookkeeper-cpu-affinity-*.jar - Verified the Cassandra connector - Verified the Stateful Function - Verified the Trino connector - Tested perfor

Re: [VOTE] Pulsar Client Go Release 0.12.1 Candidate 1

2024-03-07 Thread PengHui Li
+1 (binding) - Checked the signatures - Build and Run the local test. Regards, Penghui On Fri, Mar 8, 2024 at 12:55 PM Matteo Merli wrote: > +1 > > Verified checksums and signatures > Verified tests and local perf client > > -- > Matteo Merli > > > > On Wed, Mar 6, 2024 at 9:23 PM Yunze Xu w

Re: Pulsar Version upgrade guidelines

2024-03-07 Thread PengHui Li
Hi Girish, I have updated the Pulsar website https://pulsar.apache.org/contribute/release-policy/ ``` 3.0 -> 4.0 -> 3.0 is OK; 3.2 -> 4.0 -> 3.2 is OK; 3.2 -> 4.4 -> 3.2 is OK; 3.0 -> 3.1 -> 3.0 is OK; 3.0 -> 3.2 -> 3.0 is OK; 3.2 -> 5.0 is not OK. ``` Regards, Penghui On Wed, Mar 6, 2024 at

Re: [VOTE] PIP-343: Use picocli instead of jcommander

2024-03-07 Thread PengHui Li
+1 (binding) Regards, Penghui On Thu, Mar 7, 2024 at 7:40 PM guo jiwei wrote: > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Thu, Mar 7, 2024 at 1:14 AM 太上玄元道君 wrote: > > > +1 nonbinding > > > > Zixuan Liu 于2024年3月6日 周三23:04写道: > > > > > Hello, > > > > > > A new proposal to improve t

Re: [VOTE] Pulsar Release 3.2.1 Candidate 1

2024-03-06 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures - Run standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Regards, Penghui On Wed, Mar 6, 2024 at 3:38 PM guo jiwei wrote: > +1 (binding) > > - Built from source > - Checked the

Re: [ANNOUNCE] New Committer: Kiryl Valkovich

2024-03-05 Thread PengHui Li
Congratulations! On Wed, Mar 6, 2024 at 7:35 AM Kalwit S wrote: > Congratulations! > > On Tue, Mar 5, 2024 at 3:13 PM ZhangJian He wrote: > > > Congratulations! > > > > Thanks > > ZhangJian He > > > > > > On Wed, Mar 6, 2024 at 5:17 AM Enrico Olivelli > > wrote: > > > > > Congratulations! > >

Re: [VOTE] PIP-324: Alpine Docker images

2024-03-05 Thread PengHui Li
+1 (binding) Regards, Penghui On Wed, Mar 6, 2024 at 7:54 AM Lari Hotari wrote: > +1 (binding) > > > -Lari > > On Tue, 5 Mar 2024 at 23:48, Matteo Merli wrote: > > > > Opening the vote thread for PIP-324: Alpine Docker images > > > > https://github.com/apache/pulsar/pull/21716 > > > > WIP PR:

Re: [DISCUSS] Do not create partitioned metadata when calling pulsarClient.getPartitionsForTopic(topicName)

2024-02-29 Thread PengHui Li
Yes, it’s better to bump a protocol version to keep the compatibility. Regards, Penghui On Thu, Feb 29, 2024 at 16:13 Enrico Olivelli wrote: > Il Gio 29 Feb 2024, 08:46 PengHui Li ha scritto: > > > +1 for the motivation > > > > We should not create partiti

Re: [VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

2024-02-28 Thread PengHui Li
> > > > > > > On Tue, Feb 27, 2024 at 10:18 AM Zike Yang wrote: > > > > > > > > > > +1 (no-binding) > > > > > > > > > > > > > > BR, > > > > > > > Zike Yang > > &g

Re: [DISCUSS] Do not create partitioned metadata when calling pulsarClient.getPartitionsForTopic(topicName)

2024-02-28 Thread PengHui Li
+1 for the motivation We should not create partitioned topics when calling `pulsarClient.getPartitionsForTopic` The tricky part is the broker doesn't know if the partition metadata getting request is from create produce/consumer or just from pulsarClient.getPartitionsForTopic(topicName). We can

Re: [ANNOUNCE] New Committer: Asaf Mesika

2024-02-26 Thread PengHui Li
Congrats, Asaf. Penghui Li On Thu, Feb 22, 2024 at 8:17 PM Cong Zhao wrote: > Congratulations! > > Thanks, > Cong > > On 2024/02/20 16:50:29 Lari Hotari wrote: > > The Apache Pulsar Project Management Committee (PMC) has invited > > Asaf Mesika https://github.c

Re: [VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

2024-02-26 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Feb 26, 2024 at 5:44 PM Pengcheng Jiang wrote: > Hi, community > > I'm starting the vote for PIP-339: Introducing the --log-topic Option for > Pulsar Sinks and Sources > PIP link: https://github.com/apache/pulsar/pull/22071 > > Thanks, > Pengcheng Jiang >

Re: [DISCUSS] Apache Pulsar 3.1.3 Release

2024-02-26 Thread PengHui Li
+1 Thanks for driving the release. And it should be the last patch release of Apache Pulsar 3.1.0 Then, we will move to 3.2.x Regards, Penghui On Mon, Feb 26, 2024 at 8:08 PM ran leon wrote: > Dear the Apache Pulsar Dev community, > > I would like to propose releasing Apache Pulsar 3.1.3. > >

Re: [VOTE] Release Apache Pulsar Helm Chart 3.3.0 based on 3.3.0-candidate-1

2024-02-26 Thread PengHui Li
+1 (binding) - Deploy pulsar cluster on local docker-desktop(with Kubernetes) - Checked the signature - Checked the license Regards, Penghui On Sat, Feb 24, 2024 at 3:38 AM Lari Hotari wrote: > Hello Apache Pulsar Community, > > This is a call for the vote to release the Apache Pulsar Helm Cha

Re: [DISCUSSION] Proposal to Replace Pulsar's Homegrown Configuration Framework with Gestalt Config

2024-02-25 Thread PengHui Li
> It would be nice to just have the config library to read the environment variables directly, instead of having to write them down in the file. I guess it should be easy to have it with the existing homegrown configuration solution without completely moving to a new lib. For the other points suc

Re: [DISCUSS] PIP-338: Introducing the --log-topic Option for Pulsar Sinks and Sources

2024-02-25 Thread PengHui Li
Do we need to take the authorization into account? Users might need to take one more step to grant permission to access the log topic. It is better to mention it in the proposal. If users try to use one log topic for multiple functions, Is it easy for them to distinguish which function the logs ar

Re: [DISCUSS] Migrate CLI parser from jcommander to picocli

2024-02-25 Thread PengHui Li
+1 Great user experience improvement. Regards, Penghui On Sat, Feb 24, 2024 at 3:15 AM Zixuan Liu wrote: > > Can you please share some pointers ? > > Only `org.apache.pulsar.shell.ShellCommandsProvider#getJCommander` uses > jcommander API. I need to use picocli instead of jcommander, or add a n

Re: [DISCUSS] The strategy for upgrading to the latest feature release from LTS version

2024-02-25 Thread PengHui Li
Created a PR https://github.com/apache/pulsar-site/pull/795 to improve the doc. Regards, Penghui On Thu, Feb 1, 2024 at 8:56 AM PengHui Li wrote: > There is a question from Girish in the Pulsar Slack channel [0] asking if > users can > upgrade to the latest feature release from the LT

Re: [VOTE] Pulsar Release 3.2.0 Candidate 5

2024-02-02 Thread PengHui Li
t-cpp/pull/394 > > Thanks, > Yunze > > On Thu, Feb 1, 2024 at 8:57 AM PengHui Li wrote: > > > > +1 (binding) > > > > - Built from source > > - Checked the signatures > > - Run standalone > > - Checked producer and consumer > > - Verified

Re: [DISCUSS] PIP-335: Oxia metadata support

2024-01-31 Thread PengHui Li
+1 Best, Penghui On Thu, Feb 1, 2024 at 7:58 AM Matteo Merli wrote: > https://github.com/apache/pulsar/pull/22009 > > === > > # PIP-335: Supporty Oxia metadata store plugin > > # Motivation > > Oxia is a scalable metadata store and coordination system that can be used > as the core infr

Re: [VOTE] Pulsar Release 3.2.0 Candidate 5

2024-01-31 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures - Run standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Regards, Penghui On Wed, Jan 31, 2024 at 11:40 PM guo jiwei wrote: > This is the fifth release candidate for Apache Pul

[DISCUSS] The strategy for upgrading to the latest feature release from LTS version

2024-01-31 Thread PengHui Li
There is a question from Girish in the Pulsar Slack channel [0] asking if users can upgrade to the latest feature release from the LTS version directly. For example, from 3.0.0 to 3.2.0 (3.1.0 is skipped) The documentation[1] doesn't have a clear answer for this ``` 3.0 -> 4.0 -> 3.0 is OK; 3.2

Re: [DISCUSS] Add a policy to delivery messages to each consumers qually if message not contains key

2024-01-29 Thread PengHui Li
+1 BTW, instead of having a random key, can we just dispatch the messages without a key in the round-robin fashion? It just works like the Shared subscription. Regards, Penghui On Tue, Jan 30, 2024 at 2:32 AM Yubiao Feng wrote: > Hi all > > ### Background > Regarding Key_Shared mode, messages

Re: [VERIFY] Pulsar Release 3.2.0 Candidate 5

2024-01-29 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures - Run standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Regards, Penghui On Sat, Jan 27, 2024 at 11:15 PM guo jiwei wrote: > This is the fifth release candidate for Apache Pul

Re: [DISCUSS] PIP-332: peek messages from topic subscription with offset value

2024-01-28 Thread PengHui Li
Hi Dalaji, It sounds good to me. And I think you can start to draft the PIP and move to the vote stage. Regards, Penghui On Sat, Jan 20, 2024 at 3:33 AM Balaji Lakshmanan wrote: > Hi, > > Currently we are able to peek at any number of messages using the Pulsar > Java Admin API. > > However, w

Re: [DISCUSS] Release Pulsar Node.js client v1.10.0

2024-01-28 Thread PengHui Li
+1 Thanks for driving the release. Penghui On Mon, Jan 29, 2024 at 9:08 AM Baodi Shi wrote: > Hi all, > > I would like to propose releasing the Pulsar Node.js client v1.10.0 > > It has been over 5 months since the last release (1.9.0). There have > been many new features and bug fixes since th

Re: [VOTE] Release Apache Pulsar Helm Chart 3.2.0 based on 3.2.0-candidate-3

2024-01-24 Thread PengHui Li
+1 (binding) - Deploy pulsar cluster on local docker-desktop(with Kubernetes) - Checked the signature - Checked the license Regards, Penghui On Sun, Jan 21, 2024 at 4:45 PM Lari Hotari wrote: > Hello Apache Pulsar Community, > > This is a call for the vote to release the Apache Pulsar Helm Cha

Re: [VOTE] Pulsar Client Go Release 0.12.0 Candidate 3

2024-01-24 Thread PengHui Li
+1 (binding) - Build from source - Run tests on 3.1.2 - Run tests on 3.0.2 Regards, Penghui On Wed, Jan 24, 2024 at 2:59 PM Zike Yang wrote: > Hi everyone, > Please review and vote on the release candidate #3 for the version > 0.12.0, as follows: > [ ] +1, Approve the release > [ ] -1, Do not

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread PengHui Li
`brokerInterceptors` > config clearly to say TTL might not work if > `AppendBrokerTimestampMetadataInterceptor` is not configured. > > Thanks, > Yunze > > On Thu, Jan 18, 2024 at 10:41 AM PengHui Li wrote: > > > > > I don't think we should provide such an opt

Re: [VERIFY] Pulsar Release 3.2.0 Candidate 2

2024-01-17 Thread PengHui Li
It looks like something broke the behavior of the querystate from Pulsar Functions. 1. The querystate exit with `Reason: key 'hello' doesn't exist`, which the old version will not exit ``` lipenghui@lipenghuis-MacBook-Pro apache-pulsar-3.2.0 % bin/pulsar-admin functions querystate --tenant test -

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread PengHui Li
+1 (binding) Regards, Penghui On Wed, Jan 17, 2024 at 8:03 PM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Jan 17, 2024 at 6:55 PM guo jiwei wrote: > > > > +1 (binding) > > > > > > Regards > > Jiwei Guo (Tboy) > > > > > > On Wed, Jan 17, 2024 at 5:39 PM 太上玄元道君 wrote: > > > >

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread PengHui Li
ssue will not damage the data or cause the data loss. You can monitor it, to skip the backlogs. TTL is not the only way to evict backlogs. Thanks, Penghui On Thu, Jan 18, 2024 at 10:33 AM PengHui Li wrote: > > We should also improve the TTL: > > When client publish time > Ledger c

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread PengHui Li
= Ledger create time + Ledger rollover time. > > > > This change can make sure entry expired when client clock is not right. > > > > On 2024/01/17 04:31:16 PengHui Li wrote: > > > > User disabling `AppendBrokerTimestampMetadataInterceptor` does not > mean

Re: [VOTE]PIP-321: Split the responsibilities of namespace replication-clusters

2024-01-16 Thread PengHui Li
+1 (binding) Regards, Penghui On Tue, Jan 16, 2024 at 4:00 PM guo jiwei wrote: > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Tue, Jan 16, 2024 at 2:41 PM Xiangying Meng > wrote: > > > Dear Pulsar community, > > > > I am initiating a voting thread for "PIP-321: Split the responsibili

Re: [VOTE] PIP-329: Strategy for maintaining the latest tag to Pulsar docker images

2024-01-16 Thread PengHui Li
+1 (binding) Regards, Penghui On Wed, Jan 17, 2024 at 11:05 AM guo jiwei wrote: > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Mon, Jan 15, 2024 at 5:50 PM Zixuan Liu wrote: > > > +1(non-binding) > > > > Thanks, > > Zixuan > > > > Zike Yang 于2024年1月15日周一 16:14写道: > > > > > Hi, all >

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-16 Thread PengHui Li
s follows: > > BrokerPublishTime > BrokerTimestamp > > If `BrokerPublishTime` exists, `BrokerReceiveTime` is not set. > If not, we set `BrokerReceiveTime` and is no longer affected by client > time. > > On 2024/01/15 02:15:17 PengHui Li wrote: > > IMO, we should enable

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-14 Thread PengHui Li
IMO, we should enable `AppendBrokerTimestampMetadataInterceptor` by default. Users can still have a way to disable it if they care about the additional metadata stored in each entry. For the `hasBrokerPublishTime` API. The topic might also have historical data without broker publish time. So, it s

Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145

2024-01-14 Thread PengHui Li
Do we have a workaround for this break change? Is disabling PIP-145 can help with it? Regards, Penghui On Fri, Jan 12, 2024 at 6:29 PM Yubiao Feng wrote: > Hi all > > I noticed that the PIP-145 made a break change that caused clients to not > subscribe to partitioned topics with a suffix-matche

Re: [VOTE] PIP-325: Add command to abort transaction

2024-01-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli wrote: > +1 (binding) > > > Enrico > > Il Lun 8 Gen 2024, 03:55 ruihongzhou ha > scritto: > > > Hi community, > > > > This thread is to start a vote for PIP-325: Add command to abort > > transaction. > > > > PIP: http

Re: [VOTE] Pulsar Client Python Release 3.4.0 Candidate 1

2023-12-28 Thread PengHui Li
+1 (binding) - Checked the signature - Install the pulsar_client-3.4.0-cp39-cp39-macosx_10_15_universal2.whl - Run Pulsar standalone - Run the Python examples `python3 ./examples/consumer.py` and `python3 ./examples/producer.py` Regards, Penghui On Tue, Dec 26, 2023 at 4:54 PM Zike Yang wrote:

Re: [VOTE] Pulsar Release 2.11.3 Candidate 2

2023-12-28 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures - Run standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Regards, Penghui On Mon, Dec 25, 2023 at 9:19 PM guo jiwei wrote: > +1 (binding) > > > - Checked the signatures > - Bui

Re: [VOTE] Pulsar Release 3.1.2 Candidate 2

2023-12-28 Thread PengHui Li
+1 (binding) - Built from source - Checked the signatures - Run standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Regards, Penghui On Mon, Dec 25, 2023 at 10:34 PM houxiaoyu wrote: > bump > > Enrico Olivelli 于2023年12月18日周一 21:21写道:

Re: [DISCUSS] PIP-328: Add a topicDeleteProtectionEnable configuration option.

2023-12-27 Thread PengHui Li
-1 It should be part of the ACLs, not a configuration. Now, only the tenant admin or super user can delete the topic. You can leverage Pulsar's AuthorizationProvider to implement fine-grained access control since Pulsar doesn't have it right now. But Pulsar has already defined the operation Namesp

Re: [DISCUSS] Removing Pulsar-Trino plugin from main repo and call for volunteers to maintain it

2023-12-24 Thread PengHui Li
+1 Regards, Penghui On Mon, Dec 25, 2023 at 10:06 AM guo jiwei wrote: > yes, +1 agree > > > Regards > Jiwei Guo (Tboy) > > > On Sat, Dec 23, 2023 at 11:37 AM Matteo Merli > wrote: > > > Good point. I have created a PR here: > > https://github.com/apache/pulsar/pull/21795 > > > > We can always

Re: [VOTE] PIP-326: Create a BOM to ease dependency management

2023-12-24 Thread PengHui Li
+1 (binding) Regards, Penghui On Sat, Dec 23, 2023 at 12:18 PM houxiaoyu wrote: > +1 non-binding > > Best, > houxiaoyu > > tison 于2023年12月23日周六 10:10写道: > > > +1 binding > > > > Best, > > tison. > > > > 太上玄元道君 于2023年12月23日周六 09:06写道: > > > > > > +1 nonbinding > > > > > > Umut Bilal Okur 于2023

Re: [VOTE] Release Apache Pulsar Helm Chart 3.1.0 based on 3.1.0-candidate-1

2023-12-20 Thread PengHui Li
+1 (binding) Tested with Docker Desktop integrated with k8s v1.27. - Deployed a cluster by using helm install pulsar apache-pulsar-dist-dev/pulsar --set affinity.anti_affinity=false - Tested produce and consume Regards, Penghui On Wed, Dec 20, 2023 at 12:25 AM Lari Hotari wrote: > +1 > > - Va

Re: [DISCUSS] PIP-327 Support force topic loading for unrecoverable errors

2023-12-20 Thread PengHui Li
Hi Rajan, I tried to test the case that you provided in the proposal. - Produce messages to a topic - Unload the topic 5 times to ensure we have some ledgers in the topic - Delete one ledger by using the bookkeeper shell - Unload the topic again - Start to produce messages again, it works - Start

Re: [VOTE] PIP-282: Change definition of the recently joined consumers position

2023-12-19 Thread PengHui Li
+1 Thanks, Penghui On Tue, Dec 19, 2023 at 3:58 PM Yubiao Feng wrote: > +1 > > Thanks > Yubiao Feng > > On Tue, Nov 28, 2023 at 4:04 PM Yuri Mizushima wrote: > > > Hi, Pulsar Community > > > > This thread is starting a vote for PIP-282. > > > > PIP design PR: > > https://github.com/apache/puls

  1   2   3   4   5   6   7   8   9   10   >