Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-06 Thread Hang Chen
Hi guys, If there are no objections, I will send out the vote. Best, Hang Hang Chen 于2024年5月6日周一 22:23写道: > > >I see, but when a broker loads a bundle with many topics, you trigger > immediately offloading for them, even if they don't have much traffic. > This is kind of a "bad surprise" wh

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-06 Thread Hang Chen
>I see, but when a broker loads a bundle with many topics, you trigger immediately offloading for them, even if they don't have much traffic. This is kind of a "bad surprise" when you update a cluster to the newer version and you don't expect load to spike unexpectedly. My concerns is only about th

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-06 Thread Enrico Olivelli
Il giorno lun 6 mag 2024 alle ore 04:15 Hang Chen ha scritto: > Hi Enrico, > I agree with Jiuming, we do not need a flag to control this > behavior. We will call `maybeOffloadInBackground` method in the > managedledger init stage. This method only checks the offload policies > to decide if we

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-05 Thread Hang Chen
Hi Enrico, I agree with Jiuming, we do not need a flag to control this behavior. We will call `maybeOffloadInBackground` method in the managedledger init stage. This method only checks the offload policies to decide if we need to trigger offload. If the offload conditions are met, use the sched

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-05 Thread 太上玄元道君
hi Enrico, I still think it doesn't matter 1. Offload a topic or not, configured by `managedLedgerOffloadAutoTriggerSizeThresholdBytes`/`managedLedgerOffloadThresholdInSeconds`, even though we may trigger a bunch of stuff, it's expected behavior 2. After triggered to offload a topic, the offload

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-04 Thread Enrico Olivelli
daojun, Il giorno sab 4 mag 2024 alle ore 22:06 太上玄元道君 ha scritto: > it doesn't matter, we don't need to wait until offload finished when > loading topic, since offloading may take a long time. > it just trigger offloading, and we don't need to handle the result. > We don't have to wait for the

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-04 Thread 太上玄元道君
it doesn't matter, we don't need to wait until offload finished when loading topic, since offloading may take a long time. it just trigger offloading, and we don't need to handle the result. Enrico Olivelli 于2024年5月5日 周日02:41写道: > Overall I think it is a good idea. > > What about adding a flag to

Re: [DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-04 Thread Enrico Olivelli
Overall I think it is a good idea. What about adding a flag to enable this behavior? In case there are problems with the offloader the topic won't be able to load. Enrico Il Sab 4 Mag 2024, 17:12 Hang Chen ha scritto: > Hi guys, > I pushed a new proposal to improve the tiered storage off

[DISCUSS] PIP-348: Trigger offload on topic load stage

2024-05-04 Thread Hang Chen
Hi guys, I pushed a new proposal to improve the tiered storage offload efficiency. Please help take a look, thanks. PIP: https://github.com/apache/pulsar/pull/22650 Thanks, Hang