RE: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-29 Thread Joo Hyuk Kim
May I make a proposal : adding `remote` flag also?  #Concern : It seems like we are sort of allowing users to assume what the ones without `local` flag are (are called by the community). #Possible Benfit : Users will benefit from not having to think about what ` non-local` clusters are called.

Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-27 Thread guo jiwei
Thanks. addressed in the PIP Regards Jiwei Guo (Tboy) On Sun, Jun 25, 2023 at 6:05 PM PengHui Li wrote: > Hi Jiwei, > > Do you need to change the REST API? or will it just apply to the Admin CLI? > If it requires REST API changes, you should also reflect them in the > proposal. > > And yes,

Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-25 Thread PengHui Li
Hi Jiwei, Do you need to change the REST API? or will it just apply to the Admin CLI? If it requires REST API changes, you should also reflect them in the proposal. And yes, using the local and remote will be confusing because users can have multiple clusters without geo-replication. Maybe we

Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-25 Thread Zixuan Liu
+1, this is a good improvement. In the proposal, I don't suggest you append the `local` to the cluster name: 1. It will be confusing when the original cluster name includes the `local` name 2. In some cases, it is not easy to distinguish between local and remote clusters so I suggest we should

RE: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-24 Thread Joo Hyuk Kim
May I make a proposal : adding `remote` flag also?  #Concern : It seems like we are sort of allowing users to assume what the ones without `local` flag are (are called by the community). #Possible Benfit : Users will benefit from not having to think about what ` non-local` clusters are called.