rdhabalia commented on a change in pull request #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#discussion_r130805588
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -338,15 +338,25 @
rdhabalia commented on issue #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#issuecomment-319595641
[re-trigger of
build](https://builds.apache.org/job/pulsar-pull-request/28/org.apache.pulsar$pulsar-broker/testReport/org.apache.pulsar.broker.servic
Hi Matteo:
> On Jul 31, 2017, at 5:10 PM, Matteo Merli wrote:
>
> On Mon, Jul 31, 2017 at 4:53 PM, Dave Fisher wrote:
>
>> Hi Pulsar Team,
>>
>> I’ve been doing my checks so far so good. I do have two concerns:
>>
>> The license for Aspect J is the EPL 1.0 which is Category B -
>> https://ww
On Wed, Aug 2, 2017 at 8:30 AM, Dave Fisher wrote:
> > We use AspectJ to instrument ZooKeeper server and client, in order to
> > collect and expose metrics that are not available in ZooKeeper itself.
> > At this point is not optional and it's not possible to turn it off.
>
> If someone took the S
merlimat opened a new issue #622: Intermittent test failures in
SimpleProducerConsumerTest.testSendCallBack
URL: https://github.com/apache/incubator-pulsar/issues/622
As seen in
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/30/testReport/junit/org.apache
merlimat opened a new issue #623: Intermittent test failure in
SLAMonitoringTest.testUnloadIfBrokerCrashes
URL: https://github.com/apache/incubator-pulsar/issues/623
As seen in
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/24/testReport/junit/org.apache.
merlimat opened a new issue #624: Intermittent test failure in
SimpleProducerConsumerTest.testBlockUnackConsumerAckByDifferentConsumer
URL: https://github.com/apache/incubator-pulsar/issues/624
As seen in
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/21/
As most of you have seen, we have a bunch of intermittent test failures.
This, added to the difficulties in rebuilding a pull-request and updating
the status lead to a bit of a cumbersome process to get a PR merged.
I have created issues for the tests I've seen failing and marked them with
label
merlimat opened a new pull request #625: Enable/Disable compilation of dynamic
lib for C++ client
URL: https://github.com/apache/incubator-pulsar/pull/625
### Motivation
Add an option in CMake build to disable compiling the dynamic library for
the C++ client.
Currently, all
> On Aug 2, 2017, at 10:03 AM, Matteo Merli wrote:
>
> On Wed, Aug 2, 2017 at 8:30 AM, Dave Fisher wrote:
>
>>> We use AspectJ to instrument ZooKeeper server and client, in order to
>>> collect and expose metrics that are not available in ZooKeeper itself.
>>> At this point is not optional and
merlimat commented on issue #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#issuecomment-319765925
@rdhabalia I think the only way to get the "rebuild" to work is to use the
proper Jenkins GitHub PR plugin.. but then I think it will just comment on
merlimat commented on issue #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#issuecomment-319768109
retest this please
This is an automated message from the Apache Git Service.
To resp
merlimat commented on issue #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#issuecomment-319768235
@rdhabalia Seen my previous comment? It triggered a new build, and this time
it will update the status
-
merlimat commented on issue #620: added new entrypoint for reader to websocket
proxy
URL: https://github.com/apache/incubator-pulsar/pull/620#issuecomment-319770854
retest this please
This is an automated message from the Ap
merlimat commented on issue #623: Intermittent test failure in
SLAMonitoringTest.testUnloadIfBrokerCrashes
URL:
https://github.com/apache/incubator-pulsar/issues/623#issuecomment-319771144
Happened again at
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/
Reading on the Jenkins Github plugin documentation at
https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin
You can trigger the build of a PR by adding a comment "retest this please"
on the PR itself. This will kick a new build that will properly update the
PR status.
This wi
Remainder for all committers:
please check the release artifacts and vote on this thread, before tomorrow
3pm PDT.
Vote as in :
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
The documentation on the release proc
merlimat commented on issue #615: Allow to compile C++ client lib in debug mode
URL: https://github.com/apache/incubator-pulsar/pull/615#issuecomment-319778630
@jai1 Can you check again?
This is an automated message from the
merlimat opened a new pull request #626: Reduce memory settings for
LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626
### Motivation
Reduce the amount of memory used for cache during the unit tests execution.
-
rdhabalia commented on a change in pull request #626: Reduce memory settings
for LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#discussion_r13090
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
merlimat commented on a change in pull request #626: Reduce memory settings for
LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#discussion_r130989284
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
Hi -
I will cast an IPMC vote.
+1 Release!
I checked the source and binary package hashes.
I built the project with Maven from the source package.
I ran the rat check and checked the rat report.
Discussed the Category B issues which look good for now.
Regards,
Dave
> On Aug 2, 2017, at 12:47 P
merlimat commented on a change in pull request #626: Reduce memory settings for
LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#discussion_r130989467
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
Another option would be to make the Jenkins build status non-mandatory for
merging the PRs.
In this case, if we see any known flaky tests, we could proceed with
merging. For any new failing test, we
should re-run the build and create a new issue to track it.
Pros:
* We don't have to spend big
rdhabalia commented on a change in pull request #626: Reduce memory settings
for LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#discussion_r130994828
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
merlimat opened a new pull request #627: Reduce thread executor pool sizes when
running unit tests
URL: https://github.com/apache/incubator-pulsar/pull/627
### Motivation
Since we're starting and stopping the pulsar broker during the unit tests
execution, we should reduce the amount
rdhabalia commented on a change in pull request #627: Reduce thread executor
pool sizes when running unit tests
URL: https://github.com/apache/incubator-pulsar/pull/627#discussion_r130997761
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
merlimat commented on a change in pull request #627: Reduce thread executor
pool sizes when running unit tests
URL: https://github.com/apache/incubator-pulsar/pull/627#discussion_r130998656
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
#
> Another option would be to make the Jenkins build status non-mandatory for
merging the PRs.
Then we might want to be careful before merging because flaky tests might
be failing due to genuine reason or bug. Probably, we can keep it enable
for sometime and disable if we really think that flaky te
+1. I ran the regression-tests and few of the load-tests with this version
and looks fine.
Thanks,
Rajan
On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher wrote:
> Hi -
>
> I will cast an IPMC vote.
>
> +1 Release!
>
> I checked the source and binary package hashes.
> I built the project with Maven f
merlimat closed pull request #615: Allow to compile C++ client lib in debug mode
URL: https://github.com/apache/incubator-pulsar/pull/615
This is an automated message from the Apache Git Service.
To respond to the message, p
merlimat commented on issue #616: Don't attach pulsar-*-{src,bin}.tar.gz to
maven artifacts
URL: https://github.com/apache/incubator-pulsar/pull/616#issuecomment-319818895
retest this please
This is an automated message from
merlimat opened a new pull request #628: Docker image to build website in
Jenkins
URL: https://github.com/apache/incubator-pulsar/pull/628
### Motivation
Building the website requires few dependencies, like Ruby and Jekyll, plus
some more tools to have auto-generated docs (Doxygen,
merlimat commented on issue #612: Intermittent test failure on
NonPersistentTopicTest
URL:
https://github.com/apache/incubator-pulsar/issues/612#issuecomment-319825429
This one is reproducible locally. There is an exception in the `sendAsync()`
:
```
java.util.concurrent.Timeou
merlimat commented on issue #612: Intermittent test failure on
NonPersistentTopicTest
URL:
https://github.com/apache/incubator-pulsar/issues/612#issuecomment-319825777
It's because the 1sec timeout is sometimes too short. I have a fix for this
merlimat opened a new pull request #629: Fix #612: NonPersistentTopicTest test
timeout was too short and sometimes failed
URL: https://github.com/apache/incubator-pulsar/pull/629
### Motivation
Use default timeout of 30s in the producer rate limit test. The 1sec was
failing multiple
merlimat commented on issue #626: Reduce memory settings for LocalBookieEsemble
in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#issuecomment-319827050
please retest this
This is an automated message fr
merlimat commented on issue #626: Reduce memory settings for LocalBookieEsemble
in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#issuecomment-319827050
please retest this
This is an automated message fr
merlimat commented on issue #626: Reduce memory settings for LocalBookieEsemble
in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#issuecomment-319827190
retest this please
This is an automated message fr
merlimat opened a new issue #630: Intermittent C++ test failure in
LatchTest.testTimedWait
URL: https://github.com/apache/incubator-pulsar/issues/630
As seen on https://builds.apache.org/job/pulsar-pull-request/45/console
```
[35/75] LatchTest.testTimedWait (108 ms)
log4cxx: Could
rdhabalia opened a new pull request #631: remove duplicate dynamic-config
listener call
URL: https://github.com/apache/incubator-pulsar/pull/631
### Motivation
right now, dynamic-config listener was being registered twice in
`configRegisteredListeners-map` and
`ZooKeeperDataCache(
+1 (non-binding)
- verified the packages (md5, sha1 and signature)
- maven artifacts looks good to me.
- successfully build the source package
- run the binary package following the instructions in the website
- Sijie
On Wed, Aug 2, 2017 at 3:07 PM, Rajan Dhabalia wrote:
> +1. I ran the regres
merlimat closed issue #612: Intermittent test failure on NonPersistentTopicTest
URL: https://github.com/apache/incubator-pulsar/issues/612
This is an automated message from the Apache Git Service.
To respond to the message,
merlimat closed pull request #629: Fix #612: NonPersistentTopicTest test
timeout was too short and sometimes failed
URL: https://github.com/apache/incubator-pulsar/pull/629
This is an automated message from the Apache Git S
hrsakai commented on issue #620: added new entrypoint for reader to websocket
proxy
URL: https://github.com/apache/incubator-pulsar/pull/620#issuecomment-319836417
retest this please
This is an automated message from the Apa
merlimat commented on issue #618: Intermittent failures in C++ unit test
BasicEndToEndTest.testResendViaSendCallback
URL:
https://github.com/apache/incubator-pulsar/issues/618#issuecomment-319837467
Seen again in https://builds.apache.org/job/pulsar-pull-request/49/console
```
lo
+1
- Confirmed md5
- Checked the build success
- Ran the binaries
Thanks!
Nozomi
2017/08/03 9:32 に、"Sijie Guo" を書き込みました:
+1 (non-binding)
- verified the packages (md5, sha1 and signature)
- maven artifacts looks good to me.
- successfully build the source package
- ru
merlimat opened a new pull request #632: Splitted Admin API reference into
multiple pages
URL: https://github.com/apache/incubator-pulsar/pull/632
### Motivation
Split the "Admin API" reference into multiple pages and promote it to its
own sections in the left website sidebar.
rdhabalia commented on a change in pull request #627: Reduce thread executor
pool sizes when running unit tests
URL: https://github.com/apache/incubator-pulsar/pull/627#discussion_r131003726
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
hrsakai commented on issue #620: added new entrypoint for reader to websocket
proxy
URL: https://github.com/apache/incubator-pulsar/pull/620#issuecomment-319844839
retest this please
This is an automated message from the Apa
+1 (non-binding)
- verified the packages (md5, sha1 and signature)
- Checked the build success
- Run the binaries by 'bin/pulsar standalone'
On Thu, Aug 3, 2017 at 8:57 AM, Nozomi Kurihara
wrote:
> +1
>
> - Confirmed md5
> - Checked the build success
> - Ran the binaries
>
> Thanks!
>
> Nozomi
>
saandrews opened a new issue #633: Introduce end to end encryption in Pulsar
Client
URL: https://github.com/apache/incubator-pulsar/issues/633
Expected behavior
Support end to end encryption to make it easier for clients to encrypt their
data published to Pulsar.
https://github.com/apache/incubator-pulsar/wiki/PIP-4:-Pulsar-End-to-End-Encryption
Please go over and provide your Feedback/comments.
Thanks,
Andrews.
rdhabalia opened a new pull request #634: Introduce message-dispatch rate
limiting
URL: https://github.com/apache/incubator-pulsar/pull/634
### Motivation
As discussed in
[PIP](https://github.com/apache/incubator-pulsar/wiki/PIP-3:-Message-dispatch-throttling),
adding message-rate
merlimat closed pull request #626: Reduce memory settings for
LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626
This is an automated message from the Apache Git Service.
To respond to
merlimat commented on issue #625: Enable/Disable compilation of dynamic lib for
C++ client
URL: https://github.com/apache/incubator-pulsar/pull/625#issuecomment-319877638
retest this please
This is an automated message from
merlimat commented on issue #625: Enable/Disable compilation of dynamic lib for
C++ client
URL: https://github.com/apache/incubator-pulsar/pull/625#issuecomment-319877695
please retest this
This is an automated message from
merlimat commented on issue #625: Enable/Disable compilation of dynamic lib for
C++ client
URL: https://github.com/apache/incubator-pulsar/pull/625#issuecomment-319877695
please retest this
This is an automated message from
merlimat commented on issue #625: Enable/Disable compilation of dynamic lib for
C++ client
URL: https://github.com/apache/incubator-pulsar/pull/625#issuecomment-319877638
retest this please
This is an automated message from
rdhabalia commented on issue #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619#issuecomment-319877898
retest this please
This is an automated message from the Apache Git Service.
To res
rdhabalia commented on issue #631: remove duplicate dynamic-config listener call
URL: https://github.com/apache/incubator-pulsar/pull/631#issuecomment-319877948
retest this please
This is an automated message from the Apache
61 matches
Mail list logo
