Review Request 23122: Proton map/hash entries can disappear

2014-06-27 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23122/ --- Review request for qpid and Rafael Schloming. Bugs: PROTON-617

[jira] [Updated] (QPID-5847) Closing 0-8..0-9-1 messaging connection from management occasionally ends with 409 conflict

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5847: - Summary: Closing 0-8..0-9-1 messaging connection from management occasionally ends with 409 conflict

[jira] [Created] (QPID-5856) Closing 0-10 messaging connection from management leads to spurious exception and timeout

2014-06-27 Thread Keith Wall (JIRA)
Keith Wall created QPID-5856: Summary: Closing 0-10 messaging connection from management leads to spurious exception and timeout Key: QPID-5856 URL: https://issues.apache.org/jira/browse/QPID-5856

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster Session exception occured while trying to commit

2014-06-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/#review46845 --- The client shouldn't have to do a full execution-sync. It should be

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster Session exception occured while trying to commit

2014-06-27 Thread Gordon Sim
On June 27, 2014, 8:27 a.m., Gordon Sim wrote: The client shouldn't have to do a full execution-sync. It should be sufficient to set the sync flag on the method. Skimming the broker code, I don't see where async handling for a commit would happen. It looks to me like perhaps the

Re: Review Request 23096: QPID-5855 JAVA Client Can not recieve message with qpid ha cluster Session exception occured while trying to commit

2014-06-27 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23096/#review46847 --- The code you highlighted around 'needSync' and the whole 'sync

Re: How to enable linearstore?

2014-06-27 Thread Pavel Moravec
Resolved by myself. QPIDC_MODULE_DIR was defined to my _installed_ qpid copy in /usr/local/lib64/qpid/client (including legacystore) and that variable was used as default value of --module-dir option. So legacystore was loaded from installed but not built qpid. Setting --module-dir=./src/

Review Request 23125: reduction of throughput regression

2014-06-27 Thread mick goulish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23125/ --- Review request for qpid, Alan Conway and Gordon Sim. Repository: qpid

Re: Review Request 23125: reduction of throughput regression

2014-06-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23125/#review46848 --- trunk/qpid/cpp/src/qpid/broker/MessageBuilder.cpp

Re: Review Request 23122: Proton map/hash entries can disappear

2014-06-27 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23122/#review46849 --- The fix looks good, but it would be nice to see a test case for

Re: Review Request 23122: Proton map/hash entries can disappear

2014-06-27 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23122/#review46850 --- Ship it! Oops, I just noticed the test case you added to the JIRA.

[jira] [Updated] (QPID-5856) Closing 0-10 messaging connection from management leads to spurious exception and timeout

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5856: - Description: If I close a messaging connection from the REST interface whist the connection is busy, the

[jira] [Updated] (QPID-5856) Closing 0-10 messaging connection from management leads to spurious exception and timeout

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5856: - Description: If I close a messaging connection from the REST interface whist the connection is busy, the

[jira] [Created] (QPID-5857) [Java Broker] Test ConsumerLoggingTest.testSubscriptionCreateQueue sporadically fails

2014-06-27 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-5857: Summary: [Java Broker] Test ConsumerLoggingTest.testSubscriptionCreateQueue sporadically fails Key: QPID-5857 URL: https://issues.apache.org/jira/browse/QPID-5857 Project:

[jira] [Updated] (QPID-5857) [Java Broker] Test ConsumerLoggingTest.testSubscriptionCreateQueue sporadically fails

2014-06-27 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-5857: - Status: Reviewable (was: In Progress) [Java Broker] Test

[jira] [Assigned] (QPID-5857) [Java Broker] Test ConsumerLoggingTest.testSubscriptionCreateQueue sporadically fails

2014-06-27 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-5857: Assignee: Keith Wall (was: Alex Rudyy) Keith, Could you please review the change I made to improve

[jira] [Commented] (QPID-5854) Qpid C++ broker Connection objects need to supply host and peer network hostnames

2014-06-27 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045911#comment-14045911 ] Chuck Rolke commented on QPID-5854: --- The description for this jira is assuming that the

[jira] [Updated] (QPID-5856) Closing 0-10 messaging connection from management leads to spurious exception and timeout

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5856: - Affects Version/s: 0.29 0.28 0.22

[jira] [Commented] (QPID-5847) Closing 0-8..0-9-1 messaging connection from management occasionally ends with 409 conflict

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045950#comment-14045950 ] Keith Wall commented on QPID-5847: -- Demonstrated that the same issue exists at least as

[jira] [Updated] (QPID-5847) Closing 0-8..0-9-1 messaging connection from management occasionally ends with 409 conflict

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5847: - Attachment: 0001-NO-JIRA-dont-commit-yet-CRT-that-kills-busy-connecti.patch Closing 0-8..0-9-1 messaging

[jira] [Updated] (QPID-5847) Closing 0-8..0-9-1 messaging connection from management occasionally ends with 409 conflict

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5847: - Affects Version/s: 0.28 0.22 0.24

[jira] [Commented] (QPID-5856) Closing 0-10 messaging connection from management leads to spurious exception and timeout

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045949#comment-14045949 ] Keith Wall commented on QPID-5856: -- Demonstrated that the same issue exists at least as

[jira] [Commented] (QPID-5847) Closing 0-8..0-9-1 messaging connection from management occasionally ends with 409 conflict

2014-06-27 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045955#comment-14045955 ] Keith Wall commented on QPID-5847: -- Attached patch that can be used to reproduce the issue

[jira] [Commented] (QPID-5853) [Java Broker] System tests starting spawn broker(s) fail when the project location has spaces

2014-06-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046009#comment-14046009 ] ASF subversion and git services commented on QPID-5853: --- Commit

[jira] [Commented] (QPID-619) MandatoryMessageTest fails occasionally

2014-06-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046093#comment-14046093 ] ASF subversion and git services commented on QPID-619: -- Commit 1606140

Review Request 23130: Removing wrapped types from proton swigged bindings

2014-06-27 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/ --- Review request for qpid and Darryl Pierce. Bugs: PROTON-620

[jira] [Created] (QPID-5858) Session::checkError() throws exceptions of wring type

2014-06-27 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-5858: Summary: Session::checkError() throws exceptions of wring type Key: QPID-5858 URL: https://issues.apache.org/jira/browse/QPID-5858 Project: Qpid Issue Type: Bug

[jira] [Updated] (QPID-5858) Session::checkError() throws exceptions of wrong type

2014-06-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-5858: - Summary: Session::checkError() throws exceptions of wrong type (was: Session::checkError() throws

Re: Review Request 23130: Removing wrapped types from proton swigged bindings

2014-06-27 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46894 --- Ship it! Ship It! - Rafael Schloming On June 27, 2014, 5:06

Re: Review Request 23130: Removing wrapped types from proton swigged bindings

2014-06-27 Thread Darryl Pierce
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46895 --- proton/trunk/proton-c/bindings/python/cproton.i

Re: Review Request 23130: Removing wrapped types from proton swigged bindings

2014-06-27 Thread Andrew Stitcher
On June 27, 2014, 7:10 p.m., Darryl Pierce wrote: proton/trunk/proton-c/bindings/python/cproton.i, line 40 https://reviews.apache.org/r/23130/diff/1/?file=619420#file619420line40 These methods are used by the Ruby and Perl bindings. I know - that's why I only removed them from the

Re: Review Request 23130: Removing wrapped types from proton swigged bindings

2014-06-27 Thread Darryl Pierce
On June 27, 2014, 7:10 p.m., Darryl Pierce wrote: proton/trunk/proton-c/bindings/python/cproton.i, line 40 https://reviews.apache.org/r/23130/diff/1/?file=619420#file619420line40 These methods are used by the Ruby and Perl bindings. Andrew Stitcher wrote: I know - that's why

[jira] [Created] (QPID-5859) Qpidd only listens to protocols that are already up when it starts

2014-06-27 Thread Andrew Stitcher (JIRA)
Andrew Stitcher created QPID-5859: - Summary: Qpidd only listens to protocols that are already up when it starts Key: QPID-5859 URL: https://issues.apache.org/jira/browse/QPID-5859 Project: Qpid

[jira] [Assigned] (QPID-5859) Qpidd only listens to protocols that are already up when it starts

2014-06-27 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned QPID-5859: - Assignee: Andrew Stitcher Qpidd only listens to protocols that are already up when it

[jira] [Commented] (QPID-5859) Qpidd only listens to protocols that are already up when it starts

2014-06-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046341#comment-14046341 ] ASF subversion and git services commented on QPID-5859: --- Commit

Re: Review Request 23130: Removing wrapped types from proton swigged bindings

2014-06-27 Thread Darryl Pierce
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46903 --- Ship it! Ship It! - Darryl Pierce On June 27, 2014, 5:06 p.m.,

[jira] [Resolved] (QPID-5859) Qpidd only listens to protocols that are already up when it starts

2014-06-27 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved QPID-5859. --- Resolution: Fixed Fix Version/s: 0.29 Qpidd only listens to protocols that are

Review Request 23138: Last time, I promise, for throughput regression improvement.

2014-06-27 Thread mick goulish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23138/ --- Review request for qpid, Alan Conway and Gordon Sim. Repository: qpid

[jira] [Resolved] (QPID-5714) Skip python tests if test code is missing

2014-06-27 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved QPID-5714. --- Resolution: Fixed Looks like this was reopened but then resolved - resolving to cleanly mark

[jira] [Commented] (QPID-620) org.apache.qpid.test.unit.topic.DurableSubscriptionTest failed

2014-06-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046357#comment-14046357 ] ASF subversion and git services commented on QPID-620: -- Commit 1606206

[jira] [Created] (QPID-5860) Sender lock held when invoking on Session

2014-06-27 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-5860: Summary: Sender lock held when invoking on Session Key: QPID-5860 URL: https://issues.apache.org/jira/browse/QPID-5860 Project: Qpid Issue Type: Bug

Re: Review Request 22975: bz693721 - Session names longer than 256 bytes cause errors when encoding session management objects

2014-06-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22975/#review46912 --- Actually it turns out when applying this patch that there is an

[jira] [Commented] (QPID-5860) Sender lock held when invoking on Session

2014-06-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046461#comment-14046461 ] ASF subversion and git services commented on QPID-5860: --- Commit

[jira] [Commented] (QPID-5858) Session::checkError() throws exceptions of wrong type

2014-06-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046460#comment-14046460 ] ASF subversion and git services commented on QPID-5858: --- Commit

[jira] [Resolved] (QPID-5860) Sender lock held when invoking on Session

2014-06-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-5860. -- Resolution: Fixed Sender lock held when invoking on Session -

[jira] [Resolved] (QPID-5858) Session::checkError() throws exceptions of wrong type

2014-06-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-5858. -- Resolution: Fixed Session::checkError() throws exceptions of wrong type

Re: Review Request 23138: Last time, I promise, for throughput regression improvement.

2014-06-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23138/#review46913 --- Ship it! Ship It! - Gordon Sim On June 27, 2014, 8:13 p.m.,