[jira] [Commented] (DISPATCH-2301) Protocol adaptors do not annotate AMQP messages

[ https://issues.apache.org/jira/browse/DISPATCH-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464075#comment-17464075 ] ASF GitHub Bot commented on DISPATCH-2301: -- codecov-commenter commented on pu

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1470: DISPATCH-2301 - Added facility for annotating new messages.

codecov-commenter commented on pull request #1470: URL: https://github.com/apache/qpid-dispatch/pull/1470#issuecomment-999887598 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[jira] [Commented] (DISPATCH-1783) Add ability to use test doubles (mocks, fakes, ...) in C tests

[ https://issues.apache.org/jira/browse/DISPATCH-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464056#comment-17464056 ] ASF GitHub Bot commented on DISPATCH-1783: -- codecov-commenter commented on pu

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1469: DISPATCH-1783 add cpp-stub unittest mocking/stubbing tool

codecov-commenter commented on pull request #1469: URL: https://github.com/apache/qpid-dispatch/pull/1469#issuecomment-999876639 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[jira] [Commented] (DISPATCH-2301) Protocol adaptors do not annotate AMQP messages

[ https://issues.apache.org/jira/browse/DISPATCH-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464014#comment-17464014 ] ASF GitHub Bot commented on DISPATCH-2301: -- ted-ross opened a new pull reques

[GitHub] [qpid-dispatch] ted-ross opened a new pull request #1470: DISPATCH-2301 - Added facility for annotating new messages.

ted-ross opened a new pull request #1470: URL: https://github.com/apache/qpid-dispatch/pull/1470 Invoked this facility from the TCP, HTTP1, and HTTP2 adaptors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (DISPATCH-1783) Add ability to use test doubles (mocks, fakes, ...) in C tests

[ https://issues.apache.org/jira/browse/DISPATCH-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464007#comment-17464007 ] ASF GitHub Bot commented on DISPATCH-1783: -- jiridanek commented on pull reque

[jira] [Commented] (DISPATCH-1783) Add ability to use test doubles (mocks, fakes, ...) in C tests

[ https://issues.apache.org/jira/browse/DISPATCH-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464008#comment-17464008 ] ASF GitHub Bot commented on DISPATCH-1783: -- jiridanek edited a comment on pul

[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #1469: DISPATCH-1783 add cpp-stub unittest mocking/stubbing tool

jiridanek edited a comment on pull request #1469: URL: https://github.com/apache/qpid-dispatch/pull/1469#issuecomment-999792080 TODO: * [ ] INTERFACE libraries are unsupported on CMake 2.8.12 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1469: DISPATCH-1783 add cpp-stub unittest mocking/stubbing tool

jiridanek commented on pull request #1469: URL: https://github.com/apache/qpid-dispatch/pull/1469#issuecomment-999792080 TODO: * [] INTERFACE libraries are unsupported on CMake 2.8.12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2

[ https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464004#comment-17464004 ] ASF GitHub Bot commented on DISPATCH-2299: -- jiridanek commented on a change i

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1468: DISPATCH-2299 re-enable system_tests_http delete listeners

jiridanek commented on a change in pull request #1468: URL: https://github.com/apache/qpid-dispatch/pull/1468#discussion_r774096309 ## File path: cmake/FindLibWebSockets.cmake ## @@ -45,10 +45,11 @@ find_path(LIBWEBSOCKETS_INCLUDE_DIRS PATHS "/usr/include" ) +# strips t

[jira] [Commented] (DISPATCH-2206) ASAN use-after-free of qdr_link_t by I/O thread

[ https://issues.apache.org/jira/browse/DISPATCH-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464001#comment-17464001 ] Jiri Daněk commented on DISPATCH-2206: -- Still present, https://github.com/jirida

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463994#comment-17463994 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r774064957 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463987#comment-17463987 ] ASF GitHub Bot commented on PROTON-2308: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

gemmellr commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r774059843 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#in

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463979#comment-17463979 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r774051417 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#

[GitHub] [qpid-proton] astitcher commented on pull request #349: A different approach to resizing the input buffer

astitcher commented on pull request #349: URL: https://github.com/apache/qpid-proton/pull/349#issuecomment-999731306 Change merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [qpid-proton] astitcher closed pull request #349: A different approach to resizing the input buffer

astitcher closed pull request #349: URL: https://github.com/apache/qpid-proton/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [qpid-proton] astitcher closed pull request #341: Change the input buffer growth logic to do something rather than nothing

astitcher closed pull request #341: URL: https://github.com/apache/qpid-proton/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [qpid-proton] astitcher commented on pull request #341: Change the input buffer growth logic to do something rather than nothing

astitcher commented on pull request #341: URL: https://github.com/apache/qpid-proton/pull/341#issuecomment-999730527 Closed in favour of #349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PROTON-2479) Improve proactor read performance by actually resizing input buffer

[ https://issues.apache.org/jira/browse/PROTON-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463966#comment-17463966 ] ASF subversion and git services commented on PROTON-2479: - Commi

[jira] [Created] (PROTON-2479) Improve proactor read performance by actually resizing input buffer

Andrew Stitcher created PROTON-2479: --- Summary: Improve proactor read performance by actually resizing input buffer Key: PROTON-2479 URL: https://issues.apache.org/jira/browse/PROTON-2479 Project: Qp

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463946#comment-17463946 ] ASF GitHub Bot commented on PROTON-2308: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

gemmellr commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r774020425 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#in

[jira] [Created] (DISPATCH-2301) Protocol adaptors do not annotate AMQP messages

Ted Ross created DISPATCH-2301: -- Summary: Protocol adaptors do not annotate AMQP messages Key: DISPATCH-2301 URL: https://issues.apache.org/jira/browse/DISPATCH-2301 Project: Qpid Dispatch Issue

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463899#comment-17463899 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773976052 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463886#comment-17463886 ] ASF GitHub Bot commented on PROTON-2308: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

gemmellr commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773945393 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#in

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463873#comment-17463873 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773948252 ## File path: cpp/include/proton/terminus.hpp ## @@ -103,6 +104,10 @@ class terminus { /// Extension capabilities that are supported/requested

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463869#comment-17463869 ] ASF GitHub Bot commented on PROTON-2308: codecov-commenter edited a comment on p

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

codecov-commenter edited a comment on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-995011027 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463867#comment-17463867 ] ASF GitHub Bot commented on PROTON-2308: codecov-commenter edited a comment on p

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

codecov-commenter edited a comment on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-995011027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463862#comment-17463862 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773943847 ## File path: cpp/include/proton/source_options.hpp ## @@ -27,6 +27,7 @@ #include "./duration.hpp" #include "./source.hpp" +#include #include

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463853#comment-17463853 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on pull request #3

[GitHub] [qpid-proton] DreamPearl commented on pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-999625841 @gemmellr I've made a few changes. Can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463852#comment-17463852 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773936572 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463851#comment-17463851 ] ASF GitHub Bot commented on PROTON-2308: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

DreamPearl commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773935495 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463840#comment-17463840 ] ASF GitHub Bot commented on PROTON-2308: astitcher commented on a change in pull

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463839#comment-17463839 ] ASF GitHub Bot commented on PROTON-2308: astitcher commented on a change in pull

[GitHub] [qpid-proton] astitcher commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

astitcher commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773914859 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#i

[GitHub] [qpid-proton] astitcher commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

astitcher commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773917402 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,121 @@ #include #include #include +#include +#include +#include +#include +#include +#i

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463824#comment-17463824 ] ASF GitHub Bot commented on PROTON-2308: astitcher commented on a change in pull

[GitHub] [qpid-proton] astitcher commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

astitcher commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773912008 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,114 @@ #include #include #include +#include +#include +#include +#include +#include +#i

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463821#comment-17463821 ] ASF GitHub Bot commented on PROTON-2308: astitcher commented on pull request #34

[GitHub] [qpid-proton] astitcher commented on pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

astitcher commented on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-999599982 As a side note making properties that represent the documented AMQP possibilities is not actually all that easy as I said in my previous comment. We maybe need something pre

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463820#comment-17463820 ] ASF GitHub Bot commented on PROTON-2308: astitcher commented on pull request #34

[GitHub] [qpid-proton] astitcher commented on pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

astitcher commented on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-999598356 > > Although @gemmellr is correct in his analysis of what is going on in a real AMQP messaging interaction, this is probably not all that important as the C++ binding (at le

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463738#comment-17463738 ] ASF GitHub Bot commented on PROTON-2308: gemmellr commented on pull request #346

[GitHub] [qpid-proton] gemmellr commented on pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

gemmellr commented on pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#issuecomment-999480504 > Although @gemmellr is correct in his analysis of what is going on in a real AMQP messaging interaction, this is probably not all that important as the C++ binding (at least

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463702#comment-17463702 ] ASF GitHub Bot commented on PROTON-2308: gemmellr commented on a change in pull

[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties

[ https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463701#comment-17463701 ] ASF GitHub Bot commented on PROTON-2308: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

gemmellr commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773774519 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,114 @@ #include #include #include +#include +#include +#include +#include +#include +#in

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties

gemmellr commented on a change in pull request #346: URL: https://github.com/apache/qpid-proton/pull/346#discussion_r773774519 ## File path: cpp/src/link_test.cpp ## @@ -23,9 +23,114 @@ #include #include #include +#include +#include +#include +#include +#include +#in